[GitHub] asoap commented on issue #355: Modified xcodeProjDir to filter out files/folders that contain "._"

2018-02-01 Thread GitBox
asoap commented on issue #355: Modified xcodeProjDir to filter out files/folders that contain "._" URL: https://github.com/apache/cordova-ios/pull/355#issuecomment-362363851 YAY! Look at me, I'm helping. :dancing_men:

[GitHub] codecov-io commented on issue #355: Modified xcodeProjDir to filter out files/folders that contain "._"

2018-02-01 Thread GitBox
codecov-io commented on issue #355: Modified xcodeProjDir to filter out files/folders that contain "._" URL: https://github.com/apache/cordova-ios/pull/355#issuecomment-362337027 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/355?src=pr=h1) Report > Merging

[GitHub] jcesarmobile commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app

2018-02-01 Thread GitBox
jcesarmobile commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-362274980 Sorry, I have no time to review the changes at this moment, as I told you on a

[GitHub] jcesarmobile commented on issue #309: CB-13415 (android) Importing corrupt images using the Camera plugin c?

2018-02-01 Thread GitBox
jcesarmobile commented on issue #309: CB-13415 (android) Importing corrupt images using the Camera plugin c? URL: https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-362273600 I would use the same e.getMessage() or e.getLocalizedMessage() for both, not one with

[GitHub] jcesarmobile commented on issue #309: CB-13415 (android) Importing corrupt images using the Camera plugin c?

2018-02-01 Thread GitBox
jcesarmobile commented on issue #309: CB-13415 (android) Importing corrupt images using the Camera plugin c? URL: https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-362273600 I would use the same e.getMessage() or e.getLocalizedMessage() for both, not one with

[GitHub] alpesh12 commented on issue #309: CB-13415 (android) Importing corrupt images using the Camera plugin c?

2018-02-01 Thread GitBox
alpesh12 commented on issue #309: CB-13415 (android) Importing corrupt images using the Camera plugin c? URL: https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-362259407 @jcesarmobile @infil00p Any updates regarding merge

[GitHub] alpesh12 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app

2018-02-01 Thread GitBox
alpesh12 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-362259288 @jcesarmobile @shazron Any updates regarding merge