[GitHub] shineabel commented on issue #64: Network.type is throwing as none after 24 hours of idle

2018-11-09 Thread GitBox
shineabel commented on issue #64: Network.type is throwing as none after 24 hours of idle URL: https://github.com/apache/cordova-plugin-network-information/issues/64#issuecomment-437564135 +1 This is an automated message

[GitHub] somnathkhamaru edited a comment on issue #543: Cordova Platform add Android command failure

2018-11-09 Thread GitBox
somnathkhamaru edited a comment on issue #543: Cordova Platform add Android command failure URL: https://github.com/apache/cordova-android/issues/543#issuecomment-437559174 @dpogue ### cordova version : 8.1.2 (cordova-lib@8.1.1) cordova-android@~7.1.1

[GitHub] somnathkhamaru commented on issue #543: Cordova Platform add Android command failure

2018-11-09 Thread GitBox
somnathkhamaru commented on issue #543: Cordova Platform add Android command failure URL: https://github.com/apache/cordova-android/issues/543#issuecomment-437559174 @dpogue cordova version : 8.1.2 (cordova-lib@8.1.1) cordova-android@~7.1.1

[GitHub] dpogue commented on issue #543: Cordova Platform add Android command failure

2018-11-09 Thread GitBox
dpogue commented on issue #543: Cordova Platform add Android command failure URL: https://github.com/apache/cordova-android/issues/543#issuecomment-437559098 Can you provide details of what version of cordova you're using, what version of cordova-android you're trying to install, and any

[GitHub] somnathkhamaru opened a new issue #543: Cordova Platform add Android command failure

2018-11-09 Thread GitBox
somnathkhamaru opened a new issue #543: Cordova Platform add Android command failure URL: https://github.com/apache/cordova-android/issues/543 This is an automated message from the Apache Git Service. To respond to the

[GitHub] kkirby commented on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
kkirby commented on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437554655 @jcesarmobile I didn't want to introduce too many changes to the codebase. Passing in the existing dest and returning it doesn't make sense to me. I think if

[GitHub] danbeo95 opened a new issue #184: List contact on phone was empty

2018-11-09 Thread GitBox
danbeo95 opened a new issue #184: List contact on phone was empty URL: https://github.com/apache/cordova-plugin-contacts/issues/184 I try update one contact on my phone by call save() method.But after update i refresh my contact on phone.It was empty.Please hep me!

[GitHub] jcesarmobile commented on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
jcesarmobile commented on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437509641 Yeah, sorry, see my edit, the remap function should not return null, it should return the path unmodified, that’s why I thought it will break it as I

[GitHub] utiq commented on issue #109: Status bar is always white

2018-11-09 Thread GitBox
utiq commented on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-437508162 I fixed it doing this: https://stackoverflow.com/a/46232813/751524 This is

[GitHub] brodybits closed pull request #541: [WIP] Reproduce GH-540 on 7.1.2

2018-11-09 Thread GitBox
brodybits closed pull request #541: [WIP] Reproduce GH-540 on 7.1.2 URL: https://github.com/apache/cordova-android/pull/541 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support

2018-11-09 Thread GitBox
theMartux commented on issue #407: [ANNOUNCEMENT] Status of Xcode 10 support URL: https://github.com/apache/cordova-ios/issues/407#issuecomment-437483430 Hello, yesterday I uploaded my build to the App Store via Xcode. I used the Legacy Build System and the automatic signature.

[GitHub] brodybits commented on issue #542: [WIP] Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
brodybits commented on issue #542: [WIP] Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437479222 I just updated with a simple solution: do not do the path remapping if target-dir="app/lib" in source-file element. CB-14125 is no longer reverted

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-09 Thread GitBox
brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437470380 @afdev82 it would really help us if you can name the specific plugin that triggers this issue. We will need

[GitHub] brodybits commented on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
brodybits commented on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437469127 > I think this PR breaks that remapping for old plugins that didn't update the target-dir paths yet The update is only for the case when

[GitHub] jcesarmobile edited a comment on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
jcesarmobile edited a comment on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437466738 Supposedly, `studioPathRemap` should not remap if the path starts with `app/src/main` as that's how they should start. I think this PR breaks that

[GitHub] jcesarmobile edited a comment on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
jcesarmobile edited a comment on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437466738 Supposedly, `studioPathRemap` should not remap if the path starts with `app/src/main` as that's how they should start. I think this PR breaks that

[GitHub] jcesarmobile commented on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
jcesarmobile commented on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437466738 Supposedly, studioPathRemap should not remap if the path starts with `app/src/main` as that's how they should start. I think this PR breaks that

[GitHub] brodybits commented on issue #542: [WIP] Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
brodybits commented on issue #542: [WIP] Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437464175 Reopening as a WIP PR for now. I will take another look over the weekend. I think PR #539 should be merged by itself, keeping the commits

[GitHub] brodybits opened a new pull request #542: [WIP] Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
brodybits opened a new pull request #542: [WIP] Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542 - include commits with hotfix & unit test proposed in GH-539 (PR #539) - revert 8a69e32 - CB-14125:(android) Increase old plugin compatibility - include unit

[GitHub] jcesarmobile commented on issue #542: [WIP] Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
jcesarmobile commented on issue #542: [WIP] Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437461589 This is not a breaking change as .jar/.aar files should be in lib-file tags, not in source-file tag. That's what we broke in cordova-android

[GitHub] Menardi opened a new issue #459: Beta versions of cocoapods cause adding of pod-dependent plugins to fail

2018-11-09 Thread GitBox
Menardi opened a new issue #459: Beta versions of cocoapods cause adding of pod-dependent plugins to fail URL: https://github.com/apache/cordova-ios/issues/459 When using a beta version of Cocoapods, adding a plugin which uses pods will fail. In my case, the plugin is

[GitHub] brodybits commented on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
brodybits commented on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437458535 > There's one other spot in `uninstall` where the same pattern appears, does that also need to be updated? I think so, would like to see unit test

[GitHub] dpogue commented on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
dpogue commented on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437456646 Thanks! I'd like to get this merged in. There's one other spot in `uninstall` where the same pattern appears, does that also need to be updated?

[GitHub] dpogue commented on issue #542: Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
dpogue commented on issue #542: Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437455986 It kinda seems like this new issue is specific to .jar files, so we could maybe special-case them the same way we're handling the .java files?

[GitHub] brodybits closed pull request #542: Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
brodybits closed pull request #542: Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] brodybits commented on issue #542: Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
brodybits commented on issue #542: Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437454151 Closing for now, will raise the question on the email forum. This is an automated

[GitHub] brodybits commented on issue #542: Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
brodybits commented on issue #542: Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437453677 > The change in CB-14125 was one of the main reasons for doing a patch release. Understood, but it did break another plugin as reported in #540

[GitHub] dpogue commented on issue #542: Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
dpogue commented on issue #542: Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542#issuecomment-437452714 The change in CB-14125 was one of the main reasons for doing a patch release. There are hundreds of plugins that will never be updated, and we have lots

[GitHub] brodybits opened a new pull request #542: Resolve GH-540 (hotfix)

2018-11-09 Thread GitBox
brodybits opened a new pull request #542: Resolve GH-540 (hotfix) URL: https://github.com/apache/cordova-android/pull/542 - include commits with hotfix & unit test proposed in GH-539 (PR #539) - revert 8a69e32 - CB-14125:(android) Increase old plugin compatibility - include unit test

[GitHub] brodybits edited a comment on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-09 Thread GitBox
brodybits edited a comment on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437422541 I just reproduced this issue in a unit test in WIP PR #541. It is caused by the following changes: *

[GitHub] brodybits commented on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
brodybits commented on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437424178 Unfortunately this proposal does not resolve the issue reported in #540. This is an

[GitHub] brodybits edited a comment on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
brodybits edited a comment on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437361922 ~~Can you confirm the following:~~ * Does the test case show the functionality working on 7.1.1 but not 7.1.2? _Answer is yes._ * Is this an

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-09 Thread GitBox
brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437422541 I just reproduced this issue in a unit test in WIP PR #541. It is caused by the following change in commit

[GitHub] brodybits opened a new pull request #541: [WIP] Reproduce GH-40 on 7.1.2

2018-11-09 Thread GitBox
brodybits opened a new pull request #541: [WIP] Reproduce GH-40 on 7.1.2 URL: https://github.com/apache/cordova-android/pull/541 - unit test from GH-39 (PR #39) - similar unit test that reproduces GH-40 (issue #40) on 7.1.2 These tests pass on 7.1.1, fail on 7.1.2 and on master.

[GitHub] brodybits commented on issue #535: Fix user agent match issue android pie

2018-11-09 Thread GitBox
brodybits commented on issue #535: Fix user agent match issue android pie URL: https://github.com/apache/cordova-android/pull/535#issuecomment-437399822 Thanks for the contribution. Considering that `check` is only used to check for version range of 4.0...4.3 and minimum Android version is

[GitHub] brodybits commented on issue #532: build fails, Could not resolve gradle files

2018-11-09 Thread GitBox
brodybits commented on issue #532: build fails, Could not resolve gradle files URL: https://github.com/apache/cordova-android/issues/532#issuecomment-437392176 I suggest you post a [mvce ([1])](https://stackoverflow.com/help/mcve) project that demonstrates this issue. [1]

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-09 Thread GitBox
brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437386476 > For the test case... I just execute `cordova platform add android` and I see that the

[GitHub] janpio commented on issue #368: Android not respecting destType of FILE_URI

2018-11-09 Thread GitBox
janpio commented on issue #368: Android not respecting destType of FILE_URI URL: https://github.com/apache/cordova-plugin-camera/issues/368#issuecomment-437377964 Could you submit the suggested change as a Pull Request please? Thanks.

[GitHub] janpio commented on issue #458: cordova run --list --device fails for Virtualhere devices

2018-11-09 Thread GitBox
janpio commented on issue #458: cordova run --list --device fails for Virtualhere devices URL: https://github.com/apache/cordova-ios/issues/458#issuecomment-437377377 This VirtualHere? https://www.virtualhere.com/home Could you maybe submit a PR for that patch? We prefer to get code

[GitHub] Dwarfex edited a comment on issue #109: Status bar is always white

2018-11-09 Thread GitBox
Dwarfex edited a comment on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-437369362 I also tried several "solutions" advised here:

[GitHub] carlo318 edited a comment on issue #110: Timeout exception Android 8+9 (v2.4.3), Android 8 (v4.0.1)

2018-11-09 Thread GitBox
carlo318 edited a comment on issue #110: Timeout exception Android 8+9 (v2.4.3), Android 8 (v4.0.1) URL: https://github.com/apache/cordova-plugin-geolocation/issues/110#issuecomment-437304141 Same problem here, with Android 8.0.0. Not working neither with v.2.4.3 nor with 4.0.1. I

[GitHub] carlo318 edited a comment on issue #110: Timeout exception Android 8+9 (v2.4.3), Android 8 (v4.0.1)

2018-11-09 Thread GitBox
carlo318 edited a comment on issue #110: Timeout exception Android 8+9 (v2.4.3), Android 8 (v4.0.1) URL: https://github.com/apache/cordova-plugin-geolocation/issues/110#issuecomment-437304141 Same problem here, with Android 8.0.0. Not working neither with v.2.4.3 nor with 4.0.1. I

[GitHub] Dwarfex edited a comment on issue #109: Status bar is always white

2018-11-09 Thread GitBox
Dwarfex edited a comment on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-437320494 Same Problem here. However: This plugin partially fixed it for me:

[GitHub] Dwarfex edited a comment on issue #109: Status bar is always white

2018-11-09 Thread GitBox
Dwarfex edited a comment on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-437369362 I also tried several "solutions" advised here:

[GitHub] afdev82 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-09 Thread GitBox
afdev82 commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437369497 For the link:

[GitHub] Dwarfex commented on issue #109: Status bar is always white

2018-11-09 Thread GitBox
Dwarfex commented on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-437369362 I also tried several "solutions" advised here:

[GitHub] brodybits commented on issue #238: added cookies support for Android and iOS

2018-11-09 Thread GitBox
brodybits commented on issue #238: added cookies support for Android and iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/238#issuecomment-437368176 Considering that this PR is closed I would not expect any more work or meaningful discussion here. In case of interest

[GitHub] usman33 commented on issue #298: Youtube, Vimeo, others - second played video crashes the app when opened in native player - IOS

2018-11-09 Thread GitBox
usman33 commented on issue #298: Youtube, Vimeo, others - second played video crashes the app when opened in native player - IOS URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/298#issuecomment-437367699 I'm facing the same issue, app is crashing with "EXC_BAD_ACCESS"

[GitHub] Drezounet commented on issue #238: added cookies support for Android and iOS

2018-11-09 Thread GitBox
Drezounet commented on issue #238: added cookies support for Android and iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/238#issuecomment-437362935 so ? This is an automated message from the Apache Git

[GitHub] raphinesse commented on issue #32: Link `node_modules` during platform creation if it exists

2018-11-09 Thread GitBox
raphinesse commented on issue #32: Link `node_modules` during platform creation if it exists URL: https://github.com/apache/cordova/issues/32#issuecomment-437362934 From the description of this issue: > we actually _still_ need to either copy or preferably link

[GitHub] brodybits commented on issue #539: Fix dest overwrite

2018-11-09 Thread GitBox
brodybits commented on issue #539: Fix dest overwrite URL: https://github.com/apache/cordova-android/pull/539#issuecomment-437361922 Can you confirm the following: * Does the test case show the functionality working on 7.1.1 but not 7.1.2? * Is this an issue on the master branch?

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-09 Thread GitBox
brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437361089 > > I see you did raise a PR on 7.1.x (< > https://github.com/apache/cordova-android/pull/539>). We would

[GitHub] brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-09 Thread GitBox
brodybits commented on issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540#issuecomment-437360256 > > This is the line in my plugin.xml for the plugin that needs the library: > > > > I think this

[GitHub] regiMario opened a new issue #458: cordova run --list --device fails for Virtualhere devices

2018-11-09 Thread GitBox
regiMario opened a new issue #458: cordova run --list --device fails for Virtualhere devices URL: https://github.com/apache/cordova-ios/issues/458 I'm using Virtualhere for developing remotely. While Safari and Xcode do see the device after connecting via Virtualhere, cordova does not.

[GitHub] brodybits commented on issue #452: [Discussion]Why not use nsoperation queue instead of dispatch queue in CDVCommandDelegateImpl.m?

2018-11-09 Thread GitBox
brodybits commented on issue #452: [Discussion]Why not use nsoperation queue instead of dispatch queue in CDVCommandDelegateImpl.m? URL: https://github.com/apache/cordova-ios/issues/452#issuecomment-437355480 I suggest you send email to: d...@cordova.apache.org You may want to try

[GitHub] Kappyh commented on issue #109: Status bar is always white

2018-11-09 Thread GitBox
Kappyh commented on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-437354906 I have the same issue and I can't change the color of the status bar for any other color. Just happens in iOS, in Android works.

[GitHub] afdev82 opened a new issue #540: Issue to copy library from plugin after updating to v7.1.2

2018-11-09 Thread GitBox
afdev82 opened a new issue #540: Issue to copy library from plugin after updating to v7.1.2 URL: https://github.com/apache/cordova-android/issues/540 Everything worked fine in v7.1.1 Now after updating to v7.1.2 I get this error: ``` BUILD FAILED in 7s 3 actionable tasks: 3

[GitHub] Dwarfex edited a comment on issue #109: Status bar is always white

2018-11-09 Thread GitBox
Dwarfex edited a comment on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-437320494 Same Problem here. However: This plugin partially fixed it for me:

[GitHub] Dwarfex commented on issue #109: Status bar is always white

2018-11-09 Thread GitBox
Dwarfex commented on issue #109: Status bar is always white URL: https://github.com/apache/cordova-plugin-statusbar/issues/109#issuecomment-437320494 Same Problem here. However: This plugin fixed it for me: https://github.com/jcesarmobile/cordova-plugin-disable-ios11-statusbar I

[GitHub] carlo318 commented on issue #110: Timeout exception Android 8+9 (v2.4.3), Android 8 (v4.0.1)

2018-11-09 Thread GitBox
carlo318 commented on issue #110: Timeout exception Android 8+9 (v2.4.3), Android 8 (v4.0.1) URL: https://github.com/apache/cordova-plugin-geolocation/issues/110#issuecomment-437304141 Same problem here, with Android 8.0.0. Not working neither with v.2.4.3 nor with 4.0.1. I tried also

[GitHub] aximobile commented on issue #259: Windows known folders support

2018-11-09 Thread GitBox
aximobile commented on issue #259: Windows known folders support URL: https://github.com/apache/cordova-plugin-file/pull/259#issuecomment-437300515 Hello, I've been testing this pull request on the following device: Windows 10 pro 1511 build 10586.1176 It seems like