[jira] [Commented] (DAFFODIL-2283) ATO and HL7 saved parsers fail with Stack Overflow errors during generation on commit 7e8e1b3e
[ https://issues.apache.org/jira/browse/DAFFODIL-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057361#comment-17057361 ] Mike Beckerle commented on DAFFODIL-2283: - Running on IntelliJ IDEA. Just doing "Run All Tests" in EDIFACT. I found I had to modify the run configuration to specify -Xss4m to get it to succeed. > ATO and HL7 saved parsers fail with Stack Overflow errors during generation > on commit 7e8e1b3e > -- > > Key: DAFFODIL-2283 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2283 > Project: Daffodil > Issue Type: Bug > Components: DFDL Schemas >Affects Versions: 2.5.0 > Environment: Nightly test platform. >Reporter: Dave Thompson >Assignee: Steve Lawrence >Priority: Blocker > Fix For: 2.6.0 > > Attachments: ATO_SavedParserFail.txt, HL7_SavedParserFail.txt > > > The ATO and HL7 saved parser (.bin) files fail to be generated on commit > 7e8e1b3ed110efe939908cdf1e12df50d1f86527, commit for schema compilation speed > improvement. > Both formats fail with a Stack Overflow error. > Attached are the trace back message for each. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DAFFODIL-2283) ATO and HL7 saved parsers fail with Stack Overflow errors during generation on commit 7e8e1b3e
[ https://issues.apache.org/jira/browse/DAFFODIL-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057305#comment-17057305 ] Steve Lawrence commented on DAFFODIL-2283: -- What command are you running and what are your DAFFODIL_JAVA_OPTS? I'm able to run "sbt test" and "daffodil save-parser ..." with the EDIFACT schema without needing to modify -Xss with the recent change. > ATO and HL7 saved parsers fail with Stack Overflow errors during generation > on commit 7e8e1b3e > -- > > Key: DAFFODIL-2283 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2283 > Project: Daffodil > Issue Type: Bug > Components: DFDL Schemas >Affects Versions: 2.5.0 > Environment: Nightly test platform. >Reporter: Dave Thompson >Assignee: Steve Lawrence >Priority: Blocker > Fix For: 2.6.0 > > Attachments: ATO_SavedParserFail.txt, HL7_SavedParserFail.txt > > > The ATO and HL7 saved parser (.bin) files fail to be generated on commit > 7e8e1b3ed110efe939908cdf1e12df50d1f86527, commit for schema compilation speed > improvement. > Both formats fail with a Stack Overflow error. > Attached are the trace back message for each. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (DAFFODIL-2283) ATO and HL7 saved parsers fail with Stack Overflow errors during generation on commit 7e8e1b3e
[ https://issues.apache.org/jira/browse/DAFFODIL-2283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057250#comment-17057250 ] Mike Beckerle commented on DAFFODIL-2283: - I tried edifact today. I still needed to enlarge the stack to -Xss4m to get it to compile and run its tests with the current 2.6.0 snapshot. It stack overflows at -Xss2m. How small are we trying to get this. Is -Xss4m acceptable? > ATO and HL7 saved parsers fail with Stack Overflow errors during generation > on commit 7e8e1b3e > -- > > Key: DAFFODIL-2283 > URL: https://issues.apache.org/jira/browse/DAFFODIL-2283 > Project: Daffodil > Issue Type: Bug > Components: DFDL Schemas >Affects Versions: 2.5.0 > Environment: Nightly test platform. >Reporter: Dave Thompson >Assignee: Steve Lawrence >Priority: Blocker > Fix For: 2.6.0 > > Attachments: ATO_SavedParserFail.txt, HL7_SavedParserFail.txt > > > The ATO and HL7 saved parser (.bin) files fail to be generated on commit > 7e8e1b3ed110efe939908cdf1e12df50d1f86527, commit for schema compilation speed > improvement. > Both formats fail with a Stack Overflow error. > Attached are the trace back message for each. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden
olabusayoT commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r391088959
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/runtime1/SequenceTermRuntime1Mixin.scala
##
@@ -76,7 +77,8 @@ trait ChoiceBranchImpliedSequenceRuntime1Mixin { self:
ChoiceBranchImpliedSequen
None,
Maybe.Nope,
Maybe.Nope,
- Maybe.Nope)
+ Maybe.Nope,
+ isHidden)
Review comment:
The Runtime structures no longer have an isHidden member
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden
olabusayoT commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r391088444
##
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala
##
@@ -732,9 +728,8 @@ trait Term
final def possibleFirstChildElementsInInfoset: Seq[ElementBase] =
LV('possibleFirstChildElementsInInfoset) {
val pfct = possibleFirstChildTerms
val firstChildren = pfct.flatMap {
- case e: ElementBase if e.isHidden => Nil
case e: ElementBase => Seq(e)
- case s: SequenceTermBase if s.isHidden => Nil
+ case gr: GroupRef if gr.asModelGroup.isHidden => Nil
Review comment:
I decided to move isHidden to GroupRef, as isHidden inherited from MG was
only ever possibly true for these cases.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #332: Refactor isHidden
mbeckerle commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r391066153
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ModelGroupGrammarMixin.scala
##
@@ -68,9 +69,16 @@ trait ModelGroupGrammarMixin
case c: ChoiceTermBase => DelimiterStackCombinatorChoice(c, content)
case s: SequenceTermBase => DelimiterStackCombinatorSequence(s,
content)
}
- } else { groupContentDef }
+ } else {
+groupContent
+ } //TODO: confirm this works; changed from groupContentDef
-finalContent
+ val mgrd = self.modelGroupRuntimeData
+ if (mgrd.isHidden) {
Review comment:
:+1:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-daffodil] olabusayoT commented on a change in pull request #332: Refactor isHidden
olabusayoT commented on a change in pull request #332: Refactor isHidden
URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r391057073
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ModelGroupGrammarMixin.scala
##
@@ -68,9 +69,16 @@ trait ModelGroupGrammarMixin
case c: ChoiceTermBase => DelimiterStackCombinatorChoice(c, content)
case s: SequenceTermBase => DelimiterStackCombinatorSequence(s,
content)
}
- } else { groupContentDef }
+ } else {
+groupContent
+ } //TODO: confirm this works; changed from groupContentDef
-finalContent
+ val mgrd = self.modelGroupRuntimeData
+ if (mgrd.isHidden) {
Review comment:
After looking a tthe code, I realized we didn't actually need
ModelGroupRuntimeData.isHidden, nor ModelGroup.isHidden (this was moved into
GroupRef)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
