olabusayoT commented on a change in pull request #332: Refactor isHidden URL: https://github.com/apache/incubator-daffodil/pull/332#discussion_r391057073
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/grammar/ModelGroupGrammarMixin.scala ########## @@ -68,9 +69,16 @@ trait ModelGroupGrammarMixin case c: ChoiceTermBase => DelimiterStackCombinatorChoice(c, content) case s: SequenceTermBase => DelimiterStackCombinatorSequence(s, content) } - } else { groupContentDef } + } else { + groupContent + } //TODO: confirm this works; changed from groupContentDef - finalContent + val mgrd = self.modelGroupRuntimeData + if (mgrd.isHidden) { Review comment: After looking a tthe code, I realized we didn't actually need ModelGroupRuntimeData.isHidden, nor ModelGroup.isHidden (this was moved into GroupRef) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services