Re: [PR] Minor: Possibility to strip datafusion error name [datafusion]

2024-04-22 Thread via GitHub
comphead commented on code in PR #10186: URL: https://github.com/apache/datafusion/pull/10186#discussion_r1575504885 ## datafusion/common/src/error.rs: ## @@ -778,6 +817,20 @@ mod test { ); } +#[test] +fn test_strip_error_name() { +let res:

Re: [PR] Minor: Possibility to strip datafusion error name [datafusion]

2024-04-22 Thread via GitHub
edmondop commented on code in PR #10186: URL: https://github.com/apache/datafusion/pull/10186#discussion_r1575501494 ## datafusion/common/src/error.rs: ## @@ -778,6 +817,20 @@ mod test { ); } +#[test] +fn test_strip_error_name() { +let res:

Re: [PR] Minor: Possibility to strip datafusion error name [datafusion]

2024-04-22 Thread via GitHub
comphead commented on PR #10186: URL: https://github.com/apache/datafusion/pull/10186#issuecomment-2071162551 The implementation might not be super elegant though, please share your thoughts and opininions -- This is an automated message from the Apache Git Service. To respond to the

[PR] Minor: Possibility to strip datafusion error name [datafusion]

2024-04-22 Thread via GitHub
comphead opened a new pull request, #10186: URL: https://github.com/apache/datafusion/pull/10186 ## Which issue does this PR close? Closes #. ## Rationale for this change Currently Datafusion wraps the original error message and includes Datafusion name on top of

Re: [PR] Minor: Possibility to strip datafusion error name [datafusion]

2024-04-22 Thread via GitHub
comphead commented on PR #10186: URL: https://github.com/apache/datafusion/pull/10186#issuecomment-2071162770 @andygrove cc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.