[GitHub] [dolphinscheduler] fuchanghai commented on a diff in pull request #14930: [feature-#14449] add secret in k8s Task

2023-09-26 Thread via GitHub
fuchanghai commented on code in PR #14930: URL: https://github.com/apache/dolphinscheduler/pull/14930#discussion_r1338073502 ## dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/impl/K8sTaskExecutor.java: ## @@

[dolphinscheduler-website] branch asf-site updated: Automated deployment: e5e2850e37a905e4efd14ea719266c26cc7acf72

2023-09-26 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/dolphinscheduler-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 1d0111647d Automated

[GitHub] [dolphinscheduler] linlin-coder commented on issue #14960: [docker-compose run failed] [zookeeper] EndOfStreamException: Unable to read additional data from client, it probably closed the soc

2023-09-26 Thread via GitHub
linlin-coder commented on issue #14960: URL: https://github.com/apache/dolphinscheduler/issues/14960#issuecomment-1736609922 i have annother question, dolphinscheduler worker running in docker-container, how can i register the host ip of computer to zookeeper, becuase i found that

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14431: [Improvement][Registry][Jdbc] Add jdbc registry config in helm charts

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14431: URL: https://github.com/apache/dolphinscheduler/pull/14431#issuecomment-1736595804 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14431: [Improvement][Registry][Jdbc] Add jdbc registry config in helm charts

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14431: URL: https://github.com/apache/dolphinscheduler/pull/14431#issuecomment-1736595419 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[dolphinscheduler] branch 3.1.9-prepare updated: cherry-pick [Fix-14963] Fix the error of using shell task to obtain Home variable in Ubuntu system #14964

2023-09-26 Thread kerwin
This is an automated email from the ASF dual-hosted git repository. kerwin pushed a commit to branch 3.1.9-prepare in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git The following commit(s) were added to refs/heads/3.1.9-prepare by this push: new ed1cf53987 cherry-pick

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14934: [Improvement][K8S] K8S task support passing context parameters to downstream task

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14934: URL: https://github.com/apache/dolphinscheduler/pull/14934#issuecomment-1736584965 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] qingwli commented on pull request #14968: [Improvement][Common] Obtain resource information in the k8s environm…

2023-09-26 Thread via GitHub
qingwli commented on PR #14968: URL: https://github.com/apache/dolphinscheduler/pull/14968#issuecomment-1736584901 Please run 'mvn spotless:apply' to fix these violations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [dolphinscheduler] qingwli commented on a diff in pull request #14968: [Improvement][Common] Obtain resource information in the k8s environm…

2023-09-26 Thread via GitHub
qingwli commented on code in PR #14968: URL: https://github.com/apache/dolphinscheduler/pull/14968#discussion_r1337978672 ## dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java: ## @@ -103,9 +104,15 @@ public static double

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14934: [Improvement][K8S] K8S task support passing context parameters to downstream task

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14934: URL: https://github.com/apache/dolphinscheduler/pull/14934#issuecomment-1736582247 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #14569: [Feature][lmprovement] Master/Worker restore fault tolerant optimization

2023-09-26 Thread via GitHub
Radeity commented on code in PR #14569: URL: https://github.com/apache/dolphinscheduler/pull/14569#discussion_r1337953378 ## dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java: ## @@ -825,6 +825,27 @@ private

[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #14569: [Feature][lmprovement] Master/Worker restore fault tolerant optimization

2023-09-26 Thread via GitHub
Radeity commented on code in PR #14569: URL: https://github.com/apache/dolphinscheduler/pull/14569#discussion_r1337953378 ## dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java: ## @@ -825,6 +825,27 @@ private

[GitHub] [dolphinscheduler] Radeity commented on a diff in pull request #14569: [Feature][lmprovement] Master/Worker restore fault tolerant optimization

2023-09-26 Thread via GitHub
Radeity commented on code in PR #14569: URL: https://github.com/apache/dolphinscheduler/pull/14569#discussion_r1337949098 ## dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java: ## @@ -2248,4 +2269,118 @@ private

[GitHub] [dolphinscheduler] gjzhappy opened a new issue, #14969: [Bug] [dolphinshceduler-api] batch-copy

2023-09-26 Thread via GitHub
gjzhappy opened a new issue, #14969: URL: https://github.com/apache/dolphinscheduler/issues/14969 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened

[GitHub] [dolphinscheduler] amaoisnb commented on a diff in pull request #14569: [Feature][lmprovement] Master/Worker restore fault tolerant optimization

2023-09-26 Thread via GitHub
amaoisnb commented on code in PR #14569: URL: https://github.com/apache/dolphinscheduler/pull/14569#discussion_r1337937478 ## dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java: ## @@ -825,6 +825,27 @@ private

[GitHub] [dolphinscheduler] amaoisnb commented on a diff in pull request #14569: [Feature][lmprovement] Master/Worker restore fault tolerant optimization

2023-09-26 Thread via GitHub
amaoisnb commented on code in PR #14569: URL: https://github.com/apache/dolphinscheduler/pull/14569#discussion_r1337935511 ## dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java: ## @@ -2248,4 +2269,118 @@ private

[GitHub] [dolphinscheduler] amaoisnb commented on a diff in pull request #14569: [Feature][lmprovement] Master/Worker restore fault tolerant optimization

2023-09-26 Thread via GitHub
amaoisnb commented on code in PR #14569: URL: https://github.com/apache/dolphinscheduler/pull/14569#discussion_r1337935280 ## dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java: ## @@ -2248,4 +2269,118 @@ private

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14967: Fix When the task instance status is 'STOP'

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14967: URL: https://github.com/apache/dolphinscheduler/pull/14967#issuecomment-1736517550 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] fuchanghai commented on a diff in pull request #14967: Fix When the task instance status is 'STOP'

2023-09-26 Thread via GitHub
fuchanghai commented on code in PR #14967: URL: https://github.com/apache/dolphinscheduler/pull/14967#discussion_r1337925458 ## dolphinscheduler-ui/src/common/types.ts: ## @@ -19,6 +19,7 @@ import { Component } from 'vue' export type ITaskState = | 'SUBMITTED_SUCCESS' |

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14967: Fix When the task instance status is 'STOP'

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14967: URL: https://github.com/apache/dolphinscheduler/pull/14967#issuecomment-1736512445 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #14967: Fix When the task instance status is 'STOP'

2023-09-26 Thread via GitHub
codecov-commenter commented on PR #14967: URL: https://github.com/apache/dolphinscheduler/pull/14967#issuecomment-1736506322 ## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14967?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

[GitHub] [dolphinscheduler] github-actions[bot] commented on pull request #11393: [Fix] Fix Environment variable data error

2023-09-26 Thread via GitHub
github-actions[bot] commented on PR #11393: URL: https://github.com/apache/dolphinscheduler/pull/11393#issuecomment-1736469829 This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity

[GitHub] [dolphinscheduler] github-actions[bot] closed issue #14758: [Bug] [dolphinscheduler-master] node disable issue

2023-09-26 Thread via GitHub
github-actions[bot] closed issue #14758: [Bug] [dolphinscheduler-master] node disable issue URL: https://github.com/apache/dolphinscheduler/issues/14758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14934: [Improvement][K8S] K8S task support passing context parameters to downstream task

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14934: URL: https://github.com/apache/dolphinscheduler/pull/14934#issuecomment-1735507596 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14934: [Improvement][K8S] K8S task support passing context parameters to downstream task

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14934: URL: https://github.com/apache/dolphinscheduler/pull/14934#issuecomment-1735492866 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png

[GitHub] [dolphinscheduler] qingwli merged pull request #14966: [Bug] [Api] Logback file STDOUT duplicate

2023-09-26 Thread via GitHub
qingwli merged PR #14966: URL: https://github.com/apache/dolphinscheduler/pull/14966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dolphinscheduler] qingwli closed issue #14965: [Bug] [Api] Logback file STDOUT duplicate

2023-09-26 Thread via GitHub
qingwli closed issue #14965: [Bug] [Api] Logback file STDOUT duplicate URL: https://github.com/apache/dolphinscheduler/issues/14965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[dolphinscheduler] branch dev updated: [Bug] [Api] Logback file STDOUT duplicate (#14966)

2023-09-26 Thread wangyang
This is an automated email from the ASF dual-hosted git repository. wangyang pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git The following commit(s) were added to refs/heads/dev by this push: new 8cb765bdcb [Bug] [Api] Logback file

[GitHub] [dolphinscheduler] qingwli commented on pull request #14966: [Bug] [Api] Logback file STDOUT duplicate

2023-09-26 Thread via GitHub
qingwli commented on PR #14966: URL: https://github.com/apache/dolphinscheduler/pull/14966#issuecomment-1735358089 > hi @qingwli I think we should delete the content in the if tag, otherwise the application will not print logs when running on the physical machine. Hi, in machine

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14934: [Improvement][K8S] K8S task support passing context parameters to downstream task

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14934: URL: https://github.com/apache/dolphinscheduler/pull/14934#issuecomment-1735329679 Please retry analysis of this Pull-Request directly on [SonarCloud](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=14934). -- This is an automated

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14934: [Improvement][K8S] K8S task support passing context parameters to downstream task

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14934: URL: https://github.com/apache/dolphinscheduler/pull/14934#issuecomment-1735328787 SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png

[GitHub] [dolphinscheduler] imizao opened a new pull request, #14967: Fix When the task instance status is 'STOP'

2023-09-26 Thread via GitHub
imizao opened a new pull request, #14967: URL: https://github.com/apache/dolphinscheduler/pull/14967 ## Purpose of the pull request Fix When the task instance status is 'STOP', and avoid the 'STOP' state causing the stateOption not to match and reporting an error ## Verify

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14956: [Fix-14956][dolphinscheduler-api] Sub_process node import exception in workflow

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14956: URL: https://github.com/apache/dolphinscheduler/pull/14956#issuecomment-1735265636 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14966: [Bug] [Api] Logback file STDOUT duplicate

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14966: URL: https://github.com/apache/dolphinscheduler/pull/14966#issuecomment-1735262792 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14956: [Fix-14956][dolphinscheduler-api] Sub_process node import exception in workflow

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14956: URL: https://github.com/apache/dolphinscheduler/pull/14956#issuecomment-1735262510 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14966: [Bug] [Api] Logback file STDOUT duplicate

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14966: URL: https://github.com/apache/dolphinscheduler/pull/14966#issuecomment-1735261051 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] qingwli opened a new pull request, #14966: [Bug] [Api] Logback file STDOUT duplicate

2023-09-26 Thread via GitHub
qingwli opened a new pull request, #14966: URL: https://github.com/apache/dolphinscheduler/pull/14966 - close #14965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [dolphinscheduler] qingwli opened a new issue, #14965: [Bug] [Api] Logback file STDOUT duplicate

2023-09-26 Thread via GitHub
qingwli opened a new issue, #14965: URL: https://github.com/apache/dolphinscheduler/issues/14965 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened

[dolphinscheduler] branch dev updated: Fix the error of using shell task to obtain Home variable in Ubuntu system. (#14964)

2023-09-26 Thread kerwin
This is an automated email from the ASF dual-hosted git repository. kerwin pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git The following commit(s) were added to refs/heads/dev by this push: new 6de1e2c1b3 Fix the error of using shell

[GitHub] [dolphinscheduler] zhuangchong merged pull request #14964: [Fix-14963] Fix the error of using shell task to obtain Home variable in Ubuntu system

2023-09-26 Thread via GitHub
zhuangchong merged PR #14964: URL: https://github.com/apache/dolphinscheduler/pull/14964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [dolphinscheduler] zhuangchong closed issue #14963: [Bug] [Task] The error of using shell task to obtain Home variable in Ubuntu system

2023-09-26 Thread via GitHub
zhuangchong closed issue #14963: [Bug] [Task] The error of using shell task to obtain Home variable in Ubuntu system URL: https://github.com/apache/dolphinscheduler/issues/14963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14964: [Fix-14963] Fix the error of using shell task to obtain Home variable in Ubuntu system

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14964: URL: https://github.com/apache/dolphinscheduler/pull/14964#issuecomment-1735120979 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14964: [Fix-14963] Fix the error of using shell task to obtain Home variable in Ubuntu system

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14964: URL: https://github.com/apache/dolphinscheduler/pull/14964#issuecomment-1735114336 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #14964: [Fix-14963] Fix the error of using shell task to obtain Home variable in Ubuntu system

2023-09-26 Thread via GitHub
codecov-commenter commented on PR #14964: URL: https://github.com/apache/dolphinscheduler/pull/14964#issuecomment-1735101352 ## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/14964?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14431: [Improvement][Registry][Jdbc] Add jdbc registry config in helm charts

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14431: URL: https://github.com/apache/dolphinscheduler/pull/14431#issuecomment-1735082407 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #14431: [Improvement][Registry][Jdbc] Add jdbc registry config in helm charts

2023-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #14431: URL: https://github.com/apache/dolphinscheduler/pull/14431#issuecomment-1735069826 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [dolphinscheduler] zhuangchong opened a new pull request, #14964: [Fix-14963] Fix the error of using shell task to obtain Home variable in Ubuntu system

2023-09-26 Thread via GitHub
zhuangchong opened a new pull request, #14964: URL: https://github.com/apache/dolphinscheduler/pull/14964 ## Purpose of the pull request close #14963 sudo -E: The -E option retains the current user's environment variables. This means that when using sudo

[GitHub] [dolphinscheduler] zhuangchong opened a new issue, #14963: [Bug] [Task] The error of using shell task to obtain Home variable in Ubuntu system

2023-09-26 Thread via GitHub
zhuangchong opened a new issue, #14963: URL: https://github.com/apache/dolphinscheduler/issues/14963 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What

[GitHub] [dolphinscheduler] Gallardot commented on a diff in pull request #14934: [Improvement][K8S] K8S task support passing context parameters to downstream task

2023-09-26 Thread via GitHub
Gallardot commented on code in PR #14934: URL: https://github.com/apache/dolphinscheduler/pull/14934#discussion_r1336739386 ## dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/impl/K8sTaskExecutor.java: ## @@

[GitHub] [dolphinscheduler] Gallardot commented on a diff in pull request #14934: [Improvement][K8S] K8S task support passing context parameters to downstream task

2023-09-26 Thread via GitHub
Gallardot commented on code in PR #14934: URL: https://github.com/apache/dolphinscheduler/pull/14934#discussion_r1336739386 ## dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/k8s/impl/K8sTaskExecutor.java: ## @@

[GitHub] [dolphinscheduler] AmriStrong commented on pull request #14949: [Improvement][Master/Worker]Change Master/Worker default zookeeper timeout setting

2023-09-26 Thread via GitHub
AmriStrong commented on PR #14949: URL: https://github.com/apache/dolphinscheduler/pull/14949#issuecomment-1734944781 @ruanwenjun Review and merge code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above