Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

ruanwenjun merged PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2055106353 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2055101867 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

ruanwenjun commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1565175338 ## dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_postgresql.sql: ## @@ -1993,11 +1993,15 @@ CREATE TABLE t_ds_task_group ( DROP TABLE IF

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

qingwli commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2054624253 PTAL @ruanwenjun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2054592604 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2054589118 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2051017899 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2051016957 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2046474545 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2046471717 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2041792188 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2041792616 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2041291432 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2041291251 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2038993774 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2038993456 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2033670253 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2033670969 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2031179542 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2031178929 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2031017326 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2031016120 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

github-advanced-security[bot] commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547095110 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/operator/BaseAuditOperator.java: ## @@ -0,0 +1,225 @@ +/*

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547068414 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java: ## @@ -293,7 +293,7 @@ private void

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2030970991 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2030969234 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547065411 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/operator/BaseOperator.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547060184 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/operator/Operator.java: ## @@ -15,14 +15,13 @@ * limitations under the

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547059530 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/OperatorLogAspect.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547058643 ## dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditObjectType.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547057095 ## dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql: ## @@ -2008,10 +2008,14 @@ DROP TABLE IF EXISTS `t_ds_audit_log`; CREATE TABLE

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

ruanwenjun commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2029068093 > ## [![Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

ruanwenjun commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1545897018 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/OperatorLogAspect.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache