Re: [PR] [Bug] Fix can modify file which is not under resource path [dolphinscheduler]

2024-03-01 Thread via GitHub
caishunfeng merged PR #15652: URL: https://github.com/apache/dolphinscheduler/pull/15652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [Bug] Fix can modify file which is not under resource path [dolphinscheduler]

2024-02-29 Thread via GitHub
ruanwenjun commented on code in PR #15652: URL: https://github.com/apache/dolphinscheduler/pull/15652#discussion_r1507419008 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java: ## @@ -182,10 +165,7 @@ private String

Re: [PR] [Bug] Fix can modify file which is not under resource path [dolphinscheduler]

2024-02-29 Thread via GitHub
rickchengx commented on code in PR #15652: URL: https://github.com/apache/dolphinscheduler/pull/15652#discussion_r1507209582 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java: ## @@ -182,10 +165,7 @@ private String

Re: [PR] [Bug] Fix can modify file which is not under resource path [dolphinscheduler]

2024-02-28 Thread via GitHub
sonarcloud[bot] commented on PR #15652: URL: https://github.com/apache/dolphinscheduler/pull/15652#issuecomment-1970318244 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] [Bug] Fix can modify file which is not under resource path [dolphinscheduler]

2024-02-28 Thread via GitHub
sonarcloud[bot] commented on PR #15652: URL: https://github.com/apache/dolphinscheduler/pull/15652#issuecomment-1970317634 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] [Bug] Fix can modify file which is not under resource path [dolphinscheduler]

2024-02-28 Thread via GitHub
codecov-commenter commented on PR #15652: URL: https://github.com/apache/dolphinscheduler/pull/15652#issuecomment-1970312879 ## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15652?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)

Re: [PR] [Bug] Fix can modify file which is not under resource path [dolphinscheduler]

2024-02-28 Thread via GitHub
github-advanced-security[bot] commented on code in PR #15652: URL: https://github.com/apache/dolphinscheduler/pull/15652#discussion_r1505841576 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ResourcesServiceImpl.java: ## @@ -241,8 +221,8 @@