[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #222: update documents
sonarcloud[bot] commented on issue #222: update documents URL: https://github.com/apache/incubator-dolphinscheduler/pull/222#issuecomment-574532035 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=222=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=222=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=222=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1835: add BaseServiceTest BaseDAGServiceTest UT
sonarcloud[bot] commented on issue #1835: add BaseServiceTest BaseDAGServiceTest UT URL: https://github.com/apache/incubator-dolphinscheduler/pull/1835#issuecomment-574527343 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1835=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1835=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1835=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1835=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1826: [Fix issue #1770]check udf and data source in order to fix issue 1770
qiaozhanwei merged pull request #1826: [Fix issue #1770]check udf and data source in order to fix issue 1770 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1826 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated (07f9637 -> 779672e)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a change to branch dev
in repository
https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git.
from 07f9637 replace strings with constants already exist. (#1825)
add 779672e [Fix issue #1770]check udf and data source in order to fix
issue 1770 (#1826)
No new revisions were added by this update.
Summary of changes:
.../enums/{Flag.java => AuthorizationType.java}| 22 ++-
.../apache/dolphinscheduler/dao/ProcessDao.java| 55 +++-
.../dao/mapper/DataSourceMapper.java | 9 ++
.../dao/mapper/ResourceMapper.java | 8 ++
.../dolphinscheduler/dao/mapper/UdfFuncMapper.java | 7 +
.../dao/permission/PermissionCheck.java| 157 +
.../dao/mapper/DataSourceMapper.xml| 13 ++
.../dolphinscheduler/dao/mapper/UdfFuncMapper.xml | 13 ++
.../dao/mapper/DataSourceMapperTest.java | 77 +-
.../dao/mapper/ResourceMapperTest.java | 97 -
.../dao/mapper/UdfFuncMapperTest.java | 50 +++
.../server/worker/runner/TaskScheduleThread.java | 32 +++--
.../server/worker/task/sql/SqlTask.java| 48 ++-
13 files changed, 548 insertions(+), 40 deletions(-)
copy
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/{Flag.java
=> AuthorizationType.java} (81%)
create mode 100644
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/permission/PermissionCheck.java
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1835: add BaseServiceTest BaseDAGServiceTest UT
codecov-io edited a comment on issue #1835: add BaseServiceTest BaseDAGServiceTest UT URL: https://github.com/apache/incubator-dolphinscheduler/pull/1835#issuecomment-574525683 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=h1) Report > Merging [#1835](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/a1fe80eaa302c26c236a181ebd0e0970d71eade6?src=pr=desc) will **increase** coverage by `1.21%`. > The diff coverage is `44.39%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=tree) ```diff @@Coverage Diff @@ ## dev#1835 +/- ## == + Coverage 20.22% 21.44% +1.21% == Files 290 293 +3 Lines 1408214122 +40 Branches 2374 2340 -34 == + Hits 2848 3028 +180 + Misses 1090910766 -143 - Partials 325 328 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=tree) | Coverage Δ | | |---|---|---| | [...pache/dolphinscheduler/dao/entity/ProjectUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9qZWN0VXNlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...inscheduler/common/zk/ZookeeperCachedOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlckNhY2hlZE9wZXJhdG9yLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...hinscheduler/api/controller/ProjectController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvamVjdENvbnRyb2xsZXIuamF2YQ==) | `1.75% <ø> (+1.75%)` | :arrow_up: | | [...apache/dolphinscheduler/common/thread/Stopper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9TdG9wcGVyLmphdmE=) | `80% <ø> (ø)` | :arrow_up: | | [...rg/apache/dolphinscheduler/dao/entity/UdfFunc.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VZGZGdW5jLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...rg/apache/dolphinscheduler/dao/entity/UDFUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VREZVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...che/dolphinscheduler/dao/entity/ResourcesUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9SZXNvdXJjZXNVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [.../org/apache/dolphinscheduler/dao/entity/Alert.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BbGVydC5qYXZh) | `8.69% <ø> (+0.69%)` | :arrow_up: | | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | ... and [84 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1835: add BaseServiceTest BaseDAGServiceTest UT
codecov-io commented on issue #1835: add BaseServiceTest BaseDAGServiceTest UT URL: https://github.com/apache/incubator-dolphinscheduler/pull/1835#issuecomment-574525683 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=h1) Report > Merging [#1835](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/a1fe80eaa302c26c236a181ebd0e0970d71eade6?src=pr=desc) will **increase** coverage by `1.33%`. > The diff coverage is `44.39%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=tree) ```diff @@Coverage Diff @@ ## dev#1835 +/- ## == + Coverage 20.22% 21.55% +1.33% == Files 290 293 +3 Lines 1408214047 -35 Branches 2374 2318 -56 == + Hits 2848 3028 +180 + Misses 1090910691 -218 - Partials 325 328 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=tree) | Coverage Δ | | |---|---|---| | [...pache/dolphinscheduler/dao/entity/ProjectUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9Qcm9qZWN0VXNlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...inscheduler/common/zk/ZookeeperCachedOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlckNhY2hlZE9wZXJhdG9yLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...uler/server/worker/log/SensitiveDataConverter.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9sb2cvU2Vuc2l0aXZlRGF0YUNvbnZlcnRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...hinscheduler/api/controller/ProjectController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvamVjdENvbnRyb2xsZXIuamF2YQ==) | `1.75% <ø> (+1.75%)` | :arrow_up: | | [...apache/dolphinscheduler/common/thread/Stopper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9TdG9wcGVyLmphdmE=) | `80% <ø> (ø)` | :arrow_up: | | [...rg/apache/dolphinscheduler/dao/entity/UdfFunc.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VZGZGdW5jLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...rg/apache/dolphinscheduler/dao/entity/UDFUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9VREZVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...che/dolphinscheduler/dao/entity/ResourcesUser.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9SZXNvdXJjZXNVc2VyLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [.../org/apache/dolphinscheduler/dao/entity/Alert.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL2VudGl0eS9BbGVydC5qYXZh) | `8.69% <ø> (+0.69%)` | :arrow_up: | | [.../org/apache/dolphinscheduler/common/Constants.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL0NvbnN0YW50cy5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | ... and [77 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1835?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ =
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1826: [Fix issue #1770]check udf and data source in order to fix issue 1770
sonarcloud[bot] commented on issue #1826: [Fix issue #1770]check udf and data source in order to fix issue 1770 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1826#issuecomment-574524731 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=CODE_SMELL) [13 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1826=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1826=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1826=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1826=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1826=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #120: tasks run on the specified worker
sonarcloud[bot] commented on issue #120: tasks run on the specified worker URL: https://github.com/apache/incubator-dolphinscheduler/pull/120#issuecomment-574522403 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=120=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=120=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=120=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #221: Dev 20190415
sonarcloud[bot] commented on issue #221: Dev 20190415 URL: https://github.com/apache/incubator-dolphinscheduler/pull/221#issuecomment-574516154 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=221=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=221=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=221=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request #1835: add BaseServiceTest BaseDAGServiceTest UT
samz406 opened a new pull request #1835: add BaseServiceTest BaseDAGServiceTest UT URL: https://github.com/apache/incubator-dolphinscheduler/pull/1835 **What is the purpose of the pull request** For #1465 add UT class BaseServiceTest BaseDAGServiceTest modify root pom ``` **/api/service/BaseServiceTest.java **/api/service/BaseDAGServiceTest.java ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1825: replace strings with constants already exist.
qiaozhanwei merged pull request #1825: replace strings with constants already exist. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1825 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated: replace strings with constants already exist. (#1825)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 07f9637 replace strings with constants already exist. (#1825)
07f9637 is described below
commit 07f96375b3975b005c0cc3a44cbb6d01b6550080
Author: ZHAOLIPAN <1185807...@qq.com>
AuthorDate: Wed Jan 15 14:00:28 2020 +0800
replace strings with constants already exist. (#1825)
---
.../apache/dolphinscheduler/common/job/db/ClickHouseDataSource.java| 3 ++-
.../java/org/apache/dolphinscheduler/common/job/db/HiveDataSource.java | 3 ++-
.../org/apache/dolphinscheduler/common/job/db/MySQLDataSource.java | 3 ++-
.../org/apache/dolphinscheduler/common/job/db/OracleDataSource.java| 3 ++-
.../org/apache/dolphinscheduler/common/job/db/PostgreDataSource.java | 3 ++-
.../org/apache/dolphinscheduler/common/job/db/SQLServerDataSource.java | 3 ++-
.../org/apache/dolphinscheduler/common/job/db/SparkDataSource.java | 3 ++-
7 files changed, 14 insertions(+), 7 deletions(-)
diff --git
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/ClickHouseDataSource.java
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/ClickHouseDataSource.java
index 457ddb0..fe76497 100644
---
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/ClickHouseDataSource.java
+++
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/ClickHouseDataSource.java
@@ -16,6 +16,7 @@
*/
package org.apache.dolphinscheduler.common.job.db;
+import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -58,7 +59,7 @@ public class ClickHouseDataSource extends BaseDataSource {
public void isConnectable() throws Exception {
Connection con = null;
try {
-Class.forName("ru.yandex.clickhouse.ClickHouseDriver");
+Class.forName(Constants.COM_CLICKHOUSE_JDBC_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(),
getPassword());
} finally {
if (con != null) {
diff --git
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/HiveDataSource.java
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/HiveDataSource.java
index 101efae..cddedd1 100644
---
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/HiveDataSource.java
+++
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/HiveDataSource.java
@@ -16,6 +16,7 @@
*/
package org.apache.dolphinscheduler.common.job.db;
+import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -61,7 +62,7 @@ public class HiveDataSource extends BaseDataSource {
public void isConnectable() throws Exception {
Connection con = null;
try {
- Class.forName("org.apache.hive.jdbc.HiveDriver");
+ Class.forName(Constants.ORG_APACHE_HIVE_JDBC_HIVE_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(), "");
} finally {
if (con != null) {
diff --git
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/MySQLDataSource.java
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/MySQLDataSource.java
index 3cf2b2c..fa149e6 100644
---
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/MySQLDataSource.java
+++
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/MySQLDataSource.java
@@ -16,6 +16,7 @@
*/
package org.apache.dolphinscheduler.common.job.db;
+import org.apache.dolphinscheduler.common.Constants;
import org.apache.dolphinscheduler.common.utils.StringUtils;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -56,7 +57,7 @@ public class MySQLDataSource extends BaseDataSource {
public void isConnectable() throws Exception {
Connection con = null;
try {
- Class.forName("com.mysql.jdbc.Driver");
+ Class.forName(Constants.COM_MYSQL_JDBC_DRIVER);
con = DriverManager.getConnection(getJdbcUrl(), getUser(),
getPassword());
} finally {
if (con != null) {
diff --git
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/OracleDataSource.java
b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/OracleDataSource.java
index 551c782..c3dc3a9 100644
---
a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/job/db/OracleDataSource.java
+++
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1832: Requests the previous page when there is no data on the list page(#1768)
qiaozhanwei merged pull request #1832: Requests the previous page when there is no data on the list page(#1768) URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated: Requests the previous page when there is no data on the list page(#1768) (#1832)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new d02422d Requests the previous page when there is no data on the list
page(#1768) (#1832)
d02422d is described below
commit d02422d030b46e61238224ae328241b27c98cd15
Author: break60 <790061...@qq.com>
AuthorDate: Wed Jan 15 13:55:25 2020 +0800
Requests the previous page when there is no data on the list page(#1768)
(#1832)
* fix udfs assignment and task instance page jump #1789
* jest add coverage display
* Fix data echo, style, popup cannot be closed and license
* Fix data echo, style, popup cannot be closed and license
* fix
* Requests the previous page when there is no data on the list page
---
.../pages/dag/_source/formModel/tasks/_source/sqlType.vue| 2 +-
.../src/js/conf/home/pages/datasource/pages/list/index.vue | 12
.../pages/projects/pages/definition/pages/list/index.vue | 12
.../home/pages/projects/pages/instance/pages/list/index.vue | 12
.../src/js/conf/home/pages/projects/pages/list/index.vue | 12
.../conf/home/pages/resource/pages/file/pages/list/index.vue | 10 +++---
.../home/pages/resource/pages/udf/pages/function/index.vue | 12
.../home/pages/resource/pages/udf/pages/resource/index.vue | 12
.../src/js/conf/home/pages/security/pages/queue/index.vue| 12
.../src/js/conf/home/pages/security/pages/tenement/index.vue | 12
.../src/js/conf/home/pages/security/pages/users/index.vue| 12
.../conf/home/pages/security/pages/warningGroups/index.vue | 12
.../js/conf/home/pages/security/pages/workerGroups/index.vue | 12
.../src/js/conf/home/pages/user/pages/token/index.vue| 12
14 files changed, 104 insertions(+), 52 deletions(-)
diff --git
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/sqlType.vue
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/sqlType.vue
index 49fb4a2..ecb7d2c 100644
---
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/sqlType.vue
+++
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/sqlType.vue
@@ -20,7 +20,7 @@
v-model="sqlTypeId"
:disabled="isDetails"
@on-change="_handleSqlTypeChanged"
-style="width: 90px;">
+style="width: 120px;">
{
- this.datasourcesList = []
- this.datasourcesList = res.totalList
- this.total = res.total
- this.isLoading = false
+ if(this.searchParams.pageNo>1 && res.totalList.length == 0) {
+this.searchParams.pageNo = this.searchParams.pageNo -1
+ } else {
+this.datasourcesList = []
+this.datasourcesList = res.totalList
+this.total = res.total
+this.isLoading = false
+ }
}).catch(e => {
this.isLoading = false
})
diff --git
a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/index.vue
b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/index.vue
index d168ce7..1f28578 100644
---
a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/index.vue
+++
b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/index.vue
@@ -100,10 +100,14 @@
_getList (flag) {
this.isLoading = !flag
this.getProcessListP(this.searchParams).then(res => {
- this.processListP = []
- this.processListP = res.totalList
- this.total = res.total
- this.isLoading = false
+ if(this.searchParams.pageNo>1 && res.totalList.length == 0) {
+this.searchParams.pageNo = this.searchParams.pageNo -1
+ } else {
+this.processListP = []
+this.processListP = res.totalList
+this.total = res.total
+this.isLoading = false
+ }
}).catch(e => {
this.isLoading = false
})
diff --git
a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/list/index.vue
b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/list/index.vue
index 4bf169b..7bcf9ac 100644
---
a/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/list/index.vue
+++
b/dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/instance/pages/list/index.vue
@@ -105,10 +105,14 @@
_getProcessInstanceListP (flag) {
this.isLoading = !flag
this.getProcessInstance(this.searchParams).then(res => {
-
[incubator-dolphinscheduler] branch dev updated: fix the bug #1816 (#1834)
This is an automated email from the ASF dual-hosted git repository.
journey pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new be4fa72 fix the bug #1816 (#1834)
be4fa72 is described below
commit be4fa728e9efe4e87c785a27f912c1eb0c669493
Author: zhukai
AuthorDate: Wed Jan 15 13:56:02 2020 +0800
fix the bug #1816 (#1834)
---
.../formModel/tasks/_source/dependItemList.vue | 50 --
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/dependItemList.vue
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/dependItemList.vue
index d6c8657..abec923 100644
---
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/dependItemList.vue
+++
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/dependItemList.vue
@@ -22,7 +22,7 @@
-
+
@@ -64,7 +64,6 @@
data () {
return {
list: [],
-definitionList: [],
projectList: [],
cycleList: cycleList,
isInstance: false,
@@ -88,16 +87,19 @@
_add () {
// btn loading
this.isLoading = true
-// dependItemList index
-let is = (value) => _.some(this.dependItemList, { definitionId: value
})
-let noArr = _.filter(this.definitionList, v => !is(v.value))
-let value = noArr[0] && noArr[0].value || null
-let val = value || this.definitionList[0].value
+
// add task list
let projectId = this.projectList[0].value
-this._getDependItemList(val).then(depTasksList => {
- this.$nextTick(() => {
-this.$emit('dependItemListEvent', _.concat(this.dependItemList,
this._rtNewParams(val, depTasksList,projectId)))
+this._getProcessByProjectId(projectId).then(definitionList => {
+ // dependItemList index
+ let is = (value) => _.some(this.dependItemList, { definitionId:
value })
+ let noArr = _.filter(definitionList, v => !is(v.value))
+ let value = noArr[0] && noArr[0].value || null
+ let val = value || definitionList[0].value
+ this._getDependItemList(val).then(depTasksList => {
+this.$nextTick(() => {
+ this.$emit('dependItemListEvent', _.concat(this.dependItemList,
this._rtNewParams(val, definitionList, depTasksList, projectId)))
+})
})
})
// remove tooltip
@@ -131,25 +133,25 @@
*/
_getProcessList () {
return new Promise((resolve, reject) => {
- this.definitionList =
_.map(_.cloneDeep(this.store.state.dag.processListS), v => {
+ let definitionList =
_.map(_.cloneDeep(this.store.state.dag.processListS), v => {
return {
value: v.id,
label: v.name
}
})
- resolve()
+ resolve(definitionList)
})
},
_getProcessByProjectId (id) {
return new Promise((resolve, reject) => {
this.store.dispatch('dag/getProcessByProjectId', { projectId: id
}).then(res => {
-this.definitionList = _.map(_.cloneDeep(res), v => {
+let definitionList = _.map(_.cloneDeep(res), v => {
return {
value: v.id,
label: v.name
}
})
-resolve(res)
+resolve(definitionList)
})
})
},
@@ -175,7 +177,7 @@
_onChangeProjectId ({ value }) {
this._getProcessByProjectId(value).then(definitionList => {
/*this.$set(this.dependItemList, this.itemIndex,
this._dlOldParams(value, definitionList, item))*/
- let definitionId = definitionList[0].id
+ let definitionId = definitionList[0].value
this._getDependItemList(definitionId).then(depTasksList => {
let item = this.dependItemList[this.itemIndex]
// init set depTasks All
@@ -192,7 +194,7 @@
// init set depTasks All
item.depTasks = 'ALL'
// set dependItemList item data
- this.$set(this.dependItemList, this.itemIndex,
this._rtOldParams(value, depTasksList, item))
+ this.$set(this.dependItemList, this.itemIndex,
this._rtOldParams(value, item.definitionList, depTasksList, item))
})
},
_onChangeCycle ({ value }) {
@@ -200,10 +202,12 @@
this.$set(this.dependItemList[this.itemIndex], 'dateValue',
list[0].value)
this.$set(this.dependItemList[this.itemIndex], 'dateValueList', list)
},
- _rtNewParams (value, depTasksList,projectId) {
+ _rtNewParams (value, definitionList, depTasksList, projectId) {
return {
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1834: fix the bug #1816
qiaozhanwei merged pull request #1834: fix the bug #1816 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1834 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] samz406 commented on issue #1580: Problem creating session logic
samz406 commented on issue #1580: Problem creating session logic URL: https://github.com/apache/incubator-dolphinscheduler/issues/1580#issuecomment-574506161 support k8s ,use userId check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] samz406 closed issue #1580: Problem creating session logic
samz406 closed issue #1580: Problem creating session logic URL: https://github.com/apache/incubator-dolphinscheduler/issues/1580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] samz406 commented on issue #1819: fix session signOut may fail
samz406 commented on issue #1819: fix session signOut may fail URL: https://github.com/apache/incubator-dolphinscheduler/pull/1819#issuecomment-574504452 support k8s ,use userId check. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] samz406 closed pull request #1819: fix session signOut may fail
samz406 closed pull request #1819: fix session signOut may fail URL: https://github.com/apache/incubator-dolphinscheduler/pull/1819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #220: Dev 20190415
sonarcloud[bot] commented on issue #220: Dev 20190415 URL: https://github.com/apache/incubator-dolphinscheduler/pull/220#issuecomment-574490459 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=220=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=220=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=220=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1832: Requests the previous page when there is no data on the list page(#1768)
sonarcloud[bot] commented on issue #1832: Requests the previous page when there is no data on the list page(#1768) URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832#issuecomment-574487508 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1832=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1832=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1832=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1832: Requests the previous page when there is no data on the list page(#1768)
sonarcloud[bot] removed a comment on issue #1832: Requests the previous page when there is no data on the list page(#1768) URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832#issuecomment-574465706 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1832=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1832=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1832=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1832: Requests the previous page when there is no data on the list page(#1768)
codecov-io edited a comment on issue #1832: Requests the previous page when there is no data on the list page(#1768) URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832#issuecomment-574464965 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=h1) Report > Merging [#1832](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/09f9943fb6c4b64fdbe57add09846087b299840e?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=tree) ```diff @@ Coverage Diff @@ ## dev#1832 +/- ## === Coverage 21.38% 21.38% === Files 293 293 Lines 1404714047 Branches 2318 2318 === Hits 3004 3004 - Misses 1071610717+1 + Partials 327 326-1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=tree) | Coverage Δ | | |---|---|---| | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=footer). Last update [09f9943...1f29d93](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1834: fix the bug #1816
sonarcloud[bot] commented on issue #1834: fix the bug #1816 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1834#issuecomment-574485058 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1834=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1834=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1834=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1834=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen removed a comment on issue #1832: Requests the previous page when there is no data on the list page（#1768）
xingchun-chen removed a comment on issue #1832: Requests the previous page when there is no data on the list page（#1768） URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832#issuecomment-574472115 + This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] break60 commented on issue #1834: fix the bug #1816
break60 commented on issue #1834: fix the bug #1816 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1834#issuecomment-574483244 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] nauu opened a new pull request #1834: fix the bug #1816
nauu opened a new pull request #1834: fix the bug #1816 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1834 ## What is the purpose of the pull request fix the bug #1816. ## Brief change log - *Edit dependItemList.vue* ## Verify this pull request This change added tests and can be verified as follows: - *Manually verified the change by testing locally.* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1833: [Feature] AbstractCommandExecutor.commandType difficult to understand
sonarcloud[bot] commented on issue #1833: [Feature] AbstractCommandExecutor.commandType difficult to understand URL: https://github.com/apache/incubator-dolphinscheduler/pull/1833#issuecomment-574479310 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1833=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1833=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1833=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1833=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1833=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1814: fix bug, add the cache logic in getInstancedetail
qiaozhanwei merged pull request #1814: fix bug, add the cache logic in getInstancedetail URL: https://github.com/apache/incubator-dolphinscheduler/pull/1814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated (0b272f9 -> 512e7c1)
This is an automated email from the ASF dual-hosted git repository. journey pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 0b272f9 [feature] #1813 remove "_001" after the master/server register path in zookeeper (#1820) add 512e7c1 fix bug, add the cache logic in getInstancedetail. (#1814) No new revisions were added by this update. Summary of changes: .../src/js/conf/home/pages/dag/_source/formModel/formModel.vue | 3 ++- dolphinscheduler-ui/src/js/conf/home/store/dag/actions.js| 5 + 2 files changed, 7 insertions(+), 1 deletion(-)
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1833: [Feature] AbstractCommandExecutor.commandType difficult to understand
codecov-io commented on issue #1833: [Feature] AbstractCommandExecutor.commandType difficult to understand URL: https://github.com/apache/incubator-dolphinscheduler/pull/1833#issuecomment-574478583 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833?src=pr=h1) Report > Merging [#1833](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/0b272f9ca668e10f130482e93e6850ea5daa8bd1?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833?src=pr=tree) ```diff @@Coverage Diff @@ ## dev#1833 +/- ## == - Coverage 21.39% 21.38% -0.01% == Files 293 293 Lines 1404714047 Branches 2318 2318 == - Hits 3005 3004 -1 - Misses 1071510716 +1 Partials 327 327 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833?src=pr=tree) | Coverage Δ | | |---|---|---| | [...duler/server/worker/task/ShellCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1NoZWxsQ29tbWFuZEV4ZWN1dG9yLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...uler/server/worker/task/PythonCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL1B5dGhvbkNvbW1hbmRFeGVjdXRvci5qYXZh) | `0% <ø> (ø)` | :arrow_up: | | [...er/server/worker/task/AbstractCommandExecutor.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL0Fic3RyYWN0Q29tbWFuZEV4ZWN1dG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833?src=pr=footer). Last update [0b272f9...67ee0db](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1833?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1814: fix bug, add the cache logic in getInstancedetail
xingchun-chen commented on issue #1814: fix bug, add the cache logic in getInstancedetail URL: https://github.com/apache/incubator-dolphinscheduler/pull/1814#issuecomment-574477291 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] gabrywu opened a new pull request #1833: [Feature] AbstractCommandExecutor.commandType difficult to understand
gabrywu opened a new pull request #1833: [Feature] AbstractCommandExecutor.commandType difficult to understand URL: https://github.com/apache/incubator-dolphinscheduler/pull/1833 https://github.com/apache/incubator-dolphinscheduler/issues/1831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen closed issue #1816: [dev_1.2.1] Add multiple dependencies, the workflow definitions of the first few dependencies read the workflow definition of th
xingchun-chen closed issue #1816: [dev_1.2.1] Add multiple dependencies, the workflow definitions of the first few dependencies read the workflow definition of the last project URL: https://github.com/apache/incubator-dolphinscheduler/issues/1816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen closed issue #1810: [dev_1.2.1]Workflow instance does not show dependencies
xingchun-chen closed issue #1810: [dev_1.2.1]Workflow instance does not show dependencies URL: https://github.com/apache/incubator-dolphinscheduler/issues/1810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1832: Requests the previous page when there is no data on the list page（#1768）
xingchun-chen commented on issue #1832: Requests the previous page when there is no data on the list page（#1768） URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832#issuecomment-574472115 + This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1832: Requests the previous page when there is no data on the list page（#1768）
xingchun-chen commented on issue #1832: Requests the previous page when there is no data on the list page（#1768） URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832#issuecomment-574472157 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev-1.2.1 updated: Fix DAG add dependent project value exception # 1816 and keep requesting task interface (#1827)
This is an automated email from the ASF dual-hosted git repository.
lgcareer pushed a commit to branch dev-1.2.1
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev-1.2.1 by this push:
new 99a9db2 Fix DAG add dependent project value exception # 1816 and keep
requesting task interface (#1827)
99a9db2 is described below
commit 99a9db2ba1a803a121b8ad95f5ac096c6ef2e764
Author: break60 <790061...@qq.com>
AuthorDate: Wed Jan 15 10:30:57 2020 +0800
Fix DAG add dependent project value exception # 1816 and keep requesting
task interface (#1827)
* merge dev branch front-end code
* fix udfs assignment
* Fix task instance page jump
* fix udfs assignment and task instance page jump #1789
* Fixed space and icon display issues before and after the input box
* add license
* add license
* Fix data echo, style and popup cannot be closed
* Fix page number loading issue and dag not getting value
* Fix DAG add dependent project value exception # 1816 and keep requesting
task interface
---
.../src/js/conf/home/pages/dag/_source/dag.scss| 9 +++--
.../src/js/conf/home/pages/dag/_source/dag.vue | 22 +++-
.../formModel/tasks/_source/dependItemList.vue | 42 +++---
.../src/js/module/i18n/locale/en_US.js | 1 +
.../src/js/module/i18n/locale/zh_CN.js | 1 +
5 files changed, 44 insertions(+), 31 deletions(-)
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.scss
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.scss
index a63157d..fbb4f41 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.scss
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.scss
@@ -159,6 +159,9 @@
border-radius: 0 3px 0 0;
.ans-btn-text {
color: #337ab7;
+.ans-icon {
+ font-size: 16px;
+}
}
.assist-btn {
position: absolute;
@@ -206,7 +209,7 @@
color: #333;
}
&.active {
- background: #e1e2e3;
+ // background: #e1e2e3;
i {
color: #2d8cf0;
}
@@ -234,7 +237,9 @@
border-radius: 3px 3px 0px 0px;
}
}
-
+#screen {
+ margin-right: 5px;
+}
.v-modal-custom-log {
z-index: 101;
}
diff --git a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.vue
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.vue
index feb756d..40b6d85 100644
--- a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.vue
+++ b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.vue
@@ -61,20 +61,28 @@
-
+
-
+
-
+
+
{})
-// Round robin acquisition status
-this.setIntervalP = setInterval(() => {
- this._getTaskState(true).then(res => {})
-}, 9)
}
} else {
Dag.create()
diff --git
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/dependItemList.vue
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/dependItemList.vue
index d6c8657..00c5503 100644
---
a/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/dependItemList.vue
+++
b/dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/_source/dependItemList.vue
@@ -22,7 +22,7 @@
-
+
@@ -64,7 +64,6 @@
data () {
return {
list: [],
-definitionList: [],
projectList: [],
cycleList: cycleList,
isInstance: false,
@@ -88,16 +87,19 @@
_add () {
// btn loading
this.isLoading = true
-// dependItemList index
-let is = (value) => _.some(this.dependItemList, { definitionId: value
})
-let noArr = _.filter(this.definitionList, v => !is(v.value))
-let value = noArr[0] && noArr[0].value || null
-let val = value || this.definitionList[0].value
+// // dependItemList index
+// let is = (value) => _.some(this.dependItemList, { definitionId:
value })
+// let noArr = _.filter(this.definitionList, v => !is(v.value))
+// let value = noArr[0] && noArr[0].value || null
+// let val = value || this.definitionList[0].value
// add task list
let projectId = this.projectList[0].value
-this._getDependItemList(val).then(depTasksList => {
- this.$nextTick(() => {
-this.$emit('dependItemListEvent', _.concat(this.dependItemList,
this._rtNewParams(val, depTasksList,projectId)))
+
[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface
lgcareer merged pull request #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface URL: https://github.com/apache/incubator-dolphinscheduler/pull/1827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1832: Requests the previous page when there is no data on the list page（#1768）
sonarcloud[bot] commented on issue #1832: Requests the previous page when there is no data on the list page（#1768） URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832#issuecomment-574465706 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1832=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1832=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1832=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1832=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1832: Requests the previous page when there is no data on the list page（#1768）
codecov-io commented on issue #1832: Requests the previous page when there is no data on the list page（#1768） URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832#issuecomment-574464965 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=h1) Report > Merging [#1832](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/ca5a8a5258d27782fb6b57bbc57734afff1bcfce?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `2.77%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=tree) ```diff @@Coverage Diff @@ ## dev#1832 +/- ## == - Coverage 21.38% 21.38% -0.01% == Files 293 293 Lines 1405114047 -4 Branches 2316 2318 +2 == - Hits 3005 3004 -1 + Misses 1071910716 -3 Partials 327 327 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=tree) | Coverage Δ | | |---|---|---| | [...e/dolphinscheduler/server/worker/WorkerServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9Xb3JrZXJTZXJ2ZXIuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: | | [...apache/dolphinscheduler/common/thread/Stopper.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3RocmVhZC9TdG9wcGVyLmphdmE=) | `80% <ø> (ø)` | :arrow_up: | | [...inscheduler/common/zk/ZookeeperCachedOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlckNhY2hlZE9wZXJhdG9yLmphdmE=) | `0% <ø> (ø)` | :arrow_up: | | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...g/apache/dolphinscheduler/api/utils/FileUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0ZpbGVVdGlscy5qYXZh) | `72% <0%> (ø)` | :arrow_up: | | [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [...e/dolphinscheduler/server/master/MasterServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9NYXN0ZXJTZXJ2ZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...apache/dolphinscheduler/alert/utils/MailUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9NYWlsVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...che/dolphinscheduler/alert/runner/AlertSender.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9ydW5uZXIvQWxlcnRTZW5kZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1832?src=pr=continue). > **Legend** - [Click here to learn
[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1832: Requests the previous page when there is no data on the list page
break60 opened a new pull request #1832: Requests the previous page when there is no data on the list page URL: https://github.com/apache/incubator-dolphinscheduler/pull/1832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] gabrywu opened a new issue #1831: [Feature] AbstractCommandExecutor.commandType difficult to understand
gabrywu opened a new issue #1831: [Feature] AbstractCommandExecutor.commandType
difficult to understand
URL: https://github.com/apache/incubator-dolphinscheduler/issues/1831
## Background
In the AbstractCommandExecutor class ,commandType function is used to
stitching the final command strings.
`processBuilder.command("sudo", "-u", tenantCode, commandType(),
commandFile);`
That is difficult to understand, which even is ambiguous.
Why not rename commandType function a better name
## Suggestion
rename 'commandType' to 'rootCommand'
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface
xingchun-chen commented on issue #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface URL: https://github.com/apache/incubator-dolphinscheduler/pull/1827#issuecomment-574456728 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1716: Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause.
dailidong commented on issue #1716: Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1716#issuecomment-574170024 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #1716: Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause.
dailidong commented on a change in pull request #1716: Fix bug: Use
try-with-resources or close this "Socket" in a "finally" clause.
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1716#discussion_r363068718
##
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/FourLetterWordMain.java
##
@@ -59,23 +59,22 @@ public static String send4LetterWord(String host, int
port, String cmd)
*/
public static String send4LetterWord(String host, int port, String cmd,
int timeout)
throws IOException {
-LOG.info("connecting to " + host + " " + port);
-Socket sock = new Socket();
+LOG.info("connecting to {0} {1}", host, port);
InetSocketAddress hostaddress= host != null ? new
InetSocketAddress(host, port) :
new InetSocketAddress(InetAddress.getByName(null), port);
-BufferedReader reader = null;
-try {
+
+try (Socket sock = new Socket();
+ OutputStream outstream = sock.getOutputStream();
+ BufferedReader reader =
+new BufferedReader(
+new InputStreamReader(sock.getInputStream( {
sock.setSoTimeout(timeout);
sock.connect(hostaddress, timeout);
-OutputStream outstream = sock.getOutputStream();
outstream.write(cmd.getBytes());
outstream.flush();
// this replicates NC - close the output stream before reading
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #1716: Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause.
dailidong commented on a change in pull request #1716: Fix bug: Use
try-with-resources or close this "Socket" in a "finally" clause.
URL:
https://github.com/apache/incubator-dolphinscheduler/pull/1716#discussion_r363068716
##
File path:
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/utils/FourLetterWordMain.java
##
@@ -59,23 +59,22 @@ public static String send4LetterWord(String host, int
port, String cmd)
*/
public static String send4LetterWord(String host, int port, String cmd,
int timeout)
throws IOException {
-LOG.info("connecting to " + host + " " + port);
-Socket sock = new Socket();
+LOG.info("connecting to {0} {1}", host, port);
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #1716: Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause.
dailidong commented on a change in pull request #1716: Fix bug: Use try-with-resources or close this "Socket" in a "finally" clause. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1716#discussion_r363068712 ## File path: dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java ## @@ -446,6 +452,6 @@ public void printReplacedSql(String content, String formatSql,String rgex, Map
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1830: Supplementary data by schedule
sonarcloud[bot] commented on issue #1830: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1830#issuecomment-574132998 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1830=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1830=new_coverage=list) [57.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1830=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1830=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1830=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1829: Supplementary data by schedule
sonarcloud[bot] commented on issue #1829: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1829#issuecomment-574132313 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1829=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1829=new_coverage=list) [57.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1829=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1829=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1829=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lfyee opened a new pull request #1830: Supplementary data by schedule
lfyee opened a new pull request #1830: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1830 ## What is the purpose of the pull request #1550 fix feature: Supplementary data with schedule When the task complement is run, a execution plan list is generated according to the scheduling plan. If the execution plan list is not empty, it is scheduled according to the plan list. If the execution plan is empty, it is executed daily. ## Brief change log for parallel run - edit dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java for serial run - edit dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java dao - edit dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/ProcessDao.java - edit dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.java - edit dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.xml util - add dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ScheduleUtils.java ui - edit dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue - edit dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js - edit dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js ## Verify this pull request Manually verified the change by testing locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lfyee closed pull request #1829: Supplementary data by schedule
lfyee closed pull request #1829: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lfyee opened a new pull request #1829: Supplementary data by schedule
lfyee opened a new pull request #1829: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1829 ## What is the purpose of the pull request #1550 fix feature: Supplementary data with schedule When the task complement is run, a execution plan list is generated according to the scheduling plan. If the execution plan list is not empty, it is scheduled according to the plan list. If the execution plan is empty, it is executed daily. ## Brief change log for parallel run - edit dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java for serial run - edit dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java dao - edit dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/ProcessDao.java - edit dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.java - edit dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.xml util - add dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ScheduleUtils.java ui - edit dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue - edit dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js - edit dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js ## Verify this pull request Manually verified the change by testing locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lfyee closed pull request #1811: Supplementary data by schedule
lfyee closed pull request #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1811: Supplementary data by schedule
sonarcloud[bot] commented on issue #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811#issuecomment-574126593 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_coverage=list) [57.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1811: Supplementary data by schedule
sonarcloud[bot] removed a comment on issue #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811#issuecomment-574104161 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_coverage=list) [57.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Yeleights closed pull request #1808: fix sonar bug: null check in api.executorService
Yeleights closed pull request #1808: fix sonar bug: null check in api.executorService URL: https://github.com/apache/incubator-dolphinscheduler/pull/1808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1811: Supplementary data by schedule
codecov-io edited a comment on issue #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811#issuecomment-573609450 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=h1) Report > Merging [#1811](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/289ae6ac96857dc965a05f37285def8cbc4a5b34?src=pr=desc) will **increase** coverage by `0.36%`. > The diff coverage is `58.75%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=tree) ```diff @@Coverage Diff@@ ## dev#1811 +/- ## = + Coverage 21.4% 21.76% +0.36% = Files293 294 +1 Lines 1405114205 +154 Branches2316 2352 +36 = + Hits3007 3092 +85 - Misses 1071710766 +49 - Partials 327 347 +20 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=tree) | Coverage Δ | | |---|---|---| | [...va/org/apache/dolphinscheduler/dao/ProcessDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL1Byb2Nlc3NEYW8uamF2YQ==) | `0.85% <0%> (-0.01%)` | :arrow_down: | | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `28.38% <87.09%> (+27.91%)` | :arrow_up: | | [...e/dolphinscheduler/server/utils/ScheduleUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NjaGVkdWxlVXRpbHMuamF2YQ==) | `95.23% <95.23%> (ø)` | | | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | :arrow_down: | | [...he/dolphinscheduler/alert/utils/PropertyUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Qcm9wZXJ0eVV0aWxzLmphdmE=) | `87.5% <0%> (-0.74%)` | :arrow_down: | | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `35.66% <0%> (-0.18%)` | :arrow_down: | | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...apache/dolphinscheduler/alert/utils/MailUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9NYWlsVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | ... and [3 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=continue). >
[GitHub] [incubator-dolphinscheduler] xingchun-chen commented on issue #1828: [dev_1.2.1] After executing the authorized UDF function, the path of the read resource file is incorrect
xingchun-chen commented on issue #1828: [dev_1.2.1] After executing the authorized UDF function, the path of the read resource file is incorrect URL: https://github.com/apache/incubator-dolphinscheduler/issues/1828#issuecomment-574111264 @lgcareer This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] xingchun-chen opened a new issue #1828: [dev_1.2.1] After executing the authorized UDF function, the path of the read resource file is incorrect
xingchun-chen opened a new issue #1828: [dev_1.2.1] After executing the authorized UDF function, the path of the read resource file is incorrect URL: https://github.com/apache/incubator-dolphinscheduler/issues/1828  1.Authorize the udf function of the tenant hdfs to user A. 2.User A creates a hive SQL and selects the authorized udf function. 3.After running the workflow, the path of the resource file read by the udf is incorrect, as shown in the figure above, but the udf resource of the tenant hdfs The path is shown below 1.将租户hdfs的udf函数授权给用户A 2.用户A创建hive类型的sql,并选择授权的udf函数， 3.运行工作流后，udf读取的资源文件路径不正确，如上图所示，但租户hdfs的udf资源路径如下图所示：  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1811: Supplementary data by schedule
codecov-io edited a comment on issue #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811#issuecomment-573609450 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=h1) Report > Merging [#1811](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/289ae6ac96857dc965a05f37285def8cbc4a5b34?src=pr=desc) will **increase** coverage by `0.37%`. > The diff coverage is `60.25%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=tree) ```diff @@Coverage Diff@@ ## dev#1811 +/- ## = + Coverage 21.4% 21.77% +0.37% = Files293 294 +1 Lines 1405114205 +154 Branches2316 2352 +36 = + Hits3007 3093 +86 - Misses 1071710764 +47 - Partials 327 348 +21 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=tree) | Coverage Δ | | |---|---|---| | [...va/org/apache/dolphinscheduler/dao/ProcessDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL1Byb2Nlc3NEYW8uamF2YQ==) | `0.85% <0%> (-0.01%)` | :arrow_down: | | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `28.38% <87.09%> (+27.91%)` | :arrow_up: | | [...e/dolphinscheduler/server/utils/ScheduleUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NjaGVkdWxlVXRpbHMuamF2YQ==) | `95.23% <95.23%> (ø)` | | | [...he/dolphinscheduler/alert/utils/PropertyUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Qcm9wZXJ0eVV0aWxzLmphdmE=) | `87.5% <0%> (-0.74%)` | :arrow_down: | | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `35.66% <0%> (-0.18%)` | :arrow_down: | | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...apache/dolphinscheduler/alert/utils/MailUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9NYWlsVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...inscheduler/common/zk/ZookeeperCachedOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlckNhY2hlZE9wZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=continue). > **Legend** -
[GitHub] [incubator-dolphinscheduler] lfyee closed pull request #1811: Supplementary data by schedule
lfyee closed pull request #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lfyee opened a new pull request #1811: Supplementary data by schedule
lfyee opened a new pull request #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811 ## What is the purpose of the pull request #1550 fix feature: Supplementary data with schedule When the task complement is run, a execution plan list is generated according to the scheduling plan. If the execution plan list is not empty, it is scheduled according to the plan list. If the execution plan is empty, it is executed daily. ## Brief change log for parallel run - edit dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java for serial run - edit dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java dao - edit dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/ProcessDao.java - edit dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.java - edit dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.xml util - add dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ScheduleUtils.java ui - edit dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue - edit dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js - edit dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js ## Verify this pull request Manually verified the change by testing locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface
codecov-io commented on issue #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface URL: https://github.com/apache/incubator-dolphinscheduler/pull/1827#issuecomment-574105118 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`dev-1.2.1@fa55b50`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827?src=pr=tree) ```diff @@ Coverage Diff @@ ## dev-1.2.1#1827 +/- ## Coverage ? 13.33% Files? 284 Lines?13993 Branches ? 2262 Hits ? 1866 Misses ?11921 Partials ? 206 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827?src=pr=tree) | Coverage Δ | | |---|---|---| | [...inscheduler/common/zk/ZookeeperCachedOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlckNhY2hlZE9wZXJhdG9yLmphdmE=) | `0% <ø> (ø)` | | | [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | | | [...lphinscheduler/common/enums/AuthorizationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0F1dGhvcml6YXRpb25UeXBlLmphdmE=) | `0% <0%> (ø)` | | | [...lphinscheduler/dao/permission/PermissionCheck.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3Blcm1pc3Npb24vUGVybWlzc2lvbkNoZWNrLmphdmE=) | `0% <0%> (ø)` | | | [...lphinscheduler/server/worker/task/sql/SqlTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NxbC9TcWxUYXNrLmphdmE=) | `0% <0%> (ø)` | | | [...duler/server/worker/runner/TaskScheduleThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza1NjaGVkdWxlVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | | | [...va/org/apache/dolphinscheduler/dao/ProcessDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL1Byb2Nlc3NEYW8uamF2YQ==) | `0.84% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827?src=pr=footer). Last update [fa55b50...adc744d](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1827?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface
sonarcloud[bot] commented on issue #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface URL: https://github.com/apache/incubator-dolphinscheduler/pull/1827#issuecomment-574105119 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1827=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1827=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1827=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1811: Supplementary data by schedule
sonarcloud[bot] commented on issue #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811#issuecomment-574104161 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_coverage=list) [57.6% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1811: Supplementary data by schedule
sonarcloud[bot] removed a comment on issue #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811#issuecomment-573626555 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1811=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1811=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] break60 opened a new pull request #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface
break60 opened a new pull request #1827: Fix DAG add dependent project value exception # 1816 and keep requesting task interface URL: https://github.com/apache/incubator-dolphinscheduler/pull/1827 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1811: Supplementary data by schedule
codecov-io edited a comment on issue #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811#issuecomment-573609450 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=h1) Report > Merging [#1811](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/289ae6ac96857dc965a05f37285def8cbc4a5b34?src=pr=desc) will **increase** coverage by `0.37%`. > The diff coverage is `60.25%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=tree) ```diff @@Coverage Diff@@ ## dev#1811 +/- ## = + Coverage 21.4% 21.77% +0.37% = Files293 294 +1 Lines 1405114205 +154 Branches2316 2352 +36 = + Hits3007 3093 +86 - Misses 1071710764 +47 - Partials 327 348 +21 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=tree) | Coverage Δ | | |---|---|---| | [...va/org/apache/dolphinscheduler/dao/ProcessDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL1Byb2Nlc3NEYW8uamF2YQ==) | `0.85% <0%> (-0.01%)` | :arrow_down: | | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `28.38% <87.09%> (+27.91%)` | :arrow_up: | | [...e/dolphinscheduler/server/utils/ScheduleUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NjaGVkdWxlVXRpbHMuamF2YQ==) | `95.23% <95.23%> (ø)` | | | [...he/dolphinscheduler/alert/utils/PropertyUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Qcm9wZXJ0eVV0aWxzLmphdmE=) | `87.5% <0%> (-0.74%)` | :arrow_down: | | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `35.66% <0%> (-0.18%)` | :arrow_down: | | [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...e/dolphinscheduler/common/zk/AbstractZKClient.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL0Fic3RyYWN0WktDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...apache/dolphinscheduler/alert/utils/MailUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9NYWlsVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: | | [...inscheduler/common/zk/ZookeeperCachedOperator.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3prL1pvb2tlZXBlckNhY2hlZE9wZXJhdG9yLmphdmE=) | `0% <0%> (ø)` | :arrow_up: | | ... and [2 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=continue). > **Legend** -
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1811: Supplementary data by schedule
codecov-io edited a comment on issue #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811#issuecomment-573609450 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=h1) Report > Merging [#1811](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/289ae6ac96857dc965a05f37285def8cbc4a5b34?src=pr=desc) will **increase** coverage by `0.49%`. > The diff coverage is `60.25%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=tree) ```diff @@Coverage Diff@@ ## dev#1811 +/- ## = + Coverage 21.4% 21.89% +0.49% = Files293 294 +1 Lines 1405114111 +60 Branches2316 2329 +13 = + Hits3007 3089 +82 + Misses 1071710674 -43 - Partials 327 348 +21 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=tree) | Coverage Δ | | |---|---|---| | [...va/org/apache/dolphinscheduler/dao/ProcessDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL1Byb2Nlc3NEYW8uamF2YQ==) | `0.85% <0%> (-0.01%)` | :arrow_down: | | [...heduler/server/master/runner/MasterExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyRXhlY1RocmVhZC5qYXZh) | `0% <0%> (ø)` | :arrow_up: | | [.../dolphinscheduler/api/service/ExecutorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvRXhlY3V0b3JTZXJ2aWNlLmphdmE=) | `28.38% <87.09%> (+27.91%)` | :arrow_up: | | [...e/dolphinscheduler/server/utils/ScheduleUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3V0aWxzL1NjaGVkdWxlVXRpbHMuamF2YQ==) | `95.23% <95.23%> (ø)` | | | [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | :arrow_down: | | [...cheduler/api/service/ProcessDefinitionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvUHJvY2Vzc0RlZmluaXRpb25TZXJ2aWNlLmphdmE=) | `35.66% <0%> (-0.18%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=footer). Last update [289ae6a...46e7d37](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1811?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lfyee opened a new pull request #1811: Supplementary data by schedule
lfyee opened a new pull request #1811: Supplementary data by schedule URL: https://github.com/apache/incubator-dolphinscheduler/pull/1811 ## What is the purpose of the pull request #1550 fix feature: Supplementary data with schedule When the task complement is run, a execution plan list is generated according to the scheduling plan. If the execution plan list is not empty, it is scheduled according to the plan list. If the execution plan is empty, it is executed daily. ## Brief change log for parallel run - edit dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java for serial run - edit dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java dao - edit dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/ProcessDao.java - edit dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.java - edit dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ScheduleMapper.xml util - add dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/ScheduleUtils.java ui - edit dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue - edit dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js - edit dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js ## Verify this pull request Manually verified the change by testing locally. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lgcareer opened a new pull request #1826: [Fix issue #1770]check udf and data source in order to fix issue 1770
lgcareer opened a new pull request #1826: [Fix issue #1770]check udf and data source in order to fix issue 1770 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1826 ## What is the purpose of the pull request *check udf and data source in order to fix issue 1770* ## Brief change log *(for example:)* - *Add AuthorizationType Enum* - *Add PermissionCheck* - *Add listAuthorizedDataSource in DataSourceMapper* - *Add listAuthorizedUdfFunc in UdfFuncMapper* ## Verify this pull request This change added tests and can be verified as follows: *(example:)* - *testListAuthorizedUdfFunc in UdfFuncMapperTest* - *testListAuthorizedDataSource in DataSourceMapperTest* This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1825: replace strings with constants already exist.
sonarcloud[bot] commented on issue #1825: replace strings with constants already exist. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1825#issuecomment-574093388 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1825=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1825=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1825=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1825=new_duplicated_lines_density=list) [14.3% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1825=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] samz406 commented on issue #1465: [CI/CD]Add unit test
samz406 commented on issue #1465: [CI/CD]Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/issues/1465#issuecomment-574088824 and I want to implements org.apache.dolphinscheduler.api.service.BaseDAGService This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] Nivane opened a new pull request #1825: replace strings with constants already exist.
Nivane opened a new pull request #1825: replace strings with constants already exist. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1825 ## What is the purpose of the pull request replace strings with constants already exist. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev-1.2.1 updated: remove install.sh server.servlet.context-path replace (#1823)
This is an automated email from the ASF dual-hosted git repository.
lgcareer pushed a commit to branch dev-1.2.1
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git
The following commit(s) were added to refs/heads/dev-1.2.1 by this push:
new 9819599 remove install.sh server.servlet.context-path replace (#1823)
9819599 is described below
commit 9819599cab52373662e1af85a91470032c5cbda3
Author: qiaozhanwei
AuthorDate: Tue Jan 14 17:11:22 2020 +0800
remove install.sh server.servlet.context-path replace (#1823)
* fix #1775 bug，delete process definition when process instance is running
* revert CONTRIBUTING.md
* dockerfile modify
* dockerfile modify
* dockerfile modify
* remove install.sh server.servlet.context-path replace
---
install.sh | 8
1 file changed, 8 deletions(-)
diff --git a/install.sh b/install.sh
index 354cdd2..5147d95 100644
--- a/install.sh
+++ b/install.sh
@@ -145,10 +145,6 @@ enterpriseWechatAgentId="xx"
# Enterprise WeChat user configuration, multiple users to , split
enterpriseWechatUsers="x,x"
-
-# whether to start monitoring self-starting scripts
-monitorServerState="false"
-
# resource Center upload and select storage method：HDFS,S3,NONE
resUploadStartupType="NONE"
@@ -268,9 +264,6 @@ apiServerPort="12345"
# api session timeout
apiServerSessionTimeout="7200"
-# api server context path
-apiServerContextPath="/dolphinscheduler/"
-
# spring max file size
springMaxFileSize="1024MB"
@@ -351,7 +344,6 @@ sed -i ${txt}
"s#zookeeper.retry.maxtime.*#zookeeper.retry.maxtime=${zkRetryMaxt
sed -i ${txt} "s#server.port.*#server.port=${apiServerPort}#g"
conf/application-api.properties
sed -i ${txt}
"s#server.servlet.session.timeout.*#server.servlet.session.timeout=${apiServerSessionTimeout}#g"
conf/application-api.properties
-sed -i ${txt}
"s#server.servlet.context-path.*#server.servlet.context-path=${apiServerContextPath}#g"
conf/application-api.properties
sed -i ${txt}
"s#spring.servlet.multipart.max-file-size.*#spring.servlet.multipart.max-file-size=${springMaxFileSize}#g"
conf/application-api.properties
sed -i ${txt}
"s#spring.servlet.multipart.max-request-size.*#spring.servlet.multipart.max-request-size=${springMaxRequestSize}#g"
conf/application-api.properties
sed -i ${txt}
"s#server.jetty.max-http-post-size.*#server.jetty.max-http-post-size=${apiMaxHttpPostSize}#g"
conf/application-api.properties
[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1823: remove install.sh server.servlet.context-path replace
lgcareer merged pull request #1823: remove install.sh server.servlet.context-path replace URL: https://github.com/apache/incubator-dolphinscheduler/pull/1823 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev-1.2.1 updated (d7b55ab -> 372e58d)
This is an automated email from the ASF dual-hosted git repository. leonbao pushed a change to branch dev-1.2.1 in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from d7b55ab [Fix issue #1770]check udf and data source in order to fix issue 1770 (#1817) add 372e58d #1813 remove "_001" after the master/server register path in zookeepe (#1824) No new revisions were added by this update. Summary of changes: .../common/zk/AbstractZKClient.java| 55 +- .../common/zk/ZookeeperCachedOperator.java | 1 + 2 files changed, 22 insertions(+), 34 deletions(-)
[GitHub] [incubator-dolphinscheduler] lenboo merged pull request #1824: #1813 remove "_001" after the master/server register path in zookeepe
lenboo merged pull request #1824: #1813 remove "_001" after the master/server register path in zookeepe URL: https://github.com/apache/incubator-dolphinscheduler/pull/1824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1824: #1813 remove "_001" after the master/server register path in zookeepe
sonarcloud[bot] commented on issue #1824: #1813 remove "_001" after the master/server register path in zookeepe URL: https://github.com/apache/incubator-dolphinscheduler/pull/1824#issuecomment-574073321 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1824=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1824=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1824=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1824=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1824=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1824: #1813 remove "_001" after the master/server register path in zookeepe
codecov-io commented on issue #1824: #1813 remove "_001" after the master/server register path in zookeepe URL: https://github.com/apache/incubator-dolphinscheduler/pull/1824#issuecomment-574073086 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`dev-1.2.1@d5ddab2`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824?src=pr=tree) ```diff @@ Coverage Diff @@ ## dev-1.2.1#1824 +/- ## Coverage ? 13.33% Files? 284 Lines?13993 Branches ? 2262 Hits ? 1866 Misses ?11921 Partials ? 206 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824?src=pr=tree) | Coverage Δ | | |---|---|---| | [...lphinscheduler/common/enums/AuthorizationType.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL2VudW1zL0F1dGhvcml6YXRpb25UeXBlLmphdmE=) | `0% <0%> (ø)` | | | [...lphinscheduler/dao/permission/PermissionCheck.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL3Blcm1pc3Npb24vUGVybWlzc2lvbkNoZWNrLmphdmE=) | `0% <0%> (ø)` | | | [...lphinscheduler/server/worker/task/sql/SqlTask.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci90YXNrL3NxbC9TcWxUYXNrLmphdmE=) | `0% <0%> (ø)` | | | [...duler/server/worker/runner/TaskScheduleThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvVGFza1NjaGVkdWxlVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | | | [...va/org/apache/dolphinscheduler/dao/ProcessDao.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824/diff?src=pr=tree#diff-ZG9scGhpbnNjaGVkdWxlci1kYW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvZGFvL1Byb2Nlc3NEYW8uamF2YQ==) | `0.84% <0%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824?src=pr=footer). Last update [d5ddab2...d86f0ce](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1824?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lenboo opened a new pull request #1824: #1813 remove "_001" after the master/server register path in zookeepe
lenboo opened a new pull request #1824: #1813 remove "_001" after the master/server register path in zookeepe URL: https://github.com/apache/incubator-dolphinscheduler/pull/1824 #1813 remove "_001" after the master/server register path in zookeeper This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1823: remove install.sh server.servlet.context-path replace
sonarcloud[bot] commented on issue #1823: remove install.sh server.servlet.context-path replace URL: https://github.com/apache/incubator-dolphinscheduler/pull/1823#issuecomment-574063596 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1823=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1823=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1823=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] qiaozhanwei opened a new pull request #1823: remove install.sh server.servlet.context-path replace
qiaozhanwei opened a new pull request #1823: remove install.sh server.servlet.context-path replace URL: https://github.com/apache/incubator-dolphinscheduler/pull/1823 remove install.sh server.servlet.context-path replace This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lanluyu123 commented on issue #1818: 在safari浏览器下，没有开始时间和提交时间
lanluyu123 commented on issue #1818: 在safari浏览器下，没有开始时间和提交时间 URL: https://github.com/apache/incubator-dolphinscheduler/issues/1818#issuecomment-574061799 Under the safari browser, there are no two fields: start time and submission time.Tks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] samz406 commented on issue #1465: [CI/CD]Add unit test
samz406 commented on issue #1465: [CI/CD]Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/issues/1465#issuecomment-574061606 and I want to implements org.apache.dolphinscheduler.api.service.BaseService This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] lgcareer merged pull request #1820: [feature] #1813 remove "_001" after the master/server register path in zookeeper
lgcareer merged pull request #1820: [feature] #1813 remove "_001" after the master/server register path in zookeeper URL: https://github.com/apache/incubator-dolphinscheduler/pull/1820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated (68f7369 -> 0b272f9)
This is an automated email from the ASF dual-hosted git repository. lgcareer pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 68f7369 fix typos (#1821) add 0b272f9 [feature] #1813 remove "_001" after the master/server register path in zookeeper (#1820) No new revisions were added by this update. Summary of changes: .../common/zk/AbstractZKClient.java| 55 +- .../common/zk/ZookeeperCachedOperator.java | 1 + 2 files changed, 22 insertions(+), 34 deletions(-)
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1821: fix typos
dailidong commented on issue #1821: fix typos URL: https://github.com/apache/incubator-dolphinscheduler/pull/1821#issuecomment-574056785 Thanks for your contribution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[incubator-dolphinscheduler] branch dev updated (8399ab4 -> 68f7369)
This is an automated email from the ASF dual-hosted git repository. lidongdai pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 8399ab4 add null check in markdownTable & modify EnterpriseWeChatManager logger class (#1809) add 68f7369 fix typos (#1821) No new revisions were added by this update. Summary of changes: .../src/main/java/org/apache/dolphinscheduler/alert/AlertServer.java| 2 +- .../main/java/org/apache/dolphinscheduler/alert/utils/Constants.java| 2 +- .../main/java/org/apache/dolphinscheduler/common/thread/Stopper.java| 2 +- .../org/apache/dolphinscheduler/common/threadutils/ThreadUtilsTest.java | 2 +- .../java/org/apache/dolphinscheduler/server/master/MasterServer.java| 2 +- .../java/org/apache/dolphinscheduler/server/worker/WorkerServer.java| 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1821: fix typos
dailidong commented on issue #1821: fix typos URL: https://github.com/apache/incubator-dolphinscheduler/pull/1821#issuecomment-574056561 small changes， no need more Committer review this pr This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #1821: fix typos
dailidong merged pull request #1821: fix typos URL: https://github.com/apache/incubator-dolphinscheduler/pull/1821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1819: fix session signOut may fail
sonarcloud[bot] commented on issue #1819: fix session signOut may fail URL: https://github.com/apache/incubator-dolphinscheduler/pull/1819#issuecomment-574051966 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1819=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1819=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1819=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1819=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1819: fix session signOut may fail
sonarcloud[bot] removed a comment on issue #1819: fix session signOut may fail URL: https://github.com/apache/incubator-dolphinscheduler/pull/1819#issuecomment-574046528 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1819=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1819=new_coverage=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1819=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1819=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler=1819=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
