liaoxin01 merged PR #35287:
URL: https://github.com/apache/doris/pull/35287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
github-actions[bot] commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2136614818
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2133113862
ClickBench: Total hot run time: 30.56 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2133103769
TPC-DS: Total hot run time: 172477 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2133082616
TPC-H: Total hot run time: 40475 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2132575909
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kaijchen commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2132572152
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
kaijchen commented on code in PR #35287:
URL: https://github.com/apache/doris/pull/35287#discussion_r1615429531
##
regression-test/suites/partition_p1/auto_partition/sql/multi_thread_load.groovy:
##
@@ -19,7 +19,7 @@ import groovy.io.FileType
import java.nio.file.Files
import
zclllyybb commented on code in PR #35287:
URL: https://github.com/apache/doris/pull/35287#discussion_r1615427689
##
regression-test/suites/partition_p1/auto_partition/sql/multi_thread_load.groovy:
##
@@ -19,7 +19,7 @@ import groovy.io.FileType
import java.nio.file.Files
import
github-actions[bot] commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2132568250
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
doris-robot commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2131245871
ClickBench: Total hot run time: 30.23 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2131244679
TPC-DS: Total hot run time: 172524 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2131242102
TPC-H: Total hot run time: 40230 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2131226799
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2131226478
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kaijchen commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2131225460
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
kaijchen commented on code in PR #35287:
URL: https://github.com/apache/doris/pull/35287#discussion_r1614602442
##
be/src/vec/sink/writer/vtablet_writer_v2.cpp:
##
@@ -311,6 +311,10 @@ Status VTabletWriterV2::_build_tablet_node_mapping() {
tablet.set_index_i
zclllyybb commented on code in PR #35287:
URL: https://github.com/apache/doris/pull/35287#discussion_r1613838254
##
be/src/vec/sink/writer/vtablet_writer_v2.cpp:
##
@@ -311,6 +311,10 @@ Status VTabletWriterV2::_build_tablet_node_mapping() {
tablet.set_index_
doris-robot commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2129181867
ClickBench: Total hot run time: 30.49 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2129172513
TPC-DS: Total hot run time: 171689 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2129145699
TPC-H: Total hot run time: 41961 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2129078839
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb closed pull request #34740: [Fix](auto-partition) fix auto partition
load lost data in multi sender
URL: https://github.com/apache/doris/pull/34740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
zclllyybb commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2129078255
close this since https://github.com/apache/doris/pull/35287 covered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2129066892
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kaijchen commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2129065612
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
kaijchen commented on PR #35287:
URL: https://github.com/apache/doris/pull/35287#issuecomment-2129052655
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
github-actions[bot] commented on code in PR #35287:
URL: https://github.com/apache/doris/pull/35287#discussion_r1613165552
##
be/src/vec/sink/load_stream_stub.h:
##
@@ -195,6 +195,8 @@ class LoadStreamStub : public
std::enable_shared_from_this {
int64_t dst_id() const {
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2112869216
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2112868126
ClickBench: Total hot run time: 30.37 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
zclllyybb commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2112854956
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2112854914
TPC-DS: Total hot run time: 187038 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
zclllyybb commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1601850856
##
be/src/vec/sink/writer/vtablet_writer.h:
##
@@ -114,6 +106,10 @@ struct AddBatchCounter {
}
};
+struct WriteBlockCallbackContext {
Review Comment:
intr
zclllyybb commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1601849249
##
be/src/vec/sink/writer/vtablet_writer.cpp:
##
@@ -1411,7 +1414,6 @@ Status VTabletWriter::_send_new_partition_batch() {
}
void VTabletWriter::_do_try_close(Run
doris-robot commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2112828808
TPC-H: Total hot run time: 41113 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
liaoxin01 commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1600900041
##
be/src/vec/sink/writer/vtablet_writer.cpp:
##
@@ -1411,7 +1414,6 @@ Status VTabletWriter::_send_new_partition_batch() {
}
void VTabletWriter::_do_try_close(Run
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2112632591
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2112612145
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zclllyybb commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1601184380
##
be/src/runtime/tablets_channel.cpp:
##
@@ -142,9 +142,16 @@ Status BaseTabletsChannel::open(const
PTabletWriterOpenRequest& request) {
RETURN_IF_ERROR(_schem
zclllyybb commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1601180459
##
be/src/runtime/load_channel.cpp:
##
@@ -195,6 +196,22 @@ Status LoadChannel::_handle_eos(BaseTabletsChannel*
channel,
auto index_id = request.index_id();
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2109125110
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2109119419
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2108752835
TPC-DS: Total hot run time: 187323 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2108735535
TPC-H: Total hot run time: 41730 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2108680469
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2108670816
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2108643802
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2108513061
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2107335559
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HappenLee commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1597853085
##
be/src/vec/sink/writer/vtablet_writer.cpp:
##
@@ -359,22 +357,23 @@ Status VNodeChannel::init(RuntimeState* state) {
// add block closure
// Has to using
HappenLee commented on code in PR #34740:
URL: https://github.com/apache/doris/pull/34740#discussion_r1597841125
##
be/src/vec/sink/writer/vtablet_writer.cpp:
##
@@ -969,17 +980,50 @@ void VNodeChannel::_close_check() {
CHECK(_cur_mutable_block == nullptr) << name();
}
+
doris-robot commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2106375965
TPC-DS: Total hot run time: 186958 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2106373160
TPC-H: Total hot run time: 40797 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2106365452
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2106364311
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2106340616
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2106340056
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2106339311
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
zclllyybb closed pull request #33996: [Fix](auto-partition) fix auto partition
load lost data in multi sender
URL: https://github.com/apache/doris/pull/33996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
zclllyybb opened a new pull request, #34740:
URL: https://github.com/apache/doris/pull/34740
## Proposed changes
Issue Number: close #xxx
Before if we have multi sender but some of their sink node have no data of
some specific partition, then this sink won't know it has to clos
zclllyybb commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2106338742
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #34740:
URL: https://github.com/apache/doris/pull/34740#issuecomment-2106338711
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
doris-robot commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071690890
ClickBench: Total hot run time: 31.4 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
C
github-actions[bot] commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071673420
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071619093
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071609517
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071314268
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071314301
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071281057
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071278939
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
zclllyybb commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071276095
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33996:
URL: https://github.com/apache/doris/pull/33996#issuecomment-2071273951
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
zclllyybb opened a new pull request, #33996:
URL: https://github.com/apache/doris/pull/33996
## Proposed changes
Issue Number: close #xxx
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d.
73 matches
Mail list logo
