yiguolei merged PR #32641:
URL: https://github.com/apache/doris/pull/32641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2026869495
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2026787628
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit c8f6c475195c6fa5512777393f6824eb63ce1a44 with
default session variables
Stream
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2026784311
ClickBench: Total hot run time: 29.21 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2026778442
TPC-DS: Total hot run time: 182069 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-202676
TPC-H: Total hot run time: 37970 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
jacktengg commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2026677979
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1544065493
##
be/src/pipeline/pipeline_x/pipeline_x_task.cpp:
##
@@ -327,6 +305,50 @@ Status PipelineXTask::execute(bool* eos) {
return status;
}
+bool
github-actions[bot] commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2026354103
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2026354187
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2025006677
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit df0ddde4d7f8ba7db99389a85bb281abe6306fe4 with
default session variables
Stream
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024992428
TPC-DS: Total hot run time: 180902 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024972418
TPC-H: Total hot run time: 37769 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
github-actions[bot] commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542711431
##
be/src/runtime/workload_group/workload_group_manager.cpp:
##
@@ -135,6 +137,127 @@ void
WorkloadGroupMgr::delete_workload_group_by_ids(std::set
jacktengg commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024907750
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024897391
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 09207c21e85cb9bb7da144b2960060fec2a8e348 with
default session variables
Stream
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024884658
TPC-DS: Total hot run time: 180802 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024866370
TPC-H: Total hot run time: 37716 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542662525
##
be/src/runtime/workload_group/workload_group_manager.cpp:
##
@@ -135,6 +137,135 @@ void
WorkloadGroupMgr::delete_workload_group_by_ids(std::set used_wg_i
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542650160
##
be/src/runtime/workload_group/workload_group_manager.cpp:
##
@@ -135,6 +137,135 @@ void
WorkloadGroupMgr::delete_workload_group_by_ids(std::set used_wg_i
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542643876
##
be/src/runtime/workload_group/workload_group_manager.cpp:
##
@@ -135,6 +137,135 @@ void
WorkloadGroupMgr::delete_workload_group_by_ids(std::set used_wg_i
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542643876
##
be/src/runtime/workload_group/workload_group_manager.cpp:
##
@@ -135,6 +137,135 @@ void
WorkloadGroupMgr::delete_workload_group_by_ids(std::set used_wg_i
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542627384
##
be/src/runtime/workload_group/workload_group_manager.cpp:
##
@@ -135,6 +137,135 @@ void
WorkloadGroupMgr::delete_workload_group_by_ids(std::set used_wg_i
jacktengg commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024719391
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542541083
##
be/src/pipeline/pipeline_x/pipeline_x_task.cpp:
##
@@ -326,6 +304,47 @@ Status PipelineXTask::execute(bool* eos) {
return status;
}
+bool
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542352340
##
be/src/runtime/workload_group/workload_group.h:
##
@@ -141,7 +166,8 @@ class WorkloadGroup : public
std::enable_shared_from_this {
const uint64_t _id;
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542293516
##
be/src/runtime/memory/mem_tracker_limiter.h:
##
@@ -244,6 +245,20 @@ class MemTrackerLimiter final : public MemTracker {
// Log the memory usage when memory
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542293320
##
be/src/runtime/memory/mem_tracker_limiter.h:
##
@@ -244,6 +245,20 @@ class MemTrackerLimiter final : public MemTracker {
// Log the memory usage when memory
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542290653
##
be/src/pipeline/pipeline_x/pipeline_x_task.cpp:
##
@@ -326,6 +304,46 @@ Status PipelineXTask::execute(bool* eos) {
return status;
}
+bool
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542290286
##
be/src/pipeline/pipeline_x/pipeline_x_task.cpp:
##
@@ -326,6 +304,46 @@ Status PipelineXTask::execute(bool* eos) {
return status;
}
+bool
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542289829
##
be/src/runtime/workload_group/workload_group.h:
##
@@ -82,6 +82,31 @@ class WorkloadGroup : public
std::enable_shared_from_this {
int64_t memory_used();
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542288795
##
be/src/pipeline/pipeline_x/pipeline_x_task.cpp:
##
@@ -326,6 +304,46 @@ Status PipelineXTask::execute(bool* eos) {
return status;
}
+bool
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542289053
##
be/src/pipeline/pipeline_x/pipeline_x_task.cpp:
##
@@ -326,6 +304,46 @@ Status PipelineXTask::execute(bool* eos) {
return status;
}
+bool
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1542283442
##
be/src/pipeline/exec/partitioned_aggregation_source_operator.cpp:
##
@@ -128,6 +129,7 @@ Status PartitionedAggSourceOperatorX::close(RuntimeState*
state) {
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024336558
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 615fff13fc8d598fd9aad875a0fb730eabc282d0 with
default session variables
Stream
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024330793
TPC-DS: Total hot run time: 181686 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024321329
TPC-H: Total hot run time: 37958 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
jacktengg commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2024274053
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2021945803
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit e1783354448196d335626f926218759a3286ec2e with
default session variables
Stream
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2021937403
TPC-DS: Total hot run time: 181926 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2021926523
TPC-H: Total hot run time: 38470 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
github-actions[bot] commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1540421187
##
be/src/runtime/workload_group/workload_group_manager.cpp:
##
@@ -135,6 +137,125 @@ void
WorkloadGroupMgr::delete_workload_group_by_ids(std::set
jacktengg commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2021868148
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2017739697
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 0e279b3fac84fecc43a2e6fc9829bd07ba245b4f with
default session variables
Stream
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2017733857
TPC-DS: Total hot run time: 186969 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2017726728
TeamCity be ut coverage result:
Function Coverage: 35.23% (8733/24790)
Line Coverage: 27.03% (71513/264560)
Region Coverage: 26.28% (37103/141203)
Branch Coverage:
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2017713206
TPC-H: Total hot run time: 38070 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
github-actions[bot] commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1537294093
##
be/src/runtime/workload_group/workload_group.h:
##
@@ -82,6 +82,31 @@ class WorkloadGroup : public
std::enable_shared_from_this {
int64_t
jacktengg commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2017575653
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1534078055
##
be/src/pipeline/exec/partitioned_hash_join_probe_operator.cpp:
##
@@ -462,6 +472,10 @@ Status
PartitionedHashJoinProbeOperatorX::open(RuntimeState* state) {
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1534078055
##
be/src/pipeline/exec/partitioned_hash_join_probe_operator.cpp:
##
@@ -462,6 +472,10 @@ Status
PartitionedHashJoinProbeOperatorX::open(RuntimeState* state) {
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1534070171
##
be/src/vec/exprs/vexpr.cpp:
##
@@ -97,11 +97,11 @@ TExprNode create_texpr_node_from(const void* data, const
PrimitiveType& type, in
break;
}
yiguolei commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1534069010
##
be/src/vec/spill/spill_writer.cpp:
##
@@ -35,13 +35,19 @@ Status SpillWriter::open() {
return Status::OK();
}
+SpillWriter::~SpillWriter() {
+if
github-actions[bot] commented on code in PR #32641:
URL: https://github.com/apache/doris/pull/32641#discussion_r1533875471
##
be/src/pipeline/exec/partitioned_hash_join_sink_operator.cpp:
##
@@ -48,15 +48,25 @@ Status
PartitionedHashJoinSinkLocalState::open(RuntimeState*
jacktengg opened a new pull request, #32641:
URL: https://github.com/apache/doris/pull/32641
## Proposed changes
Issue Number: close #xxx
## Further comments
If this is a relatively large or complex change, kick off the discussion at
doris-robot commented on PR #32641:
URL: https://github.com/apache/doris/pull/32641#issuecomment-2012234980
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
56 matches
Mail list logo
