[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3661: [Optimize] Using sorted schema change processing to merge the data

chaoyli commented on a change in pull request #3661: URL: https://github.com/apache/incubator-doris/pull/3661#discussion_r429507733 ## File path: be/src/olap/schema_change.cpp ## @@ -1859,6 +1859,29 @@ OLAPStatus SchemaChangeHandler::_parse_request(TabletSharedPtr

[GitHub] [incubator-doris] HappenLee commented on pull request #3666: Del some useless code and impove the performance of sort

HappenLee commented on pull request #3666: URL: https://github.com/apache/incubator-doris/pull/3666#issuecomment-632982262 @chaoyli OK！This is performance result. ### ENV CPU : Intel(R) Xeon(R) CPU E5-2620 v2 @ 2.10GHz 6cores * 2 RAM : 96GB ### Data

[GitHub] [incubator-doris] chaoyli commented on pull request #3666: Del some useless code and impove the performance of sort

chaoyli commented on pull request #3666: URL: https://github.com/apache/incubator-doris/pull/3666#issuecomment-632975491 It's better to post the performance result. This is an automated message from the Apache Git Service.

[GitHub] [incubator-doris] morningman commented on pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

morningman commented on pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#issuecomment-632980410 Hi @imay Please review This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] decster opened a new issue #3669: [Memory Engine] MemTablet creation and compatibility handling in BE

decster opened a new issue #3669: URL: https://github.com/apache/incubator-doris/issues/3669 After adding meta, BE now can create MemTablet, and put it into TabletManager, but MemTablet is not compatible with Tablet, a lot of code may break. I propose the following changes: Step 1:

[GitHub] [incubator-doris] morningman commented on a change in pull request #3661: [Optimize] Using sorted schema change processing to merge the data

morningman commented on a change in pull request #3661: URL: https://github.com/apache/incubator-doris/pull/3661#discussion_r429508808 ## File path: be/src/olap/schema_change.cpp ## @@ -1859,6 +1859,29 @@ OLAPStatus SchemaChangeHandler::_parse_request(TabletSharedPtr

[GitHub] [incubator-doris] morningman commented on pull request #3604: (#3464) fix Query failed when fact table has no data in join case

morningman commented on pull request #3604: URL: https://github.com/apache/incubator-doris/pull/3604#issuecomment-632976533 > 1 make HASH_TBL_SPACE_OVERHEAD a configurable param,but it seems not a common solution, because I'm not sure what factors can affect the real hash table size. >

[GitHub] [incubator-doris] morningman commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

morningman commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429082195 ## File path: docs/zh-CN/administrator-guide/load-data/spark-load-manual.md ## @@ -0,0 +1,397 @@ +--- +{ +"title": "Spark Load", +

[GitHub] [incubator-doris] morningman commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

morningman commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429094156 ## File path: fe/src/main/java/org/apache/doris/catalog/ResourceMgr.java ## @@ -0,0 +1,189 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] morningman merged pull request #3638: Support utf-8 encoding in instr, locate, locate_pos, lpad, rpad

morningman merged pull request #3638: URL: https://github.com/apache/incubator-doris/pull/3638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] wyb commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

wyb commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429139485 ## File path: docs/zh-CN/administrator-guide/load-data/spark-load-manual.md ## @@ -0,0 +1,397 @@ +--- +{ +"title": "Spark Load", +"language":

[GitHub] [incubator-doris] HappenLee opened a new pull request #3665: Del some useless code and impove the performance of sort

HappenLee opened a new pull request #3665: URL: https://github.com/apache/incubator-doris/pull/3665 1. Delete the code of Sort Node we do not use now. 2. Optimize the quick sort by find_the_median and try to reduce recursion level of quick sort. I have tested 50 million pieces of

[incubator-doris] branch master updated: [Function] Support utf-8 encoding in instr, locate, locate_pos, lpad, rpad (#3638)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new ba7d2db [Function] Support utf-8

[GitHub] [incubator-doris] wyb commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

wyb commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429129008 ## File path: fe/src/main/java/org/apache/doris/catalog/Resource.java ## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF) under

[GitHub] [incubator-doris] HappenLee opened a new pull request #3666: Del some useless code and impove the performance of sort

HappenLee opened a new pull request #3666: URL: https://github.com/apache/incubator-doris/pull/3666 1. Delete the code of Sort Node we do not use now. 2. Optimize the quick sort by find_the_median and try to reduce recursion level of quick sort. I have tested 50 million pieces of

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

wangbo commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429148045 ## File path: docs/zh-CN/administrator-guide/resource-management.md ## @@ -0,0 +1,125 @@ +--- +{ +"title": "资源管理", +"language": "zh-CN" +}

[GitHub] [incubator-doris] wyb commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

wyb commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429127459 ## File path: fe/src/main/java/org/apache/doris/analysis/ResourcePattern.java ## @@ -0,0 +1,118 @@ +// Licensed to the Apache Software Foundation

[GitHub] [incubator-doris] morningman commented on pull request #3647: [Enhancement] Add detail msg to show the reason of publish failure.

morningman commented on pull request #3647: URL: https://github.com/apache/incubator-doris/pull/3647#issuecomment-632517552 > Do you have any idea why the partition commitInfo version is not equal with 743 plus one?and how can we handler the situation more graceful instead wait too long

[GitHub] [incubator-doris] morningman commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

morningman commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429083102 ## File path: fe/src/main/java/org/apache/doris/mysql/privilege/PaloPrivilege.java ## @@ -25,7 +25,8 @@ LOAD_PRIV("Load_priv", 4,

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

wangbo commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429174060 ## File path: docs/zh-CN/administrator-guide/resource-management.md ## @@ -0,0 +1,125 @@ +--- +{ +"title": "资源管理", +"language": "zh-CN" +}

[GitHub] [incubator-doris] wangbo commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

wangbo commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429174060 ## File path: docs/zh-CN/administrator-guide/resource-management.md ## @@ -0,0 +1,125 @@ +--- +{ +"title": "资源管理", +"language": "zh-CN" +}

[GitHub] [incubator-doris] decster opened a new pull request #3668: [Memory Engine] Add TabletType to PartitionInfo and TabletMeta

decster opened a new pull request #3668: URL: https://github.com/apache/incubator-doris/pull/3668 This CL add TabletType to TabletMeta and PartitionInfo, it also adds a create table property "tablet_type" : "disk/memory" for user to specify tablet type. This is a temporary entry point for

[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #3651: Support create materialized view with bitmap or hll

HangyuanLiu commented on a change in pull request #3651: URL: https://github.com/apache/incubator-doris/pull/3651#discussion_r429168634 ## File path: fe/src/main/java/org/apache/doris/analysis/CreateMaterializedViewStmt.java ## @@ -167,15 +167,25 @@ private void

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

chaoyli commented on a change in pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r429084494 ## File path: be/src/olap/memory/CMakeLists.txt ## @@ -29,5 +29,8 @@ add_library(Memory STATIC delta_index.cpp hash_index.cpp

[GitHub] [incubator-doris] wyb commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

wyb commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429167261 ## File path: docs/zh-CN/administrator-guide/resource-management.md ## @@ -0,0 +1,125 @@ +--- +{ +"title": "资源管理", +"language": "zh-CN" +}

[GitHub] [incubator-doris] morningman closed issue #3646: [Enhancement][Txn] Add more info to find way publish failed.

morningman closed issue #3646: URL: https://github.com/apache/incubator-doris/issues/3646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-doris] branch master updated: [Enhancement] Add detail msg to show the reason of publish failure. (#3647)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git The following commit(s) were added to refs/heads/master by this push: new 1124808 [Enhancement] Add detail

[GitHub] [incubator-doris] morningman merged pull request #3647: [Enhancement] Add detail msg to show the reason of publish failure.

morningman merged pull request #3647: URL: https://github.com/apache/incubator-doris/pull/3647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r429319147 ## File path: docs/zh-CN/administrator-guide/outfile.md ## @@ -0,0 +1,183 @@ +--- +{ +"title": "导出查询结果集", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] decster commented on a change in pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

decster commented on a change in pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r429256669 ## File path: be/src/olap/memory/mem_sub_tablet.cpp ## @@ -0,0 +1,235 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] decster commented on a change in pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

decster commented on a change in pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r429260157 ## File path: be/src/olap/memory/partial_row_batch.h ## @@ -0,0 +1,172 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[incubator-doris] 01/01: [Bug] Fix bug that missing OP_SET_REPLICA_STATUS when reading journal (#3662)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git commit ef9c716682dd943cac5aa48618f108c9b33c9efb Merge: 1124808 74fb1b8 Author: Mingyu Chen AuthorDate: Fri May 22

[GitHub] [incubator-doris] morningman closed issue #3663: [Bug] FE crash after executing ADMIN SET REPLICA STATUS

morningman closed issue #3663: URL: https://github.com/apache/incubator-doris/issues/3663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-doris] morningman merged pull request #3662: [Bug] Fix bug that missing OP_SET_REPLICA_STATUS when reading journal

morningman merged pull request #3662: URL: https://github.com/apache/incubator-doris/pull/3662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-doris] branch master updated (1124808 -> ef9c716)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 1124808 [Enhancement] Add detail msg to show the reason of publish failure. (#3647) add 74fb1b8

[GitHub] [incubator-doris] decster commented on a change in pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

decster commented on a change in pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r429258167 ## File path: be/src/olap/memory/mem_sub_tablet.cpp ## @@ -0,0 +1,247 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [incubator-doris] morningman commented on a change in pull request #3584: [OUTFILE] Support `INTO OUTFILE` to export query result

morningman commented on a change in pull request #3584: URL: https://github.com/apache/incubator-doris/pull/3584#discussion_r429319050 ## File path: docs/zh-CN/administrator-guide/outfile.md ## @@ -0,0 +1,183 @@ +--- +{ +"title": "导出查询结果集", +"language": "zh-CN" +} +---

[GitHub] [incubator-doris] decster commented on a change in pull request #3637: [Memory Engine] Add MemSubTablet, MemTablet, WriteTx, PartialRowBatch

decster commented on a change in pull request #3637: URL: https://github.com/apache/incubator-doris/pull/3637#discussion_r429252915 ## File path: be/src/olap/memory/CMakeLists.txt ## @@ -29,5 +29,8 @@ add_library(Memory STATIC delta_index.cpp hash_index.cpp

[GitHub] [incubator-doris] wyb commented on a change in pull request #3418: [Spark load] Add spark etl cluster and cluster manager

wyb commented on a change in pull request #3418: URL: https://github.com/apache/incubator-doris/pull/3418#discussion_r429501802 ## File path: docs/zh-CN/administrator-guide/resource-management.md ## @@ -0,0 +1,125 @@ +--- +{ +"title": "资源管理", +"language": "zh-CN" +}