[GitHub] [incubator-doris] imay commented on issue #2242: Is that will be better create table with column default enable to be null?

imay commented on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-556961195 For me, I think it is OK to change default from not null to NULL. Because it will not bring more

[GitHub] [incubator-doris] caiconghui edited a comment on issue #2242: Is that will be better create table with column default enable to be null?

caiconghui edited a comment on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-556955387 @imay @morningman Maybe default nullable column may confuse users except hadoop

[GitHub] [incubator-doris] caiconghui commented on issue #2242: Is that will be better create table with column default enable to be null?

caiconghui commented on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-556955387 Maybe default nullable column may confuse users except hadoop users. In many database system,

[GitHub] [incubator-doris] lingbin commented on issue #2249: add a mechanism for FE to collect the table's format statistics

lingbin commented on issue #2249: add a mechanism for FE to collect the table's format statistics URL: https://github.com/apache/incubator-doris/issues/2249#issuecomment-556953137 This is a one-time job, which means that the tool is no longer needed after the feature is fully online, so

[GitHub] [incubator-doris] morningman commented on a change in pull request #2241: Fix some bugs about load label

morningman commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r348920708 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -106,7 +109,7 @@ public

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #2235: Support setting properties for storage_root_path

vagetablechicken commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348917646 ## File path: be/src/olap/options.h ## @@ -26,14 +26,25 @@ namespace doris {

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348880244 ## File path: be/src/tools/meta_tool.cpp ## @@ -139,8 +140,14 @@ int main(int argc, char

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348880272 ## File path: be/src/tools/meta_tool.cpp ## @@ -139,8 +140,14 @@ int main(int argc, char

[GitHub] [incubator-doris] manannan2017 commented on issue #2259: cast decimal，query large precision or small precision, the result precision is same as creating table

manannan2017 commented on issue #2259: cast decimal，query large precision or small precision, the result precision is same as creating table URL: https://github.com/apache/incubator-doris/issues/2259#issuecomment-556923502 #2135

[GitHub] [incubator-doris] manannan2017 opened a new issue #2259: cast decimal，query large precision or small precision, the result precision is same as creating table

manannan2017 opened a new issue #2259: cast decimal，query large precision or small precision, the result precision is same as creating table URL: https://github.com/apache/incubator-doris/issues/2259 1、table k2 decimal(9,3)

[GitHub] [incubator-doris] manannan2017 opened a new issue #2258: when using <=> operator，i meet some problems

manannan2017 opened a new issue #2258: when using <=> operator，i meet some problems URL: https://github.com/apache/incubator-doris/issues/2258 1、sql： select cast('2019-09-09' as int) <=> NULL, cast('2019' as int) <=> NULL; ERROR 1064 (HY000): Unexpected exception: null excepted

[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #2241: Fix some bugs about load label

EmmyMiao87 commented on a change in pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r348896948 ## File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java ## @@ -106,7 +109,7 @@ public

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348875456 ## File path: be/src/olap/options.h ## @@ -26,14 +26,25 @@ namespace doris { struct

[GitHub] [incubator-doris] vagetablechicken commented on a change in pull request #2235: Support setting properties for storage_root_path

vagetablechicken commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348874505 ## File path: be/src/olap/options.h ## @@ -26,14 +26,25 @@ namespace doris {

[GitHub] [incubator-doris] morningman closed pull request #2241: Fix some bugs about load label

morningman closed pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-doris] morningman opened a new pull request #2241: Fix some bugs about load label

morningman opened a new pull request #2241: Fix some bugs about load label URL: https://github.com/apache/incubator-doris/pull/2241 1. `dbIdToTxnLabels` in `GlobalTransactionMgr` should be consistent with `idToTransactionState`, not only contains running or finished transactions' labels.

[GitHub] [incubator-doris] morningman commented on issue #2222: Publish version immediately after txt commited

morningman commented on issue #: Publish version immediately after txt commited URL: https://github.com/apache/incubator-doris/pull/#issuecomment-556859778 @yiguolei Plz review this PR This is an automated message

[incubator-doris] branch master updated: Add schema hash to tablet proc info (#2257)

This is an automated email from the ASF dual-hosted git repository. morningman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git View the commit online: https://github.com/apache/incubator-doris/commit/9c85a04580bcadc3b5da91f380334a860c1fdc7e

[GitHub] [incubator-doris] morningman merged pull request #2257: Add schema hash to tablet proc info

morningman merged pull request #2257: Add schema hash to tablet proc info URL: https://github.com/apache/incubator-doris/pull/2257 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348853682 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348851661 ## File path:

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348851150 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348851898 ## File path:

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348850375 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348850825 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/backend/BackendClient.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348853199 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension

wuyunfeng commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348851944 ## File path:

[GitHub] [incubator-doris] lingbin opened a new pull request #2257: Add schema hash to tablet proc info

lingbin opened a new pull request #2257: Add schema hash to tablet proc info URL: https://github.com/apache/incubator-doris/pull/2257 #2249 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348430812 ## File path: be/src/olap/options.cpp ## @@ -29,36 +29,96 @@ namespace doris { //

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348428536 ## File path: be/src/olap/options.cpp ## @@ -29,36 +29,96 @@ namespace doris { //

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348426225 ## File path: be/src/olap/options.h ## @@ -26,14 +26,25 @@ namespace doris { struct

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348430521 ## File path: be/src/olap/options.cpp ## @@ -29,36 +29,96 @@ namespace doris { //

[GitHub] [incubator-doris] imay commented on a change in pull request #2235: Support setting properties for storage_root_path

imay commented on a change in pull request #2235: Support setting properties for storage_root_path URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348429090 ## File path: be/src/olap/options.h ## @@ -26,14 +26,25 @@ namespace doris { struct

[GitHub] [incubator-doris] morningman commented on issue #2242: Is that will be better create table with column default enable to be null?

morningman commented on issue #2242: Is that will be better create table with column default enable to be null? URL: https://github.com/apache/incubator-doris/issues/2242#issuecomment-555959059 I am not sure it is a good idea to change the default behavior of a system back and forth.

[GitHub] [incubator-doris] imay merged pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error

imay merged pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error URL: https://github.com/apache/incubator-doris/pull/2254 This is an automated message from the Apache Git Service. To

[incubator-doris] branch master updated (d72fbdf -> 88236de)

This is an automated email from the ASF dual-hosted git repository. zhaoc pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from d72fbdf Support bitmap index build (#2050) add 88236de Fix bug for showing columns from non exist

[GitHub] [incubator-doris] vinson0526 closed pull request #2228: add spark-doris-connector extension

vinson0526 closed pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-doris] vinson0526 opened a new pull request #2228: add spark-doris-connector extension

vinson0526 opened a new pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228 Spark-Doris-Connector for Spark to query data from Doris. More info in: https://github.com/apache/incubator-doris/issues/1525

[GitHub] [incubator-doris] imay closed pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error

imay closed pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error URL: https://github.com/apache/incubator-doris/pull/2254 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-doris] caiconghui opened a new pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error

caiconghui opened a new pull request #2254: Fix bug for showing columns from non exist table doesn't prompt error URL: https://github.com/apache/incubator-doris/pull/2254 when we execute show columns statement for non exist table, the response from doris is nothing, which may make user

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348347413 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348347323 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348347172 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348347207 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348347249 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348338606 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348337597 ## File path: extension/spark-doris-connector/src/main/java/org/apache/doris/spark/rest/RestService.java

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348335591 ## File path:

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348333995 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +#

[GitHub] [incubator-doris] vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension

vinson0526 commented on a change in pull request #2228: add spark-doris-connector extension URL: https://github.com/apache/incubator-doris/pull/2228#discussion_r348334018 ## File path: extension/spark-doris-connector/README.md ## @@ -0,0 +1,126 @@ +#