zhangstar333 merged PR #33124:
URL: https://github.com/apache/doris/pull/33124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2044175909
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
github-actions[bot] commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2044175870
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2042614787
TeamCity be ut coverage result:
Function Coverage: 35.64% (8904/24982)
Line Coverage: 27.38% (73147/267153)
Region Coverage: 26.54% (37791/142409)
Branch Coverage:
zhangstar333 commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2042441330
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r183551
##
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##
@@ -88,5 +88,25 @@ Status
DataTypeIPv4SerDe::deserialize_one_cell_from_json(IColumn& column,
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041841886
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit bc1fdb95f7a18f03b81c904ead8ed3bb3a585b64 with
default session variables
Stream
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041839625
ClickBench: Total hot run time: 29.56 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041838650
TeamCity be ut coverage result:
Function Coverage: 35.66% (8899/24955)
Line Coverage: 27.39% (73101/266864)
Region Coverage: 26.56% (37773/142226)
Branch Coverage:
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041835478
TPC-DS: Total hot run time: 181576 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041826413
TPC-H: Total hot run time: 39159 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
zhangstar333 commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041778693
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
HappenLee commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1555147432
##
be/src/vec/data_types/serde/data_type_number_serde.h:
##
@@ -109,47 +109,47 @@ template
Status DataTypeNumberSerDe::read_column_from_pb(IColumn& column, const
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041455265
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 004db2d86d46f9d33084fbd86ddae836877ddad4 with
default session variables
Stream
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041454424
ClickBench: Total hot run time: 29.76 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041453010
TPC-DS: Total hot run time: 181218 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041449816
TPC-H: Total hot run time: 38546 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
github-actions[bot] commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554948193
##
be/src/vec/data_types/serde/data_type_ipv6_serde.h:
##
@@ -53,6 +53,13 @@ class DataTypeIPv6SerDe : public DataTypeNumberSerDe {
zhangstar333 commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041436983
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
HappenLee commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554887335
##
be/src/vec/data_types/serde/data_type_struct_serde.cpp:
##
@@ -413,5 +413,32 @@ Status DataTypeStructSerDe::write_column_to_orc(const
std::string& timezone, con
HappenLee commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554854111
##
be/src/vec/data_types/serde/data_type_jsonb_serde.cpp:
##
@@ -239,6 +239,35 @@ Status
DataTypeJsonbSerDe::read_one_cell_from_json(IColumn& column,
HappenLee commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554853179
##
be/src/vec/data_types/serde/data_type_jsonb_serde.cpp:
##
@@ -239,6 +239,35 @@ Status
DataTypeJsonbSerDe::read_one_cell_from_json(IColumn& column,
HappenLee commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554852365
##
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##
@@ -87,6 +87,33 @@ Status
DataTypeIPv4SerDe::deserialize_one_cell_from_json(IColumn& column, Slice&
HappenLee commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554852194
##
be/src/vec/data_types/serde/data_type_decimal_serde.h:
##
@@ -154,10 +154,10 @@ template
Status DataTypeDecimalSerDe::read_column_from_pb(IColumn& column, const
HappenLee commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554845002
##
gensrc/proto/types.proto:
##
@@ -188,6 +188,8 @@ message PValues {
repeated string string_value = 11;
repeated bytes bytes_value = 12;
repeated
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041337709
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 2f5a8bb75643c1fe572b580e47fc657ab97a0390 with
default session variables
Stream
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041337062
ClickBench: Total hot run time: 30.18 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041335745
TPC-DS: Total hot run time: 182175 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041332833
TPC-H: Total hot run time: 38657 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
zhangstar333 commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2041314425
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1554806398
##
be/src/vec/data_types/serde/data_type_ipv4_serde.cpp:
##
@@ -87,6 +87,33 @@
column_data.insert_value(val);
return Status::OK();
}
+Status
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2029694494
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 51302f6cb900373eef2f052ed1c7ca577f7b5115 with
default session variables
Stream
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2029690657
ClickBench: Total hot run time: 31.32 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2029684193
TPC-DS: Total hot run time: 182090 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2029681528
TeamCity be ut coverage result:
Function Coverage: 35.59% (8853/24872)
Line Coverage: 27.31% (72616/265864)
Region Coverage: 26.51% (37581/141769)
Branch Coverage:
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2029671578
TPC-H: Total hot run time: 38852 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch
github-actions[bot] commented on code in PR #33124:
URL: https://github.com/apache/doris/pull/33124#discussion_r1546216699
##
be/test/vec/data_types/serde/data_type_serde_pb_test.cpp:
##
@@ -19,6 +19,7 @@
#include
Review Comment:
warning: 'gen_cpp/types.pb.h' file not
zhangstar333 commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2029578763
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zhangstar333 opened a new pull request, #33124:
URL: https://github.com/apache/doris/pull/33124
## Proposed changes
support complex type in
DataTypeSerDe::write_column_to_pb/read_column_from_pb function
Issue Number: close #xxx
## Further comments
If this
doris-robot commented on PR #33124:
URL: https://github.com/apache/doris/pull/33124#issuecomment-2029578632
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
40 matches
Mail list logo
