[GitHub] [incubator-druid] shivtools commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach

shivtools commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#discussion_r262822576 ## File path:

[GitHub] [incubator-druid] shivtools commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach

shivtools commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#discussion_r262822576 ## File path:

[GitHub] [incubator-druid] shivtools commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach

shivtools commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#discussion_r262823654 ## File path:

[GitHub] [incubator-druid] shivtools commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach

shivtools commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#discussion_r262822576 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

clintropolis commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262821482 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r262819095 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r262811871 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r262808616 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r262811427 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r262817348 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

clintropolis commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r262808007 ## File path:

[incubator-druid] branch master updated: Reduce default max # of subTasks to 1 for native parallel task (#7181)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new e48a9c1 Reduce default max # of subTasks

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262786690 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262787887 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262787838 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262786627 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262786493 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262786690 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262786627 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262786493 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop

asdf2014 commented on a change in pull request #7020: Write null byte when indexing numeric dimensions with Hadoop URL: https://github.com/apache/incubator-druid/pull/7020#discussion_r262786113 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/InputRowSerde.java

[GitHub] [incubator-druid] stale[bot] commented on issue #6798: Druid gRPC-json server extension

stale[bot] commented on issue #6798: Druid gRPC-json server extension URL: https://github.com/apache/incubator-druid/pull/6798#issuecomment-469934717 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262762752 ## File path:

[GitHub] [incubator-druid] fjy merged pull request #7196: [Backport] Add more approximate algorithm docs (#7195)

fjy merged pull request #7196: [Backport] Add more approximate algorithm docs (#7195) URL: https://github.com/apache/incubator-druid/pull/7196 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch 0.14.0-incubating updated: Add more approximate algorithm docs (#7195) (#7196)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch 0.14.0-incubating in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.14.0-incubating by this push: new 62a655a Add more

[GitHub] [incubator-druid] jon-wei opened a new pull request #7196: [Backport] Add more approximate algorithm docs (#7195)

jon-wei opened a new pull request #7196: [Backport] Add more approximate algorithm docs (#7195) URL: https://github.com/apache/incubator-druid/pull/7196 Backport of #7195 to 0.14.0-incubating This is an automated message

[incubator-druid] branch master updated: Add more approximate algorithm docs (#7195)

This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 9183e32 Add more approximate algorithm

[GitHub] [incubator-druid] fjy merged pull request #7195: Add more approximate algorithm docs

fjy merged pull request #7195: Add more approximate algorithm docs URL: https://github.com/apache/incubator-druid/pull/7195 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] jon-wei opened a new pull request #7195: Add more approximate algorithm docs

jon-wei opened a new pull request #7195: Add more approximate algorithm docs URL: https://github.com/apache/incubator-druid/pull/7195 This PR adds deprecation notices for the ApproximateHistogram and Cardinality/HyperUnique aggregators. (See

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469439146 ### Objective - Improve the current internal heuristic algorithm for "TopN" with streaming algorithms including DataSketches [Frequent Items

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469439146 ### Objective - Improve the current internal heuristic algorithm for "TopN" with streaming algorithms including DataSketches [Frequent Items

[incubator-druid] branch master updated: Adjust issue templates (#7188)

This is an automated email from the ASF dual-hosted git repository. jonwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 37cbad7 Adjust issue templates

[GitHub] [incubator-druid] jon-wei merged pull request #7188: Adjust issue templates

jon-wei merged pull request #7188: Adjust issue templates URL: https://github.com/apache/incubator-druid/pull/7188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262739896 ## File path:

[GitHub] [incubator-druid] leerho commented on issue #7187: Improve topN algorithm

leerho commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469906625 I should point out that Case 1 above is also streamable and solvable with significantly less resources than you are using now. And I think we have a

[GitHub] [incubator-druid] leventov commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach

leventov commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#discussion_r262738218 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #6740: Zookeeper loss

leventov commented on a change in pull request #6740: Zookeeper loss URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r262736461 ## File path: server/src/main/java/org/apache/druid/curator/CuratorModule.java ## @@ -127,6 +154,29 @@ public

[GitHub] [incubator-druid] leventov commented on a change in pull request #6740: Zookeeper loss

leventov commented on a change in pull request #6740: Zookeeper loss URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r262736628 ## File path: server/src/test/java/org/apache/druid/curator/BoundedExponentialBackoffRetryWithQuitTest.java ## @@ -0,0

[GitHub] [incubator-druid] leventov commented on a change in pull request #6740: Zookeeper loss

leventov commented on a change in pull request #6740: Zookeeper loss URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r262737197 ## File path: server/src/main/java/org/apache/druid/curator/BoundedExponentialBackoffRetryWithQuit.java ## @@ -0,0 +1,59 @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #6740: Zookeeper loss

leventov commented on a change in pull request #6740: Zookeeper loss URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r262736461 ## File path: server/src/main/java/org/apache/druid/curator/CuratorModule.java ## @@ -127,6 +154,29 @@ public

[GitHub] [incubator-druid] leventov commented on a change in pull request #7120: Locale problem is fixed which fails tests.

leventov commented on a change in pull request #7120: Locale problem is fixed which fails tests. URL: https://github.com/apache/incubator-druid/pull/7120#discussion_r262733876 ## File path: codestyle/druid-forbidden-apis.txt ## @@ -35,6 +35,11 @@ java.lang.Math#random() @

[GitHub] [incubator-druid] leventov commented on issue #7121: Prohibit Throwables.propagate()

leventov commented on issue #7121: Prohibit Throwables.propagate() URL: https://github.com/apache/incubator-druid/pull/7121#issuecomment-469899826 @kamaci please don't force-push pull-request branches, use merge commits instead.

[GitHub] [incubator-druid] leventov commented on a change in pull request #7121: Prohibit Throwables.propagate()

leventov commented on a change in pull request #7121: Prohibit Throwables.propagate() URL: https://github.com/apache/incubator-druid/pull/7121#discussion_r262733204 ## File path: indexing-hadoop/src/main/java/org/apache/druid/indexer/updater/HadoopConverterJob.java ## @@

[GitHub] [incubator-druid] jihoonson commented on issue #7181: Reduce default max # of subTasks to 1 for native parallel task

jihoonson commented on issue #7181: Reduce default max # of subTasks to 1 for native parallel task URL: https://github.com/apache/incubator-druid/pull/7181#issuecomment-469898509 Fixed the failing IT test. This is an

[GitHub] [incubator-druid] drcrallen commented on a change in pull request #7183: add postgresql meta db table schema configuration property (#7137)

drcrallen commented on a change in pull request #7183: add postgresql meta db table schema configuration property (#7137) URL: https://github.com/apache/incubator-druid/pull/7183#discussion_r262730777 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262723785 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission

clintropolis commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262723556 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262722499 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request at

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262719317 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request at

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262720884 ## File path: server/src/test/java/org/apache/druid/server/coordinator/DruidCoordinatorBalancerTest.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262720237 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request at

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262719317 ## File path: docs/content/configuration/index.md ## @@ -803,9 +803,9 @@ Issuing a GET request at

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262721152 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262718253 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #7154: rename maintenance mode to decommission

leventov commented on a change in pull request #7154: rename maintenance mode to decommission URL: https://github.com/apache/incubator-druid/pull/7154#discussion_r262717943 ## File path: server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorBalancer.java

[GitHub] [incubator-druid] jihoonson commented on issue #7181: Reduce default max # of subTasks to 1 for native parallel task

jihoonson commented on issue #7181: Reduce default max # of subTasks to 1 for native parallel task URL: https://github.com/apache/incubator-druid/pull/7181#issuecomment-469862171 I fixed a wrong if clause in `ParallelIndexSupervisorTask.run()` and added a unit test.

[GitHub] [incubator-druid] drcrallen commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach

drcrallen commented on a change in pull request #7174: Change reservoir sampling of segments to spliterator approach URL: https://github.com/apache/incubator-druid/pull/7174#discussion_r262694458 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #6953: Move GCP to a core extension

gianm commented on a change in pull request #6953: Move GCP to a core extension URL: https://github.com/apache/incubator-druid/pull/6953#discussion_r262647392 ## File path: cloud/gcp-common/src/main/java/org/apache/druid/common/gcp/GcpModule.java ## @@ -0,0 +1,80 @@ +/* +

[GitHub] [incubator-druid] gianm commented on a change in pull request #6953: Move GCP to a core extension

gianm commented on a change in pull request #6953: Move GCP to a core extension URL: https://github.com/apache/incubator-druid/pull/6953#discussion_r262649969 ## File path: pom.xml ## @@ -141,9 +145,11 @@ extensions-core/protobuf-extensions

[GitHub] [incubator-druid] gianm commented on a change in pull request #6953: Move GCP to a core extension

gianm commented on a change in pull request #6953: Move GCP to a core extension URL: https://github.com/apache/incubator-druid/pull/6953#discussion_r262647267 ## File path: cloud/gcp-common/src/main/java/org/apache/druid/common/gcp/GcpModule.java ## @@ -0,0 +1,80 @@ +/* +

[GitHub] [incubator-druid] gianm commented on a change in pull request #6953: Move GCP to a core extension

gianm commented on a change in pull request #6953: Move GCP to a core extension URL: https://github.com/apache/incubator-druid/pull/6953#discussion_r262649612 ## File path: server/pom.xml ## @@ -42,6 +42,11 @@ druid-aws-common

[GitHub] [incubator-druid] gianm commented on issue #7076: GCS task logs: "logs (last 8kb)" link is broken

gianm commented on issue #7076: GCS task logs: "logs (last 8kb)" link is broken URL: https://github.com/apache/incubator-druid/issues/7076#issuecomment-469744352 @glasser, the latter sounds good to me. If you are interested in implementing it then please go for it!

[GitHub] [incubator-druid] gianm commented on issue #7187: Improve topN algorithm

gianm commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469742231 > Also curious on people's thoughts on user's being explicit in their queries that can return approximate results versus optimising queries based on

[GitHub] [incubator-druid] Dylan1312 commented on issue #7187: Improve topN algorithm

Dylan1312 commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469658363 Also curious on people's thoughts on user's being explicit in their queries that can return approximate results versus optimising queries based on

[GitHub] [incubator-druid] Dylan1312 commented on issue #7187: Improve topN algorithm

Dylan1312 commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-469652385 I'm not sure how widely it's used but TopN's also supports ascending order. Curious if the sketch supports returning the inverse "most infrequent"

[GitHub] [incubator-druid] andresgomezfrr commented on issue #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-469620719 Yes, I use it at indexing time. Could you share your ingestion spec and some example input data?

[GitHub] [incubator-druid] glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension

glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-469595884 Does stringFirst actually work at ingestion time? The doc change made here (changing the existing claim that first/last