[GitHub] [incubator-druid] jihoonson opened a new pull request #7253: Fix log level and throw NPE on null currOffset in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
jihoonson opened a new pull request #7253: Fix log level and throw NPE on null currOffset in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7253 Follow up of #7246. This is an automated

[GitHub] [incubator-druid] clintropolis opened a new issue #7252: Kafka Tasks unable restore persisted segments properly

2019-03-12 Thread GitBox
clintropolis opened a new issue #7252: Kafka Tasks unable restore persisted segments properly URL: https://github.com/apache/incubator-druid/issues/7252 ### Affected Version All versions after #6431 ### Description Kakfa indexing tasks (likely kinesis as well) are

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
jihoonson commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246#discussion_r264981329 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
jihoonson commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246#discussion_r264981163 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
jihoonson commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246#discussion_r264981043 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #6883: Deprecate NoneShardSpec

2019-03-12 Thread GitBox
gianm commented on a change in pull request #6883: Deprecate NoneShardSpec URL: https://github.com/apache/incubator-druid/pull/6883#discussion_r264973193 ## File path: server/src/main/java/org/apache/druid/guice/ServerModule.java ## @@ -61,14 +55,6 @@ public

[GitHub] [incubator-druid] lxqfy opened a new issue #7251: Segment level Redis cache, keys not balanced when using codis or druid clusters

2019-03-12 Thread GitBox
lxqfy opened a new issue #7251: Segment level Redis cache, keys not balanced when using codis or druid clusters URL: https://github.com/apache/incubator-druid/issues/7251 Content in first {} will be recognized as hash tags. If query has javascript filters with same function will be

[GitHub] [incubator-druid] gianm commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
gianm commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246#discussion_r264963771 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
gianm commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246#discussion_r264971161 ## File path:

[GitHub] [incubator-druid] gianm commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
gianm commented on a change in pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246#discussion_r264971393 ## File path:

[GitHub] [incubator-druid] fjy closed issue #7239: Kafka tasks fail after resuming for incremental handoff

2019-03-12 Thread GitBox
fjy closed issue #7239: Kafka tasks fail after resuming for incremental handoff URL: https://github.com/apache/incubator-druid/issues/7239 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated: Fix record validation in SeekableStreamIndexTaskRunner (#7246)

2019-03-12 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 32e86ea Fix record validation in

[GitHub] [incubator-druid] fjy merged pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
fjy merged pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] srggrs edited a comment on issue #6786: apache-druid-0.13.0-incubating router /druid/router/v1/brokers

2019-03-12 Thread GitBox
srggrs edited a comment on issue #6786: apache-druid-0.13.0-incubating router /druid/router/v1/brokers URL: https://github.com/apache/incubator-druid/issues/6786#issuecomment-472252883 I have a similar error when introspec a global caches lookup (Druid 0.13.0):

[GitHub] [incubator-druid] srggrs commented on issue #6786: apache-druid-0.13.0-incubating router /druid/router/v1/brokers

2019-03-12 Thread GitBox
srggrs commented on issue #6786: apache-druid-0.13.0-incubating router /druid/router/v1/brokers URL: https://github.com/apache/incubator-druid/issues/6786#issuecomment-472252883 I have a similar error when introspec a global caches lookup: `2019-03-13T02:05:12,997 ERROR

[GitHub] [incubator-druid] stale[bot] closed pull request #6798: Druid gRPC-json server extension

2019-03-12 Thread GitBox
stale[bot] closed pull request #6798: Druid gRPC-json server extension URL: https://github.com/apache/incubator-druid/pull/6798 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-druid] stale[bot] commented on issue #6798: Druid gRPC-json server extension

2019-03-12 Thread GitBox
stale[bot] commented on issue #6798: Druid gRPC-json server extension URL: https://github.com/apache/incubator-druid/pull/6798#issuecomment-472251154 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can

[GitHub] [incubator-druid] jihoonson commented on issue #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
jihoonson commented on issue #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246#issuecomment-472246865 Added a test for Kinesis index task. This is an

[GitHub] [incubator-druid] a2l007 opened a new pull request #7250: Add support for optional client authentication on TLS

2019-03-12 Thread GitBox
a2l007 opened a new pull request #7250: Add support for optional client authentication on TLS URL: https://github.com/apache/incubator-druid/pull/7250 Fixes #6900 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-druid] jihoonson commented on issue #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
jihoonson commented on issue #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246#issuecomment-472237789 Oops, I noticed that the unit test for kinesis indexing is missing. I'll add it.

[GitHub] [incubator-druid] justinborromeo edited a comment on issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors

2019-03-12 Thread GitBox
justinborromeo edited a comment on issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors URL: https://github.com/apache/incubator-druid/issues/7217#issuecomment-472215067 Updated proposed states and when they change: | State| Description

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7249: Consolidate kafka consumer configs

2019-03-12 Thread GitBox
surekhasaharan commented on a change in pull request #7249: Consolidate kafka consumer configs URL: https://github.com/apache/incubator-druid/pull/7249#discussion_r264936740 ## File path:

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7249: Consolidate kafka consumer configs

2019-03-12 Thread GitBox
surekhasaharan commented on a change in pull request #7249: Consolidate kafka consumer configs URL: https://github.com/apache/incubator-druid/pull/7249#discussion_r264936704 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7249: Consolidate kafka consumer configs

2019-03-12 Thread GitBox
jon-wei commented on a change in pull request #7249: Consolidate kafka consumer configs URL: https://github.com/apache/incubator-druid/pull/7249#discussion_r264935831 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #7249: Consolidate kafka consumer configs

2019-03-12 Thread GitBox
jon-wei commented on a change in pull request #7249: Consolidate kafka consumer configs URL: https://github.com/apache/incubator-druid/pull/7249#discussion_r264935788 ## File path:

[GitHub] [incubator-druid] surekhasaharan opened a new pull request #7249: Consolidate kafka consumer configs

2019-03-12 Thread GitBox
surekhasaharan opened a new pull request #7249: Consolidate kafka consumer configs URL: https://github.com/apache/incubator-druid/pull/7249 Keep kafka consumer config properties in a common class for easy maintenance and avoid bugs due to missing properties.

[GitHub] [incubator-druid] justinborromeo opened a new pull request #7248: Added better QueryInterruptedException error message for UnsupportedOperationException

2019-03-12 Thread GitBox
justinborromeo opened a new pull request #7248: Added better QueryInterruptedException error message for UnsupportedOperationException URL: https://github.com/apache/incubator-druid/pull/7248 When a UOE is thrown from query code, the resulting QueryInterruptedException has an error code

[GitHub] [incubator-druid] jon-wei commented on issue #7133: 6088 - Time Ordering On Scans

2019-03-12 Thread GitBox
jon-wei commented on issue #7133: 6088 - Time Ordering On Scans URL: https://github.com/apache/incubator-druid/pull/7133#issuecomment-472224026 @justinborromeo Yeah, that's fine This is an automated message from the Apache

[GitHub] [incubator-druid] vogievetsky opened a new pull request #7247: [Console] Allow killing waiting and pending tasks

2019-03-12 Thread GitBox
vogievetsky opened a new pull request #7247: [Console] Allow killing waiting and pending tasks URL: https://github.com/apache/incubator-druid/pull/7247 Just a small fix that will show the 'Kill' action also for 'WAITING' and 'PENDING' tasks.

[GitHub] [incubator-druid] justinborromeo commented on issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors

2019-03-12 Thread GitBox
justinborromeo commented on issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors URL: https://github.com/apache/incubator-druid/issues/7217#issuecomment-472215067 | State| Description | Where supervisor gets

[GitHub] [incubator-druid] jihoonson opened a new pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner

2019-03-12 Thread GitBox
jihoonson opened a new pull request #7246: Fix record validation in SeekableStreamIndexTaskRunner URL: https://github.com/apache/incubator-druid/pull/7246 Fix https://github.com/apache/incubator-druid/issues/7239. In `verifyInitialRecordAndSkipExclusivePartition()`, `currOffset` is

[GitHub] [incubator-druid] surekhasaharan commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table

2019-03-12 Thread GitBox
surekhasaharan commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-472193691 Below statement is correct : >All segments with used = true in the metadata store (what

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-12 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-472185432 @gianm @leventov Perhaps it is "well-known" amongst the Druid developers, but I think the Druid team is taking a serious risk with

[GitHub] [incubator-druid] jihoonson opened a new issue #7245: Missing integration tests for Kafka/Kinesis indexing services

2019-03-12 Thread GitBox
jihoonson opened a new issue #7245: Missing integration tests for Kafka/Kinesis indexing services URL: https://github.com/apache/incubator-druid/issues/7245 Currently we have only an integration for Kafka indexing service with non-transactional topics. It would be nice if we can test it

[GitHub] [incubator-druid] leerho edited a comment on issue #7187: Improve topN algorithm

2019-03-12 Thread GitBox
leerho edited a comment on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-472185432 Perhaps it is "well-known" amongst the Druid developers, but I think the Druid team is taking a serious risk with Druid's reputation. Druid's

[GitHub] [incubator-druid] leerho commented on issue #7187: Improve topN algorithm

2019-03-12 Thread GitBox
leerho commented on issue #7187: Improve topN algorithm URL: https://github.com/apache/incubator-druid/issues/7187#issuecomment-472185432 Perhaps it is "well-known" amongst the Druid developers, but I think the Druid team is taking a serious risk with Druid's reputation. Druid's

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7082: Register lookup module with overlord and middle manager.

2019-03-12 Thread GitBox
clintropolis commented on a change in pull request #7082: Register lookup module with overlord and middle manager. URL: https://github.com/apache/incubator-druid/pull/7082#discussion_r264888771 ## File path: services/src/main/java/org/apache/druid/cli/CliMiddleManager.java

[GitHub] [incubator-druid] jon-wei commented on issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors

2019-03-12 Thread GitBox
jon-wei commented on issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors URL: https://github.com/apache/incubator-druid/issues/7217#issuecomment-472184495 I think NO_TASKS_RESPONDING is more of a kind of failure than a state (the state would be more why the supervisor was trying to

[GitHub] [incubator-druid] clintropolis commented on issue #7222: refactor lookups to be more chill to router

2019-03-12 Thread GitBox
clintropolis commented on issue #7222: refactor lookups to be more chill to router URL: https://github.com/apache/incubator-druid/pull/7222#issuecomment-472183428 >Perhaps I could rename RouterLookupModule to something more generic if so. Renamed to `LookupSerdeModule`

[GitHub] [incubator-druid] justinborromeo commented on issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors

2019-03-12 Thread GitBox
justinborromeo commented on issue #7217: [PROPOSAL] API Endpoint for Supervisor Errors URL: https://github.com/apache/incubator-druid/issues/7217#issuecomment-472180696 Proposed States: POSTED_NOT_RUNNING_YET: Supervisor spec has been posted but waiting for start delay

[GitHub] [incubator-druid] leventov commented on issue #4947: Historicals should only write to remote cache

2019-03-12 Thread GitBox
leventov commented on issue #4947: Historicals should only write to remote cache URL: https://github.com/apache/incubator-druid/issues/4947#issuecomment-472180143 > I think the local cache could help if the remote cache is churning too much. Since the local cache only stores results for

[GitHub] [incubator-druid] leventov commented on issue #7121: Prohibit Throwables.propagate()

2019-03-12 Thread GitBox
leventov commented on issue #7121: Prohibit Throwables.propagate() URL: https://github.com/apache/incubator-druid/pull/7121#issuecomment-472177426 @kamaci please fix the TC build

[GitHub] [incubator-druid] leventov edited a comment on issue #6942: Shade Guava manually

2019-03-12 Thread GitBox
leventov edited a comment on issue #6942: Shade Guava manually URL: https://github.com/apache/incubator-druid/issues/6942#issuecomment-472176539 On the other hand, when somebody discovers a small utility in Guava that they would use in their code, but it's not copied yet, they may decide

[GitHub] [incubator-druid] leventov commented on issue #6942: Shade Guava manually

2019-03-12 Thread GitBox
leventov commented on issue #6942: Shade Guava manually URL: https://github.com/apache/incubator-druid/issues/6942#issuecomment-472176539 On the other hand, when somebody discovers a small utility in Guava that they would use in their code, but it's not copied yet, they may decide to get

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #6496: Support kafka transactional topics (#5404)

2019-03-12 Thread GitBox
jihoonson commented on a change in pull request #6496: Support kafka transactional topics (#5404) URL: https://github.com/apache/incubator-druid/pull/6496#discussion_r264878472 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-12 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r264877604 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] glasser commented on issue #7243: stringFirst/stringLast crashes at aggregation time

2019-03-12 Thread GitBox
glasser commented on issue #7243: stringFirst/stringLast crashes at aggregation time URL: https://github.com/apache/incubator-druid/issues/7243#issuecomment-472171439 Maybe this is a question that @leventov (who added AggregateCombiners) could help with? I'm wondering where would be a

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-12 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r264863323 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-12 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r264860371 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] clintropolis commented on issue #7222: refactor lookups to be more chill to router

2019-03-12 Thread GitBox
clintropolis commented on issue #7222: refactor lookups to be more chill to router URL: https://github.com/apache/incubator-druid/pull/7222#issuecomment-472157066 Would the module introduced in this PR also be a good solution to the problem of #5727 since it would allow lookup serde

[GitHub] [incubator-druid] leventov commented on a change in pull request #7206: Add the pull-request template

2019-03-12 Thread GitBox
leventov commented on a change in pull request #7206: Add the pull-request template URL: https://github.com/apache/incubator-druid/pull/7206#discussion_r264856399 ## File path: .github/pull_request_template.md ## @@ -0,0 +1,53 @@ +Fixes #. + +(Replace with the id

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #6496: Support kafka transactional topics (#5404)

2019-03-12 Thread GitBox
surekhasaharan commented on a change in pull request #6496: Support kafka transactional topics (#5404) URL: https://github.com/apache/incubator-druid/pull/6496#discussion_r264856301 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7110: Add missing doc link for operations/http-compression.html

2019-03-12 Thread GitBox
clintropolis commented on a change in pull request #7110: Add missing doc link for operations/http-compression.html URL: https://github.com/apache/incubator-druid/pull/7110#discussion_r264855592 ## File path: web-console/package-lock.json ## @@ -3274,12 +3274,14 @@

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264848831 ## File path:

[GitHub] [incubator-druid] shuqi7 opened a new pull request #7244: [Console] Add SQL auto complete in druid console

2019-03-12 Thread GitBox
shuqi7 opened a new pull request #7244: [Console] Add SQL auto complete in druid console URL: https://github.com/apache/incubator-druid/pull/7244 In the SQL console, we are enabling auto complete by detecting keywords from: - Local words - Datasource names - Database column names

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264848831 ## File path:

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264848831 ## File path:

[GitHub] [incubator-druid] gianm commented on issue #7236: Further improve caching documentation.

2019-03-12 Thread GitBox
gianm commented on issue #7236: Further improve caching documentation. URL: https://github.com/apache/incubator-druid/pull/7236#issuecomment-472146765 Those are all good questions. I'm not sure what the exact tradeoff is between letting the broker use (but not populate) a remote cache. I

[GitHub] [incubator-druid] glasser commented on issue #7243: stringFirst/stringLast crashes at aggregation time

2019-03-12 Thread GitBox
glasser commented on issue #7243: stringFirst/stringLast crashes at aggregation time URL: https://github.com/apache/incubator-druid/issues/7243#issuecomment-472146301 I'd be happy to fix this, and it's probably a small fix, but I'm lost as to where the appropriate place to add a unit

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264844513 ## File path:

[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264844112 ## File path:

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264839420 ## File path:

[GitHub] [incubator-druid] peferron commented on issue #7236: Further improve caching documentation.

2019-03-12 Thread GitBox
peferron commented on issue #7236: Further improve caching documentation. URL: https://github.com/apache/incubator-druid/pull/7236#issuecomment-472143133 @gianm I'm glad to see that the original PR led to a comprehensive rewrite of the caching doc :) What I'm curious about is the

[GitHub] [incubator-druid] glasser edited a comment on issue #5789: Add stringLast and stringFirst aggregators extension

2019-03-12 Thread GitBox
glasser edited a comment on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-472138276 Oh, right. We need to actually make things roll up with each other, so set a non-trivial queryGranularity. I now

[GitHub] [incubator-druid] glasser opened a new issue #7243: stringFirst/stringLast crashes at aggregation time

2019-03-12 Thread GitBox
glasser opened a new issue #7243: stringFirst/stringLast crashes at aggregation time URL: https://github.com/apache/incubator-druid/issues/7243 ### Affected Version 0.13.0-incubating (and maybe older versions) ### Description See discussion on #5789 for background.

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264839420 ## File path:

[GitHub] [incubator-druid] glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension

2019-03-12 Thread GitBox
glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-472138276 Oh, right. We need to actually make things roll up with each other, so set a non-trivial queryGranularity. I now have an

[GitHub] [incubator-druid] glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension

2019-03-12 Thread GitBox
glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-472137069 Oh hmm. `"rollup" : false` looks bad, but fixing that to be `"rollup": true` also doesn't reproduce.

[GitHub] [incubator-druid] glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension

2019-03-12 Thread GitBox
glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-472135189 Yeah, running this task against a fresh download of 0.13-incubating succeeds, even though I would think it would need to

[GitHub] [incubator-druid] glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension

2019-03-12 Thread GitBox
glasser commented on issue #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#issuecomment-472128679 Hmm, I'm not sure if that's exactly it. I've been trying the standard quickstart Kafka ingestion example with this

[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264826467 ## File path:

[GitHub] [incubator-druid] shuqi7 opened a new pull request #7242: [Console] Add compaction dialog in druid console which allows users to add/edit data source compaction configuration

2019-03-12 Thread GitBox
shuqi7 opened a new pull request #7242: [Console] Add compaction dialog in druid console which allows users to add/edit data source compaction configuration URL: https://github.com/apache/incubator-druid/pull/7242 The compaction dialog is implemented in order to allow users to add and

[GitHub] [incubator-druid] peferron commented on issue #4947: Historicals should only write to remote cache

2019-03-12 Thread GitBox
peferron commented on issue #4947: Historicals should only write to remote cache URL: https://github.com/apache/incubator-druid/issues/4947#issuecomment-472125502 One of your previous comments indicated that you were using local cache in this setting: > BTW there is hybrid cache

[GitHub] [incubator-druid] peferron edited a comment on issue #4947: Historicals should only write to remote cache

2019-03-12 Thread GitBox
peferron edited a comment on issue #4947: Historicals should only write to remote cache URL: https://github.com/apache/incubator-druid/issues/4947#issuecomment-472125502 @leventov One of your previous comments indicated that you were using local cache in this setting: > BTW there

[GitHub] [incubator-druid] pdeva opened a new pull request #7241: document query downtime behavior of upgrading overlords in 0.14

2019-03-12 Thread GitBox
pdeva opened a new pull request #7241: document query downtime behavior of upgrading overlords in 0.14 URL: https://github.com/apache/incubator-druid/pull/7241 upgrading overlord nodes in 0.14.0 can result in few minutes of query downtime for KIS tasks, as noticed in #6854 this

[GitHub] [incubator-druid] jihoonson commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table

2019-03-12 Thread GitBox
jihoonson commented on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-472101340 Hmm, ok. It looks that there are some misunderstandings and confusions. First of all, I think

[GitHub] [incubator-druid] drcrallen commented on issue #6953: Move GCP to a core extension

2019-03-12 Thread GitBox
drcrallen commented on issue #6953: Move GCP to a core extension URL: https://github.com/apache/incubator-druid/pull/6953#issuecomment-472081406 I still need to update the docs before merging This is an automated message from

[GitHub] [incubator-druid] jihoonson commented on issue #7239: Kafka tasks fail after resuming for incremental handoff

2019-03-12 Thread GitBox
jihoonson commented on issue #7239: Kafka tasks fail after resuming for incremental handoff URL: https://github.com/apache/incubator-druid/issues/7239#issuecomment-472072934 Yeah, `verifyInitialRecordAndSkipExclusivePartition` was added in #6431. The similar check was done like below

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264704895 ## File path:

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264700180 ## File path:

[incubator-druid] branch master updated: lifecycle stage refactor to ensure proper start and stop ordering of servers and announcements (#7234)

2019-03-12 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 4d3987c lifecycle stage refactor to

[GitHub] [incubator-druid] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264694385 ## File path:

[GitHub] [incubator-druid] xqwbx163 commented on issue #7240: summation calculation, the 2 decimal point becomes 6 or more

2019-03-12 Thread GitBox
xqwbx163 commented on issue #7240: summation calculation, the 2 decimal point becomes 6 or more URL: https://github.com/apache/incubator-druid/issues/7240#issuecomment-472010080 that is mysql sum result :

[GitHub] [incubator-druid] kamaci commented on issue #7121: Prohibit Throwables.propagate()

2019-03-12 Thread GitBox
kamaci commented on issue #7121: Prohibit Throwables.propagate() URL: https://github.com/apache/incubator-druid/pull/7121#issuecomment-471999622 @leventov is there anything left to improve my PR? This is an automated message

[GitHub] [incubator-druid] gianm edited a comment on issue #7239: Kafka tasks fail after resuming for incremental handoff

2019-03-12 Thread GitBox
gianm edited a comment on issue #7239: Kafka tasks fail after resuming for incremental handoff URL: https://github.com/apache/incubator-druid/issues/7239#issuecomment-471992898 Did you manage to nail down which specific change in #6431 introduced this bug?

[GitHub] [incubator-druid] gianm commented on issue #7239: Kafka tasks fail after resuming for incremental handoff

2019-03-12 Thread GitBox
gianm commented on issue #7239: Kafka tasks fail after resuming for incremental handoff URL: https://github.com/apache/incubator-druid/issues/7239#issuecomment-471992898 Did you manage to nail down which specific change in #6431 introduced this bug? I wonder if that part of the patch

[GitHub] [incubator-druid] gianm commented on issue #7240: summation calculation, the 2 decimal point becomes 6 or more

2019-03-12 Thread GitBox
gianm commented on issue #7240: summation calculation, the 2 decimal point becomes 6 or more URL: https://github.com/apache/incubator-druid/issues/7240#issuecomment-471991669 How different is it? Floating-point types behave a bit differently from decimal types, and Druid only supports

[GitHub] [incubator-druid] kamaci commented on issue #7027: Auto Detection of Field Types

2019-03-12 Thread GitBox
kamaci commented on issue #7027: Auto Detection of Field Types URL: https://github.com/apache/incubator-druid/issues/7027#issuecomment-471960247 Hi @jihoonson These are possible solutions. I can go with 3th one but I've wanted to talk about it before doing implementation. I can

[GitHub] [incubator-druid] asdf2014 commented on issue #7224: Add ROUND function in druid-sql.

2019-03-12 Thread GitBox
asdf2014 commented on issue #7224: Add ROUND function in druid-sql. URL: https://github.com/apache/incubator-druid/pull/7224#issuecomment-471910844 @KazuhitoT BTW, we should also update the `math-expr.md` file at the same time.

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql.

2019-03-12 Thread GitBox
asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql. URL: https://github.com/apache/incubator-druid/pull/7224#discussion_r264564989 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/RoundOperatorConversion.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql.

2019-03-12 Thread GitBox
asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql. URL: https://github.com/apache/incubator-druid/pull/7224#discussion_r264563676 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/RoundOperatorConversion.java

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql.

2019-03-12 Thread GitBox
asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql. URL: https://github.com/apache/incubator-druid/pull/7224#discussion_r264560966 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -441,18 +443,43 @@

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql.

2019-03-12 Thread GitBox
asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql. URL: https://github.com/apache/incubator-druid/pull/7224#discussion_r264559997 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/expression/ExpressionsTest.java ## @@ -354,6

[GitHub] [incubator-druid] asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql.

2019-03-12 Thread GitBox
asdf2014 commented on a change in pull request #7224: Add ROUND function in druid-sql. URL: https://github.com/apache/incubator-druid/pull/7224#discussion_r264559548 ## File path: core/src/main/java/org/apache/druid/math/expr/Function.java ## @@ -441,18 +443,43 @@

[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264550896 ## File path: docs/content/configuration/index.md ## @@ -1251,7

[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264550538 ## File path:

[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264550478 ## File path:

[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264550391 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7138: 'core' ORC extension

2019-03-12 Thread GitBox
clintropolis commented on a change in pull request #7138: 'core' ORC extension URL: https://github.com/apache/incubator-druid/pull/7138#discussion_r264546667 ## File path: extensions-core/orc-extensions/src/main/java/org/apache/druid/data/input/orc/OrcStructConverter.java

[GitHub] [incubator-druid] samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

2019-03-12 Thread GitBox
samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r264546712 ## File path:

  1   2   >