[GitHub] [druid] jihoonson opened a new pull request #10082: Fix RetryQueryRunner to actually do the job

2020-06-25 Thread GitBox
jihoonson opened a new pull request #10082: URL: https://github.com/apache/druid/pull/10082 ### Description `RetryQueryRunner` is responsible for retrying the query when some segments are missing during the query (it's possible since the coordinator can move segments anytime).

[GitHub] [druid] clintropolis commented on a change in pull request #9938: Add https to druid-influxdb-emitter extension

2020-06-25 Thread GitBox
clintropolis commented on a change in pull request #9938: URL: https://github.com/apache/druid/pull/9938#discussion_r445968955 ## File path: extensions-contrib/influxdb-emitter/src/main/java/org/apache/druid/emitter/influxdb/InfluxdbEmitterConfig.java ## @@ -130,6 +159,10 @@

[GitHub] [druid] ccaominh commented on a change in pull request #9956: Segment timeline doesn't show results older than 3 months

2020-06-25 Thread GitBox
ccaominh commented on a change in pull request #9956: URL: https://github.com/apache/druid/pull/9956#discussion_r445959200 ## File path: web-console/src/components/segment-timeline/segment-timeline.tsx ## @@ -394,14 +394,16 @@ ORDER BY "start" DESC`; onTimeSpanChange = (e:

[GitHub] [druid] stale[bot] commented on issue #8560: Feature request: Implement bitwise operators & and |

2020-06-25 Thread GitBox
stale[bot] commented on issue #8560: URL: https://github.com/apache/druid/issues/8560#issuecomment-649938319 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this issue is still relevant, please simply write

[GitHub] [druid] stale[bot] commented on issue #8456: ingesting with high cardinality dimension have low performance

2020-06-25 Thread GitBox
stale[bot] commented on issue #8456: URL: https://github.com/apache/druid/issues/8456#issuecomment-649938318 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If this issue is still relevant, please simply write

[GitHub] [druid] clintropolis closed issue #9798: [Draft] 0.18.1 Release notes

2020-06-25 Thread GitBox
clintropolis closed issue #9798: URL: https://github.com/apache/druid/issues/9798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] clintropolis opened a new pull request #10081: Information schema doc update

2020-06-25 Thread GitBox
clintropolis opened a new pull request #10081: URL: https://github.com/apache/druid/pull/10081 Follow-up to #10041, documents `IS_JOINABLE` and `IS_BROADCAST` and fills out a bit more details on `INFORMATION_SCHEMA` tables. Also fixed a bunch of links on the SQL query docs page to

[druid] branch master updated: More prominent instructions on code coverage failure (#10060)

2020-06-25 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new b7d771f More prominent instructions on code

[GitHub] [druid] fjy merged pull request #10060: More prominent instructions on code coverage failure

2020-06-25 Thread GitBox
fjy merged pull request #10060: URL: https://github.com/apache/druid/pull/10060 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] maytasm commented on pull request #9449: Add Sql InputSource

2020-06-25 Thread GitBox
maytasm commented on pull request #9449: URL: https://github.com/apache/druid/pull/9449#issuecomment-649888286 Have a PR up for adding integration tests to SqlInputSource. Please see: https://github.com/apache/druid/pull/10080

[GitHub] [druid] maytasm opened a new pull request #10080: Add integration tests for SqlInputSource

2020-06-25 Thread GitBox
maytasm opened a new pull request #10080: URL: https://github.com/apache/druid/pull/10080 Add integration tests for SqlInputSource ### Description Add integration tests for SqlInputSource This PR has: - [x] been self-reviewed. - [ ] added documentation for new or

[GitHub] [druid] clintropolis merged pull request #10046: Fix missing temp dir for native single_dim

2020-06-25 Thread GitBox
clintropolis merged pull request #10046: URL: https://github.com/apache/druid/pull/10046 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[druid] branch master updated (aaee72c -> f6594ff)

2020-06-25 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from aaee72c Allow append to existing datasources when dynamic partitioning is used (#10033) add f6594ff Fix

[GitHub] [druid] clintropolis closed issue #9467: Ingestion fails on 'Connection reset by peer' when using native parallel ingestion

2020-06-25 Thread GitBox
clintropolis closed issue #9467: URL: https://github.com/apache/druid/issues/9467 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] jihoonson opened a new pull request #10079: Move shardSpec tests to core

2020-06-25 Thread GitBox
jihoonson opened a new pull request #10079: URL: https://github.com/apache/druid/pull/10079 ### Description Follow-up for https://github.com/apache/druid/pull/10033#issuecomment-649750336. This PR has: - [x] been self-reviewed. - [ ] using the [concurrency

[druid] branch master updated (0f51b3c -> aaee72c)

2020-06-25 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 0f51b3c fix dropwizard emitter jvm bufferpoolName metric (#10075) add aaee72c Allow append to existing

[GitHub] [druid] jihoonson merged pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-25 Thread GitBox
jihoonson merged pull request #10033: URL: https://github.com/apache/druid/pull/10033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [druid] jihoonson closed issue #9352: Broken feature: appending linearly partitioned segments into a hash partitioned datasource

2020-06-25 Thread GitBox
jihoonson closed issue #9352: URL: https://github.com/apache/druid/issues/9352 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] jihoonson commented on pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-25 Thread GitBox
jihoonson commented on pull request #10033: URL: https://github.com/apache/druid/pull/10033#issuecomment-649804890 > If those unit tests had been in `core` instead of `server` then the coverage check for this PR would have passed since the relevant unit tests were added to

[GitHub] [druid] pjain1 closed issue #10069: RandomBalancerStrategy does not assign segments if there is only one historical

2020-06-25 Thread GitBox
pjain1 closed issue #10069: URL: https://github.com/apache/druid/issues/10069 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] pjain1 commented on issue #10069: RandomBalancerStrategy does not assign segments if there is only one historical

2020-06-25 Thread GitBox
pjain1 commented on issue #10069: URL: https://github.com/apache/druid/issues/10069#issuecomment-649804334 Fixed in https://github.com/apache/druid/pull/10070 This is an automated message from the Apache Git Service. To

[GitHub] [druid] pjain1 commented on issue #10068: RandomBalancerStrategy gets stuck into loop

2020-06-25 Thread GitBox
pjain1 commented on issue #10068: URL: https://github.com/apache/druid/issues/10068#issuecomment-649804164 fixed in https://github.com/apache/druid/pull/10070 This is an automated message from the Apache Git Service. To

[GitHub] [druid] pjain1 closed issue #10068: RandomBalancerStrategy gets stuck into loop

2020-06-25 Thread GitBox
pjain1 closed issue #10068: URL: https://github.com/apache/druid/issues/10068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[druid] branch master updated (422a8af -> 0f51b3c)

2020-06-25 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 422a8af Fix balancer strategy (#10070) add 0f51b3c fix dropwizard emitter jvm bufferpoolName metric (#10075)

[GitHub] [druid] clintropolis merged pull request #10075: fix dropwizard emitter jvm bufferpoolName metric

2020-06-25 Thread GitBox
clintropolis merged pull request #10075: URL: https://github.com/apache/druid/pull/10075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [druid] ccaominh commented on pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-25 Thread GitBox
ccaominh commented on pull request #10033: URL: https://github.com/apache/druid/pull/10033#issuecomment-649750336 Looking at the code coverage issue a bit more: All the ShardSpecs live in `core`: ``` find . -name "*ShardSpec.java"

[GitHub] [druid] jon-wei commented on a change in pull request #9898: support Aliyun OSS service as deep storage

2020-06-25 Thread GitBox
jon-wei commented on a change in pull request #9898: URL: https://github.com/apache/druid/pull/9898#discussion_r445754298 ## File path: extensions-contrib/aliyun-oss-extensions/src/main/java/org/apache/druid/storage/aliyun/ObjectSummaryIterator.java ## @@ -0,0 +1,163 @@ +/* +

[GitHub] [druid] ccaominh commented on pull request #10033: Allow append to existing datasources when dynamic partitioning is used

2020-06-25 Thread GitBox
ccaominh commented on pull request #10033: URL: https://github.com/apache/druid/pull/10033#issuecomment-649737980 > ``` > 133 F default boolean sharePartitionSpace(PartialShardSpec partialShardSpec) > 134 F { > 135 F | L | B(0/2)return

[GitHub] [druid] jihoonson edited a comment on pull request #10013: Add NonnullPair

2020-06-25 Thread GitBox
jihoonson edited a comment on pull request #10013: URL: https://github.com/apache/druid/pull/10013#issuecomment-649726856 @clintropolis thank you for the review. > Though now I wonder if `Pair` should be renamed `NullablePair` and this should be renamed `Pair` 樂  Yeah, I

[GitHub] [druid] jihoonson commented on pull request #10013: Add NonnullPair

2020-06-25 Thread GitBox
jihoonson commented on pull request #10013: URL: https://github.com/apache/druid/pull/10013#issuecomment-649726856 > Though now I wonder if `Pair` should be renamed `NullablePair` and this should be renamed `Pair` 樂  Yeah, I agree it would be better. However, Intellij finds 1286

[GitHub] [druid] jihoonson commented on a change in pull request #10027: fix query memory leak

2020-06-25 Thread GitBox
jihoonson commented on a change in pull request #10027: URL: https://github.com/apache/druid/pull/10027#discussion_r445720081 ## File path: processing/src/main/java/org/apache/druid/query/ChainedExecutionQueryRunner.java ## @@ -141,33 +144,34 @@ public

[GitHub] [druid] jihoonson commented on a change in pull request #10076: ensure ParallelMergeCombiningSequence closes it's closeables

2020-06-25 Thread GitBox
jihoonson commented on a change in pull request #10076: URL: https://github.com/apache/druid/pull/10076#discussion_r445696870 ## File path: core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java ## @@ -1350,4 +1363,24 @@ long

[GitHub] [druid] FrankChen021 edited a comment on pull request #9898: support Aliyun OSS service as deep storage

2020-06-25 Thread GitBox
FrankChen021 edited a comment on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-649602917 Hi @jon-wei , I've updated the code, and re-tested all core functions. IT testcases runs OK, and real time ingestion task, compact task, kill task, index task log

[GitHub] [druid] FrankChen021 commented on pull request #9898: support Aliyun OSS service as deep storage

2020-06-25 Thread GitBox
FrankChen021 commented on pull request #9898: URL: https://github.com/apache/druid/pull/9898#issuecomment-649602917 Hi @jon-wei , I've updated the code, and re-tested all core functions. IT testcases runs OK, and real time ingestion task, compact task, kill task runs well in our test

[GitHub] [druid] FrankChen021 commented on a change in pull request #9898: support Aliyun OSS service as deep storage

2020-06-25 Thread GitBox
FrankChen021 commented on a change in pull request #9898: URL: https://github.com/apache/druid/pull/9898#discussion_r445616439 ## File path: extensions-contrib/aliyun-oss-extensions/src/main/java/org/apache/druid/storage/aliyun/OssDataSegmentPusher.java ## @@ -0,0 +1,131 @@

[GitHub] [druid] FrankChen021 commented on a change in pull request #9898: support Aliyun OSS service as deep storage

2020-06-25 Thread GitBox
FrankChen021 commented on a change in pull request #9898: URL: https://github.com/apache/druid/pull/9898#discussion_r445615267 ## File path: extensions-contrib/aliyun-oss-extensions/src/main/java/org/apache/druid/storage/aliyun/ObjectSummaryIterator.java ## @@ -0,0 +1,163 @@

[GitHub] [druid] FrankChen021 commented on a change in pull request #9898: support Aliyun OSS service as deep storage

2020-06-25 Thread GitBox
FrankChen021 commented on a change in pull request #9898: URL: https://github.com/apache/druid/pull/9898#discussion_r445612812 ## File path: extensions-contrib/aliyun-oss-extensions/src/main/java/org/apache/druid/data/input/aliyun/OssInputSource.java ## @@ -0,0 +1,178 @@ +/*

[GitHub] [druid] suneet-s commented on a change in pull request #10060: More prominent instructions on code coverage failure

2020-06-25 Thread GitBox
suneet-s commented on a change in pull request #10060: URL: https://github.com/apache/druid/pull/10060#discussion_r445611807 ## File path: .travis.yml ## @@ -183,7 +183,7 @@ jobs: --log-template "totals-complete" --log-template "errors" -- -

[GitHub] [druid] zenfenan commented on issue #6743: IncrementalIndex generally overestimates theta sketch size

2020-06-25 Thread GitBox
zenfenan commented on issue #6743: URL: https://github.com/apache/druid/issues/6743#issuecomment-649569424 This is still an issue. We are having `thetaSketch` based metrics and ingestion does a frequent flush with fewer records. For the time being, we have set `maxBytesInMemory` to -1 and

[GitHub] [druid] liran-funaro commented on pull request #10001: Optimizing incremental-index ingestion using off-heap key/value map (OakMap)

2020-06-25 Thread GitBox
liran-funaro commented on pull request #10001: URL: https://github.com/apache/druid/pull/10001#issuecomment-649515567 Hi @jihoonson, have you had a chance to check out our issue/PR? We will be happy to answer any questions you might have.

[druid] branch master updated: Fix balancer strategy (#10070)

2020-06-25 Thread pjain1
This is an automated email from the ASF dual-hosted git repository. pjain1 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 422a8af Fix balancer strategy (#10070) 422a8af

[GitHub] [druid] pjain1 merged pull request #10070: Fix balancer strategy

2020-06-25 Thread GitBox
pjain1 merged pull request #10070: URL: https://github.com/apache/druid/pull/10070 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] pjain1 closed issue #10067: CostBalancerStrategy over assigns segments to historicals over their max size

2020-06-25 Thread GitBox
pjain1 closed issue #10067: URL: https://github.com/apache/druid/issues/10067 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] jp707049 opened a new issue #10078: How to use `environment variables` in runtime.properties?

2020-06-25 Thread GitBox
jp707049 opened a new issue #10078: URL: https://github.com/apache/druid/issues/10078 Hello, - We've have an env variable defined in a node called `DRUID_HOST` which points to the actual hostname of the node. - How can we use `DRUID_HOST` in runtime.properties of a druid service?

[GitHub] [druid] ArvinZheng closed issue #8609: Zero filling for TopN

2020-06-25 Thread GitBox
ArvinZheng closed issue #8609: URL: https://github.com/apache/druid/issues/8609 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] ArvinZheng closed issue #8882: equals method in SegmentId looks buggy

2020-06-25 Thread GitBox
ArvinZheng closed issue #8882: URL: https://github.com/apache/druid/issues/8882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] AndyLin0128 opened a new issue #10077: build druid-0.18.1 failed

2020-06-25 Thread GitBox
AndyLin0128 opened a new issue #10077: URL: https://github.com/apache/druid/issues/10077 [INFO] Analysis Started [INFO] Finished Archive Analyzer (3 seconds) [INFO] Finished File Name Analyzer (0 seconds) [INFO] Finished Jar Analyzer (2 seconds) [ERROR]

[GitHub] [druid] clintropolis commented on a change in pull request #10076: ensure ParallelMergeCombiningSequence closes it's closeables

2020-06-25 Thread GitBox
clintropolis commented on a change in pull request #10076: URL: https://github.com/apache/druid/pull/10076#discussion_r445326768 ## File path: core/src/main/java/org/apache/druid/java/util/common/guava/ParallelMergeCombiningSequence.java ## @@ -1036,11 +1047,13 @@ public

[GitHub] [druid] clintropolis opened a new pull request #10076: Parallel merge combining sequence close yielders

2020-06-25 Thread GitBox
clintropolis opened a new pull request #10076: URL: https://github.com/apache/druid/pull/10076 ### Description #9934 but for `ParallelMergeCombiningSequence`. Also spotted a place where we weren't closing a non-exploding `BatchedResultCursor` so fixes more leaks than I was