[GitHub] [druid] AnswerNo2 commented on issue #10310: I use Druid Connection pool that met a question

2020-08-21 Thread GitBox
AnswerNo2 commented on issue #10310: URL: https://github.com/apache/druid/issues/10310#issuecomment-678603505 just the ‘orderBy’ is wrong, other SQL keywords No mistake This is an automated message from the Apache Git Servic

[GitHub] [druid] AnswerNo2 opened a new issue #10310: I use Druid Connection pool that met a question

2020-08-21 Thread GitBox
AnswerNo2 opened a new issue #10310: URL: https://github.com/apache/druid/issues/10310 environment: Springboot + mybatis + postgresql + Druid when you send a parameter to mybatis , if parameter's key is 'orderBy' , then ,that problem is coming: SQL will be wrong ! !

[GitHub] [druid] himanshug commented on pull request #9693: Allow bootstrap.servers to be provided for Kafka ingestion.

2020-08-21 Thread GitBox
himanshug commented on pull request #9693: URL: https://github.com/apache/druid/pull/9693#issuecomment-678586003 closing this in favor of #10309 which makes all kafka consumer props including `bootstrap.servers` to be provided in a dynamic way via extensions. -

[GitHub] [druid] himanshug closed pull request #9693: Allow bootstrap.servers to be provided for Kafka ingestion.

2020-08-21 Thread GitBox
himanshug closed pull request #9693: URL: https://github.com/apache/druid/pull/9693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] himanshug opened a new pull request #10309: introduce DynamicConfigProvider interface and make kafka consumer props extensible

2020-08-21 Thread GitBox
himanshug opened a new pull request #10309: URL: https://github.com/apache/druid/pull/10309 supersedes #9693 ### Description This patch really came from need of supplying few kafka consumer properties such as `bootstrap.servers` using user specific extensible mechanisms simila

[GitHub] [druid] jihoonson commented on a change in pull request #9638: refactor internal type system

2020-08-21 Thread GitBox
jihoonson commented on a change in pull request #9638: URL: https://github.com/apache/druid/pull/9638#discussion_r475018525 ## File path: extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/HllSketchToEstimatePostAggregator.java ## @@

[GitHub] [druid] himanshug merged pull request #10295: introduce interning of internal files names in SmooshedFileMapper

2020-08-21 Thread GitBox
himanshug merged pull request #10295: URL: https://github.com/apache/druid/pull/10295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[druid] branch master updated (0910d22 -> a607e9e)

2020-08-21 Thread himanshug
This is an automated email from the ASF dual-hosted git repository. himanshug pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 0910d22 Add SQL "OFFSET" clause. (#10279) add a607e9e introduce interning of internal files names in Smoosh

[GitHub] [druid] himanshug commented on pull request #10295: introduce interning of internal files names in SmooshedFileMapper

2020-08-21 Thread GitBox
himanshug commented on pull request #10295: URL: https://github.com/apache/druid/pull/10295#issuecomment-678567687 @jihoonson thanks for reviewing. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [druid] jihoonson opened a new pull request #10308: Move tools for indexing to TaskToolbox instead of injecting them in constructor

2020-08-21 Thread GitBox
jihoonson opened a new pull request #10308: URL: https://github.com/apache/druid/pull/10308 ### Description This is a simple refactoring to have all tools necessary for indexing in `TaskToolbox` rather than having them separately in different classes. This PR also fixes a bug in `Pa

[druid] branch master updated (b5b3e6e -> 0910d22)

2020-08-21 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from b5b3e6e Add maxNumFiles to splitHintSpec (#10243) add 0910d22 Add SQL "OFFSET" clause. (#10279) No new revisions

[GitHub] [druid] gianm merged pull request #10279: Add SQL "OFFSET" clause.

2020-08-21 Thread GitBox
gianm merged pull request #10279: URL: https://github.com/apache/druid/pull/10279 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [druid] jon-wei edited a comment on issue #9380: Fine grained config and state resources

2020-08-21 Thread GitBox
jon-wei edited a comment on issue #9380: URL: https://github.com/apache/druid/issues/9380#issuecomment-677957679 @pjain1 > For both compaction and load rule I thought it more intuitive to bind read with read and write with write. Should we just add a new resource type like DATASOUR

[GitHub] [druid] sthetland commented on a change in pull request #10306: Adding supported compression formats for native batch ingestion

2020-08-21 Thread GitBox
sthetland commented on a change in pull request #10306: URL: https://github.com/apache/druid/pull/10306#discussion_r474913436 ## File path: docs/ingestion/native-batch.md ## @@ -69,6 +69,9 @@ Some other cloud storage types are supported with the legacy [`firehose`](#fireh The

[GitHub] [druid] jihoonson opened a new pull request #10307: Add support for all partitioing schemes for auto compaction

2020-08-21 Thread GitBox
jihoonson opened a new pull request #10307: URL: https://github.com/apache/druid/pull/10307 ### Description This PR allows using all supported partitioning schemes in auto compaction. In addition to that, all tuningConfigs in `ParallelIndexTuningConfig` are now available for auto co

[GitHub] [druid] fermelone opened a new pull request #10306: Adding supported compression formats for native batch ingestion

2020-08-21 Thread GitBox
fermelone opened a new pull request #10306: URL: https://github.com/apache/druid/pull/10306 ### Description Added compression format support for native batch ingestion --

[GitHub] [druid] abhishekrb19 commented on issue #10282: Druid SQL: A sub-query with expressions returns no data potentially due to an incorrect Query plan.

2020-08-21 Thread GitBox
abhishekrb19 commented on issue #10282: URL: https://github.com/apache/druid/issues/10282#issuecomment-678400182 @gianm, I updated the details with the native JSON queries. Note that I edited the original query a bit for clarity purposes that will hopefully help narrow down the issue to th

[GitHub] [druid] jihoonson merged pull request #10243: Add maxNumFiles to splitHintSpec

2020-08-21 Thread GitBox
jihoonson merged pull request #10243: URL: https://github.com/apache/druid/pull/10243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[druid] branch master updated: Add maxNumFiles to splitHintSpec (#10243)

2020-08-21 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new b5b3e6e Add maxNumFiles to splitHintSpec (#10

[GitHub] [druid] lgtm-com[bot] commented on pull request #10304: Add vectorization for druid-histogram extension

2020-08-21 Thread GitBox
lgtm-com[bot] commented on pull request #10304: URL: https://github.com/apache/druid/pull/10304#issuecomment-678382987 This pull request **fixes 1 alert** when merging b47c90634c746d66812736b6202a976ea7dc7cb2 into 7620b0c54e31ed466adf149b2b7fbd815c4c70ce - [view on LGTM.com](https://lgtm.

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10304: Add vectorization for druid-histogram extension

2020-08-21 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10304: URL: https://github.com/apache/druid/pull/10304#discussion_r474782276 ## File path: extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/ApproximateHistogramFoldingBufferAggregatorInternal.

[GitHub] [druid] abhishekagarwal87 commented on a change in pull request #10304: Add vectorization for druid-histogram extension

2020-08-21 Thread GitBox
abhishekagarwal87 commented on a change in pull request #10304: URL: https://github.com/apache/druid/pull/10304#discussion_r474780398 ## File path: extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/ApproximateHistogramFoldingBufferAggregatorInternal.

[GitHub] [druid] aewhite commented on issue #10289: S3 extensions does not retry on 503 slow down responses

2020-08-21 Thread GitBox
aewhite commented on issue #10289: URL: https://github.com/apache/druid/issues/10289#issuecomment-678274491 @jihoonson I would personally use the built in [RetryPolicy](https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/retry/RetryPolicy.html) and configure it directly in

[GitHub] [druid] liguifa closed pull request #10305: New version management function of datasource segment

2020-08-21 Thread GitBox
liguifa closed pull request #10305: URL: https://github.com/apache/druid/pull/10305 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [druid] liguifa opened a new pull request #10305: New version management function of datasource segment

2020-08-21 Thread GitBox
liguifa opened a new pull request #10305: URL: https://github.com/apache/druid/pull/10305 New version management function of datasource segment. During the reuse process, there are often exceptions to the version data. At this time, we hope to roll back to the old version in a very short t