[GitHub] [druid] FrankChen021 commented on pull request #12026: Unify HTTP response model and API

2022-03-04 Thread GitBox
FrankChen021 commented on pull request #12026: URL: https://github.com/apache/druid/pull/12026#issuecomment-1059709010 Description has been updated to reflect the latest change. And the old API will be added to the forbidden API list in later commits. -- This is an automated message

[GitHub] [druid] rohangarg commented on issue #12311: Historical crashes with OOM on SQL join query

2022-03-04 Thread GitBox
rohangarg commented on issue #12311: URL: https://github.com/apache/druid/issues/12311#issuecomment-1059704043 @cheezman34 : Thanks for reporting the issue! I think the issue is because of a filter explosion that happens in one of the join optimizations if the number of OR filters in the

[GitHub] [druid] cheezman34 opened a new issue #12311: Historical crashes with OOM on SQL join query

2022-03-04 Thread GitBox
cheezman34 opened a new issue #12311: URL: https://github.com/apache/druid/issues/12311 ### Affected Version 21.1 ### Description ``` SELECT "field1", "field2", "subquery_count", Count(*) as "count" FROM datamodel LEFT JOIN ( SELECT "field1" as

[GitHub] [druid] jihoonson commented on pull request #12298: [WIP] Add config for lazy connections to mitigate overwhelming of Coordinator

2022-03-04 Thread GitBox
jihoonson commented on pull request #12298: URL: https://github.com/apache/druid/pull/12298#issuecomment-1059649490 Hi @AmatyaAvadhanula, thank you for your contribution. Can you please elaborate more on what problem you want to solve in this PR? It would be nice to include your answer in

[GitHub] [druid] gianm commented on a change in pull request #12307: Always reopen stream in FileUtils.copyLarge, RetryingInputStream.

2022-03-04 Thread GitBox
gianm commented on a change in pull request #12307: URL: https://github.com/apache/druid/pull/12307#discussion_r820017853 ## File path: core/src/main/java/org/apache/druid/data/input/impl/RetryingInputStream.java ## @@ -19,99 +19,105 @@ package

[GitHub] [druid] gianm commented on a change in pull request #12307: Always reopen stream in FileUtils.copyLarge, RetryingInputStream.

2022-03-04 Thread GitBox
gianm commented on a change in pull request #12307: URL: https://github.com/apache/druid/pull/12307#discussion_r820017814 ## File path: core/src/main/java/org/apache/druid/data/input/impl/RetryingInputStream.java ## @@ -19,99 +19,105 @@ package

[GitHub] [druid] FrankChen021 commented on a change in pull request #12307: Always reopen stream in FileUtils.copyLarge, RetryingInputStream.

2022-03-04 Thread GitBox
FrankChen021 commented on a change in pull request #12307: URL: https://github.com/apache/druid/pull/12307#discussion_r820016604 ## File path: core/src/main/java/org/apache/druid/data/input/impl/RetryingInputStream.java ## @@ -19,99 +19,105 @@ package

[GitHub] [druid] FrankChen021 commented on a change in pull request #12307: Always reopen stream in FileUtils.copyLarge, RetryingInputStream.

2022-03-04 Thread GitBox
FrankChen021 commented on a change in pull request #12307: URL: https://github.com/apache/druid/pull/12307#discussion_r820016475 ## File path: core/src/main/java/org/apache/druid/data/input/impl/RetryingInputStream.java ## @@ -19,99 +19,105 @@ package

[GitHub] [druid] FrankChen021 commented on pull request #12111: add a new query laning metrics to visualize lane assignment

2022-03-04 Thread GitBox
FrankChen021 commented on pull request #12111: URL: https://github.com/apache/druid/pull/12111#issuecomment-1059642931 Thank you @gianm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] gianm commented on issue #12262: Multi-stage distributed queries

2022-03-04 Thread GitBox
gianm commented on issue #12262: URL: https://github.com/apache/druid/issues/12262#issuecomment-1059631099 @julianhyde Do you have a reference for what sort of algorithm you had in mind that uses such opposite-direction-flowing Bloom filters? I'd like to read more about it. -- This is

[GitHub] [druid] jihoonson commented on pull request #12111: add a new query laning metrics to visualize lane assignment

2022-03-04 Thread GitBox
jihoonson commented on pull request #12111: URL: https://github.com/apache/druid/pull/12111#issuecomment-1059614441 Thank you @gianm! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [druid] gianm commented on pull request #12111: add a new query laning metrics to visualize lane assignment

2022-03-04 Thread GitBox
gianm commented on pull request #12111: URL: https://github.com/apache/druid/pull/12111#issuecomment-1059613007 I included a fix in #12307. It was a logical conflict between this patch and #12202, that as far as I can tell only affected the test case QueryableModuleTest. -- This is an

[GitHub] [druid] gianm commented on a change in pull request #12307: Always reopen stream in FileUtils.copyLarge, RetryingInputStream.

2022-03-04 Thread GitBox
gianm commented on a change in pull request #12307: URL: https://github.com/apache/druid/pull/12307#discussion_r819988928 ## File path: core/src/main/java/org/apache/druid/data/input/impl/RetryingInputStream.java ## @@ -131,76 +136,92 @@ private static void

[GitHub] [druid] gianm commented on pull request #12307: Always reopen stream in FileUtils.copyLarge, RetryingInputStream.

2022-03-04 Thread GitBox
gianm commented on pull request #12307: URL: https://github.com/apache/druid/pull/12307#issuecomment-1059610581 FYI I included a fix for a logical conflict between #12111 and #12202 in this patch, because it was causing CI to fail. The fix is in QueryableModuleTest. -- This is an

[GitHub] [druid] techdocsmith merged pull request #12308: Correct errors on compaction doc

2022-03-04 Thread GitBox
techdocsmith merged pull request #12308: URL: https://github.com/apache/druid/pull/12308 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[druid] branch master updated (3b37311 -> 903174d)

2022-03-04 Thread techdocsmith
This is an automated email from the ASF dual-hosted git repository. techdocsmith pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 3b37311 Officially support Java 11. (#12232) add 903174d correct errors on compaction doc (#12308) No

[druid] branch dependabot/maven/org.apache.maven.plugins-maven-site-plugin-3.11.0 created (now f12260a)

2022-03-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-site-plugin-3.11.0 in repository https://gitbox.apache.org/repos/asf/druid.git. at f12260a Bump maven-site-plugin from 3.1 to 3.11.0

[GitHub] [druid] dependabot[bot] opened a new pull request #12310: Bump maven-site-plugin from 3.1 to 3.11.0

2022-03-04 Thread GitBox
dependabot[bot] opened a new pull request #12310: URL: https://github.com/apache/druid/pull/12310 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 3.1 to 3.11.0. Release notes Sourced from

[GitHub] [druid] maytasm commented on a change in pull request #12299: Introducing new config to make errors in jetty layer return by defaul…

2022-03-04 Thread GitBox
maytasm commented on a change in pull request #12299: URL: https://github.com/apache/druid/pull/12299#discussion_r819962177 ## File path: server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java ## @@ -475,6 +478,25 @@ public void stop()

[GitHub] [druid] maytasm commented on a change in pull request #12299: Introducing new config to make errors in jetty layer return by defaul…

2022-03-04 Thread GitBox
maytasm commented on a change in pull request #12299: URL: https://github.com/apache/druid/pull/12299#discussion_r819960643 ## File path: server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java ## @@ -483,6 +505,28 @@ public boolean

[GitHub] [druid] maytasm commented on a change in pull request #12299: Introducing new config to make errors in jetty layer return by defaul…

2022-03-04 Thread GitBox
maytasm commented on a change in pull request #12299: URL: https://github.com/apache/druid/pull/12299#discussion_r819961340 ## File path: docs/configuration/index.md ## @@ -651,7 +651,7 @@ You can configure Druid API error responses to hide internal information like th

[GitHub] [druid] maytasm commented on a change in pull request #12299: Introducing new config to make errors in jetty layer return by defaul…

2022-03-04 Thread GitBox
maytasm commented on a change in pull request #12299: URL: https://github.com/apache/druid/pull/12299#discussion_r819960643 ## File path: server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java ## @@ -483,6 +505,28 @@ public boolean

[GitHub] [druid] maytasm commented on a change in pull request #12299: Introducing new config to make errors in jetty layer return by defaul…

2022-03-04 Thread GitBox
maytasm commented on a change in pull request #12299: URL: https://github.com/apache/druid/pull/12299#discussion_r819960008 ## File path: server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java ## @@ -483,6 +505,28 @@ public boolean

[GitHub] [druid] jihoonson commented on a change in pull request #12307: Always reopen stream in FileUtils.copyLarge, RetryingInputStream.

2022-03-04 Thread GitBox
jihoonson commented on a change in pull request #12307: URL: https://github.com/apache/druid/pull/12307#discussion_r819955319 ## File path: core/src/main/java/org/apache/druid/data/input/impl/RetryingInputStream.java ## @@ -131,76 +136,92 @@ private static void

[druid] branch master updated (ada3ae0 -> 3b37311)

2022-03-04 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from ada3ae0 Retain order in TaskReport. (#12005) add 3b37311 Officially support Java 11. (#12232) No new revisions

[GitHub] [druid] gianm merged pull request #12232: Officially support Java 11.

2022-03-04 Thread GitBox
gianm merged pull request #12232: URL: https://github.com/apache/druid/pull/12232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] gianm commented on pull request #12232: Officially support Java 11.

2022-03-04 Thread GitBox
gianm commented on pull request #12232: URL: https://github.com/apache/druid/pull/12232#issuecomment-1059570139 OK, it turns out I didn't have time to pursue those warnings after all. I'll merge this and then we can improve it in future patches. Still very exciting  -- This is an

[GitHub] [druid] gianm opened a new pull request #12309: GroupBy: Cap dictionary-building selector memory usage.

2022-03-04 Thread GitBox
gianm opened a new pull request #12309: URL: https://github.com/apache/druid/pull/12309 New context parameter "maxSelectorDictionarySize" controls when the per-segment processing code should return early and trigger a trip to the merge buffer. Includes: - Vectorized and

[GitHub] [druid] vtlim opened a new pull request #12308: Correct errors on compaction doc

2022-03-04 Thread GitBox
vtlim opened a new pull request #12308: URL: https://github.com/apache/druid/pull/12308 Fixes description for the compaction example, and formats the JSON examples to be nicer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [druid] gianm opened a new pull request #12307: Always reopen stream in FileUtils.copyLarge, RetryingInputStream.

2022-03-04 Thread GitBox
gianm opened a new pull request #12307: URL: https://github.com/apache/druid/pull/12307 When an InputStream throws an exception from one of its read methods, we should assume it's bad and reopen it. The main changes here are: - In FileUtils.copyLarge, replace InputStream

[GitHub] [druid] xvrl opened a new pull request #12306: upgrade Error Prone to 2.11 (requires Java 11)

2022-03-04 Thread GitBox
xvrl opened a new pull request #12306: URL: https://github.com/apache/druid/pull/12306 The latest version of Error Prone now requires Java 11. Upgrading means we can remove a lot of the maven profile complexity required to run checks with Java 8. This also requires switching our

[GitHub] [druid] jihoonson commented on pull request #12111: add a new query laning metrics to visualize lane assignment

2022-03-04 Thread GitBox
jihoonson commented on pull request #12111: URL: https://github.com/apache/druid/pull/12111#issuecomment-1059399027 @isandeep41 @FrankChen021 @asdf2014, thank you for getting this PR merged. It seems that Travis has started to fail after this PR is merged

[GitHub] [druid] jihoonson commented on pull request #12304: Fix ci

2022-03-04 Thread GitBox
jihoonson commented on pull request #12304: URL: https://github.com/apache/druid/pull/12304#issuecomment-1059395451 @samarthjain thanks for merging this PR. I think that LGTM has a step that runs a build against master before applying your change. LGTM seems to have failed in that step,

[GitHub] [druid] gianm closed pull request #11970: Try to fix flaky ITBroadcastJoinQueryTest.

2022-03-04 Thread GitBox
gianm closed pull request #11970: URL: https://github.com/apache/druid/pull/11970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[druid] branch master updated: Retain order in TaskReport. (#12005)

2022-03-04 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new ada3ae0 Retain order in TaskReport. (#12005)

[GitHub] [druid] gianm merged pull request #12005: Retain order in TaskReport maps.

2022-03-04 Thread GitBox
gianm merged pull request #12005: URL: https://github.com/apache/druid/pull/12005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [druid] happy5035 opened a new issue #12305: HttpRemoteTaskRunner leak memory

2022-03-04 Thread GitBox
happy5035 opened a new issue #12305: URL: https://github.com/apache/druid/issues/12305 In my test environment, there was a total of 3500supervisor(index_kafka,task count:1, replicas:1),task is pending The runPendingTasksExec thread pool in HttpRemoteTaskRunner contains 50