Re: [PR] [DO NOT MERGE] OBSDATA-3156: Add confluent patches to Druid 28 (druid)

2023-11-27 Thread via GitHub
pagrawal10 closed pull request #15437: [DO NOT MERGE] OBSDATA-3156: Add confluent patches to Druid 28 URL: https://github.com/apache/druid/pull/15437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] OBSDATA-3156: Add confluent patches to Druid 28 (druid)

2023-11-27 Thread via GitHub
pagrawal10 opened a new pull request, #15437: URL: https://github.com/apache/druid/pull/15437 Apply Confluent patches on top of Druid 28. Druid 25 release notes can be found [here](https://github.com/apache/druid/releases/tag/druid-28.0.0)

Re: [PR] Add option to compare results with relative error tolerance (druid)

2023-11-27 Thread via GitHub
abhishekagarwal87 merged PR #15429: URL: https://github.com/apache/druid/pull/15429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: Add option to compare results with relative error tolerance (#15429)

2023-11-27 Thread abhishek
This is an automated email from the ASF dual-hosted git repository. abhishek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new ca544e552cf Add option to compare results with

Re: [PR] [Security Fix] Upgrade mysql connector to 8.0.28 (druid)

2023-11-27 Thread via GitHub
abhishekagarwal87 commented on code in PR #15408: URL: https://github.com/apache/druid/pull/15408#discussion_r1407322340 ## processing/src/main/java/org/apache/druid/utils/ConnectionUriUtils.java: ## @@ -177,19 +178,26 @@ public static Set tryParsePostgresConnectionUri(String

Re: [PR] Kinesis adaptive memory management (druid)

2023-11-27 Thread via GitHub
zachjsh commented on code in PR #15360: URL: https://github.com/apache/druid/pull/15360#discussion_r1407313784 ## extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java: ## @@ -437,42 +429,35 @@ public

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
kgyrtkirk commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1407192800 ## docs/querying/sql-functions.md: ## @@ -50,7 +50,7 @@ Calculates the arc cosine of a numeric expression. ## ANY_VALUE -`ANY_VALUE(expr, [maxBytesPerValue])`

Re: [PR] testing the update of zookeeper to 3.7.2 (druid)

2023-11-27 Thread via GitHub
abhishekagarwal87 commented on PR #15432: URL: https://github.com/apache/druid/pull/15432#issuecomment-1829162041 Does upgrading to 3.8.2 fails for some reason? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
soumyava commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1407200355 ## processing/src/test/java/org/apache/druid/query/aggregation/any/StringAnyBufferAggregatorTest.java: ## @@ -44,17 +51,14 @@ public void testBufferAggregate() {

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
clintropolis commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1407200862 ## processing/src/main/java/org/apache/druid/query/aggregation/any/StringAnyVectorAggregator.java: ## @@ -78,7 +84,22 @@ public void aggregate(ByteBuffer buf, int

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
pranavbhole commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1407083766 ## sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java: ## @@ -13433,6 +13433,45 @@ public void testStringAggExpressionNonConstantSeparator()

Re: [PR] Fixing failing compaction/parallel index jobs during upgrade due to new actions being available on the overlord. (druid)

2023-11-27 Thread via GitHub
cryptoe commented on PR #15430: URL: https://github.com/apache/druid/pull/15430#issuecomment-1829053531 The error message that comes without this patch is ``` 2023-11-27T16:44:44,180 ERROR

(druid) branch master updated: Use StubServiceEmitter in tests (#15426)

2023-11-27 Thread kfaraz
This is an automated email from the ASF dual-hosted git repository. kfaraz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 58a724c7e40 Use StubServiceEmitter in tests

Re: [PR] Use StubServiceEmitter in tests (druid)

2023-11-27 Thread via GitHub
kfaraz merged PR #15426: URL: https://github.com/apache/druid/pull/15426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use StubServiceEmitter in tests (druid)

2023-11-27 Thread via GitHub
kfaraz commented on code in PR #15426: URL: https://github.com/apache/druid/pull/15426#discussion_r1407055481 ## server/src/test/java/org/apache/druid/curator/DruidConnectionStateListenerTest.java: ## @@ -120,31 +104,8 @@ public void test_reconnectedMetric()

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
clintropolis commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1407001862 ## processing/src/main/java/org/apache/druid/query/aggregation/any/StringAnyVectorAggregator.java: ## @@ -78,7 +84,23 @@ public void aggregate(ByteBuffer buf, int

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
pranavbhole commented on PR #15434: URL: https://github.com/apache/druid/pull/15434#issuecomment-1828967863 Addressed all comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
pranavbhole commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1407001551 ## processing/src/test/java/org/apache/druid/query/aggregation/any/StringAnyAggregatorFactoryTest.java: ## @@ -72,43 +68,107 @@ public void

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
pranavbhole commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1407000710 ## processing/src/main/java/org/apache/druid/query/aggregation/any/StringAnyVectorAggregator.java: ## @@ -78,7 +84,23 @@ public void aggregate(ByteBuffer buf, int

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
pranavbhole commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1406999287 ## processing/src/main/java/org/apache/druid/query/aggregation/any/StringAnyAggregator.java: ## @@ -24,38 +24,45 @@ import

Re: [PR] Kinesis adaptive memory management (druid)

2023-11-27 Thread via GitHub
github-advanced-security[bot] commented on code in PR #15360: URL: https://github.com/apache/druid/pull/15360#discussion_r1406932606 ## processing/src/main/java/org/apache/druid/java/util/common/MemoryBoundLinkedBlockingQueue.java: ## @@ -61,12 +92,56 @@ return ret; }

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
clintropolis commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1406899167 ## processing/src/main/java/org/apache/druid/query/aggregation/any/StringAnyVectorAggregator.java: ## @@ -78,7 +84,23 @@ public void aggregate(ByteBuffer buf, int

Re: [PR] Kinesis adaptive memory management (druid)

2023-11-27 Thread via GitHub
zachjsh commented on code in PR #15360: URL: https://github.com/apache/druid/pull/15360#discussion_r1406908345 ## extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisIndexTaskTuningConfig.java: ## @@ -81,7 +80,7 @@ public

Re: [PR] Kinesis adaptive memory management (druid)

2023-11-27 Thread via GitHub
zachjsh commented on code in PR #15360: URL: https://github.com/apache/druid/pull/15360#discussion_r1406908526 ## extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java: ## @@ -1059,11 +1045,22 @@ private void

Re: [PR] Kinesis adaptive memory management (druid)

2023-11-27 Thread via GitHub
zachjsh commented on code in PR #15360: URL: https://github.com/apache/druid/pull/15360#discussion_r1406907369 ## docs/development/extensions-core/kinesis-ingestion.md: ## @@ -656,25 +655,22 @@ For more detail, see [Segment size optimization](../../operations/segment-optimi

Re: [PR] Kinesis adaptive memory management (druid)

2023-11-27 Thread via GitHub
zachjsh commented on code in PR #15360: URL: https://github.com/apache/druid/pull/15360#discussion_r1406907369 ## docs/development/extensions-core/kinesis-ingestion.md: ## @@ -656,25 +655,22 @@ For more detail, see [Segment size optimization](../../operations/segment-optimi

Re: [PR] Kinesis adaptive memory management (druid)

2023-11-27 Thread via GitHub
zachjsh commented on code in PR #15360: URL: https://github.com/apache/druid/pull/15360#discussion_r1406907369 ## docs/development/extensions-core/kinesis-ingestion.md: ## @@ -656,25 +655,22 @@ For more detail, see [Segment size optimization](../../operations/segment-optimi

Re: [PR] Fix deadlock that can occur while merging group by results (druid)

2023-11-27 Thread via GitHub
github-advanced-security[bot] commented on code in PR #15420: URL: https://github.com/apache/druid/pull/15420#discussion_r1406769405 ## processing/src/test/java/org/apache/druid/query/groupby/GroupByLimitPushDownMultiNodeMergeTest.java: ## @@ -627,23 +626,26 @@ @Test

(druid) branch master updated: Improved web-console's time-chart brush and added auto-granularity (#14990)

2023-11-27 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new c8eb7adeb9b Improved web-console's

Re: [PR] Improved web-console's time-chart brush and added auto-granularity (druid)

2023-11-27 Thread via GitHub
vogievetsky merged PR #14990: URL: https://github.com/apache/druid/pull/14990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Feature: Add IPv6 Match Function (druid)

2023-11-27 Thread via GitHub
sb89594 commented on PR #15212: URL: https://github.com/apache/druid/pull/15212#issuecomment-1828136039 > Hi - is there an approx ETA for a release containing this change? It will depend when this PR gets reviewed. I've been keeping an eye on it but unfortunately I don't have any way

[I] Additional username/password login required even after SSO login using pac4j (druid)

2023-11-27 Thread via GitHub
Subhashini2610 opened a new issue, #15436: URL: https://github.com/apache/druid/issues/15436 ### Description Please include as much detailed information about the problem as possible. I am trying to install Druid on K8s cluster using Helm chart. I need to add the SSO (Open ID

Re: [PR] Web console: time shift literals also (druid)

2023-11-27 Thread via GitHub
lorem--ipsum commented on PR #15433: URL: https://github.com/apache/druid/pull/15433#issuecomment-1827767432  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] fix maq missing last row. if the last record is exactly 1 (druid)

2023-11-27 Thread via GitHub
VodelaPremChander commented on PR #15435: URL: https://github.com/apache/druid/pull/15435#issuecomment-1827680304 Addressing the issue - https://github.com/apache/druid/issues/15390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Feature: Add IPv6 Match Function (druid)

2023-11-27 Thread via GitHub
zargarf commented on PR #15212: URL: https://github.com/apache/druid/pull/15212#issuecomment-1827578465 Hi - is there an approx ETA for a release containing this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] fix maq missing last row. if the last record is exactly 1 (druid)

2023-11-27 Thread via GitHub
suryaMittapalli opened a new pull request, #15435: URL: https://github.com/apache/druid/pull/15435 Fixes #. ### Description Fixed the bug ... Renamed the class ... Added a forbidden-apis entry ...

Re: [PR] Use StubServiceEmitter in tests (druid)

2023-11-27 Thread via GitHub
kgyrtkirk commented on code in PR #15426: URL: https://github.com/apache/druid/pull/15426#discussion_r1405861536 ## server/src/test/java/org/apache/druid/curator/DruidConnectionStateListenerTest.java: ## @@ -120,31 +104,8 @@ public void test_reconnectedMetric()

Re: [PR] Enabling aggregateMultipleValues in all StringAnyAggregators (druid)

2023-11-27 Thread via GitHub
github-advanced-security[bot] commented on code in PR #15434: URL: https://github.com/apache/druid/pull/15434#discussion_r1405788337 ## processing/src/test/java/org/apache/druid/query/aggregation/any/StringAnyBufferAggregatorTest.java: ## @@ -198,4 +189,77 @@