Re: [PR] Add indexer level task metrics to provide more visibility in the task distribution (druid)

2024-02-27 Thread via GitHub
kfaraz commented on code in PR #15991: URL: https://github.com/apache/druid/pull/15991#discussion_r1505486575 ## indexing-service/src/main/java/org/apache/druid/indexing/worker/WorkerTaskManagerMonitor.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation

[PR] Use cache for password hash while validating LDAP password (druid)

2024-02-27 Thread via GitHub
kfaraz opened a new pull request, #15993: URL: https://github.com/apache/druid/pull/15993 Follow up to #15648 This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency

Re: [PR] Add indexer level task metrics to provide more visibility in the task distribution (druid)

2024-02-27 Thread via GitHub
abhishekagarwal87 commented on code in PR #15991: URL: https://github.com/apache/druid/pull/15991#discussion_r1505452622 ## indexing-service/src/main/java/org/apache/druid/indexing/worker/WorkerTaskManagerMonitor.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software

Re: [PR] Add indexer level task metrics to provide more visibility in the task distribution (druid)

2024-02-27 Thread via GitHub
rbankar7 commented on code in PR #15991: URL: https://github.com/apache/druid/pull/15991#discussion_r1505441271 ## indexing-service/src/main/java/org/apache/druid/indexing/worker/WorkerTaskManagerMonitor.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
kfaraz commented on PR #15976: URL: https://github.com/apache/druid/pull/15976#issuecomment-1968330433 Marked this as a `Design Review` to get some more eyes on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
kfaraz commented on PR #15976: URL: https://github.com/apache/druid/pull/15976#issuecomment-1968330003 __Summary__ IIUC, this PR seems to be implementing a task laning mechanism to better utilize available task slots. The lane that a particular task may be assigned to is determined by

Re: [PR] Add indexer level task metrics to provide more visibility in the task distribution (druid)

2024-02-27 Thread via GitHub
abhishekagarwal87 commented on code in PR #15991: URL: https://github.com/apache/druid/pull/15991#discussion_r1505428773 ## indexing-service/src/main/java/org/apache/druid/indexing/worker/WorkerTaskManagerMonitor.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software

(druid) branch master updated (3df161f73cb -> d2c2036ea2b)

2024-02-27 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 3df161f73cb docs: update security doc for hashing (#15970) add d2c2036ea2b Optimize MSQ realtime queries (#15399)

Re: [PR] Optimize MSQ realtime queries (druid)

2024-02-27 Thread via GitHub
cryptoe merged PR #15399: URL: https://github.com/apache/druid/pull/15399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Upgrade pending segments transactionally (druid)

2024-02-27 Thread via GitHub
AmatyaAvadhanula opened a new pull request, #15992: URL: https://github.com/apache/druid/pull/15992 The segment transactional replace action facilitates concurrent replace with streaming append by 1) Upgrading pending segments in the metadata store 2) Relaying this information to

Re: [PR] adaptive filter partitioning (druid)

2024-02-27 Thread via GitHub
imply-cheddar commented on code in PR #15838: URL: https://github.com/apache/druid/pull/15838#discussion_r1505367724 ## processing/src/main/java/org/apache/druid/segment/DimensionHandler.java: ## @@ -143,7 +143,7 @@ DimensionMergerV9 makeMerger( */ Comparator

Re: [PR] adaptive filter partitioning (druid)

2024-02-27 Thread via GitHub
imply-cheddar commented on code in PR #15838: URL: https://github.com/apache/druid/pull/15838#discussion_r1505364675 ## processing/src/main/java/org/apache/druid/segment/filter/OrFilter.java: ## @@ -107,6 +273,27 @@ public T computeBitmapResult(BitmapResultFactory

[PR] Add indexer level task metrics to provide more visibility in the task distribution (druid)

2024-02-27 Thread via GitHub
rbankar7 opened a new pull request, #15991: URL: https://github.com/apache/druid/pull/15991 Adds indexer level task metrics ### Description This PR adds indexer level task metrics- ``` "worker/task/running/count" "worker/task/assigned/count"

Re: [PR] Add pre-check for heavy debug log (druid)

2024-02-27 Thread via GitHub
fectrain commented on PR #15706: URL: https://github.com/apache/druid/pull/15706#issuecomment-1968167613 oh, I might have missed this one, let me refine on it, thanks for reminding @FrankChen021 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
adarshsanjeev commented on code in PR #15976: URL: https://github.com/apache/druid/pull/15976#discussion_r1505319966 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java: ## @@ -147,6 +149,24 @@ public String getType()

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
cryptoe commented on code in PR #15976: URL: https://github.com/apache/druid/pull/15976#discussion_r1505308264 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTask.java: ## @@ -116,6 +119,11 @@ public String getType() return TYPE;

Re: [I] DefaultPasswordProvider shows password when task is running (druid)

2024-02-27 Thread via GitHub
AlbericByte commented on issue #15882: URL: https://github.com/apache/druid/issues/15882#issuecomment-1968143106 @maytasm could you help to describe how to reproduce the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-02-27 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1505308018 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -209,13 +217,52 @@ private void removeNode(DiscoveryDruidNode druidNode)

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-02-27 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1505307825 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -71,22 +71,35 @@ public class BaseNodeRoleWatcher private volatile

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-02-27 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1505307578 ## server/src/main/java/org/apache/druid/rpc/DiscoveryServiceLocator.java: ## @@ -157,5 +157,18 @@ public void nodeViewInitialized() } }

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-02-27 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1505307419 ## server/src/main/java/org/apache/druid/discovery/DruidNodeDiscoveryProvider.java: ## @@ -235,6 +235,28 @@ public void nodeViewInitialized() }

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-02-27 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1505306907 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -65,8 +65,11 @@ public class BaseNodeRoleWatcher private final Object

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-02-27 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1505307211 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -209,13 +217,52 @@ private void removeNode(DiscoveryDruidNode druidNode)

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-02-27 Thread via GitHub
AmatyaAvadhanula commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1505307061 ## indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java: ## @@ -542,6 +542,13 @@ public void nodeViewInitialized()

(druid) branch master updated: docs: update security doc for hashing (#15970)

2024-02-27 Thread frankchen
This is an automated email from the ASF dual-hosted git repository. frankchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 3df161f73cb docs: update security doc for

Re: [PR] docs: update security doc for hashing (druid)

2024-02-27 Thread via GitHub
FrankChen021 merged PR #15970: URL: https://github.com/apache/druid/pull/15970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] pin Testng dependencies to 7.3.0 (druid)

2024-02-27 Thread via GitHub
FrankChen021 merged PR #15924: URL: https://github.com/apache/druid/pull/15924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Update basic-cluster-tuning.md (druid)

2024-02-27 Thread via GitHub
FrankChen021 merged PR #14964: URL: https://github.com/apache/druid/pull/14964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(druid) branch master updated: pin Testng dependencies to 7.3.0 (#15924)

2024-02-27 Thread frankchen
This is an automated email from the ASF dual-hosted git repository. frankchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new f07d402f48e pin Testng dependencies to 7.3.0

Re: [I] pin Testng dependencies to 7.3.0 (druid)

2024-02-27 Thread via GitHub
FrankChen021 closed issue #15923: pin Testng dependencies to 7.3.0 URL: https://github.com/apache/druid/issues/15923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(druid) branch master updated: Update basic-cluster-tuning.md (#14964)

2024-02-27 Thread frankchen
This is an automated email from the ASF dual-hosted git repository. frankchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 0c601bf430d Update basic-cluster-tuning.md

Re: [PR] Add pre-check for heavy debug log (druid)

2024-02-27 Thread via GitHub
FrankChen021 commented on PR #15706: URL: https://github.com/apache/druid/pull/15706#issuecomment-1968037577 Hi @fectrain Can you pick up this PR again to resolve the conflict so that we can merge it? -- This is an automated message from the Apache Git Service. To respond to the message,

(druid) branch master updated: update the doc for dump-segment tool when using jdk11+ (#15971)

2024-02-27 Thread frankchen
This is an automated email from the ASF dual-hosted git repository. frankchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new e7d753d4b03 update the doc for dump-segment

Re: [PR] update the doc for dump-segment tool when using jdk11+ (druid)

2024-02-27 Thread via GitHub
FrankChen021 merged PR #15971: URL: https://github.com/apache/druid/pull/15971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Web console: add table and column search (druid)

2024-02-27 Thread via GitHub
vogievetsky opened a new pull request, #15990: URL: https://github.com/apache/druid/pull/15990 Added the ability to search on tables and column in the query view https://github.com/apache/druid/assets/177816/a18deb57-d529-4cfd-ab66-2999ef29464b;> -- This is an automated message

Re: [PR] fix bug join query with require time condition (druid)

2024-02-27 Thread via GitHub
github-actions[bot] commented on PR #14890: URL: https://github.com/apache/druid/pull/14890#issuecomment-1967952077 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this

(druid) branch dependabot/maven/com.nimbusds-oauth2-oidc-sdk-11.10 deleted (was 096975ba8cf)

2024-02-27 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.nimbusds-oauth2-oidc-sdk-11.10 in repository https://gitbox.apache.org/repos/asf/druid.git was 096975ba8cf Bump com.nimbusds:oauth2-oidc-sdk from 8.22 to 11.10

(druid) branch dependabot/maven/com.nimbusds-oauth2-oidc-sdk-11.10.1 created (now 1c3f4496ff0)

2024-02-27 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.nimbusds-oauth2-oidc-sdk-11.10.1 in repository https://gitbox.apache.org/repos/asf/druid.git at 1c3f4496ff0 Bump com.nimbusds:oauth2-oidc-sdk from 8.22 to 11.10.1

Re: [PR] Bump com.nimbusds:oauth2-oidc-sdk from 8.22 to 11.10 (druid)

2024-02-27 Thread via GitHub
dependabot[bot] commented on PR #15928: URL: https://github.com/apache/druid/pull/15928#issuecomment-1967921265 Superseded by #15989. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump com.nimbusds:oauth2-oidc-sdk from 8.22 to 11.10 (druid)

2024-02-27 Thread via GitHub
dependabot[bot] closed pull request #15928: Bump com.nimbusds:oauth2-oidc-sdk from 8.22 to 11.10 URL: https://github.com/apache/druid/pull/15928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] Bump com.nimbusds:oauth2-oidc-sdk from 8.22 to 11.10.1 (druid)

2024-02-27 Thread via GitHub
dependabot[bot] opened a new pull request, #15989: URL: https://github.com/apache/druid/pull/15989 Bumps [com.nimbusds:oauth2-oidc-sdk](https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions) from 8.22 to 11.10.1. Changelog Sourced from

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
YongGang commented on code in PR #15976: URL: https://github.com/apache/druid/pull/15976#discussion_r1505137149 ## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/TaskLaneCapacityPolicy.java: ## @@ -0,0 +1,26 @@ +/* + *

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
YongGang commented on code in PR #15976: URL: https://github.com/apache/druid/pull/15976#discussion_r1505136918 ## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/TaskLaneConfig.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to

(druid) branch dependabot/maven/io.grpc-grpc-netty-shaded-1.61.1 deleted (was f0e4192a3ef)

2024-02-27 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.grpc-grpc-netty-shaded-1.61.1 in repository https://gitbox.apache.org/repos/asf/druid.git was f0e4192a3ef Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.61.1 The

Re: [PR] Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.61.1 (druid)

2024-02-27 Thread via GitHub
dependabot[bot] commented on PR #15829: URL: https://github.com/apache/druid/pull/15829#issuecomment-1967897656 Superseded by #15988. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.61.1 (druid)

2024-02-27 Thread via GitHub
dependabot[bot] closed pull request #15829: Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.61.1 URL: https://github.com/apache/druid/pull/15829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(druid) branch dependabot/maven/io.grpc-grpc-netty-shaded-1.62.2 created (now 56d014a02e8)

2024-02-27 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.grpc-grpc-netty-shaded-1.62.2 in repository https://gitbox.apache.org/repos/asf/druid.git at 56d014a02e8 Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.62.2 No

[PR] Bump io.grpc:grpc-netty-shaded from 1.57.2 to 1.62.2 (druid)

2024-02-27 Thread via GitHub
dependabot[bot] opened a new pull request, #15988: URL: https://github.com/apache/druid/pull/15988 Bumps [io.grpc:grpc-netty-shaded](https://github.com/grpc/grpc-java) from 1.57.2 to 1.62.2. Release notes Sourced from

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
YongGang commented on code in PR #15976: URL: https://github.com/apache/druid/pull/15976#discussion_r1505131057 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java: ## @@ -147,6 +149,24 @@ public String getType() return

Re: [PR] Introduce dynamic table append (druid)

2024-02-27 Thread via GitHub
vtlim commented on code in PR #15897: URL: https://github.com/apache/druid/pull/15897#discussion_r1505079620 ## docs/querying/datasource.md: ## @@ -211,6 +219,50 @@ Inline datasources are not available in Druid SQL. Refer to the [Query execution](query-execution.md#inline)

Re: [PR] Fix bug while materializing scan's result to frames (druid)

2024-02-27 Thread via GitHub
github-advanced-security[bot] commented on code in PR #15987: URL: https://github.com/apache/druid/pull/15987#discussion_r1505077911 ## processing/src/main/java/org/apache/druid/query/scan/ScanResultValueFramesBatcher.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache

[PR] Fix bug while materializing scan's result to frames (druid)

2024-02-27 Thread via GitHub
LakshSingla opened a new pull request, #15987: URL: https://github.com/apache/druid/pull/15987 ### Description While converting `Sequence` to `Sequence`, when `maxSubqueryBytes` is enabled, we batch the results to prevent creating a single frame per `ScanResultValue.` Batching

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-02-27 Thread via GitHub
adithyachakilam commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1504960237 ## indexing-service/src/main/java/org/apache/druid/indexing/common/IngestionStatsAndErrorsTaskReportData.java: ## @@ -57,7 +62,9 @@ public

Re: [PR] Release notes for 29.0.1 hotfix (druid)

2024-02-27 Thread via GitHub
ektravel commented on code in PR #15960: URL: https://github.com/apache/druid/pull/15960#discussion_r1504959187 ## docs/release-info/release-notes.md: ## @@ -24,6 +24,20 @@ title: "Release notes" +## Druid 29.0.1 + +Apache Druid 29.0.1 is a patch release that fixes some

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-02-27 Thread via GitHub
YongGang commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1504888115 ## indexing-service/src/main/java/org/apache/druid/indexing/common/IngestionStatsAndErrorsTaskReportData.java: ## @@ -57,7 +62,9 @@ public

[PR] feat: add debug log for S3 showing ID when granting full control (druid)

2024-02-27 Thread via GitHub
WilliamRoyNelson opened a new pull request, #15986: URL: https://github.com/apache/druid/pull/15986 ### Adds a debug log message for S3 when granting Full Control ACL If either `druid.indexer.logs.disableAcl` or `druid.storage.disableAcl` is set to true, and logging is set to debug, this

[PR] [DRAFT] Add query templates to catalog (druid)

2024-02-27 Thread via GitHub
jon-wei opened a new pull request, #15985: URL: https://github.com/apache/druid/pull/15985 This PR adds a feature to the Druid catalog for storing query templates that can be referenced when issuing queries via Druid SQL. An initial "concat" template is implemented, which stores a

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
arunramani commented on code in PR #15976: URL: https://github.com/apache/druid/pull/15976#discussion_r1504801806 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQControllerTask.java: ## @@ -147,6 +149,24 @@ public String getType() return

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
arunramani commented on code in PR #15976: URL: https://github.com/apache/druid/pull/15976#discussion_r1504800545 ## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/TaskLaneCapacityPolicy.java: ## @@ -0,0 +1,26 @@ +/* + *

Re: [PR] Task concurrency management in K8s Task Scheduling extension (druid)

2024-02-27 Thread via GitHub
arunramani commented on code in PR #15976: URL: https://github.com/apache/druid/pull/15976#discussion_r1504799267 ## extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/TaskLaneConfig.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to

Re: [PR] Release notes for 29.0.1 hotfix (druid)

2024-02-27 Thread via GitHub
vogievetsky commented on code in PR #15960: URL: https://github.com/apache/druid/pull/15960#discussion_r1504766561 ## docs/release-info/release-notes.md: ## @@ -24,6 +24,20 @@ title: "Release notes" +## Druid 29.0.1 + +Apache Druid 29.0.1 is a patch release that fixes

[PR] remove use log of log4j v1 (druid)

2024-02-27 Thread via GitHub
AlbericByte opened a new pull request, #15984: URL: https://github.com/apache/druid/pull/15984 Fixes #12425. ### Description log4j v1 is end of life and full of security issues indexing-hadoop/pom.xml extensions-core/hdfs-storage/pom.xml remove log4j v1 dependences

[PR] Web console: fix crash when parsing data in data loader that can not be parsed (druid)

2024-02-27 Thread via GitHub
vogievetsky opened a new pull request, #15983: URL: https://github.com/apache/druid/pull/15983 Due to a fragility in `allowKeys` and the change introduced in https://github.com/apache/druid/pull/15858 the data loader now crashes if the incoming sample can not be parsed. (`undefined` value

[PR] gRPC query extension (druid)

2024-02-27 Thread via GitHub
findingrish opened a new pull request, #15982: URL: https://github.com/apache/druid/pull/15982 Fixes #. ### Description Fixed the bug ... Renamed the class ... Added a forbidden-apis entry ...

[PR] Fix compaction tasks reports getting overwritten (druid)

2024-02-27 Thread via GitHub
adithyachakilam opened a new pull request, #15981: URL: https://github.com/apache/druid/pull/15981 ### Description A single compaction task could be splitted the into multiple index tasks based on the interval given in spec. In such cases, all the index tasks are run with same id

Re: [PR] Enable segments read/published stats on Compaction task completion reports (druid)

2024-02-27 Thread via GitHub
adithyachakilam commented on code in PR #15947: URL: https://github.com/apache/druid/pull/15947#discussion_r1504730052 ## indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java: ## @@ -633,6 +635,14 @@ private

[PR] Refactor Test Code to Reduce Mock Duplication For Issue #15979 (druid)

2024-02-27 Thread via GitHub
gzhao9 opened a new pull request, #15980: URL: https://github.com/apache/druid/pull/15980 Description Fixes #15979 This PR addresses the issue #15979 of duplicated mock creation code across multiple test classes within the Apache Druid project. By introducing the

[I] Refactoring the Duplicated/Redundant Mock Objects in `Test Case` of org.apache.druid.query.groupby.epinephelinae.column (druid)

2024-02-27 Thread via GitHub
gzhao9 opened a new issue, #15979: URL: https://github.com/apache/druid/issues/15979 ### Description Hello Druid Developers, I have identified a recurring pattern of code duplication across several test classes in the Apache Druid project. Specifically, the process of mocking

Re: [PR] Handle uninitialized cache in Node role watchers (druid)

2024-02-27 Thread via GitHub
gianm commented on code in PR #15726: URL: https://github.com/apache/druid/pull/15726#discussion_r1504695530 ## server/src/main/java/org/apache/druid/discovery/BaseNodeRoleWatcher.java: ## @@ -71,22 +71,35 @@ public class BaseNodeRoleWatcher private volatile boolean

Re: [PR] fix issues with array_contains and array_overlap with null left side arguments (druid)

2024-02-27 Thread via GitHub
clintropolis commented on code in PR #15974: URL: https://github.com/apache/druid/pull/15974#discussion_r1504694300 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidRexExecutor.java: ## @@ -83,7 +83,11 @@ public void reduce( final RexNode literal;

Re: [PR] fix issues with array_contains and array_overlap with null left side arguments (druid)

2024-02-27 Thread via GitHub
clintropolis commented on code in PR #15974: URL: https://github.com/apache/druid/pull/15974#discussion_r1504686302 ## processing/src/main/java/org/apache/druid/math/expr/Function.java: ## @@ -3779,15 +3781,55 @@ public ExpressionType getOutputType(Expr.InputBindingInspector

Re: [PR] fix issues with array_contains and array_overlap with null left side arguments (druid)

2024-02-27 Thread via GitHub
somu-imply commented on code in PR #15974: URL: https://github.com/apache/druid/pull/15974#discussion_r1504681020 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidRexExecutor.java: ## @@ -83,7 +83,11 @@ public void reduce( final RexNode literal;

Re: [PR] fix issues with array_contains and array_overlap with null left side arguments (druid)

2024-02-27 Thread via GitHub
somu-imply commented on code in PR #15974: URL: https://github.com/apache/druid/pull/15974#discussion_r1504671535 ## processing/src/main/java/org/apache/druid/math/expr/Function.java: ## @@ -3779,15 +3781,55 @@ public ExpressionType getOutputType(Expr.InputBindingInspector

Re: [PR] Fix deadlock that can occur while merging group by results (druid)

2024-02-27 Thread via GitHub
LakshSingla commented on PR #15420: URL: https://github.com/apache/druid/pull/15420#issuecomment-1966918130 @gianm I am working on fixing up the ITs and the UTs due to the changed semantics of resource passing. A few issues I ran into were sharing of the same resource ID on the

(druid) branch master updated (5bb5b41b188 -> beccc401e19)

2024-02-27 Thread abhishekrb
This is an automated email from the ASF dual-hosted git repository. abhishekrb pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git from 5bb5b41b188 Adding task pending time in MSQ reports (#15966) add beccc401e19 Segments created in the same

Re: [PR] Segments created in the same batch have the same `created_date` entry & rename metric (druid)

2024-02-27 Thread via GitHub
abhishekrb19 merged PR #15977: URL: https://github.com/apache/druid/pull/15977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Introduce dynamic table append (druid)

2024-02-27 Thread via GitHub
kgyrtkirk commented on code in PR #15897: URL: https://github.com/apache/druid/pull/15897#discussion_r1491016435 ## sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java: ## @@ -177,7 +177,7 @@ public void validateCall(SqlCall call, SqlValidatorScope

Re: [PR] Segments created in the same batch have the same `created_date` entry & rename metric (druid)

2024-02-27 Thread via GitHub
kfaraz commented on code in PR #15977: URL: https://github.com/apache/druid/pull/15977#discussion_r1503938728 ## server/src/main/java/org/apache/druid/server/coordinator/duty/KillUnusedSegments.java: ## @@ -275,10 +275,10 @@ private Interval findIntervalForKill( );

(druid) branch master updated: Adding task pending time in MSQ reports (#15966)

2024-02-27 Thread karan
This is an automated email from the ASF dual-hosted git repository. karan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/druid.git The following commit(s) were added to refs/heads/master by this push: new 5bb5b41b188 Adding task pending time in MSQ

Re: [PR] Adding task pending time in MSQ reports (druid)

2024-02-27 Thread via GitHub
cryptoe merged PR #15966: URL: https://github.com/apache/druid/pull/15966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: