gianm commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-763818055
Pushed up a new patch.
This is an automated message from the Apache Git Service.
To respond to the message, please
gianm commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-763398344
When debugging a test failure, I realized that some additional work is
needed to make the aggregator able to handle both complex inputs (existing
theta sketches) and regular input
gianm commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-761138114
I've pushed up a new patch that undoes the refactoring and instead
implements things using the same technique as #10304.
-
gianm commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-760776516
Which pattern do you think is better? I haven't had a chance to take a look
at yours yet, so I'm wondering if I should make yours match mine, or mine match
yours.
--
gianm commented on pull request #10767:
URL: https://github.com/apache/druid/pull/10767#issuecomment-760769950
> By the way, I did a similar thing in #10304 to reduce some boilerplate
code but used composition instead of inheritance. Added
package-private`*BufferAggregatorHelper` classes w
