[GitHub] [incubator-druid] himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators

2019-07-22 Thread GitBox
himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators URL: https://github.com/apache/incubator-druid/issues/8031#issuecomment-513949670 related to https://github.com/apache/incubator-druid/issues/8126 which removes usage of `Aggregator` f

[GitHub] [incubator-druid] himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators

2019-07-11 Thread GitBox
himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators URL: https://github.com/apache/incubator-druid/issues/8031#issuecomment-510633717 @Eshcar thanks for pointing to that benchmark, that is the performance in ideal condition and specific

[GitHub] [incubator-druid] himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators

2019-07-10 Thread GitBox
himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators URL: https://github.com/apache/incubator-druid/issues/8031#issuecomment-510193661 @pdeva this proposal is not about removing/modifying synchronizations where there is real concurrency.

[GitHub] [incubator-druid] himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators

2019-07-09 Thread GitBox
himanshug commented on issue #8031: remove unnecessary synchronization overhead from complex Aggregators URL: https://github.com/apache/incubator-druid/issues/8031#issuecomment-509840466 I ran this benchmark ``` @State(Scope.Benchmark) public class SynchronizeOverhead { p