Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-09 Thread via GitHub
cryptoe merged PR #16175: URL: https://github.com/apache/druid/pull/16175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
adarshsanjeev commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1553110171 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2057,25 +2071,25 @@ private static List

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
adarshsanjeev commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1553104056 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2036,19 +2045,24 @@ private static boolean

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
adarshsanjeev commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1553104056 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2036,19 +2045,24 @@ private static boolean

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
adarshsanjeev commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1553103594 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2036,19 +2045,24 @@ private static boolean

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-05 Thread via GitHub
cryptoe commented on PR #16175: URL: https://github.com/apache/druid/pull/16175#issuecomment-2039023633 cc @vogievetsky for the web console changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-04 Thread via GitHub
LakshSingla commented on PR #16175: URL: https://github.com/apache/druid/pull/16175#issuecomment-2036420180 I missed it before, but we should also add MSQTests where these cases are getting tripped, and assert the reason in the report. -- This is an automated message from the Apache

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-04-04 Thread via GitHub
adarshsanjeev commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1551006103 ## docs/api-reference/sql-ingestion-api.md: ## @@ -299,7 +299,7 @@ The response shows an example report for a query. }, "pendingTasks": 0,

Re: [PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-03-31 Thread via GitHub
LakshSingla commented on code in PR #16175: URL: https://github.com/apache/druid/pull/16175#discussion_r1545966059 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java: ## @@ -2036,19 +2045,24 @@ private static boolean

[PR] Add reasoning for choosing shardSpec to the MSQ report (druid)

2024-03-20 Thread via GitHub
adarshsanjeev opened a new pull request, #16175: URL: https://github.com/apache/druid/pull/16175 MSQ chooses the shard spec based on certain criteria. However, this criteria is not very transparent to the user. The only way to find the shard spec which was chosen is to search for a segment