[incubator-druid] branch master updated: Fix ClassNotFoundException in druid-kerberos extension (#4776)

This is an automated email from the ASF dual-hosted git repository. bslim pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new b0ecfee Fix ClassNotFoundException in

[GitHub] gianm commented on a change in pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask

gianm commented on a change in pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask URL: https://github.com/apache/incubator-druid/pull/6065#discussion_r205929239 ## File path:

[GitHub] gianm opened a new pull request #6067: FinalizingFieldAccessPostAggregator: Fix serde.

gianm opened a new pull request #6067: FinalizingFieldAccessPostAggregator: Fix serde. URL: https://github.com/apache/incubator-druid/pull/6067 Fixes #6063. This is an automated message from the Apache Git Service. To

[GitHub] b-slim closed pull request #4776: Fix ClassNotFoundException in druid-kerberos extension

b-slim closed pull request #4776: Fix ClassNotFoundException in druid-kerberos extension URL: https://github.com/apache/incubator-druid/pull/4776 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] jon-wei opened a new pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask

jon-wei opened a new pull request #6065: Fix CombiningFirehoseFactory with IngestSegmentFirehoseFactory in IndexTask URL: https://github.com/apache/incubator-druid/pull/6065 If I define a CombiningFirehose with a IngestSegmentFirehose delegate in an IndexTask: ``` "firehose" : {

[GitHub] gianm commented on issue #6063: FinalizingFieldAccessPostAggregator cannot be deserialized once it gets decorated

gianm commented on issue #6063: FinalizingFieldAccessPostAggregator cannot be deserialized once it gets decorated URL: https://github.com/apache/incubator-druid/issues/6063#issuecomment-408575833 FinalizingFieldAccessPostAggregator is documented, so I think we should fix it. I'll do a

[GitHub] leventov opened a new pull request #6062: Fix a bug in GroupByQueryEngine

leventov opened a new pull request #6062: Fix a bug in GroupByQueryEngine URL: https://github.com/apache/incubator-druid/pull/6062 It was potentially missing many unaggregated buffers. This is an automated message from the

[GitHub] leventov commented on issue #6027: Make Parser.parseToMap() to return a mutable Map

leventov commented on issue #6027: Make Parser.parseToMap() to return a mutable Map URL: https://github.com/apache/incubator-druid/pull/6027#issuecomment-408565906 If Spark updates Kryo (BTW I cannot even find on what version it depends), and Spark cluster users update Spark, this change

[GitHub] jihoonson commented on issue #5566: Applying doubleSum over doubleFirst aggregations in nested groupBy fails

jihoonson commented on issue #5566: Applying doubleSum over doubleFirst aggregations in nested groupBy fails URL: https://github.com/apache/incubator-druid/issues/5566#issuecomment-408567669 Hi all, `DoubleFirstAggregator` returns `SerializedPair`s which is the intermediate

[GitHub] leventov opened a new issue #6064: Duplicate DataSegmentTest

leventov opened a new issue #6064: Duplicate DataSegmentTest URL: https://github.com/apache/incubator-druid/issues/6064 Seems that `io.druid.timeline.DataSegmentTest` is duplicated in druid-api and druid-server modules. This

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r205681438 ## File path:

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r205684184 ## File path:

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r205683689 ## File path:

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r205683872 ## File path:

[GitHub] nishantmonu51 opened a new issue #6053: Add config to replace nulls with default value at ingestion time instead of relying on system wide config

nishantmonu51 opened a new issue #6053: Add config to replace nulls with default value at ingestion time instead of relying on system wide config URL: https://github.com/apache/incubator-druid/issues/6053 Review comment from Gian - Add configs for to enable following behavior -

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205739736 ## File path:

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205739656 ## File path: processing/src/main/java/io/druid/query/extraction/StrlenExtractionFn.java

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205739705 ## File path: processing/src/main/java/io/druid/query/filter/SelectorDimFilter.java

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205739756 ## File path: processing/src/main/java/io/druid/segment/filter/LikeFilter.java ##

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205739451 ## File path:

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205739490 ## File path:

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205739367 ## File path:

[GitHub] nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205739396 ## File path:

[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-408389965 @jihoonson : For the pending work, I have labelled the issues with Area : Null Handling

[GitHub] nishantmonu51 edited a comment on issue #5958: Part 2 of changes for SQL Compatible Null Handling

nishantmonu51 edited a comment on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-408389965 @jihoonson : For the pending work, I have labelled the issues with Area : Null Handling

[GitHub] andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

andresgomezfrr commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r205747961 ## File path:

[GitHub] jihoonson commented on issue #6013: Fix transient test failures

jihoonson commented on issue #6013: Fix transient test failures URL: https://github.com/apache/incubator-druid/issues/6013#issuecomment-408488846 https://travis-ci.org/apache/incubator-druid/jobs/408919411 ``` Tests run: 24, Failures: 0, Errors: 1, Skipped: 0, Time elapsed:

[GitHub] jihoonson closed pull request #6050: Fix IllegalArgumentException in TaskLockBox.syncFromStorage() on rolling update

jihoonson closed pull request #6050: Fix IllegalArgumentException in TaskLockBox.syncFromStorage() on rolling update URL: https://github.com/apache/incubator-druid/pull/6050 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] jihoonson commented on a change in pull request #6052: Update development/build.md with detailed build & test directions

jihoonson commented on a change in pull request #6052: Update development/build.md with detailed build & test directions URL: https://github.com/apache/incubator-druid/pull/6052#discussion_r205864672 ## File path: docs/content/development/build.md ## @@ -2,28 +2,70 @@

[GitHub] a2l007 opened a new issue #6057: Broker sends sequential requests to the historical for union queries

a2l007 opened a new issue #6057: Broker sends sequential requests to the historical for union queries URL: https://github.com/apache/incubator-druid/issues/6057 Analyzing groupBy queries based on Union datasources, we have seen that for a given query if a historical has segments for the

[incubator-druid] branch 0.12.2 updated: [Backport] Fix IllegalArgumentException in TaskLockBox.syncFromStorage() (#6050) (#6054)

This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a commit to branch 0.12.2 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/0.12.2 by this push: new f823e80 [Backport] Fix

[GitHub] jihoonson opened a new pull request #6056: [Backport] Synchronize scheduled poll() calls in SQLMetadataSegmentManager

jihoonson opened a new pull request #6056: [Backport] Synchronize scheduled poll() calls in SQLMetadataSegmentManager URL: https://github.com/apache/incubator-druid/pull/6056 Backport of #6041 to 0.12.2. This is an automated

[GitHub] jihoonson commented on issue #6036: use S3 as a backup storage for hdfs deep storage

jihoonson commented on issue #6036: use S3 as a backup storage for hdfs deep storage URL: https://github.com/apache/incubator-druid/pull/6036#issuecomment-408511472 Thanks @gianm. Now I can understand better what @gaodayue' use case is. I'm fine with this approach if we can make it as a

[GitHub] gianm closed pull request #6060: Add the correct createdTime to waiting tasks

gianm closed pull request #6060: Add the correct createdTime to waiting tasks URL: https://github.com/apache/incubator-druid/pull/6060 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-druid] branch master updated: Add the correct createdTime to waiting tasks (#6060)

This is an automated email from the ASF dual-hosted git repository. gian pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git The following commit(s) were added to refs/heads/master by this push: new 74ae73d Add the correct createdTime to

[GitHub] jihoonson commented on issue #5699: Convert pair returned by first/last aggregators to number (#5566)

jihoonson commented on issue #5699: Convert pair returned by first/last aggregators to number (#5566) URL: https://github.com/apache/incubator-druid/pull/5699#issuecomment-408550366 @kskalski sorry for the delayed review. I'm closing and reopening this PR to trigger Travis build. The link

[GitHub] jihoonson closed pull request #5699: Convert pair returned by first/last aggregators to number (#5566)

jihoonson closed pull request #5699: Convert pair returned by first/last aggregators to number (#5566) URL: https://github.com/apache/incubator-druid/pull/5699 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] kskalski opened a new pull request #5699: Convert pair returned by first/last aggregators to number (#5566)

kskalski opened a new pull request #5699: Convert pair returned by first/last aggregators to number (#5566) URL: https://github.com/apache/incubator-druid/pull/5699 This is an automated message from the Apache Git Service.

[GitHub] jihoonson commented on issue #6027: Make Parser.parseToMap() to return a mutable Map

jihoonson commented on issue #6027: Make Parser.parseToMap() to return a mutable Map URL: https://github.com/apache/incubator-druid/pull/6027#issuecomment-408553979 @leventov I don't understand why kryo uses the map returned from `ObjectFlatteners`. Are you using something like

[GitHub] leventov commented on issue #6027: Make Parser.parseToMap() to return a mutable Map

leventov commented on issue #6027: Make Parser.parseToMap() to return a mutable Map URL: https://github.com/apache/incubator-druid/pull/6027#issuecomment-408556427 It looks like a bug in Kryo. At least in newer Kryo versions, the code of MapSerializer is completely different from what I

[GitHub] jihoonson commented on issue #6027: Make Parser.parseToMap() to return a mutable Map

jihoonson commented on issue #6027: Make Parser.parseToMap() to return a mutable Map URL: https://github.com/apache/incubator-druid/pull/6027#issuecomment-408558963 Does it mean that this error won't happen if spark updates its kryo version? And do we need this PR even in that case?

[GitHub] jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205896989 ## File path: processing/src/main/java/io/druid/query/aggregation/NullableBufferAggregator.java

[GitHub] jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205897566 ## File path:

[GitHub] gianm commented on issue #6061: skip travis on doc only changes

gianm commented on issue #6061: skip travis on doc only changes URL: https://github.com/apache/incubator-druid/pull/6061#issuecomment-408537729 I think `examples` includes code (and we ship it in the distro) so that should still have Travis run on it.

[GitHub] jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension

jihoonson commented on a change in pull request #5789: Add stringLast and stringFirst aggregators extension URL: https://github.com/apache/incubator-druid/pull/5789#discussion_r205900679 ## File path:

[GitHub] clintropolis commented on issue #6061: skip travis on doc only changes

clintropolis commented on issue #6061: skip travis on doc only changes URL: https://github.com/apache/incubator-druid/pull/6061#issuecomment-408542314 Ah so it, does. I suppose I could ignore some of it's subfolders, maybe `examples/bin` `examples/conf` `examples/conf-quickstart`

[GitHub] clintropolis edited a comment on issue #6061: skip travis on doc only changes

clintropolis edited a comment on issue #6061: skip travis on doc only changes URL: https://github.com/apache/incubator-druid/pull/6061#issuecomment-408542314 Ah so it, does. I suppose I could ignore some of it's subfolders, maybe `examples/bin` `examples/conf` `examples/conf-quickstart`

[GitHub] clintropolis edited a comment on issue #6061: skip travis on doc only changes

clintropolis edited a comment on issue #6061: skip travis on doc only changes URL: https://github.com/apache/incubator-druid/pull/6061#issuecomment-408542314 Ah so it, does. I suppose I could ignore some of it's subfolders, maybe `examples/bin, examples/conf, examples/conf-quickstart,

[GitHub] jihoonson commented on issue #6058: Remove some unnecessary task storage internal APIs.

jihoonson commented on issue #6058: Remove some unnecessary task storage internal APIs. URL: https://github.com/apache/incubator-druid/pull/6058#issuecomment-408543471 Please check this: ``` [ERROR]

[GitHub] jihoonson commented on issue #6059: CompactionTask: Reject empty intervals on construction.

jihoonson commented on issue #6059: CompactionTask: Reject empty intervals on construction. URL: https://github.com/apache/incubator-druid/pull/6059#issuecomment-408543351 Please check the Travis failure. ``` [ERROR] Forbidden method invocation:

[GitHub] jihoonson commented on issue #6045: Fix 'auto' encoded longs + compression serializer

jihoonson commented on issue #6045: Fix 'auto' encoded longs + compression serializer URL: https://github.com/apache/incubator-druid/pull/6045#issuecomment-408543647 @clintropolis I'm fine with it. This is an automated

[GitHub] jihoonson closed pull request #5734: Multiple dimension partitioning spec

jihoonson closed pull request #5734: Multiple dimension partitioning spec URL: https://github.com/apache/incubator-druid/pull/5734 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] niketh opened a new pull request #5734: Multiple dimension partitioning spec

niketh opened a new pull request #5734: Multiple dimension partitioning spec URL: https://github.com/apache/incubator-druid/pull/5734 @gianm @b-slim Currently Druid supports only single dimension partitioning. This PR extends that and allows for multiple dimension partitioning. A

[GitHub] gianm opened a new pull request #6059: CompactionTask: Reject empty intervals on construction.

gianm opened a new pull request #6059: CompactionTask: Reject empty intervals on construction. URL: https://github.com/apache/incubator-druid/pull/6059 They don't make sense anyway, and it's better to fail fast. This is an

[GitHub] gianm commented on issue #6058: Remove some unnecessary task storage internal APIs.

gianm commented on issue #6058: Remove some unnecessary task storage internal APIs. URL: https://github.com/apache/incubator-druid/pull/6058#issuecomment-408531016 The error looks like the travis cache got corrupted? I cleared it and tried the job again. ```[INFO] Changes detected

[GitHub] jihoonson commented on issue #6013: Fix transient test failures

jihoonson commented on issue #6013: Fix transient test failures URL: https://github.com/apache/incubator-druid/issues/6013#issuecomment-408531646 ``` Tests run: 5, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.046 sec <<< FAILURE! - in

[GitHub] jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205894027 ## File path: processing/src/main/java/io/druid/query/aggregation/NullableAggregator.java

[GitHub] jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205893700 ## File path: processing/src/main/java/io/druid/query/aggregation/AggregatorUtil.java

[GitHub] surekhasaharan opened a new pull request #6060: Add the correct createdTime to waiting tasks

surekhasaharan opened a new pull request #6060: Add the correct createdTime to waiting tasks URL: https://github.com/apache/incubator-druid/pull/6060 Fix the creationTime for the tasks in `waiting` state. TaskInfo object has the `createdTime` field , that should be used to create AnyTask,

[GitHub] clintropolis commented on issue #6045: Fix 'auto' encoded longs + compression serializer

clintropolis commented on issue #6045: Fix 'auto' encoded longs + compression serializer URL: https://github.com/apache/incubator-druid/pull/6045#issuecomment-408527671 @jihoonson I considered that but it seemed more invasive of a change and I'm trying to deprecate this code path anyway..

[GitHub] jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

jihoonson commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r205893788 ## File path: