[GitHub] clintropolis edited a comment on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
clintropolis edited a comment on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410153475 I ran some additional benchmarks after realizing that the generated rows from previous benchmarks were rows with no opportun

[GitHub] clintropolis edited a comment on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
clintropolis edited a comment on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410153475 I ran some additional benchmarks after realizing that the generated rows from previous benchmarks were rows with no opportun

[GitHub] clintropolis commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
clintropolis commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410153475 I ran some additional benchmarks after realizing that the generated rows from previous benchmarks were rows with no opportunity for

[GitHub] jacktomcat opened a new issue #6099: Inconsistencies in the result of the quantile aggregator

2018-08-02 Thread GitBox
jacktomcat opened a new issue #6099: Inconsistencies in the result of the quantile aggregator URL: https://github.com/apache/incubator-druid/issues/6099 I use the quantile aggregator, but many times the query results are inconsistent. The version of Druid is 0.12.1 Here's my script

[GitHub] jihoonson commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
jihoonson commented on issue #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#issuecomment-410140748 @chengchengpei sorry for the fragile unit tests. I'll restart the failed ones if exist. --

[GitHub] chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 https://github.com/apache/incubator-druid/issues/6071 The changes validate that baseDataSource is not a empty

[GitHub] jacktomcat closed issue #6098: Inconsistencies in the result of the quantile aggregator

2018-08-02 Thread GitBox
jacktomcat closed issue #6098: Inconsistencies in the result of the quantile aggregator URL: https://github.com/apache/incubator-druid/issues/6098 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 https://github.com/apache/incubator-druid/issues/6071 The changes validate that baseDataSource is not a empty

[GitHub] chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 https://github.com/apache/incubator-druid/issues/6071 The changes validate that baseDataSource is not a empty

[GitHub] jacktomcat opened a new issue #6098: Inconsistencies in the result of the quantile aggregator

2018-08-02 Thread GitBox
jacktomcat opened a new issue #6098: Inconsistencies in the result of the quantile aggregator URL: https://github.com/apache/incubator-druid/issues/6098 I use the quantile aggregator, but many times the query results are inconsistent. Here's my script { "queryType": "gro

[GitHub] asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-02 Thread GitBox
asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410121501 @jihoonson Okay, I keep those changes, and patch them to get the job

[GitHub] jihoonson commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-02 Thread GitBox
jihoonson commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410120923 @asdf2014 yes, they are definitely useful. If you want, I think it's

[GitHub] asdf2014 edited a comment on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-02 Thread GitBox
asdf2014 edited a comment on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410119637 Hi, @jihoonson . Yep, that's right. :+1: Perhaps something in

[GitHub] asdf2014 edited a comment on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-02 Thread GitBox
asdf2014 edited a comment on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410119637 Hi, @jihoonson . Yep, that's right. :+1: Perhaps something in

[GitHub] asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-02 Thread GitBox
asdf2014 commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410119637 Hi, @jihoonson . Yep, that's right. :+1: Perhaps something in this PR

[GitHub] chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 https://github.com/apache/incubator-druid/issues/6071 The changes validate that baseDataSource is not a empty

[GitHub] chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei opened a new pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 https://github.com/apache/incubator-druid/issues/6071 The changes validate that baseDataSource is not a empty

[GitHub] chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei closed pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] chengchengpei commented on a change in pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
chengchengpei commented on a change in pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#discussion_r207408616 ## File path: extensions-contrib/materialized-view-maintenance/src/main/j

[GitHub] jon-wei commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
jon-wei commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410102421 @hpandeycodeit For that error, you'd want to adjust `-XX:MaxDirectMemorySize=4096m` in the `jvm.config` file for the corr

[GitHub] hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410098043 @jihoonson, I am getting "Not Enough direct memory" error: ``` 1) Not enough direct memory. Ple

[GitHub] jihoonson commented on a change in pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad…

2018-08-02 Thread GitBox
jihoonson commented on a change in pull request #6072: validate baseDataSource non-empty string in DerivativeDataSourceMetad… URL: https://github.com/apache/incubator-druid/pull/6072#discussion_r207387259 ## File path: extensions-contrib/materialized-view-maintenance/src/main/java/

[GitHub] gianm commented on issue #6017: Logging of invalid queries

2018-08-02 Thread GitBox
gianm commented on issue #6017: Logging of invalid queries URL: https://github.com/apache/incubator-druid/issues/6017#issuecomment-410080968 Sounds like a good idea -- the main challenge is probably that right now, the request logger expects to get a valid Query object, but we could add a

[GitHub] jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410080616 @jon-wei that sounds nice! This is an automated messag

[GitHub] jon-wei commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
jon-wei commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410080147 > I think it's more important to replace those long java commands with our simple scripts. For example, we have a script,

[GitHub] jihoonson commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-08-02 Thread GitBox
jihoonson commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-410079446 @gianm thanks for the clarifying the requirements. FYI, I'm very ambitious about this! -

[GitHub] jihoonson commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory`

2018-08-02 Thread GitBox
jihoonson commented on issue #6090: Fix missing exception handling as part of `io.druid.java.util.http.client.netty.HttpClientPipelineFactory` URL: https://github.com/apache/incubator-druid/pull/6090#issuecomment-410076531 Hi @asdf2014, I've looked into this more and found something.

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r207381285 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@ -0,

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r207380790 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@ -0,

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r207380680 ## File path: processing/src/main/java/io/druid/segment/CompressedPools.java ## @@ -77,41 +102,245 @@ publ

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r207370256 ## File path: processing/src/main/java/io/druid/segment/data/ShapeShiftingColumnSerializer.java ## @@ -0,

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r207370004 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/IntFormMetrics.java ## @@ -0,0 +

[GitHub] gianm commented on issue #6076: Mutual TLS support

2018-08-02 Thread GitBox
gianm commented on issue #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#issuecomment-410063706 @jon-wei, thanks, I think it is really valuable especially as we add more features to the feature. (I heard you like features so we put features in your

[GitHub] gianm commented on issue #6097: Possible performance issue during DruidSchema metadata refresh

2018-08-02 Thread GitBox
gianm commented on issue #6097: Possible performance issue during DruidSchema metadata refresh URL: https://github.com/apache/incubator-druid/issues/6097#issuecomment-410063021 Hi @egor-ryashin, There have been some improvements to the refreshing mechanism in later versions (try 0.

[GitHub] egor-ryashin opened a new issue #6097: Possible performance issue during DruidSchema metadata refresh

2018-08-02 Thread GitBox
egor-ryashin opened a new issue #6097: Possible performance issue during DruidSchema metadata refresh URL: https://github.com/apache/incubator-druid/issues/6097 `Druid Broker 0.11.0` with `druid.sql.enable=true` produces much more garbage than usual, profiling shows a lot of `Object[]` whi

[GitHub] gianm commented on issue #5108: Cache: Add maxEntrySize config, make groupBy cacheable by default.

2018-08-02 Thread GitBox
gianm commented on issue #5108: Cache: Add maxEntrySize config, make groupBy cacheable by default. URL: https://github.com/apache/incubator-druid/pull/5108#issuecomment-410062074 Oops, missed those. I pushed with new license headers.

[GitHub] jihoonson commented on issue #5108: Cache: Add maxEntrySize config, make groupBy cacheable by default.

2018-08-02 Thread GitBox
jihoonson commented on issue #5108: Cache: Add maxEntrySize config, make groupBy cacheable by default. URL: https://github.com/apache/incubator-druid/pull/5108#issuecomment-410061268 @gianm please fix the licenses. ``` [ERROR] /home/travis/build/apache/incubator-druid/server/src/

[GitHub] gianm commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
gianm commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410053931 > @gianm Cool, I'll go ahead and make a PR as soon as I get some tests finished up. I'm not certain the cause of slower group-by performanc

[GitHub] clintropolis commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
clintropolis commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410053497 @gianm Cool, I'll go ahead and make a PR as soon as I get some tests finished up. I'm not certain the cause of slower group-by perfo

[GitHub] gianm commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
gianm commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410052884 > I'm guessing Druid does the rollup by sorting the dimensions in the order in the ingestion spec, which would indicate that dimension orde

[GitHub] jihoonson closed issue #5934: eccn

2018-08-02 Thread GitBox
jihoonson closed issue #5934: eccn URL: https://github.com/apache/incubator-druid/issues/5934 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to

[GitHub] jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410051112 It should work. Would you please check your broker logs? --

[GitHub] gianm commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-08-02 Thread GitBox
gianm commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-410045743 Yeah -- StringInputRowParser is a bit of a special snowflake. Maybe doing this feature is the motivation we need to rethink how th

[GitHub] mistercrunch commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
mistercrunch commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410043357 I'm guessing Druid does the rollup by sorting the dimensions in the order in the ingestion spec, which would indicate that dimension

[GitHub] gianm commented on issue #6066: Sorting rows when rollup is disabled

2018-08-02 Thread GitBox
gianm commented on issue #6066: Sorting rows when rollup is disabled URL: https://github.com/apache/incubator-druid/issues/6066#issuecomment-410039394 IMO the speed hit on ingestion is acceptable. It is small, and performance is not really worse than the rollup case. Adding sorting will in

[GitHub] vogievetsky commented on issue #1204: Define granularities in UTC

2018-08-02 Thread GitBox
vogievetsky commented on issue #1204: Define granularities in UTC URL: https://github.com/apache/incubator-druid/issues/1204#issuecomment-410039263 Is this still an issue after https://github.com/apache/incubator-druid/pull/4611 ? --

[GitHub] vogievetsky commented on issue #6094: Introduce SystemSchema tables (#5989)

2018-08-02 Thread GitBox
vogievetsky commented on issue #6094: Introduce SystemSchema tables (#5989) URL: https://github.com/apache/incubator-druid/pull/6094#issuecomment-410038602 so excited about this one! This is an automated message from the Apach

[GitHub] hpandeycodeit edited a comment on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
hpandeycodeit edited a comment on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410037251 @jihoonson , The scripts are there but doesn't look like it's working: For eg: $./broker.s

[GitHub] hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410037251 @jihoonson , The scripts are there but doesn't look like it's working: For eg: $./broker.sh start

[GitHub] pdeva closed issue #1816: Druid 0.8.1 coordinator throws a bunch of exceptions at startup

2018-08-02 Thread GitBox
pdeva closed issue #1816: Druid 0.8.1 coordinator throws a bunch of exceptions at startup URL: https://github.com/apache/incubator-druid/issues/1816 This is an automated message from the Apache Git Service. To respond to the

[GitHub] pdeva closed issue #1598: upgrading from 0.6 to 0.7 will result in corruption of existing segment in realtime node

2018-08-02 Thread GitBox
pdeva closed issue #1598: upgrading from 0.6 to 0.7 will result in corruption of existing segment in realtime node URL: https://github.com/apache/incubator-druid/issues/1598 This is an automated message from the Apache Git

[GitHub] vogievetsky commented on issue #1449: Allow sorting by timestamp

2018-08-02 Thread GitBox
vogievetsky commented on issue #1449: Allow sorting by timestamp URL: https://github.com/apache/incubator-druid/issues/1449#issuecomment-410036629 This is now possible with GroupBy v2 (and in Druid SQL) @gianm please confirm and close. ---

[GitHub] vogievetsky commented on issue #1560: convertSpec tool completely broken

2018-08-02 Thread GitBox
vogievetsky commented on issue #1560: convertSpec tool completely broken URL: https://github.com/apache/incubator-druid/issues/1560#issuecomment-410036215 Is this still an issue? This is an automated message from the Apache G

[GitHub] vogievetsky commented on issue #1598: upgrading from 0.6 to 0.7 will result in corruption of existing segment in realtime node

2018-08-02 Thread GitBox
vogievetsky commented on issue #1598: upgrading from 0.6 to 0.7 will result in corruption of existing segment in realtime node URL: https://github.com/apache/incubator-druid/issues/1598#issuecomment-410035968 Can this be closed on a count of being super old? -

[GitHub] vogievetsky commented on issue #1671: Use isolated classloader for javascript related items

2018-08-02 Thread GitBox
vogievetsky commented on issue #1671: Use isolated classloader for javascript related items URL: https://github.com/apache/incubator-druid/issues/1671#issuecomment-410035821 I am glad that with the new expression system we are moving away form javascript (you did not hear me say this). Is

[GitHub] vogievetsky commented on issue #1684: [HttpPostEmitter] druid.emitter.http.recipientBaseUrl=http://domain:port causes invalid http header

2018-08-02 Thread GitBox
vogievetsky commented on issue #1684: [HttpPostEmitter] druid.emitter.http.recipientBaseUrl=http://domain:port causes invalid http header URL: https://github.com/apache/incubator-druid/issues/1684#issuecomment-410035486 Did @drcrallen 's PR fix this? -

[GitHub] vogievetsky commented on issue #1692: Why Deep storage No data?but realtime node can find 3413610 num data

2018-08-02 Thread GitBox
vogievetsky commented on issue #1692: Why Deep storage No data?but realtime node can find 3413610 num data URL: https://github.com/apache/incubator-druid/issues/1692#issuecomment-410035126 @zengzhihai110 can this issue be closed? ---

[GitHub] vogievetsky commented on issue #1711: null exception from filter with Query-Time Lookup

2018-08-02 Thread GitBox
vogievetsky commented on issue #1711: null exception from filter with Query-Time Lookup URL: https://github.com/apache/incubator-druid/issues/1711#issuecomment-410034795 Jonathan! Long time no see! I remember when this was filed... good times. @fjy I believe this was resolved (as noted

[GitHub] vogievetsky commented on issue #1746: Tasks that are waiting on locks are reporting as RUNNING

2018-08-02 Thread GitBox
vogievetsky commented on issue #1746: Tasks that are waiting on locks are reporting as RUNNING URL: https://github.com/apache/incubator-druid/issues/1746#issuecomment-410034139 @gianm I believe this has been greatly improved and is no longer and issue. I see pending tasks all the time now

[GitHub] vogievetsky commented on issue #1816: Druid 0.8.1 coordinator throws a bunch of exceptions at startup

2018-08-02 Thread GitBox
vogievetsky commented on issue #1816: Druid 0.8.1 coordinator throws a bunch of exceptions at startup URL: https://github.com/apache/incubator-druid/issues/1816#issuecomment-410033063 This issue is super pretty old and does not look actionable (Who even knows where to get Druid 0.8.1 thes

[GitHub] vogievetsky commented on issue #1827: JsonConfigurator does not escape quoted options

2018-08-02 Thread GitBox
vogievetsky commented on issue #1827: JsonConfigurator does not escape quoted options URL: https://github.com/apache/incubator-druid/issues/1827#issuecomment-410032588 Does https://github.com/apache/incubator-druid/pull/2033 address this? --

[GitHub] vogievetsky commented on issue #1835: Schema differences of GroupBy vs TopN/TimeSeries return data should be not be present

2018-08-02 Thread GitBox
vogievetsky commented on issue #1835: Schema differences of GroupBy vs TopN/TimeSeries return data should be not be present URL: https://github.com/apache/incubator-druid/issues/1835#issuecomment-410032064 I 👍ed this issue back in the day but since then groupBy v2 drastically improved the

[GitHub] vogievetsky commented on issue #1836: MapCache needs re-written

2018-08-02 Thread GitBox
vogievetsky commented on issue #1836: MapCache needs re-written URL: https://github.com/apache/incubator-druid/issues/1836#issuecomment-410031205 Did https://github.com/apache/incubator-druid/pull/3028 address this? This is a

[GitHub] vogievetsky commented on issue #6096: Windows Ubuntu Bash and Task Directory Name

2018-08-02 Thread GitBox
vogievetsky commented on issue #6096: Windows Ubuntu Bash and Task Directory Name URL: https://github.com/apache/incubator-druid/issues/6096#issuecomment-410030657 I think it is a good point about directory names and should be considered for the project @gianm does it make sense to avoid

[GitHub] josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-08-02 Thread GitBox
josephglanville edited a comment on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-410030450 One thing that has become apparent is the `StringInputRowParser` is a bit of a bad citizen. It extends `ByteB

[GitHub] josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser

2018-08-02 Thread GitBox
josephglanville commented on issue #5584: Decoupling FirehoseFactory and InputRowParser URL: https://github.com/apache/incubator-druid/issues/5584#issuecomment-410030450 One thing that has become apparent is the `StringInputRowParser` is a bit of a bad citizen. It extends `ByteBufferIn

[GitHub] jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
jihoonson commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410022159 @hpandeycodeit we have the scripts for all Druid components. Please check `${DRUID_HOME}/bin` directory. > And c

[GitHub] hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section

2018-08-02 Thread GitBox
hpandeycodeit commented on issue #6047: Minor change in the "Start up Druid services" Section URL: https://github.com/apache/incubator-druid/pull/6047#issuecomment-410013932 @jihoonson, Yes, I am interested in this. Do we have scripts ready for all these java commands or for just one?

[GitHub] nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling

2018-08-02 Thread GitBox
nishantmonu51 commented on issue #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#issuecomment-409936613 @leventov @jihoonson @b-slim Thanks for the review. This PR is ready for merge and has got required +1s. can one

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r207146469 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/LemireIntFormDecoder.java ## @@

[GitHub] rathish opened a new issue #6096: Windows Ubuntu Bash and Task Directory Name

2018-08-02 Thread GitBox
rathish opened a new issue #6096: Windows Ubuntu Bash and Task Directory Name URL: https://github.com/apache/incubator-druid/issues/6096 Hi Committers, I am trying to run Druid in Windows 10 enabled Ubuntu Bash environment, all the nodes are starting up fine and I am able to connect

[GitHub] clintropolis commented on issue #6016: Druid 'Shapeshifting' Columns

2018-08-02 Thread GitBox
clintropolis commented on issue #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#issuecomment-409850996 @leventov @himanshug I think I've got another viable, maybe even _better_, variant of this general idea that I can craft with relatively minor

[GitHub] terry19850829 commented on issue #6091: kafka indexing service javascript aggegation cause java.lang.IllegalArgumentException: fromIndex(0) > toIndex(-1

2018-08-02 Thread GitBox
terry19850829 commented on issue #6091: kafka indexing service javascript aggegation cause java.lang.IllegalArgumentException: fromIndex(0) > toIndex(-1 URL: https://github.com/apache/incubator-druid/issues/6091#issuecomment-409845208 When I remove the javascript aggr, the supervisor just

[GitHub] terry19850829 commented on issue #6091: kafka indexing service javascript aggegation cause java.lang.IllegalArgumentException: fromIndex(0) > toIndex(-1

2018-08-02 Thread GitBox
terry19850829 commented on issue #6091: kafka indexing service javascript aggegation cause java.lang.IllegalArgumentException: fromIndex(0) > toIndex(-1 URL: https://github.com/apache/incubator-druid/issues/6091#issuecomment-409844901 @a2l007 After add the `reportParseExceptions ` config,