[GitHub] asdf2014 commented on a change in pull request #6158: Make time-related variables more readable

2018-08-15 Thread GitBox
asdf2014 commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210461393 ## File path:

[GitHub] asdf2014 commented on a change in pull request #6158: Make time-related variables more readable

2018-08-15 Thread GitBox
asdf2014 commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210461408 ## File path: processing/src/test/java/io/druid/query/AsyncQueryRunnerTest.java ## @@ -38,7 +38,7

[GitHub] asdf2014 commented on issue #6158: Make time-related variables more readable

2018-08-15 Thread GitBox
asdf2014 commented on issue #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#issuecomment-413402400 Hi, @jihoonson . Thanks for your comments. I removed unnecessary boxing of Long type variables. Since some methods / constructors /

[GitHub] asdf2014 commented on a change in pull request #6158: Make time-related variables more readable

2018-08-15 Thread GitBox
asdf2014 commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210461367 ## File path:

[GitHub] asdf2014 commented on a change in pull request #6158: Make time-related variables more readable

2018-08-15 Thread GitBox
asdf2014 commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210461393 ## File path:

[GitHub] asdf2014 commented on a change in pull request #6158: Make time-related variables more readable

2018-08-15 Thread GitBox
asdf2014 commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210461408 ## File path: processing/src/test/java/io/druid/query/AsyncQueryRunnerTest.java ## @@ -38,7 +38,7

[GitHub] asdf2014 commented on a change in pull request #6158: Make time-related variables more readable

2018-08-15 Thread GitBox
asdf2014 commented on a change in pull request #6158: Make time-related variables more readable URL: https://github.com/apache/incubator-druid/pull/6158#discussion_r210461385 ## File path:

[GitHub] syedkhassan commented on issue #5473: Queries with UNION do not work in Druid SQL

2018-08-15 Thread GitBox
syedkhassan commented on issue #5473: Queries with UNION do not work in Druid SQL URL: https://github.com/apache/incubator-druid/issues/5473#issuecomment-413348392 Any update on union query using SQL ? This is an automated

[GitHub] rpless opened a new pull request #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options

2018-08-15 Thread GitBox
rpless opened a new pull request #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options URL: https://github.com/apache/incubator-druid/pull/6181 This PR exposes the SSL settings so a user can enable ssl if they are using postgres as their metadata storage. I also

[GitHub] jon-wei closed pull request #6080: Accept total rows over Integer.MAX_VALUE.

2018-08-15 Thread GitBox
jon-wei closed pull request #6080: Accept total rows over Integer.MAX_VALUE. URL: https://github.com/apache/incubator-druid/pull/6080 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] fjy closed pull request #6180: [Backport] Include hybrid and caffeine in cache docs and show caffeine as default

2018-08-15 Thread GitBox
fjy closed pull request #6180: [Backport] Include hybrid and caffeine in cache docs and show caffeine as default URL: https://github.com/apache/incubator-druid/pull/6180 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] fjy closed pull request #6155: Fix three bugs with segment publishing.

2018-08-15 Thread GitBox
fjy closed pull request #6155: Fix three bugs with segment publishing. URL: https://github.com/apache/incubator-druid/pull/6155 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] jon-wei opened a new pull request #6180: [Backport] Include hybrid and caffeine in cache docs and show caffeine as default

2018-08-15 Thread GitBox
jon-wei opened a new pull request #6180: [Backport] Include hybrid and caffeine in cache docs and show caffeine as default URL: https://github.com/apache/incubator-druid/pull/6180 Backport of #5737 to 0.12.3 docs. This is an

[GitHub] xy-xin commented on issue #401: Log management for long running indexing service tasks

2018-08-15 Thread GitBox
xy-xin commented on issue #401: Log management for long running indexing service tasks URL: https://github.com/apache/incubator-druid/issues/401#issuecomment-413117840 Any update on this? This is an automated message from

[GitHub] clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns

2018-08-15 Thread GitBox
clintropolis commented on a change in pull request #6016: Druid 'Shapeshifting' Columns URL: https://github.com/apache/incubator-druid/pull/6016#discussion_r210181585 ## File path: processing/src/main/java/io/druid/segment/data/codecs/ints/RunLengthBytePackedIntFormEncoder.java

[GitHub] samarthjain commented on issue #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies

2018-08-15 Thread GitBox
samarthjain commented on issue #6173: Composite request logger doesn't invoke @LifeCycleStart and @LifeCycleStop methods on its dependencies URL: https://github.com/apache/incubator-druid/pull/6173#issuecomment-413104150 Thanks for the reviews. I have updated the PR.