[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342951053 ## File path:

[GitHub] [incubator-druid] vogievetsky commented on issue #8805: Web console: fine grained capabilities / graceful degradation

2019-11-05 Thread GitBox
vogievetsky commented on issue #8805: Web console: fine grained capabilities / graceful degradation URL: https://github.com/apache/incubator-druid/pull/8805#issuecomment-550185623 One step closer to getting rid of the old consoles!

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342951053 ## File path:

[GitHub] [incubator-druid] vogievetsky merged pull request #8805: Web console: fine grained capabilities / graceful degradation

2019-11-05 Thread GitBox
vogievetsky merged pull request #8805: Web console: fine grained capabilities / graceful degradation URL: https://github.com/apache/incubator-druid/pull/8805 This is an automated message from the Apache Git Service. To

[incubator-druid] branch master updated (6f7fbeb -> 7addfc2)

2019-11-05 Thread vogievetsky
This is an automated email from the ASF dual-hosted git repository. vogievetsky pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 6f7fbeb Fix logo overflow (#8817) add 7addfc2 Web console: fine grained capabilities / graceful

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8805: Web console: fine grained capabilities / graceful degradation

2019-11-05 Thread GitBox
clintropolis commented on a change in pull request #8805: Web console: fine grained capabilities / graceful degradation URL: https://github.com/apache/incubator-druid/pull/8805#discussion_r342949872 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342947361 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/worker/WorkerTaskManager.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342940087 ## File path: core/src/main/java/org/apache/druid/java/util/common/concurrent/ListenableFutures.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342940115 ## File path: core/src/main/java/org/apache/druid/java/util/common/concurrent/ListenableFutures.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342945408 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342948998 ## File path: server/src/main/java/org/apache/druid/server/http/SegmentListerResource.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342948270 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342945993 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342939947 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342940649 ## File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8564: Fix ambiguity about IndexerSQLMetadataStorageCoordinator.getUsedSegmentsForInterval() returning only non-overshadowed o

2019-11-05 Thread GitBox
leventov commented on a change in pull request #8564: Fix ambiguity about IndexerSQLMetadataStorageCoordinator.getUsedSegmentsForInterval() returning only non-overshadowed or all used segments URL: https://github.com/apache/incubator-druid/pull/8564#discussion_r342938668 ## File

[GitHub] [incubator-druid] leventov commented on issue #8808: use copy-on-write list in InMemoryAppender

2019-11-05 Thread GitBox
leventov commented on issue #8808: use copy-on-write list in InMemoryAppender URL: https://github.com/apache/incubator-druid/pull/8808#issuecomment-550170383 @LoriLori `logEvents.toArray()` doesn't solve the race condition - it may still race with an addition to `logEvents` and throw some

[GitHub] [incubator-druid] fjy opened a new pull request #8829: Update README.md

2019-11-05 Thread GitBox
fjy opened a new pull request #8829: Update README.md URL: https://github.com/apache/incubator-druid/pull/8829 small edits to the druid readme Fixes #. ### Description Fixed the bug ... Renamed the class

[incubator-druid] branch fjy-patch-1 created (now 48683d7)

2019-11-05 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch fjy-patch-1 in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. at 48683d7 Update README.md No new revisions were added by this update.

[GitHub] [incubator-druid] leventov closed issue #8824: teamcity build is failing with node module related issue

2019-11-05 Thread GitBox
leventov closed issue #8824: teamcity build is failing with node module related issue URL: https://github.com/apache/incubator-druid/issues/8824 This is an automated message from the Apache Git Service. To respond to the

[incubator-druid] branch master updated (c2889ca -> 6f7fbeb)

2019-11-05 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from c2889ca show hollow circle when unavailable (#8819) add 6f7fbeb Fix logo overflow (#8817) No new

[GitHub] [incubator-druid] fjy merged pull request #8817: Web console: Fix logo overflow

2019-11-05 Thread GitBox
fjy merged pull request #8817: Web console: Fix logo overflow URL: https://github.com/apache/incubator-druid/pull/8817 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-druid] fjy merged pull request #8819: Web console: show hollow circle when unavailable

2019-11-05 Thread GitBox
fjy merged pull request #8819: Web console: show hollow circle when unavailable URL: https://github.com/apache/incubator-druid/pull/8819 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated (3b602da -> c2889ca)

2019-11-05 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 3b602da Bump Apache Thrift to 0.10.0 (#8419) add c2889ca show hollow circle when unavailable (#8819)

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8814: SQL: Add RAND() function.

2019-11-05 Thread GitBox
lgtm-com[bot] commented on issue #8814: SQL: Add RAND() function. URL: https://github.com/apache/incubator-druid/pull/8814#issuecomment-550140092 This pull request **introduces 2 alerts** when merging 97a07809fe6fa92d566ef0ae4161a16d35a76e5a into 3b602da8f7b0ff78071404b0cf6ca8a9831dd985 -

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8777: Web console: Interval input component

2019-11-05 Thread GitBox
vogievetsky commented on a change in pull request #8777: Web console: Interval input component URL: https://github.com/apache/incubator-druid/pull/8777#discussion_r342884494 ## File path: web-console/src/views/query-view/query-output/query-output.scss ## @@ -22,6 +22,7 @@

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8777: Web console: Interval input component

2019-11-05 Thread GitBox
vogievetsky commented on a change in pull request #8777: Web console: Interval input component URL: https://github.com/apache/incubator-druid/pull/8777#discussion_r342883478 ## File path: web-console/src/components/interval-input/interval-input.tsx ## @@ -0,0 +1,114 @@

[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8777: Web console: Interval input component

2019-11-05 Thread GitBox
vogievetsky commented on a change in pull request #8777: Web console: Interval input component URL: https://github.com/apache/incubator-druid/pull/8777#discussion_r342883764 ## File path: web-console/src/components/interval-input/interval-input.tsx ## @@ -0,0 +1,114 @@

[GitHub] [incubator-druid] zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback)

2019-11-05 Thread GitBox
zhenxiao commented on issue #8809: Prohibit Futures.addCallback(Future, Callback) URL: https://github.com/apache/incubator-druid/pull/8809#issuecomment-550104154 thank you, @leventov comments addressed did a force push, put this work on top of

[GitHub] [incubator-druid] fjy commented on issue #8823: Add InputSource and InputFormat interfaces

2019-11-05 Thread GitBox
fjy commented on issue #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#issuecomment-550100991 One of the most exciting PRs on Druid ingestion in awhile. Glad we got it out.

[GitHub] [incubator-druid] vogievetsky opened a new pull request #8828: Web console: support new ingest spec format

2019-11-05 Thread GitBox
vogievetsky opened a new pull request #8828: Web console: support new ingest spec format URL: https://github.com/apache/incubator-druid/pull/8828 Makes the data loader work with the newer spec format defined by https://github.com/apache/incubator-druid/pull/8823

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8823: Add InputSource and InputFormat interfaces

2019-11-05 Thread GitBox
lgtm-com[bot] commented on issue #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#issuecomment-550098205 This pull request **fixes 1 alert** when merging d45158271d33b5795c56657e5f13f1553bcf1147 into

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8810: Make submit task API similar to supervisor API

2019-11-05 Thread GitBox
lgtm-com[bot] commented on issue #8810: Make submit task API similar to supervisor API URL: https://github.com/apache/incubator-druid/pull/8810#issuecomment-550098178 This pull request **introduces 3 alerts** when merging c34c5cf8ed430b6dc3442c202287bb96e1f4cd3d into

[GitHub] [incubator-druid] stale[bot] commented on issue #6952: ServerSelector should always return the best segment

2019-11-05 Thread GitBox
stale[bot] commented on issue #6952: ServerSelector should always return the best segment URL: https://github.com/apache/incubator-druid/issues/6952#issuecomment-550076239 This issue has been marked as stale due to 280 days of inactivity. It will be closed in 4 weeks if no further

[GitHub] [incubator-druid] jihoonson commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
jihoonson commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550073283 The LGTM is failing with the same error even after I restarted once. Since TeamCity looks fine, I think it's an issue with LGTM (maybe it's

[GitHub] [incubator-druid] jihoonson merged pull request #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
jihoonson merged pull request #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-druid] branch master updated (511fa74 -> 3b602da)

2019-11-05 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 511fa74 Move maxFetchRetry to FetchConfig; rename OpenObject (#8776) add 3b602da Bump Apache

[GitHub] [incubator-druid] scottbelden opened a new issue #8827: Failure to ingest local file when running through the tutorial with the docker cluster

2019-11-05 Thread GitBox
scottbelden opened a new issue #8827: Failure to ingest local file when running through the tutorial with the docker cluster URL: https://github.com/apache/incubator-druid/issues/8827 ### Affected Version 0.16.0-incubating ### Description I am using the docker-compose

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8564: Fix ambiguity about IndexerSQLMetadataStorageCoordinator.getUsedSegmentsForInterval() returning only non-overshadowed

2019-11-05 Thread GitBox
jihoonson commented on a change in pull request #8564: Fix ambiguity about IndexerSQLMetadataStorageCoordinator.getUsedSegmentsForInterval() returning only non-overshadowed or all used segments URL: https://github.com/apache/incubator-druid/pull/8564#discussion_r342834195 ## File

[GitHub] [incubator-druid] clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-550030106 >For example, if we're doing a longSum operation on a column, what would the cost per

[GitHub] [incubator-druid] lemire commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
lemire commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-550029911 The plots are great indeed. Bravo!

[GitHub] [incubator-druid] clintropolis commented on issue #8824: teamcity build is failing with node module related issue

2019-11-05 Thread GitBox
clintropolis commented on issue #8824: teamcity build is failing with node module related issue URL: https://github.com/apache/incubator-druid/issues/8824#issuecomment-550029229 [Looking closer at that build

[GitHub] [incubator-druid] jnaous commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
jnaous commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-550029100 Sorry my question wasn't clear. I meant in terms of the cost of the full operation on a

[GitHub] [incubator-druid] jnaous commented on a change in pull request #8825: Add note on JDBC libs for lookups

2019-11-05 Thread GitBox
jnaous commented on a change in pull request #8825: Add note on JDBC libs for lookups URL: https://github.com/apache/incubator-druid/pull/8825#discussion_r342804983 ## File path: docs/development/extensions-core/lookups-cached-global.md ## @@ -368,6 +368,12 @@ The JDBC

[GitHub] [incubator-druid] jnaous commented on a change in pull request #8825: Add note on JDBC libs for lookups

2019-11-05 Thread GitBox
jnaous commented on a change in pull request #8825: Add note on JDBC libs for lookups URL: https://github.com/apache/incubator-druid/pull/8825#discussion_r342804962 ## File path: docs/development/extensions-core/lookups-cached-global.md ## @@ -368,6 +368,12 @@ The JDBC

[GitHub] [incubator-druid] clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550024263 >though maybe it should be since there is a NOTICE file, https://github.com/apache/thrift/blob/master/NOTICE. Responding to myself, but

[GitHub] [incubator-druid] Fokko commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
Fokko commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550022104 Thanks, updating scrooge should fix the dependency on the ancient version of libthrift indeed. Jenkins is running on my fork as well:

[GitHub] [incubator-druid] clintropolis edited a comment on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
clintropolis edited a comment on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550019038 >This PR will make Travis failed because it's not updating licences.yaml. It actually might not, the old version doesn't appear

[GitHub] [incubator-druid] clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550019038 >This PR will make Travis failed because it's not updating licences.yaml. It actually might not, the old version doesn't appear to be in

[GitHub] [incubator-druid] clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
clintropolis commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550018795 >Why is this a development blocker? The old version of `scrooge-maven-plugin` uses a super old forked version of libthrift for some

[GitHub] [incubator-druid] Fokko edited a comment on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
Fokko edited a comment on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550016704 `scrooge-maven-plugin` is already using Thrift 0.10.0. The old version `4.11.0` of `scrooge-maven-plugin` is indeed using `libthrift-0.5.0-1

[GitHub] [incubator-druid] Fokko edited a comment on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
Fokko edited a comment on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550016704 `scrooge-maven-plugin` is already using Thrift 0.10.0. I've rebased onto master. Why is this a development blocker?

[GitHub] [incubator-druid] jihoonson commented on issue #8419: Bump Apache Thrift to 0.10.0

2019-11-05 Thread GitBox
jihoonson commented on issue #8419: Bump Apache Thrift to 0.10.0 URL: https://github.com/apache/incubator-druid/pull/8419#issuecomment-550010108 +1 after CI. LGTM and Teamcity are failing because of the missing libthrift-0.5.0-1 jar. I think we can solve this by simply updating the

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions

2019-11-05 Thread GitBox
SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r342776259 ## File path:

[GitHub] [incubator-druid] LoriLori commented on issue #8808: use copy-on-write list in InMemoryAppender

2019-11-05 Thread GitBox
LoriLori commented on issue #8808: use copy-on-write list in InMemoryAppender URL: https://github.com/apache/incubator-druid/pull/8808#issuecomment-550001537 I am learning from better developers and was thinking about contract of logger and how would it could be solved should it be

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions

2019-11-05 Thread GitBox
SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r342773057 ## File path:

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions

2019-11-05 Thread GitBox
SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r342776259 ## File path:

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions

2019-11-05 Thread GitBox
SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r342776259 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8825: Add note on JDBC libs for lookups

2019-11-05 Thread GitBox
ccaominh commented on a change in pull request #8825: Add note on JDBC libs for lookups URL: https://github.com/apache/incubator-druid/pull/8825#discussion_r342775228 ## File path: docs/development/extensions-core/lookups-cached-global.md ## @@ -368,6 +368,12 @@ The JDBC

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8825: Add note on JDBC libs for lookups

2019-11-05 Thread GitBox
ccaominh commented on a change in pull request #8825: Add note on JDBC libs for lookups URL: https://github.com/apache/incubator-druid/pull/8825#discussion_r342773224 ## File path: docs/development/extensions-core/lookups-cached-global.md ## @@ -368,6 +368,12 @@ The JDBC

[GitHub] [incubator-druid] himanshug edited a comment on issue #8578: parallel broker merges on fork join pool

2019-11-05 Thread GitBox
himanshug edited a comment on issue #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#issuecomment-549904438 @clintropolis thanks for all the benchmarks, I haven't had the opportunity to look at the new developments yet but get back

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions

2019-11-05 Thread GitBox
SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r342773057 ## File path:

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions

2019-11-05 Thread GitBox
SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r342773057 ## File path:

[GitHub] [incubator-druid] SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions

2019-11-05 Thread GitBox
SEKIRO-J commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r342773057 ## File path:

[GitHub] [incubator-druid] clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-549997171 >It looks like the operation in question (VectorSelectorUtils.populateNullVector) is

[GitHub] [incubator-druid] clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-549995118 >I'm curious what percentage of the entire cost for processing a row a null check

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions

2019-11-05 Thread GitBox
ccaominh commented on a change in pull request #8748: Use earliest offset on kafka newly discovered partitions URL: https://github.com/apache/incubator-druid/pull/8748#discussion_r342768107 ## File path:

[GitHub] [incubator-druid] richardstartin edited a comment on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
richardstartin edited a comment on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-549985610 Cool heatmaps! Iteration should definitely perform better than calls to

[GitHub] [incubator-druid] capistrant opened a new issue #8826: druid-basic-security - allow LDAP groupMapping updates

2019-11-05 Thread GitBox
capistrant opened a new issue #8826: druid-basic-security - allow LDAP groupMapping updates URL: https://github.com/apache/incubator-druid/issues/8826 ### Description An LDAP group mapping in druid-basic-security can only be created or deleted in its current implementation. This

[GitHub] [incubator-druid] richardstartin commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
richardstartin commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-549985610 Cool heatmaps! Iteration should definitely perform better than calls to `contains`

[GitHub] [incubator-druid] jnaous opened a new pull request #8825: Add note on JDBC libs for lookups

2019-11-05 Thread GitBox
jnaous opened a new pull request #8825: Add note on JDBC libs for lookups URL: https://github.com/apache/incubator-druid/pull/8825 Add documentation on needed lib files to make JDBC lookups work. This is an automated

[GitHub] [incubator-druid] himanshug opened a new issue #8824: teamcity build is failing with node module related issue

2019-11-05 Thread GitBox
himanshug opened a new issue #8824: teamcity build is failing with node module related issue URL: https://github.com/apache/incubator-druid/issues/8824 Message Printed.. ``` [18:05:56]org.apache.druid:druid-console (3m:39s) [18:08:39][org.apache.druid:druid-console] [BABEL] Note:

[GitHub] [incubator-druid] clintropolis edited a comment on issue #8578: parallel broker merges on fork join pool

2019-11-05 Thread GitBox
clintropolis edited a comment on issue #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#issuecomment-549966959 >@clintropolis thanks for all the benchmarks, I haven't had the opportunity to look at the new developments yet but get

[GitHub] [incubator-druid] clintropolis commented on issue #8578: parallel broker merges on fork join pool

2019-11-05 Thread GitBox
clintropolis commented on issue #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#issuecomment-549966959 >@clintropolis thanks for all the benchmarks, I haven't had the opportunity to look at the new developments yet but get back to

[GitHub] [incubator-druid] himanshug commented on issue #8802: add documentation for druid docker and k8s operator

2019-11-05 Thread GitBox
himanshug commented on issue #8802: add documentation for druid docker and k8s operator URL: https://github.com/apache/incubator-druid/pull/8802#issuecomment-549914815 TeamCity build appears to have failed for a totally unrelated reason ``` [16:44:48]org.apache.druid:druid-console

[GitHub] [incubator-druid] himanshug commented on issue #8578: parallel broker merges on fork join pool

2019-11-05 Thread GitBox
himanshug commented on issue #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#issuecomment-549904438 @clintropolis thanks for all the benchmarks, I haven't had the opportunity to look at the new developments yet but get back to

[GitHub] [incubator-druid] himanshug commented on issue #8802: add documentation for druid docker and k8s operator

2019-11-05 Thread GitBox
himanshug commented on issue #8802: add documentation for druid docker and k8s operator URL: https://github.com/apache/incubator-druid/pull/8802#issuecomment-549901339 thanks @nishantmonu51 and @clintropolis , I will have the spelling build fixed and then merge once that is successful.

[GitHub] [incubator-druid] jnaous commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
jnaous commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-549866189 Thanks Clint! These /are/ really good benchmarks. I'm curious what percentage of the entire

[GitHub] [incubator-druid] clintropolis edited a comment on issue #8578: parallel broker merges on fork join pool

2019-11-05 Thread GitBox
clintropolis edited a comment on issue #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#issuecomment-54976 ### simulated heavy load I collected another round of data using the same benchmarks as my 'more realistic worst case'

[GitHub] [incubator-druid] clintropolis commented on issue #8578: parallel broker merges on fork join pool

2019-11-05 Thread GitBox
clintropolis commented on issue #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#issuecomment-54976 ### simulated heavy load I collected another round of data using the same benchmarks as my 'more realistic worst case' comment,

[GitHub] [incubator-druid] clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-549718415 To follow-up on the PR description, I let the concise benchmarks finish where nearly

[GitHub] [incubator-druid] clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows)

2019-11-05 Thread GitBox
clintropolis commented on issue #8822: optimize numeric column null value checking for low filter selectivity (more rows) URL: https://github.com/apache/incubator-druid/pull/8822#issuecomment-549717755 >The heatmaps look super cool! (although I don't think I fully understand them yet :| )