leventov commented on a change in pull request #8809: Prohibit
Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r342948998
##########
File path:
server/src/main/java/org/apache/druid/server/http/SegmentListerResource.java
##########
@@ -205,7 +209,8 @@ public void onFailure(Throwable th)
log.debug(ex, "Request timed out or closed already.");
}
}
- }
+ },
Review comment:
Same. This code looks similar to `TaskManagementResource`. Maybe the common
logic should be extracted. Or, there should be comments to both of them noting
that these classes are written in a similar way so changes, fixes, refactorings
should be applied to both classes at the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
