[GitHub] [incubator-druid] surekhasaharan commented on issue #8869: Servers not always showing up in the ui

2019-11-14 Thread GitBox
surekhasaharan commented on issue #8869: Servers not always showing up in the ui URL: https://github.com/apache/incubator-druid/issues/8869#issuecomment-554232907 > Where does this page get its information from? This information is retrieved from `sys.servers` virtual table, which

[GitHub] [incubator-druid] mistercrunch commented on issue #6771: Druid SQL: Mapping the gaps in capability

2019-11-14 Thread GitBox
mistercrunch commented on issue #6771: Druid SQL: Mapping the gaps in capability URL: https://github.com/apache/incubator-druid/issues/6771#issuecomment-554223925 We're hoping to deprecate the REST/native Druid connector in Superset and move towards the SQL / SQLAlchemy connector.

[GitHub] [incubator-druid] mggger opened a new issue #8873: Unable to get kafka consumer group information

2019-11-14 Thread GitBox
mggger opened a new issue #8873: Unable to get kafka consumer group information URL: https://github.com/apache/incubator-druid/issues/8873 https://user-images.githubusercontent.com/13358284/68917590-f636b480-07a5-11ea-8742-70316c6a0413.png;> I am looking forward to a consumer group

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8864: add sequenceName and currentCheckPoint for backwards compatibility

2019-11-14 Thread GitBox
lgtm-com[bot] commented on issue #8864: add sequenceName and currentCheckPoint for backwards compatibility URL: https://github.com/apache/incubator-druid/pull/8864#issuecomment-554203600 This pull request **introduces 1 alert** when merging 7388323c306de4a57863501bc08d55480fbc9978 into

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8864: add sequenceName and currentCheckPoint for backwards compatibility

2019-11-14 Thread GitBox
lgtm-com[bot] commented on issue #8864: add sequenceName and currentCheckPoint for backwards compatibility URL: https://github.com/apache/incubator-druid/pull/8864#issuecomment-554180675 This pull request **introduces 1 alert** when merging eb9aa746e9bdd8467761db663da92d018a6b36f8 into

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346630087 ## File path: core/src/main/java/org/apache/druid/data/input/InputRowListPlusJson.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346630028 ## File path: core/src/main/java/org/apache/druid/data/input/Firehose.java ## @@ -74,13 +74,13

[GitHub] [incubator-druid] ccaominh commented on issue #8328: [DISCUSS] Code generation for commonly implemented basic methods

2019-11-14 Thread GitBox
ccaominh commented on issue #8328: [DISCUSS] Code generation for commonly implemented basic methods URL: https://github.com/apache/incubator-druid/issues/8328#issuecomment-554166883 Another bug that could have been prevented by auto-generating `equals/hashCode/toString`:

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility

2019-11-14 Thread GitBox
surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r346625981 ## File path:

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346617966 ## File path: core/src/main/java/org/apache/druid/data/input/Firehose.java ## @@ -74,13 +74,13

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
ccaominh commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346619475 ## File path: core/src/main/java/org/apache/druid/data/input/InputRowListPlusJson.java ## @@

[GitHub] [incubator-druid] ccaominh commented on issue #8872: Improve missing JDBC driver error for lookups

2019-11-14 Thread GitBox
ccaominh commented on issue #8872: Improve missing JDBC driver error for lookups URL: https://github.com/apache/incubator-druid/pull/8872#issuecomment-554154524 Travis failure is due to flaky `EmitterTest`. This is an

[GitHub] [incubator-druid] ccaominh opened a new pull request #8872: Improve missing JDBC driver error for lookups

2019-11-14 Thread GitBox
ccaominh opened a new pull request #8872: Improve missing JDBC driver error for lookups URL: https://github.com/apache/incubator-druid/pull/8872 ### Description If the JDBC drivers are missing from the lookup extensions, throw an exception that directs the user how to resolve the

[GitHub] [incubator-druid] SEKIRO-J opened a new pull request #8871: sampler returns nulls in CSV

2019-11-14 Thread GitBox
SEKIRO-J opened a new pull request #8871: sampler returns nulls in CSV URL: https://github.com/apache/incubator-druid/pull/8871 Fixes #8845. ### Description When parsing a CSV in the sampler, if the whole column values are not provided but column

[GitHub] [incubator-druid] jon-wei commented on issue #8870: Additional Kinesis resharding fixes

2019-11-14 Thread GitBox
jon-wei commented on issue #8870: Additional Kinesis resharding fixes URL: https://github.com/apache/incubator-druid/pull/8870#issuecomment-554112067 Marked WIP since it still needs a few javadoc updates and additional testing on clusters

[GitHub] [incubator-druid] jon-wei opened a new pull request #8870: Additional Kinesis resharding fixes

2019-11-14 Thread GitBox
jon-wei opened a new pull request #8870: Additional Kinesis resharding fixes URL: https://github.com/apache/incubator-druid/pull/8870 This PR fixes two issues with Kinesis resharding: - When shards expired after the retention period, old tasks created under the previous shard set (with

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
lgtm-com[bot] commented on issue #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#issuecomment-554097514 This pull request **fixes 1 alert** when merging ce88049c6969fbee65078064949ad0122be9565c into

[GitHub] [incubator-druid] ceastman-ibm opened a new issue #8869: Servers not always showing up in the ui

2019-11-14 Thread GitBox
ceastman-ibm opened a new issue #8869: Servers not always showing up in the ui URL: https://github.com/apache/incubator-druid/issues/8869 Please provide a detailed title (e.g. "Broker crashes when using TopN query with Bound filter" instead of just "Broker crashes"). ### Affected

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536451 ## File path: core/src/main/java/org/apache/druid/guice/annotations/UnstableApi.java ## @@

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536395 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvReader.java ## @@ -0,0

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536429 ## File path: processing/src/main/java/org/apache/druid/segment/transform/Transformer.java ##

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536351 ## File path: core/src/main/java/org/apache/druid/data/input/InputEntity.java ## @@ -0,0 +1,115

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
jihoonson commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346536378 ## File path: core/src/main/java/org/apache/druid/data/input/InputEntity.java ## @@ -0,0 +1,115

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346499344 ## File path: core/src/main/java/org/apache/druid/data/input/InputEntity.java ## @@ -0,0

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346527136 ## File path: core/src/main/java/org/apache/druid/guice/annotations/UnstableApi.java ## @@

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346499808 ## File path: core/src/main/java/org/apache/druid/data/input/InputEntity.java ## @@ -0,0

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346524637 ## File path: processing/src/main/java/org/apache/druid/segment/transform/Transformer.java

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces

2019-11-14 Thread GitBox
clintropolis commented on a change in pull request #8823: Add InputSource and InputFormat interfaces URL: https://github.com/apache/incubator-druid/pull/8823#discussion_r346519456 ## File path: core/src/main/java/org/apache/druid/data/input/impl/CsvReader.java ## @@ -0,0

[GitHub] [incubator-druid] birTiwana commented on issue #6320: Moving Average query type

2019-11-14 Thread GitBox
birTiwana commented on issue #6320: Moving Average query type URL: https://github.com/apache/incubator-druid/issues/6320#issuecomment-554054011 I noticed that `moving-average-query` has a **having** property. But can the having property be used only on aggregations or it can be used after

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-14 Thread GitBox
lgtm-com[bot] commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-554046019 This pull request **introduces 1 alert** when merging

[GitHub] [incubator-druid] ccaominh commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility

2019-11-14 Thread GitBox
ccaominh commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r346492231 ## File path:

[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility

2019-11-14 Thread GitBox
surekhasaharan commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r346486462 ## File path:

[GitHub] [incubator-druid] bibekjoshisrijan opened a new issue #8868: Docker Build is failing for 0.16.0-incubating-rc3

2019-11-14 Thread GitBox
bibekjoshisrijan opened a new issue #8868: Docker Build is failing for 0.16.0-incubating-rc3 URL: https://github.com/apache/incubator-druid/issues/8868 Docker build fails when running as instructed in the repository. ### Version 0.16.0-incubating-rc3 ### Description

[GitHub] [incubator-druid] stale[bot] commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments

2019-11-14 Thread GitBox
stale[bot] commented on issue #7306: Reconcile terminology and method naming to 'used/unused segments'; Rename MetadataSegmentManager to MetadataSegments URL: https://github.com/apache/incubator-druid/pull/7306#issuecomment-553967652 This pull request/issue is no longer marked as stale.

[GitHub] [incubator-druid] leventov opened a new issue #8867: NPE while executing org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorTest.testLatestOffset()

2019-11-14 Thread GitBox
leventov opened a new issue #8867: NPE while executing org.apache.druid.indexing.kafka.supervisor.KafkaSupervisorTest.testLatestOffset() URL: https://github.com/apache/incubator-druid/issues/8867 NPE happens in this line:

[GitHub] [incubator-druid] leventov commented on issue #6943: InterruptedExceptions should never be ignored in the code.

2019-11-14 Thread GitBox
leventov commented on issue #6943: InterruptedExceptions should never be ignored in the code. URL: https://github.com/apache/incubator-druid/pull/6943#issuecomment-553823094 @kamaci could you please complete this? This is an

[GitHub] [incubator-druid] stale[bot] commented on issue #6943: InterruptedExceptions should never be ignored in the code.

2019-11-14 Thread GitBox
stale[bot] commented on issue #6943: InterruptedExceptions should never be ignored in the code. URL: https://github.com/apache/incubator-druid/pull/6943#issuecomment-553823114 This issue is no longer marked as stale.

[GitHub] [incubator-druid] leventov opened a new issue #8866: splitHintSpec is not added to ClientCompactQueryTuningConfig's equals(), hashCode(), and toString()

2019-11-14 Thread GitBox
leventov opened a new issue #8866: splitHintSpec is not added to ClientCompactQueryTuningConfig's equals(), hashCode(), and toString() URL: https://github.com/apache/incubator-druid/issues/8866 This bug is introduced in #8570, see

[GitHub] [incubator-druid] qiu-zhiwei opened a new issue #8865: Unable to load data from local fileļ¼šParameter 'directory' is not a directory

2019-11-14 Thread GitBox
qiu-zhiwei opened a new issue #8865: Unable to load data from local fileļ¼šParameter 'directory' is not a directory URL: https://github.com/apache/incubator-druid/issues/8865 When I use local index to load data I use "curl - x 'post' - H 'content type: application/JSON' - D

[GitHub] [incubator-druid] zhaolihe commented on issue #7095: Adding offset to SQL

2019-11-14 Thread GitBox
zhaolihe commented on issue #7095: Adding offset to SQL URL: https://github.com/apache/incubator-druid/issues/7095#issuecomment-553773291 expect this feature to achieve This is an automated message from the Apache Git