[GitHub] jon-wei closed pull request #5881: Docs: Fix bound query keys for Filtering on numeric values

2018-08-23 Thread GitBox
jon-wei closed pull request #5881: Docs: Fix bound query keys for Filtering on numeric values URL: https://github.com/apache/incubator-druid/pull/5881 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] gianm closed pull request #6217: do not ignore ms in ruby time

2018-08-23 Thread GitBox
gianm closed pull request #6217: do not ignore ms in ruby time URL: https://github.com/apache/incubator-druid/pull/6217 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] gianm commented on a change in pull request #6217: do not ignore ms in ruby time

2018-08-23 Thread GitBox
gianm commented on a change in pull request #6217: do not ignore ms in ruby time URL: https://github.com/apache/incubator-druid/pull/6217#discussion_r212458244 ## File path: java-util/src/test/java/io/druid/java/util/common/parsers/TimestampParserTest.java ## @@ -97,8

[GitHub] jihoonson commented on a change in pull request #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup

2018-08-23 Thread GitBox
jihoonson commented on a change in pull request #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup URL: https://github.com/apache/incubator-druid/pull/6206#discussion_r212466540 ## File path:

[GitHub] gianm commented on issue #6112: Prohibit LinkedList

2018-08-23 Thread GitBox
gianm commented on issue #6112: Prohibit LinkedList URL: https://github.com/apache/incubator-druid/pull/6112#issuecomment-415610146 @fjy is your -1 intended as a "veto" in the ASF sense (https://www.apache.org/foundation/voting.html)? > A code-modification proposal may be stopped

[GitHub] jihoonson commented on a change in pull request #6207: Fix timeout in KafkaSupervisorTest.testCheckpointForInactiveTaskGroup

2018-08-23 Thread GitBox
jihoonson commented on a change in pull request #6207: Fix timeout in KafkaSupervisorTest.testCheckpointForInactiveTaskGroup URL: https://github.com/apache/incubator-druid/pull/6207#discussion_r212461128 ## File path:

[GitHub] himanshug commented on issue #6224: Zstandard decompression support

2018-08-23 Thread GitBox
himanshug commented on issue #6224: Zstandard decompression support URL: https://github.com/apache/incubator-druid/pull/6224#issuecomment-415590971 is license ( https://github.com/luben/zstd-jni/blob/master/LICENSE ) ok for apache ?

[GitHub] himanshug commented on issue #6223: make COMPLEX column filterable in Druid code

2018-08-23 Thread GitBox
himanshug commented on issue #6223: make COMPLEX column filterable in Druid code URL: https://github.com/apache/incubator-druid/pull/6223#issuecomment-415594030 > Would it make sense to add a canFilter method to ColumnCapabilities to have a finer level of control than just mapping

[GitHub] gianm commented on issue #6224: Zstandard decompression support

2018-08-23 Thread GitBox
gianm commented on issue #6224: Zstandard decompression support URL: https://github.com/apache/incubator-druid/pull/6224#issuecomment-415610916 That looks like 2-clause BSD, which is ok (http://apache.org/legal/resolved.html#category-a). And zstd itself is 3-clause BSD, which is also ok.

[GitHub] leventov commented on issue #6112: Prohibit LinkedList

2018-08-23 Thread GitBox
leventov commented on issue #6112: Prohibit LinkedList URL: https://github.com/apache/incubator-druid/pull/6112#issuecomment-415585376 @fjy could you please respond This is an automated message from the Apache Git Service. To

[GitHub] gianm commented on issue #6223: make COMPLEX column filterable in Druid code

2018-08-23 Thread GitBox
gianm commented on issue #6223: make COMPLEX column filterable in Druid code URL: https://github.com/apache/incubator-druid/pull/6223#issuecomment-415610712 > Actually I think existence of Filterable.FILTERABLE_TYPE is redundant. For me, ColumnCapability.hasBitmapIndexes() is already the

[GitHub] drcrallen commented on a change in pull request #6219: Add optional `name` to top level of FilteredAggregatorFactory

2018-08-24 Thread GitBox
drcrallen commented on a change in pull request #6219: Add optional `name` to top level of FilteredAggregatorFactory URL: https://github.com/apache/incubator-druid/pull/6219#discussion_r212738542 ## File path:

[GitHub] rpless edited a comment on issue #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options

2018-08-21 Thread GitBox
rpless edited a comment on issue #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options URL: https://github.com/apache/incubator-druid/pull/6181#issuecomment-414789216 Thanks for the feedback @jon-wei! I've updated the PR with it. > Let's do that in a separate PR

[GitHub] himanshug edited a comment on issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-21 Thread GitBox
himanshug edited a comment on issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176#issuecomment-414780324 @jihoonson My test environment had 3 brokers, 2 coordinators, 2 overlords, ~40 Middle Managers

[GitHub] jihoonson edited a comment on issue #6162: Add maven.exec.xxx.skip option for exec-maven-plugin

2018-08-21 Thread GitBox
jihoonson edited a comment on issue #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#issuecomment-414823704 Thanks @asdf2014. Would you check this warning which is seen when building the project. ``` [INFO]

[GitHub] jihoonson commented on issue #6162: Add maven.exec.xxx.skip option for exec-maven-plugin

2018-08-21 Thread GitBox
jihoonson commented on issue #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#issuecomment-414823704 Thanks @asdf2014. Would you check this warning which is seen when building the project. ```

[GitHub] jihoonson commented on issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-21 Thread GitBox
jihoonson commented on issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176#issuecomment-414759793 @himanshug would you give us more details about your test environments? In our company, we are still

[GitHub] jon-wei commented on issue #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options

2018-08-21 Thread GitBox
jon-wei commented on issue #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options URL: https://github.com/apache/incubator-druid/pull/6181#issuecomment-414782610 @rpless Thanks for the contribution! > I also noticed that the version of the postgres driver is quite

[GitHub] himanshug edited a comment on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner

2018-08-21 Thread GitBox
himanshug edited a comment on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/6201#issuecomment-414808208 great, that helps. I think I understand the problem. HRTR is calling notification on attached listeners while

[GitHub] a2l007 commented on issue #5400: Deadlock bug within HttpRemoteTaskRunner

2018-08-21 Thread GitBox
a2l007 commented on issue #5400: Deadlock bug within HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/5400#issuecomment-414829197 Related #6201 This is an automated message from the Apache Git

[GitHub] himanshug closed issue #5400: Deadlock bug within HttpRemoteTaskRunner

2018-08-21 Thread GitBox
himanshug closed issue #5400: Deadlock bug within HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/5400 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] himanshug commented on issue #5400: Deadlock bug within HttpRemoteTaskRunner

2018-08-21 Thread GitBox
himanshug commented on issue #5400: Deadlock bug within HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/5400#issuecomment-414832077 this also seems to be the same cause, let me close this one and continue putting updates on #6201 .

[GitHub] himanshug edited a comment on issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-21 Thread GitBox
himanshug edited a comment on issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176#issuecomment-414780324 @jihoonson My test environment had 3 brokers, 2 coordinators, 2 overlords, ~40 Middle Managers

[GitHub] himanshug edited a comment on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner

2018-08-21 Thread GitBox
himanshug edited a comment on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/6201#issuecomment-414808208 great, that helps. I think I understand the problem. HRTR is calling notification on attached listeners while

[GitHub] jihoonson commented on issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-21 Thread GitBox
jihoonson commented on issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176#issuecomment-414789398 @himanshug thanks for the details. > 1. switching coordinator to use HTTP (using HttpLoadQueuePeon)

[GitHub] jon-wei commented on a change in pull request #6076: Mutual TLS support

2018-08-21 Thread GitBox
jon-wei commented on a change in pull request #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#discussion_r211740610 ## File path: docs/content/operations/tls-support.md ## @@ -31,6 +31,16 @@ values for the below mentioned configs among

[GitHub] jihoonson commented on issue #4841: Issues wth Hadoop batch indexing using S3A in 0.10.1 and hadoop client 2.7.3

2018-08-21 Thread GitBox
jihoonson commented on issue #4841: Issues wth Hadoop batch indexing using S3A in 0.10.1 and hadoop client 2.7.3 URL: https://github.com/apache/incubator-druid/issues/4841#issuecomment-414762194 Hi @kskalski, a possible solution is to build your own hadoop-aws.jar which shades all

[GitHub] jon-wei closed pull request #6193: Docs: remove duplicate link to operations/recommendations.html

2018-08-21 Thread GitBox
jon-wei closed pull request #6193: Docs: remove duplicate link to operations/recommendations.html URL: https://github.com/apache/incubator-druid/pull/6193 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jihoonson commented on issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-21 Thread GitBox
jihoonson commented on issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176#issuecomment-414796201 Thanks. It sounds like this is definitely needed to support rolling update if HTTP task runner becomes

[GitHub] QiuMM opened a new pull request #6202: fix port conflict for druid peon

2018-08-21 Thread GitBox
QiuMM opened a new pull request #6202: fix port conflict for druid peon URL: https://github.com/apache/incubator-druid/pull/6202 Recently, I upgraded my druid cluster to 0.12.2 version. When I using `druid.plaintextPort` not `druid.port` to configure service port for Middle Manager, I

[GitHub] gianm commented on issue #6199: [Proposal] Vectorized querying for lookups

2018-08-21 Thread GitBox
gianm commented on issue #6199: [Proposal] Vectorized querying for lookups URL: https://github.com/apache/incubator-druid/issues/6199#issuecomment-414835147 It's not, just the inner parts of the query engines. This is an

[GitHub] jon-wei opened a new issue #6201: Deadlock on overlord with HttpRemoteTaskRunner

2018-08-21 Thread GitBox
jon-wei opened a new issue #6201: Deadlock on overlord with HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/6201 We noticed deadlocks on the overlord in our test cluster, which was using HttpRemoteTaskRunner: ``` "hrtr-pending-tasks-runner-0" #193

[GitHub] jihoonson closed pull request #6192: Fix assertionError at testCheckpointForInactiveTaskGroup in KafkaSupervisorTest

2018-08-21 Thread GitBox
jihoonson closed pull request #6192: Fix assertionError at testCheckpointForInactiveTaskGroup in KafkaSupervisorTest URL: https://github.com/apache/incubator-druid/pull/6192 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] himanshug commented on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner

2018-08-21 Thread GitBox
himanshug commented on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/6201#issuecomment-414796348 @jon-wei do you have full thread dump ? above shows threads waiting to get hold of locks but doesn't show which threads

[GitHub] himanshug edited a comment on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner

2018-08-21 Thread GitBox
himanshug edited a comment on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/6201#issuecomment-414796348 @jon-wei do you have full thread dump ? above shows threads waiting to get hold of locks but doesn't show which

[GitHub] jihoonson opened a new pull request #6203: Add support targetCompactionSizeBytes for compactionTask

2018-08-21 Thread GitBox
jihoonson opened a new pull request #6203: Add support targetCompactionSizeBytes for compactionTask URL: https://github.com/apache/incubator-druid/pull/6203 `targetCompactionSizeBytes` is similar to that of automatic compaction and means the size of the result segments after compaction.

[GitHub] jihoonson edited a comment on issue #6162: Add maven.exec.xxx.skip option for exec-maven-plugin

2018-08-21 Thread GitBox
jihoonson edited a comment on issue #6162: Add maven.exec.xxx.skip option for exec-maven-plugin URL: https://github.com/apache/incubator-druid/pull/6162#issuecomment-414823704 Thanks @asdf2014. Would you check this warning which is seen when building the project. ``` [INFO]

[GitHub] jon-wei commented on a change in pull request #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options

2018-08-21 Thread GitBox
jon-wei commented on a change in pull request #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options URL: https://github.com/apache/incubator-druid/pull/6181#discussion_r211715799 ## File path: docs/content/development/extensions-core/postgresql.md ## @@

[GitHub] jon-wei commented on a change in pull request #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options

2018-08-21 Thread GitBox
jon-wei commented on a change in pull request #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options URL: https://github.com/apache/incubator-druid/pull/6181#discussion_r211716882 ## File path: docs/content/development/extensions-core/postgresql.md ## @@

[GitHub] jihoonson commented on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner

2018-08-21 Thread GitBox
jihoonson commented on issue #6201: Deadlock on overlord with HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/6201#issuecomment-414797778 Here it is:

[GitHub] himanshug edited a comment on issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-21 Thread GitBox
himanshug edited a comment on issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176#issuecomment-414793443 > What I meant for removing remaining codes writing data on ZK is [this kind of

[GitHub] jihoonson commented on issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-21 Thread GitBox
jihoonson commented on issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176#issuecomment-414760515 Also, I would say we should remove all remaining codes writing data on ZK in HTTP-based

[GitHub] himanshug commented on issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-21 Thread GitBox
himanshug commented on issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176#issuecomment-414780324 @jihoonson My test environment had 3 brokers, 2 coordinators, 2 overlords, ~40 Middle Managers (each

[GitHub] rpless commented on issue #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options

2018-08-21 Thread GitBox
rpless commented on issue #6181: Add PostgreSQLConnectorConfig to expose SSL configuration options URL: https://github.com/apache/incubator-druid/pull/6181#issuecomment-414789216 Thanks for the feedback @jon-wei! I've updated the PR with it. > Let's do that in a separate PR

[GitHub] himanshug commented on issue #6176: CuratorInventoryManager may not report inventory as initialized

2018-08-21 Thread GitBox
himanshug commented on issue #6176: CuratorInventoryManager may not report inventory as initialized URL: https://github.com/apache/incubator-druid/issues/6176#issuecomment-414793443 > What I meant for removing remaining codes writing data on ZK is [this kind of

[GitHub] jon-wei edited a comment on issue #6076: Mutual TLS support

2018-08-21 Thread GitBox
jon-wei edited a comment on issue #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#issuecomment-414801194 > Different private keys and certs for the client and server. (Can be the same root CA, and same CN/altNames, but generate two different keys, and two

[GitHub] jon-wei commented on issue #6076: Mutual TLS support

2018-08-21 Thread GitBox
jon-wei commented on issue #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#issuecomment-414801194 > Different private keys and certs for the client and server. (Can be the same root CA, and same CN/altNames, but generate two different keys, and two

[GitHub] gianm commented on issue #6177: TimeBoundary, DataSourceMetadata filterSegments flawed with overlapping segments

2018-08-21 Thread GitBox
gianm commented on issue #6177: TimeBoundary, DataSourceMetadata filterSegments flawed with overlapping segments URL: https://github.com/apache/incubator-druid/issues/6177#issuecomment-414835392 I think we could filter at the broker, we just want to check any segment that overlaps with

[GitHub] gianm commented on issue #6211: SQL planning error for nested queries

2018-08-25 Thread GitBox
gianm commented on issue #6211: SQL planning error for nested queries URL: https://github.com/apache/incubator-druid/issues/6211#issuecomment-415996489 I backported this in #6228, and I will close this issue since it's fixed by #5788.

[GitHub] gianm closed issue #6211: SQL planning error for nested queries

2018-08-25 Thread GitBox
gianm closed issue #6211: SQL planning error for nested queries URL: https://github.com/apache/incubator-druid/issues/6211 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] gianm opened a new pull request #6230: Fix four bugs with numeric dimension output types. (#6220)

2018-08-25 Thread GitBox
gianm opened a new pull request #6230: Fix four bugs with numeric dimension output types. (#6220) URL: https://github.com/apache/incubator-druid/pull/6230 * Fix four bugs with numeric dimension output types. This patch includes the following bug fixes: -

[GitHub] leventov commented on issue #6220: Fix four bugs with numeric dimension output types.

2018-08-25 Thread GitBox
leventov commented on issue #6220: Fix four bugs with numeric dimension output types. URL: https://github.com/apache/incubator-druid/pull/6220#issuecomment-416003192 @fjy please don't merge PRs with unanswered comments (despite the approval), otherwise why they are left?

[GitHub] gianm commented on issue #6220: Fix four bugs with numeric dimension output types.

2018-08-25 Thread GitBox
gianm commented on issue #6220: Fix four bugs with numeric dimension output types. URL: https://github.com/apache/incubator-druid/pull/6220#issuecomment-416003871 Follow-up is in #6231. This is an automated message from the

[GitHub] gianm opened a new pull request #6231: Minor followup to #6220.

2018-08-25 Thread GitBox
gianm opened a new pull request #6231: Minor followup to #6220. URL: https://github.com/apache/incubator-druid/pull/6231 Adjustments to comments and usage of generics. This is an automated message from the Apache Git Service.

[GitHub] gianm opened a new pull request #6228: [Backport] Support projection after sorting in SQL

2018-08-25 Thread GitBox
gianm opened a new pull request #6228: [Backport] Support projection after sorting in SQL URL: https://github.com/apache/incubator-druid/pull/6228 Backport of #5788 to 0.12.3. This is an automated message from the Apache Git

[GitHub] gianm commented on issue #5912: [SQL] Fix missing postAggregations for Timeseries and TopN

2018-08-25 Thread GitBox
gianm commented on issue #5912: [SQL] Fix missing postAggregations for Timeseries and TopN URL: https://github.com/apache/incubator-druid/pull/5912#issuecomment-415996756 I believe this fixes a bug introduced by #5788, so it must be included in 0.12.3. I'll mark it.

[GitHub] gianm closed issue #6201: Deadlock on overlord with HttpRemoteTaskRunner

2018-08-25 Thread GitBox
gianm closed issue #6201: Deadlock on overlord with HttpRemoteTaskRunner URL: https://github.com/apache/incubator-druid/issues/6201 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] gianm closed pull request #6212: fix TaskQueue-HRTR deadlock

2018-08-25 Thread GitBox
gianm closed pull request #6212: fix TaskQueue-HRTR deadlock URL: https://github.com/apache/incubator-druid/pull/6212 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] fjy closed pull request #6220: Fix four bugs with numeric dimension output types.

2018-08-25 Thread GitBox
fjy closed pull request #6220: Fix four bugs with numeric dimension output types. URL: https://github.com/apache/incubator-druid/pull/6220 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] fjy closed issue #6123: ClassCastException in groupBy when sorting on numeric columns containing nulls

2018-08-25 Thread GitBox
fjy closed issue #6123: ClassCastException in groupBy when sorting on numeric columns containing nulls URL: https://github.com/apache/incubator-druid/issues/6123 This is an automated message from the Apache Git Service. To

[GitHub] gianm closed pull request #6221: SQL: Finalize aggregations for inner queries when necessary.

2018-08-25 Thread GitBox
gianm closed pull request #6221: SQL: Finalize aggregations for inner queries when necessary. URL: https://github.com/apache/incubator-druid/pull/6221 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] gianm closed issue #5779: HLL in inner group by does not get finalized

2018-08-25 Thread GitBox
gianm closed issue #5779: HLL in inner group by does not get finalized URL: https://github.com/apache/incubator-druid/issues/5779 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] gianm commented on issue #6212: fix TaskQueue-HRTR deadlock

2018-08-25 Thread GitBox
gianm commented on issue #6212: fix TaskQueue-HRTR deadlock URL: https://github.com/apache/incubator-druid/pull/6212#issuecomment-415997052 LGTM, thanks @himanshug This is an automated message from the Apache Git Service. To

[GitHub] leventov commented on issue #6220: Fix four bugs with numeric dimension output types.

2018-08-25 Thread GitBox
leventov commented on issue #6220: Fix four bugs with numeric dimension output types. URL: https://github.com/apache/incubator-druid/pull/6220#issuecomment-416004813 Thanks. Yes it means non-blocking comments, however answering them before merging is appreciated.

[GitHub] gianm commented on issue #6191: SQL: Support more result formats, add columns header.

2018-08-25 Thread GitBox
gianm commented on issue #6191: SQL: Support more result formats, add columns header. URL: https://github.com/apache/incubator-druid/pull/6191#issuecomment-416011442 I realized that a single blank line is a better trailer (it still lets you detect truncation, and is easier to ignore).

[GitHub] gianm commented on issue #6076: Mutual TLS support

2018-08-25 Thread GitBox
gianm commented on issue #6076: Mutual TLS support URL: https://github.com/apache/incubator-druid/pull/6076#issuecomment-416006702 @jon-wei is this still a WIP or is it ready for re-review? This is an automated message from

[GitHub] gianm opened a new pull request #6232: Fix NPE on constant null numeric expressions.

2018-08-25 Thread GitBox
gianm opened a new pull request #6232: Fix NPE on constant null numeric expressions. URL: https://github.com/apache/incubator-druid/pull/6232 The bug was caused by makeExprEvalSelector returning a null object, which it isn't supposed to do. Fixed this by renaming

[GitHub] gianm commented on a change in pull request #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup

2018-08-25 Thread GitBox
gianm commented on a change in pull request #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup URL: https://github.com/apache/incubator-druid/pull/6206#discussion_r212811973 ## File path:

[GitHub] gianm commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-25 Thread GitBox
gianm commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r212812039 ## File path: docs/content/querying/groupbyquery.md ## @@ -113,6 +114,94 @@ improve

[GitHub] gianm commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-25 Thread GitBox
gianm commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r212812038 ## File path: docs/content/querying/groupbyquery.md ## @@ -70,6 +70,7 @@ There are 11 main

[GitHub] gianm commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-25 Thread GitBox
gianm commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r212812046 ## File path: docs/content/querying/groupbyquery.md ## @@ -113,6 +114,94 @@ improve

[GitHub] gianm commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query

2018-08-25 Thread GitBox
gianm commented on a change in pull request #5280: add "subtotalsSpec" attribute to groupBy query URL: https://github.com/apache/incubator-druid/pull/5280#discussion_r212812069 ## File path: docs/content/querying/groupbyquery.md ## @@ -113,6 +114,94 @@ improve

[GitHub] gianm commented on issue #6223: make COMPLEX column filterable in Druid code

2018-08-25 Thread GitBox
gianm commented on issue #6223: make COMPLEX column filterable in Druid code URL: https://github.com/apache/incubator-druid/pull/6223#issuecomment-416006551 @himanshug probably it makes sense for this new capability to always be true for string, long, float, double; and for it to be false

[GitHub] gianm opened a new pull request #6233: FilteredBufferAggregator: Fix missing relocate, isNull methods.

2018-08-25 Thread GitBox
gianm opened a new pull request #6233: FilteredBufferAggregator: Fix missing relocate, isNull methods. URL: https://github.com/apache/incubator-druid/pull/6233 FilteredBufferAggregator was missing these two methods, which meant that nullability and relocation wouldn't work properly for

[GitHub] gianm commented on issue #6191: SQL: Support more result formats, add columns header.

2018-08-25 Thread GitBox
gianm commented on issue #6191: SQL: Support more result formats, add columns header. URL: https://github.com/apache/incubator-druid/pull/6191#issuecomment-416010989 I'm not a huge fan of the 'trailers' here, but from what I can see, our version of Jetty (9.4.10.v20180503) will use

[GitHub] sanastas commented on issue #5698: Oak: New Concurrent Key-Value Map

2018-08-26 Thread GitBox
sanastas commented on issue #5698: Oak: New Concurrent Key-Value Map URL: https://github.com/apache/incubator-druid/issues/5698#issuecomment-416028572 I have updated the pull request https://github.com/apache/incubator-druid/pull/6235 This pull request also includes interesting

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r213229161 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r212994961 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r212946302 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r212946392 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r212992036 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r213232091 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r212991239 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java

[GitHub] sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04

2018-08-28 Thread GitBox
sdimbsn commented on a change in pull request #6235: Druid with Oak supporting also plain mode v04 URL: https://github.com/apache/incubator-druid/pull/6235#discussion_r213228598 ## File path: processing/src/main/java/io/druid/segment/incremental/OakIncrementalIndex.java

[GitHub] Harish346 edited a comment on issue #6113: Inserting Nested Json into Druid

2018-08-28 Thread GitBox
Harish346 edited a comment on issue #6113: Inserting Nested Json into Druid URL: https://github.com/apache/incubator-druid/issues/6113#issuecomment-411507775 Hi @gianm **This is my ingestion spec file** { "type": "index_hadoop", "spec": { "ioConfig": {

[GitHub] Harish346 edited a comment on issue #6113: Inserting Nested Json into Druid

2018-08-28 Thread GitBox
Harish346 edited a comment on issue #6113: Inserting Nested Json into Druid URL: https://github.com/apache/incubator-druid/issues/6113#issuecomment-411507775 Hi @gianm This is my ingestion spec file { "type": "index_hadoop", "spec": { "ioConfig": {

[GitHub] zhaojiandong opened a new pull request #6254: fix opentsdb emitter occupy 100%(#6247)

2018-08-28 Thread GitBox
zhaojiandong opened a new pull request #6254: fix opentsdb emitter occupy 100%(#6247) URL: https://github.com/apache/incubator-druid/pull/6254 we found sending event thread of opentsdb emitter will cause cpu occupy 100%, as follow. And format this extension's code to pass code style

[GitHub] gaodayue opened a new issue #6255: Heavy GC activities after upgrading to 0.12

2018-08-28 Thread GitBox
gaodayue opened a new issue #6255: Heavy GC activities after upgrading to 0.12 URL: https://github.com/apache/incubator-druid/issues/6255 After upgrading some of our historical nodes from 0.11.0 to 0.12, we observed significant performance degradation on these nodes. Below is a graph

[GitHub] waixiaoyu opened a new issue #6252: Deadlock may be in TaskMaster when stopping

2018-08-28 Thread GitBox
waixiaoyu opened a new issue #6252: Deadlock may be in TaskMaster when stopping URL: https://github.com/apache/incubator-druid/issues/6252 When I try to close the whole druid cluster, I found the Overlord process still remained in the system. The following info is part of stack.

[GitHub] Harish346 opened a new issue #6253: Multiple datasources with multiple topic in one spec file

2018-08-28 Thread GitBox
Harish346 opened a new issue #6253: Multiple datasources with multiple topic in one spec file URL: https://github.com/apache/incubator-druid/issues/6253 Hi, I have multiple datasources each corresponding to a kafka topic.When I create supervisor for each datasource,many supervisors

[GitHub] gianm opened a new pull request #6240: [Backport] SQL: Fix precision of TIMESTAMP types.

2018-08-26 Thread GitBox
gianm opened a new pull request #6240: [Backport] SQL: Fix precision of TIMESTAMP types. URL: https://github.com/apache/incubator-druid/pull/6240 Backport of #5464 to 0.12.3. This is an automated message from the Apache Git

[GitHub] gianm opened a new pull request #6239: [Backport] SQL: Fix assumption that AND, OR have two arguments.

2018-08-26 Thread GitBox
gianm opened a new pull request #6239: [Backport] SQL: Fix assumption that AND, OR have two arguments. URL: https://github.com/apache/incubator-druid/pull/6239 Backport of #5470 to 0.12.3. This is an automated message from

[GitHub] gianm opened a new pull request #6238: [Backport] SQL: Fix selecting BOOLEAN type in JDBC.

2018-08-26 Thread GitBox
gianm opened a new pull request #6238: [Backport] SQL: Fix selecting BOOLEAN type in JDBC. URL: https://github.com/apache/incubator-druid/pull/6238 Backport of #5401 to 0.12.3. This is an automated message from the Apache

[GitHub] fjy closed pull request #6239: [Backport] SQL: Fix assumption that AND, OR have two arguments.

2018-08-26 Thread GitBox
fjy closed pull request #6239: [Backport] SQL: Fix assumption that AND, OR have two arguments. URL: https://github.com/apache/incubator-druid/pull/6239 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] fjy closed pull request #6241: [Backport] SQL: Remove useless boolean CASTs in filters.

2018-08-26 Thread GitBox
fjy closed pull request #6241: [Backport] SQL: Remove useless boolean CASTs in filters. URL: https://github.com/apache/incubator-druid/pull/6241 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] fjy commented on issue #6240: [Backport] SQL: Fix precision of TIMESTAMP types.

2018-08-26 Thread GitBox
fjy commented on issue #6240: [Backport] SQL: Fix precision of TIMESTAMP types. URL: https://github.com/apache/incubator-druid/pull/6240#issuecomment-416091711 @gianm there's conflicts This is an automated message from the

[GitHub] fjy closed pull request #6238: [Backport] SQL: Fix selecting BOOLEAN type in JDBC.

2018-08-26 Thread GitBox
fjy closed pull request #6238: [Backport] SQL: Fix selecting BOOLEAN type in JDBC. URL: https://github.com/apache/incubator-druid/pull/6238 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] fjy closed pull request #6237: [Backport] [SQL] Fix missing postAggregations for Timeseries and TopN

2018-08-26 Thread GitBox
fjy closed pull request #6237: [Backport] [SQL] Fix missing postAggregations for Timeseries and TopN URL: https://github.com/apache/incubator-druid/pull/6237 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] fjy closed pull request #6207: Fix timeout in KafkaSupervisorTest.testCheckpointForInactiveTaskGroup

2018-08-26 Thread GitBox
fjy closed pull request #6207: Fix timeout in KafkaSupervisorTest.testCheckpointForInactiveTaskGroup URL: https://github.com/apache/incubator-druid/pull/6207 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] gianm commented on issue #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup

2018-08-26 Thread GitBox
gianm commented on issue #6206: Fix NPE in KafkaSupervisor.checkpointTaskGroup URL: https://github.com/apache/incubator-druid/pull/6206#issuecomment-416104972 Seeing these, possibly legitimate failures? ``` Failed tests:

<    6   7   8   9   10   11   12   13   14   15   >