[GitHub] [druid] LakshSingla commented on a diff in pull request #13353: Worker retry for MSQ task

2022-12-18 Thread GitBox
LakshSingla commented on code in PR #13353: URL: https://github.com/apache/druid/pull/13353#discussion_r1051751976 ## core/src/main/java/org/apache/druid/java/util/common/function/TriConsumer.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [druid] LakshSingla commented on a diff in pull request #13353: Worker retry for MSQ task

2022-11-16 Thread GitBox
LakshSingla commented on code in PR #13353: URL: https://github.com/apache/druid/pull/13353#discussion_r1024799188 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/kernel/controller/ControllerQueryKernel.java: ## @@ -107,6 +117,19 @@ */ private

[GitHub] [druid] LakshSingla commented on a diff in pull request #13353: Worker retry for MSQ task

2022-11-16 Thread GitBox
LakshSingla commented on code in PR #13353: URL: https://github.com/apache/druid/pull/13353#discussion_r1023528416 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/RetryTask.java: ## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software

[GitHub] [druid] LakshSingla commented on a diff in pull request #13353: Worker retry for MSQ task

2022-11-15 Thread GitBox
LakshSingla commented on code in PR #13353: URL: https://github.com/apache/druid/pull/13353#discussion_r1023468190 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/kernel/controller/ControllerQueryKernel.java: ## @@ -546,4 +614,65 @@ private static Map>

[GitHub] [druid] LakshSingla commented on a diff in pull request #13353: Worker retry for MSQ task

2022-11-15 Thread GitBox
LakshSingla commented on code in PR #13353: URL: https://github.com/apache/druid/pull/13353#discussion_r1023465226 ## docs/multi-stage-query/reference.md: ## @@ -265,7 +268,9 @@ The following table describes error codes you may encounter in the `multiStageQu |

[GitHub] [druid] LakshSingla commented on a diff in pull request #13353: Worker retry for MSQ task

2022-11-15 Thread GitBox
LakshSingla commented on code in PR #13353: URL: https://github.com/apache/druid/pull/13353#discussion_r1022617563 ## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/Limits.java: ## @@ -58,4 +58,14 @@ * Maximum size of the kernel manipulation queue