[GitHub] [incubator-echarts] susiwen8 edited a comment on pull request #12947: Tooltip
susiwen8 edited a comment on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661654745 > @susiwen8 It's beautiful! > > Is it default to have a red border? I'm not sure about the design. Perhaps @Wdingding can take a loot? No, red border color on screenShot that's because the red series was the closest one to cursor in those case @pissang This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12947: Tooltip
susiwen8 commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661654745 > @susiwen8 It's beautiful! > > Is it default to have a red border? I'm not sure about the design. Perhaps @Wdingding can take a loot? No, red border color on screenShot that's because the red series was the closest one to cursor in those case This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch optimize-style updated: fix(export): add back echarts.format.getTextRect
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch optimize-style
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/optimize-style by this push:
new 41ba157 fix(export): add back echarts.format.getTextRect
41ba157 is described below
commit 41ba15732a8f3ce0ad75feabbc4fff78d95994d6
Author: pissang
AuthorDate: Tue Jul 21 14:07:32 2020 +0800
fix(export): add back echarts.format.getTextRect
---
src/legacy/getTextRect.ts | 50 +++
src/util/format.ts| 3 +++
2 files changed, 53 insertions(+)
diff --git a/src/legacy/getTextRect.ts b/src/legacy/getTextRect.ts
new file mode 100644
index 000..d656baf
--- /dev/null
+++ b/src/legacy/getTextRect.ts
@@ -0,0 +1,50 @@
+/*
+* Licensed to the Apache Software Foundation (ASF) under one
+* or more contributor license agreements. See the NOTICE file
+* distributed with this work for additional information
+* regarding copyright ownership. The ASF licenses this file
+* to you under the Apache License, Version 2.0 (the
+* "License"); you may not use this file except in compliance
+* with the License. You may obtain a copy of the License at
+*
+* http://www.apache.org/licenses/LICENSE-2.0
+*
+* Unless required by applicable law or agreed to in writing,
+* software distributed under the License is distributed on an
+* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+* KIND, either express or implied. See the License for the
+* specific language governing permissions and limitations
+* under the License.
+*/
+
+import { Text } from '../util/graphic';
+import { deprecateLog } from '../util/log';
+
+type TextStyleProps = Text['style'];
+export function getTextRect(
+text: TextStyleProps['text'],
+font?: TextStyleProps['font'],
+align?: TextStyleProps['align'],
+verticalAlign?: TextStyleProps['verticalAlign'],
+padding?: TextStyleProps['padding'],
+rich?: TextStyleProps['rich'],
+truncate?: boolean,
+lineHeight?: number
+) {
+deprecateLog('getTextRect is deprecated.');
+
+const textEl = new Text({
+style: {
+text,
+font,
+align,
+verticalAlign,
+padding,
+rich,
+overflow: truncate ? 'truncate' : null,
+lineHeight
+}
+});
+
+return textEl.getBoundingRect();
+}
\ No newline at end of file
diff --git a/src/util/format.ts b/src/util/format.ts
index 8a5b152..3317bab 100644
--- a/src/util/format.ts
+++ b/src/util/format.ts
@@ -262,3 +262,6 @@ export function windowOpen(link: string, target: string):
void {
window.open(link, target);
}
}
+
+
+export {getTextRect} from '../legacy/getTextRect';
\ No newline at end of file
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12947: Tooltip
susiwen8 commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661652463 @100pah Sure, I'll fix those soon This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Gavin-Gong commented on issue #12293: X轴上的分割线splitLine属性interval formatter函数控制显示，右边多出一条分割线
Gavin-Gong commented on issue #12293: URL: https://github.com/apache/incubator-echarts/issues/12293#issuecomment-661650940 基于4.8 的代码 & #12595 的 PR 修复，临时发布一个 npm 包 `@moon-land/echarts`，暂时过渡 使用 ``` npm i @moon-land/echarts ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] 100pah commented on pull request #12947: Tooltip
100pah commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661650537 @susiwen8 Do you mind upgrade about these below: When performing regression testing on the existing test cases (`test/*tooltip*`) and new test case (`test/new-tooltip.html`), I found some defects: ## Tooltip position issue The position is not appropriate in some case: `test/tooltip-appendToBody.html`  The tooltip is far out of the current chart instance, too high. (That is not about the css 3d) `test/new-tooltip.html`  ## Arrow position issue `test/new-tooltip.html` Use the first demo as an exmaple: Set the `grid.bottom: 0`, and set `tooltip.confine: true`, which confine the tooltip not overflow the DOM of the current chart instance. The arrow becoming wrong.  Aslo, set `grid.right: 10`, and set `tooltip.confine: true`, the arrow is also incorrect.  `tooltip.confine` is useful when there are some `overflow:hidden` setting on the any of the ancestors of the main DOM. So I think it should better to add this test case to `test/new-tooltip.html`. Is indeed an issue that the location of the tooltip body might makes the "center-vertical" arrow impossible to point to the target point. In this case, I think there probably these solutions: (A) do not show arrow. (recommended) Simple but not consistent (but I think that result can be accepted). (B) make a "oblique" arrow. Not easy to implement, especially consider the different customized style of the tooltip. I think not need to bring that complex.  (C) make a "oblique line" instead of arrow. Easier than (B) but still not consistent.  What's your opinion @Wdingding @susiwen8 @pissang @Ovilia ? ## Do not show tooltip when return `null`/`undefined` Previously, then `tooltip.formatter` return `null`/`undefined`, tooltip will not be displayed any more. But currently, it is displayed as:  I think we should better not do that break change. ## Content layout issue In these cases in `test/new-tooltip.html`: The text is not at the `vertical middle` of the tooltip, which is not good.    In this case below, the gap is too small. (The upper texts and the lower texts are from different series, should have a larger gap than the title and data in a single series)  Because that is a "default style" of tooltip, it could be used in most of the product scenario. So it is checked carefully. ( @Wdingding what's your opinion about that? ) ## About the setting to show arrow In the current commit: > When trigger was item and position is top | bottom | left | right, Tooltip will show arrow and it points to current series But I doubt that in most cases, users will not set `tooltip.position` as top | bottom | left | right . Thus in most cases, arrow will not be displayed. @Wdingding @pissang is it OK for that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #12947: Tooltip
pissang edited a comment on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661647527 @susiwen8 It's beautiful! Is it default to have a red border? I'm not sure about the design. Perhaps @Wdingding can take a loot? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #12947: Tooltip
pissang edited a comment on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661647527 @susiwen8 It's beautiful! Is it default to have a red border? I'm not sure about the design This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12947: Tooltip
pissang commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661647527 @susiwen8 It's beautiful! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #12998: Add fill color for Pie label
pissang edited a comment on pull request #12998: URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661647153 @susiwen8 Not sure about `labelLine` yet. It won't be as bad as text when using light colors. And we need to use `labelLine` to connect the label and sector. In this case, color will help. But I have to admit that `labelLine` with gray color is also very nice. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 closed pull request #12998: Add fill color for Pie label
susiwen8 closed pull request #12998: URL: https://github.com/apache/incubator-echarts/pull/12998 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12998: Add fill color for Pie label
pissang commented on pull request #12998: URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661647153 @susiwen8 Not sure about `labelLine` yet. But it won't be as bad as text when using light colors. And we need to use `labelLine` to connect the label and sector. In this case, color will help. But I have to admit that `labelLine` with gray color is also very nice. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch optimize-style updated: fix(lines): fix unexpected fill in polyline
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch optimize-style
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/optimize-style by this push:
new 3ac3175 fix(lines): fix unexpected fill in polyline
3ac3175 is described below
commit 3ac3175cfa287b34d51c8840be8fedb125ed2b7d
Author: pissang
AuthorDate: Tue Jul 21 13:38:17 2020 +0800
fix(lines): fix unexpected fill in polyline
---
src/chart/helper/Polyline.ts | 1 +
src/component/visualMap/ContinuousView.ts | 7 ---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/chart/helper/Polyline.ts b/src/chart/helper/Polyline.ts
index 4b3d011..29d0715 100644
--- a/src/chart/helper/Polyline.ts
+++ b/src/chart/helper/Polyline.ts
@@ -68,6 +68,7 @@ class Polyline extends graphic.Group {
hoverLineStyle = itemModel.getModel(['emphasis',
'lineStyle']).getLineStyle();
}
line.useStyle(lineData.getItemVisual(idx, 'style'));
+line.style.fill = null;
line.style.strokeNoScale = true;
const lineEmphasisState = line.ensureState('emphasis');
diff --git a/src/component/visualMap/ContinuousView.ts
b/src/component/visualMap/ContinuousView.ts
index 708f819..2b952cd 100644
--- a/src/component/visualMap/ContinuousView.ts
+++ b/src/component/visualMap/ContinuousView.ts
@@ -258,8 +258,9 @@ class ContinuousView extends VisualMapView {
-handleSize / 2, -handleSize / 2, handleSize, handleSize,
null, true
);
+const cursor = getCursor(this._orient);
handleThumb.attr({
-cursor: getCursor(this._orient),
+cursor: cursor,
draggable: true,
drift: onDrift,
ondragend: onDragEnd,
@@ -287,6 +288,7 @@ class ContinuousView extends VisualMapView {
// group (according to handleLabelPoint) but not barGroup.
const textStyleModel = this.visualMapModel.textStyleModel;
const handleLabel = new graphic.Text({
+cursor: cursor,
draggable: true,
drift: onDrift,
onmousemove(e) {
@@ -590,8 +592,7 @@ class ContinuousView extends VisualMapView {
const val = linearMap(handleEnds[handleIndex], [0, itemSize[1]],
dataExtent, true);
const symbolSize = this.getControllerVisual(val, 'symbolSize') as
number;
-const size = parsePercent(visualMapModel.get('handleSize'),
symbolSize);
-handleThumb.scaleX = handleThumb.scaleY = size / itemSize[0];
+handleThumb.scaleX = handleThumb.scaleY = symbolSize / itemSize[0];
handleThumb.x = itemSize[0] - symbolSize / 2;
// Update handle label position.
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12947: Tooltip
susiwen8 commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661637238 `legendDesc`  `legendAsc`  `valueDesc`  `valueAsc`  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13001: x-axis renders series multiple times
echarts-bot[bot] commented on issue #13001: URL: https://github.com/apache/incubator-echarts/issues/13001#issuecomment-661632832 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] praveenchandkasarla opened a new issue #13001: x-axis renders series multiple times
praveenchandkasarla opened a new issue #13001: URL: https://github.com/apache/incubator-echarts/issues/13001 ### Version 4.8.0 ### Steps to reproduce I have 2 x-axis, 1 y-axis and 2 series even after adding xAxisIndex same series is rendered twice everytime. Will impact performance. ### What is expected? xAxisIndex:0 in series is not working as expected ### What is actually happening? xAxisIndex:0 in series is not working as expected This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch optimize-style updated: feat(visualMap): optimize indicator and handle in symbolSize visual mapping
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch optimize-style
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/optimize-style by this push:
new 9a665c5 feat(visualMap): optimize indicator and handle in symbolSize
visual mapping
9a665c5 is described below
commit 9a665c51d2aeaa27f4b5be1a19d5e4cd4f49c776
Author: pissang
AuthorDate: Tue Jul 21 11:12:17 2020 +0800
feat(visualMap): optimize indicator and handle in symbolSize visual mapping
---
src/component/dataZoom/SliderZoomView.ts | 14 +++-
src/component/visualMap/ContinuousModel.ts | 10 ++-
src/component/visualMap/ContinuousView.ts | 108 ++---
src/util/graphic.ts| 1 -
src/util/symbol.ts | 2 +-
test/visualMap-scatter-symbolSize.html | 1 +
6 files changed, 105 insertions(+), 31 deletions(-)
diff --git a/src/component/dataZoom/SliderZoomView.ts
b/src/component/dataZoom/SliderZoomView.ts
index e6f0e22..d775d67 100644
--- a/src/component/dataZoom/SliderZoomView.ts
+++ b/src/component/dataZoom/SliderZoomView.ts
@@ -38,7 +38,9 @@ import SeriesModel from '../../model/Series';
import { AxisBaseModel } from '../../coord/AxisBaseModel';
import { getAxisMainType, collectReferCoordSysModelInfo } from './helper';
import { enableHoverEmphasis } from '../../util/states';
-import { createSymbol } from '../../util/symbol';
+import { createSymbol, symbolBuildProxies } from '../../util/symbol';
+import { deprecateLog } from '../../util/log';
+import { __DEV__ } from '../../config';
const Rect = graphic.Rect;
@@ -490,8 +492,16 @@ class SliderZoomView extends DataZoomView {
}));
each([0, 1] as const, function (handleIndex) {
+let iconStr = dataZoomModel.get('handleIcon');
+if (!symbolBuildProxies[iconStr] && iconStr.indexOf('path://') <
0) {
+// Compatitable with the old icon parsers. Which can use a
path string without path://
+iconStr = 'path://' + iconStr;
+if (__DEV__) {
+deprecateLog('handleIcon now needs \'path://\' prefix when
using a path string');
+}
+}
const path = createSymbol(
-dataZoomModel.get('handleIcon'),
+iconStr,
-1, 0, 2, 2, null, true
) as graphic.Path;
path.attr({
diff --git a/src/component/visualMap/ContinuousModel.ts
b/src/component/visualMap/ContinuousModel.ts
index 9bfae76..5759d5f 100644
--- a/src/component/visualMap/ContinuousModel.ts
+++ b/src/component/visualMap/ContinuousModel.ts
@@ -146,7 +146,7 @@ class ContinuousModel extends
VisualMapModel {
zrUtil.each(this.stateList, function (state: VisualState) {
const symbolSize = this.option.controller[state].symbolSize;
if (symbolSize && symbolSize[0] !== symbolSize[1]) {
-symbolSize[0] = 0; // For good looking.
+symbolSize[0] = symbolSize[1] / 3; // For good looking.
}
}, this);
}
@@ -286,14 +286,18 @@ class ContinuousModel extends
VisualMapModel {
handleStyle: {
borderColor: '#fff',
-borderWidth: 2
+borderWidth: 1
},
indicatorIcon: 'circle',
indicatorSize: '50%',
indicatorStyle: {
borderColor: '#fff',
-borderWidth: 2
+borderWidth: 2,
+shadowBlur: 2,
+shadowOffsetX: 1,
+shadowOffsetY: 1,
+shadowColor: 'rgba(0,0,0,0.2)'
}
// emphasis: {
// handleStyle: {
diff --git a/src/component/visualMap/ContinuousView.ts
b/src/component/visualMap/ContinuousView.ts
index 878e057..708f819 100644
--- a/src/component/visualMap/ContinuousView.ts
+++ b/src/component/visualMap/ContinuousView.ts
@@ -35,7 +35,7 @@ import Element, { ElementEvent } from 'zrender/src/Element';
import { TextVerticalAlign, TextAlign } from 'zrender/src/core/types';
import { ColorString, Payload } from '../../util/types';
import { parsePercent } from 'zrender/src/contain/text';
-import { setAsHighDownDispatcher } from '../../util/states';
+import { setAsHighDownDispatcher, enterBlur, leaveBlur } from
'../../util/states';
import { createSymbol } from '../../util/symbol';
const linearMap = numberUtil.linearMap;
@@ -104,6 +104,8 @@ class ContinuousView extends VisualMapView {
private _hovering: boolean;
+private _firstShowIndicator: boolean;
+
doRender(
visualMapModel: ContinuousModel,
@@ -250,10 +252,10 @@ class ContinuousView extends VisualMapView {
) {
const onDrift = zrUtil.bind(this._dragHandle, this, handleIndex,
false);
const onDragEnd = zrUtil.bind(this._dragHandle, this, handleIndex,
true);
-const scale = parseP
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12947: Tooltip
susiwen8 commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661621014 > Excellent job! > A small advice on the naming of `order`: may consider `'valueDesc'`, `'valueAsc'`, `'legendDesc'`, `'legendAsc'`. Right away This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Ovilia commented on pull request #12947: Tooltip
Ovilia commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661612213 Excellent job! A small advice on the naming of `order`: may consider `'valueDesc'`, `'valueAsc'`, `'legendDesc'`, `'legendAsc'`. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Gavin-Gong commented on issue #12293: X轴上的分割线splitLine属性interval formatter函数控制显示，右边多出一条分割线
Gavin-Gong commented on issue #12293: URL: https://github.com/apache/incubator-echarts/issues/12293#issuecomment-661611821 4.8.0 出现同样的问题，我看已经有大佬提了 Pull Request，加了 test，什么时候 merge 呢？@pissang This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #12947: Tooltip
pissang edited a comment on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661608153 Wonderful work! The screenshots look nice! We should make it merged before alpha release Also, do you mind describing the features like `order` in more detail with screenshots? It will make it easier for us to organize the features in the release article This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #12947: Tooltip
pissang edited a comment on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661608153 Wonderful work! The screenshots look nice! We should make it merged before alpha release This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12947: Tooltip
pissang commented on pull request #12947: URL: https://github.com/apache/incubator-echarts/pull/12947#issuecomment-661608153 Wonderful work! The screenshots look nice! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12998: Add fill color for Pie label
susiwen8 commented on pull request #12998: URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661607460 And `lableline`? Should those be dark too? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 edited a comment on pull request #12998: Add fill color for Pie label
susiwen8 edited a comment on pull request #12998: URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661607460 And `lableline`? Should those be dark too? @pissang This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #12991: fix(heatmap) Skip rendering for data out of axis content in heatmap (#12969)
pissang merged pull request #12991: URL: https://github.com/apache/incubator-echarts/pull/12991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12991: fix(heatmap) Skip rendering for data out of axis content in heatmap (#12969)
pissang commented on pull request #12991: URL: https://github.com/apache/incubator-echarts/pull/12991#issuecomment-661607114 LGTM now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12991: fix(heatmap) Skip rendering for data out of axis content in heatmap (#12969)
echarts-bot[bot] commented on pull request #12991: URL: https://github.com/apache/incubator-echarts/pull/12991#issuecomment-661607152 Congratulations! Your PR has been merged. Thanks for your contribution! 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch next updated (2db82f8 -> 39bd739)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch next in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from 2db82f8 Merge pull request #12925 from apache/state new 493f54c fix #12969 - Skip rendering for data out of axis content in heatmap new f8031ef Update HeatmapView.ts according to code review comment new 39bd739 Merge pull request #12991 from quillblue/fix-12969 The 6236 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: src/chart/heatmap/HeatmapView.ts | 18 +++- test/heatmap.html| 218 +-- 2 files changed, 154 insertions(+), 82 deletions(-) - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12997: fix(dataSample): negative size
echarts-bot[bot] commented on pull request #12997: URL: https://github.com/apache/incubator-echarts/pull/12997#issuecomment-661606473 Congratulations! Your PR has been merged. Thanks for your contribution! 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch master updated: fix(dataSample): negative size
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/master by this push:
new 75b6506 fix(dataSample): negative size
new c1e3a78 Merge pull request #12997 from SnailSword/master
75b6506 is described below
commit 75b650613d18f8a52b5647abcbed5f0cee0c57cd
Author: saniac
AuthorDate: Mon Jul 20 23:24:04 2020 +0800
fix(dataSample): negative size
---
src/processor/dataSample.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/processor/dataSample.js b/src/processor/dataSample.js
index 1fef0df..5097718 100644
--- a/src/processor/dataSample.js
+++ b/src/processor/dataSample.js
@@ -83,7 +83,7 @@ export default function (seriesType) {
var valueAxis = coordSys.getOtherAxis(baseAxis);
var extent = baseAxis.getExtent();
// Coordinste system has been resized
-var size = extent[1] - extent[0];
+var size = Math.abs(extent[1] - extent[0]);
var rate = Math.round(data.count() / size);
if (rate > 1) {
var sampler;
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang merged pull request #12997: fix(dataSample): negative size
pissang merged pull request #12997: URL: https://github.com/apache/incubator-echarts/pull/12997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12998: Add fill color for Pie label
pissang commented on pull request #12998: URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661606125 Using dark colors in labels is by design. Because the new color theme may be too bright for displaying labels. Developers can still write `color: 'inherit'` to use the color of the sector. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] cyang52 opened a new issue #13000: 为tooltip 循环添加新的元素无效问题
cyang52 opened a new issue #13000:
URL: https://github.com/apache/incubator-echarts/issues/13000
### Version
4.6.0
### Steps to reproduce
假设有这么一组数据：
var name1 = ['ww','22','ee'];
我想将这个数据循环添加进tooltip 里，使用for 循环只能添加进入第一个元素：
for (let i = 0; i <3; i ){
..
return '' obj.seriesName name1[i] ''
..
}
### What is expected?
将data1 中的元素添加进tooptip
### What is actually happening?
只能添加进第一个（‘ww’）
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #13000: 为tooltip 循环添加新的元素无效问题
echarts-bot[bot] commented on issue #13000: URL: https://github.com/apache/incubator-echarts/issues/13000#issuecomment-661559864 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] yvv11520 opened a new issue #12999: series.bar.label 及 series.line.label 点击无效
yvv11520 opened a new issue #12999: URL: https://github.com/apache/incubator-echarts/issues/12999 ### Version 4.8.0 ### Reproduction link [https://gallery.echartsjs.com/editor.html?c=xyfKams4BO&v=1](https://gallery.echartsjs.com/editor.html?c=xyfKams4BO&v=1) ### Steps to reproduce 点击拆线文字区域 ### What is expected? 显示 alert ### What is actually happening? 无法进行点击事件 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12999: series.bar.label 及 series.line.label 点击无效
echarts-bot[bot] commented on issue #12999: URL: https://github.com/apache/incubator-echarts/issues/12999#issuecomment-661551544 Hi! We've received your issue and please be patient to get responded. 🎉 The average response time is expected to be within one day for weekdays. In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer. If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to d...@echarts.apache.org. Please attach the issue link if it's a technical questions. If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html). Have a nice day! 🍵 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12998: Add fill color for Pie label
echarts-bot[bot] commented on pull request #12998: URL: https://github.com/apache/incubator-echarts/pull/12998#issuecomment-661127677 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 opened a new pull request #12998: Add fill color for Pie label
susiwen8 opened a new pull request #12998: URL: https://github.com/apache/incubator-echarts/pull/12998 ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? Fix pie label color ### Fixed issues ## Details ### Before: What was the problem? https://user-images.githubusercontent.com/20318608/87958877-a94d6f80-cae4-11ea-83b9-055a79883f0b.png";> ### After: How is it fixed in this PR? https://user-images.githubusercontent.com/20318608/87958859-a2266180-cae4-11ea-83f0-926c33f9d4d6.png";> ## Usage ### Are there any API changes? - [ ] The API has been changed. ### Related test cases or examples to use the new APIs NA. ## Others ### Merging options - [ ] Please squash the commits into a single one when merge. ### Other information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] SnailSword opened a new pull request #12997: fix(dataSample): negative size
SnailSword opened a new pull request #12997: URL: https://github.com/apache/incubator-echarts/pull/12997 ## Brief Information This pull request is in the type of: - [x] bug fixing - [ ] new feature - [ ] others ### What does this PR do? Data sampling doesn't work when `size` in `dataSample` is negative. ### Fixed issues NA. ## Details ### Before: What was the problem? e.g. In `line-large.html` and `largeLine.html`, data sampling doesn't work because `extent[1] - extent[0]` is negative. ### After: How is it fixed in this PR? Fixed. ## Usage ### Are there any API changes? - [ ] The API has been changed. ### Related test cases or examples to use the new APIs NA. ## Others ### Merging options - [ ] Please squash the commits into a single one when merge. ### Other information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12997: fix(dataSample): negative size
echarts-bot[bot] commented on pull request #12997: URL: https://github.com/apache/incubator-echarts/pull/12997#issuecomment-661115521 Thanks for your contribution! The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Nick22nd commented on issue #11508: Day label is drifting on the left when calendar range is getting smaller
Nick22nd commented on issue #11508: URL: https://github.com/apache/incubator-echarts/issues/11508#issuecomment-661073610 The issue as I tracking： If orient is horizontal and range changes, the cell will automatically adjust its width. But the weekly text margin is always equalling 50% width of cellSize. I tried to fix it by making daylabel margin always be the cell's height . It seems that the issue will be fixed. But I have 2 problem: 1. I don't know whether it will cause another issue. 2. I only changed 1 line code ,should I make a PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] branch optimize-style updated: feat(visualMap): optimize visualMap style. add several styling config
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch optimize-style
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
The following commit(s) were added to refs/heads/optimize-style by this push:
new aea2fbf feat(visualMap): optimize visualMap style. add several
styling config
aea2fbf is described below
commit aea2fbf9422f4cc1a74106deb07469c387505205
Author: pissang
AuthorDate: Mon Jul 20 20:22:35 2020 +0800
feat(visualMap): optimize visualMap style. add several styling config
Added handleIcon, handleSize, handleStyle, indicatorIcon, indicatorSize,
indicatorStyle, emphasis.handleStyle
---
src/component/dataZoom/SliderZoomModel.ts | 17 ++--
src/component/dataZoom/SliderZoomView.ts | 29 ---
src/component/visualMap/ContinuousModel.ts | 42 -
src/component/visualMap/ContinuousView.ts | 131 ++---
src/util/graphic.ts| 1 +
5 files changed, 144 insertions(+), 76 deletions(-)
diff --git a/src/component/dataZoom/SliderZoomModel.ts
b/src/component/dataZoom/SliderZoomModel.ts
index 854a3f1..c31dcca 100644
--- a/src/component/dataZoom/SliderZoomModel.ts
+++ b/src/component/dataZoom/SliderZoomModel.ts
@@ -123,13 +123,16 @@ class SliderZoomModel extends
DataZoomModel {
left: null, // Default align to grid rect.
bottom: null, // Default align to grid rect.
+borderColor: '#d2dbee',
+borderRadius: 3,
+
backgroundColor: 'rgba(47,69,84,0)',// Background of slider zoom
component.
// dataBackgroundColor: '#ddd',
dataBackground: {
lineStyle: {
color: '#d2dbee',
-width: 1
+width: 0.5
},
areaStyle: {
color: '#d2dbee',
@@ -139,7 +142,8 @@ class SliderZoomModel extends
DataZoomModel {
selectedDataBackground: {
lineStyle: {
-color: '#8fb0f7'
+color: '#8fb0f7',
+width: 0.5
},
areaStyle: {
color: '#8fb0f7',
@@ -147,11 +151,9 @@ class SliderZoomModel extends
DataZoomModel {
}
},
-borderColor: '#d2dbee',
-borderRadius: 3,
fillerColor: 'rgba(135,175,274,0.2)', // Color of selected area.
-handleIcon:
'path://M-40.23,4.23h4.1c.56,0,1,.65,1,1.46V32.05c0,.81-.46,1.46-1,1.46h-4.1c-.57,0-1-.65-1-1.46V5.69C-41.26,4.88-40.8,4.23-40.23,4.23Zm2-4.85V4.23m0,29.28v4.84',
+handleIcon:
'path://M-9.35,34.56V42m0-40V9.5m-2,0h4a2,2,0,0,1,2,2v21a2,2,0,0,1-2,2h-4a2,2,0,0,1-2-2v-21A2,2,0,0,1-11.35,9.5Z',
// Percent of the slider height
handleSize: '100%',
@@ -172,10 +174,7 @@ class SliderZoomModel extends
DataZoomModel {
emphasis: {
handleStyle: {
borderColor: '#8FB0F7',
-shadowBlur: 2,
-shadowOffsetX: 1,
-shadowOffsetY: 1,
-shadowColor: 'rgba(0,0,0,0.1)'
+borderWidth: 2
}
}
});
diff --git a/src/component/dataZoom/SliderZoomView.ts
b/src/component/dataZoom/SliderZoomView.ts
index 92c1b33..e6f0e22 100644
--- a/src/component/dataZoom/SliderZoomView.ts
+++ b/src/component/dataZoom/SliderZoomView.ts
@@ -38,6 +38,7 @@ import SeriesModel from '../../model/Series';
import { AxisBaseModel } from '../../coord/AxisBaseModel';
import { getAxisMainType, collectReferCoordSysModelInfo } from './helper';
import { enableHoverEmphasis } from '../../util/states';
+import { createSymbol } from '../../util/symbol';
const Rect = graphic.Rect;
@@ -51,10 +52,9 @@ const LABEL_GAP = 5;
const SHOW_DATA_SHADOW_SERIES_TYPE = ['line', 'bar', 'candlestick', 'scatter'];
-type Icon = ReturnType;
interface Displayables {
sliderGroup: graphic.Group;
-handles: [Icon, Icon];
+handles: [graphic.Path, graphic.Path];
handleLabels: [graphic.Text, graphic.Text];
dataShadowSegs: graphic.Group[];
filler: graphic.Rect;
@@ -285,6 +285,8 @@ class SliderZoomView extends DataZoomView {
private _renderDataShadow() {
const info = this._dataShadowInfo = this._prepareDataShadowInfo();
+this._displayables.dataShadowSegs = [];
+
if (!info) {
return;
}
@@ -297,8 +299,6 @@ class SliderZoomView extends DataZoomView {
? seriesModel.getShadowDim() // @see candlestick
: info.otherDim;
-this._displayables.dataShadowSegs = [];
-
if (otherDim == null) {
return;
}
@@ -490,18 +490,18 @@ class SliderZoomView extends DataZoomView {
}));
each([0, 1] as const, function (handleIndex) {
-const path = graphic.createIcon(
+const path = createSymbol(
dataZoomModel.get('handleIcon'),
-{
-
[incubator-echarts] branch time-formatter updated (e0f0584 -> a14c8cd)
This is an automated email from the ASF dual-hosted git repository. ovilia pushed a change to branch time-formatter in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. from e0f0584 feat(time): label style for different levels and units add 0466be2 feat(time): fix time axis extent add a14c8cd feat(time): level formatters No new revisions were added by this update. Summary of changes: src/coord/axisDefault.ts | 13 +- src/scale/Time.ts | 349 +- src/util/time.ts | 90 +++ test/timeScale-formatter.html | 253 ++ test/timeScale.html | 34 ++-- 5 files changed, 511 insertions(+), 228 deletions(-) create mode 100644 test/timeScale-formatter.html - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] wp56610 closed issue #12994: 同时设置css 和 行内样式时, tooltip 样式错误
wp56610 closed issue #12994: URL: https://github.com/apache/incubator-echarts/issues/12994 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] wp56610 commented on issue #12994: 同时设置css 和 行内样式时, tooltip 样式错误
wp56610 commented on issue #12994: URL: https://github.com/apache/incubator-echarts/issues/12994#issuecomment-660940790 thanks, 学到了 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[incubator-echarts] 01/01: feat(dataZoom): optimize style. add borderRadius, selectedDataBackground
This is an automated email from the ASF dual-hosted git repository.
shenyi pushed a commit to branch optimize-style
in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git
commit 30c00f445be26079083258a70ac7f89550779e34
Author: pissang
AuthorDate: Mon Jul 20 18:11:59 2020 +0800
feat(dataZoom): optimize style. add borderRadius, selectedDataBackground
---
src/component/dataZoom/SliderZoomModel.ts | 61 ++
src/component/dataZoom/SliderZoomView.ts | 104 +-
2 files changed, 124 insertions(+), 41 deletions(-)
diff --git a/src/component/dataZoom/SliderZoomModel.ts
b/src/component/dataZoom/SliderZoomModel.ts
index 6165d0a..854a3f1 100644
--- a/src/component/dataZoom/SliderZoomModel.ts
+++ b/src/component/dataZoom/SliderZoomModel.ts
@@ -53,11 +53,21 @@ export interface SliderDataZoomOption extends
DataZoomOption, BoxLayoutOptionMix
*/
borderColor?: ZRColor
+/**
+ * Border radius of the box.
+ */
+borderRadius?: number | number[]
+
dataBackground?: {
lineStyle?: LineStyleOption
areaStyle?: AreaStyleOption
}
+selectedDataBackground?: {
+lineStyle?: LineStyleOption
+areaStyle?: AreaStyleOption
+}
+
/**
* Color of selected area.
*/
@@ -71,7 +81,8 @@ export interface SliderDataZoomOption extends DataZoomOption,
BoxLayoutOptionMix
handleIcon?: string
/**
- * Percent of the slider height
+ * number: height of icon. width will be calculated according to the
aspect of icon.
+ * string: percent of the slider height. width will be calculated
according to the aspect of icon.
*/
handleSize?: string | number
@@ -88,6 +99,10 @@ export interface SliderDataZoomOption extends
DataZoomOption, BoxLayoutOptionMix
zoomLock?: boolean
textStyle?: LabelOption
+
+emphasis?: {
+handleStyle?: ItemStyleOption
+}
}
@@ -109,37 +124,59 @@ class SliderZoomModel extends
DataZoomModel {
bottom: null, // Default align to grid rect.
backgroundColor: 'rgba(47,69,84,0)',// Background of slider zoom
component.
+
// dataBackgroundColor: '#ddd',
dataBackground: {
lineStyle: {
-color: '#2f4554',
-width: 0.5,
-opacity: 0.3
+color: '#d2dbee',
+width: 1
},
areaStyle: {
-color: 'rgba(47,69,84,0.3)',
-opacity: 0.3
+color: '#d2dbee',
+opacity: 0.2
}
},
-borderColor: '#ddd',
-fillerColor: 'rgba(167,183,204,0.4)', // Color of selected area.
-// handleColor: 'rgba(89,170,216,0.95)', // Color of handle.
-// eslint-disable-next-line
-handleIcon:
'M8.2,13.6V3.9H6.3v9.7H3.1v14.9h3.3v9.7h1.8v-9.7h3.3V13.6H8.2z
M9.7,24.4H4.8v-1.4h4.9V24.4z M9.7,19.1H4.8v-1.4h4.9V19.1z',
+selectedDataBackground: {
+lineStyle: {
+color: '#8fb0f7'
+},
+areaStyle: {
+color: '#8fb0f7',
+opacity: 0.2
+}
+},
+
+borderColor: '#d2dbee',
+borderRadius: 3,
+
+fillerColor: 'rgba(135,175,274,0.2)', // Color of selected area.
+handleIcon:
'path://M-40.23,4.23h4.1c.56,0,1,.65,1,1.46V32.05c0,.81-.46,1.46-1,1.46h-4.1c-.57,0-1-.65-1-1.46V5.69C-41.26,4.88-40.8,4.23-40.23,4.23Zm2-4.85V4.23m0,29.28v4.84',
// Percent of the slider height
handleSize: '100%',
handleStyle: {
-color: '#a7b7cc'
+color: '#fff',
+borderColor: '#ACB8D1'
},
showDetail: true,
showDataShadow: 'auto', // Default auto decision.
realtime: true,
zoomLock: false,// Whether disable zoom.
+
textStyle: {
color: '#333'
+},
+
+emphasis: {
+handleStyle: {
+borderColor: '#8FB0F7',
+shadowBlur: 2,
+shadowOffsetX: 1,
+shadowOffsetY: 1,
+shadowColor: 'rgba(0,0,0,0.1)'
+}
}
});
}
diff --git a/src/component/dataZoom/SliderZoomView.ts
b/src/component/dataZoom/SliderZoomView.ts
index f334290..92c1b33 100644
--- a/src/component/dataZoom/SliderZoomView.ts
+++ b/src/component/dataZoom/SliderZoomView.ts
@@ -37,6 +37,7 @@ import Axis from '../../coord/Axis';
import SeriesModel from '../../model/Series';
import { AxisBaseModel } from '../../coord/AxisBaseModel';
import { getAxisMainType, collectReferCoordSysModelInfo } from './helper';
+import { enableHoverEmphasis } from '../../util/states';
const Rect = graphic.Rect;
@@ -52,9 +53,10 @@ const SHOW_DATA_SHADOW_SERIES_TYPE = ['line', 'bar',
'candlestick', 'scatter'];
type Icon = ReturnType;
interface Displayabl
[incubator-echarts] branch optimize-style created (now 30c00f4)
This is an automated email from the ASF dual-hosted git repository. shenyi pushed a change to branch optimize-style in repository https://gitbox.apache.org/repos/asf/incubator-echarts.git. at 30c00f4 feat(dataZoom): optimize style. add borderRadius, selectedDataBackground This branch includes the following new commits: new 30c00f4 feat(dataZoom): optimize style. add borderRadius, selectedDataBackground The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] plainheart commented on issue #12972: npm install not working with canvas v2.6.0
plainheart commented on issue #12972: URL: https://github.com/apache/incubator-echarts/issues/12972#issuecomment-660910934 Could you be more specific on this? If possible, it's better to provide more detailed information about the error. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] wlbksy commented on issue #8773: axis equal as in matplotlib
wlbksy commented on issue #8773: URL: https://github.com/apache/incubator-echarts/issues/8773#issuecomment-660907610 上面圆形的case没做，下面做了个正方形的例子 https://gallery.echartsjs.com/editor.html?c=xCFLh2SQxL 这个例子里面写了正方形的四个点。当绘图区域有变化时，四个点是长方形，不是正方形  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] wlbksy commented on issue #8773: axis equal as in matplotlib
wlbksy commented on issue #8773: URL: https://github.com/apache/incubator-echarts/issues/8773#issuecomment-660898694 @pissang 这个能支持一下吗？谢谢 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.
pissang commented on pull request #12993: URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660895919 LGTM, @100pah Can you think of other cases may be broken? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on pull request #12993: design(#12933): tweak the z value of axisPointer component to make it be displayed under the symbol by default.
pissang edited a comment on pull request #12993: URL: https://github.com/apache/incubator-echarts/pull/12993#issuecomment-660895919 LGTM, @100pah Can you think of other cases that may be broken? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] quillblue commented on issue #12992: 区域填充颜色重叠异常
quillblue commented on issue #12992: URL: https://github.com/apache/incubator-echarts/issues/12992#issuecomment-660859412 > > 重现了Bug，看上去是在数据里有NaN时connectNull设置为true时的一个堆叠bug（累积线没有考虑null） > > 临时的解决方案是传入数据前把非数值数据转换成0（也不是很好的过渡） > > 转换成0确实不是好办法 对的，不过在这个问题被修复之前目前想不出什么更好的临时方案了。如果你乐意为ECharts做出贡献，可以尝试自己修复这个Bug并通过PR提交给社区。 For community, please be kind to remove waiting-for tag and evaluate proper milestone & bug diffculty tag for this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] Lost-Kun commented on issue #12992: 区域填充颜色重叠异常
Lost-Kun commented on issue #12992: URL: https://github.com/apache/incubator-echarts/issues/12992#issuecomment-660850041 > 重现了Bug，看上去是在数据里有NaN时connectNull设置为true时的一个堆叠bug（累积线没有考虑null） > 临时的解决方案是传入数据前把非数值数据转换成0（也不是很好的过渡） 转换成0确实不是好办法 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] quillblue commented on issue #12996: symbolsize 值域特别大时如何保证散点图圆点大小适中
quillblue commented on issue #12996: URL: https://github.com/apache/incubator-echarts/issues/12996#issuecomment-660848348 @cyang52 试试在回调函数里用对数来算symbolSize? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] quillblue commented on issue #12992: 区域填充颜色重叠异常
quillblue commented on issue #12992: URL: https://github.com/apache/incubator-echarts/issues/12992#issuecomment-660847118 重现了Bug，看上去是在数据里有NaN时connectNull设置为true时的一个堆叠bug（累积线没有考虑null） 临时的解决方案是传入数据前把非数值数据转换成0（也不是很好的过渡） This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
[GitHub] [incubator-echarts] cyang52 commented on issue #12996: symbolsize 值域特别大时如何保证散点图圆点大小适中
cyang52 commented on issue #12996: URL: https://github.com/apache/incubator-echarts/issues/12996#issuecomment-660842965 有使用过，不过可能size 数值太大 效果不好。 比如： 1: [3453, 6214, 83008] 2: (5) [1856, 3743, 26825] 3: (5) [4242, 242, 14225] 4: (5) [4095, 110, 13698] 5: (5) [3389, 92, 8516] 6: (5) [312, 17427, 7491] 7: (5) [2312, 31, 7032] 8: (5) [2653, 563, 6853] 9: (5) [1012, 12, 2617] 10: (5) [1660, 25, 2298] 11: (5) [1073, 332, 122] 12: (5) [353, 1, 8,] 13: (5) [78, 1086, 2] 你可以看到值域从 83008～2，我的回调并不能很好满足。 我也想过if else 判断，一个范围一个回调函数 也不太行 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
