[GitHub] [incubator-echarts] plainheart edited a comment on pull request #12673: Fix #12642, add line height for axispointer

2020-05-27 Thread GitBox
plainheart edited a comment on pull request #12673: URL: https://github.com/apache/incubator-echarts/pull/12673#issuecomment-635035457 Sorry, that's only my suggestion and I thought you would finish it. Now you have closed this issue, I have to open a new one for this later. Feel free to

[GitHub] [incubator-echarts] plainheart edited a comment on pull request #12673: Fix #12642, add line height for axispointer

2020-05-27 Thread GitBox
plainheart edited a comment on pull request #12673: URL: https://github.com/apache/incubator-echarts/pull/12673#issuecomment-634829856 Hi~ @susiwen8 Thanks for your fixing. I've been inspired by following code lines from @Ovilia ~ Maybe we can make some changes like this

[GitHub] [incubator-echarts] plainheart edited a comment on pull request #12673: Fix #12642, add line height for axispointer

2020-05-27 Thread GitBox
plainheart edited a comment on pull request #12673: URL: https://github.com/apache/incubator-echarts/pull/12673#issuecomment-634829856 Hi~ @susiwen8 Thanks for your fixing. I've been inspired by following code lines from @Ovilia ~ Maybe we can make some changes like this

[GitHub] [incubator-echarts] plainheart edited a comment on pull request #12673: Fix #12642, add line height for axispointer

2020-05-20 Thread GitBox
plainheart edited a comment on pull request #12673: URL: https://github.com/apache/incubator-echarts/pull/12673#issuecomment-631847964 In fact, I did a test about this a few days ago and the result is that besides `lineHeight`, there are more properties are invalid for