vorburger commented on a change in pull request #1466:
URL: https://github.com/apache/fineract/pull/1466#discussion_r512955911
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/hooks/processor/ElasticSearchHookProcessor.java
##
@@ -0,0 +1,88 @@
This is an automated email from the ASF dual-hosted git repository.
avikg pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 0a41cdc FINERACT-1241-elastic-web-hook
avikganguly01 merged pull request #1466:
URL: https://github.com/apache/fineract/pull/1466
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
avikganguly01 commented on a change in pull request #1466:
URL: https://github.com/apache/fineract/pull/1466#discussion_r512773604
##
File path:
fineract-provider/src/main/java/org/apache/fineract/commands/service/SynchronousCommandProcessingService.java
##
@@ -205,18 +225,80
vidakovic commented on pull request #1422:
URL: https://github.com/apache/fineract/pull/1422#issuecomment-717139983
@vorburger I would merge as is, can't really hurt. And maybe it motivates
someone to contribute a little sample to illustrate how this is supposed to be
used... or I find
vidakovic commented on pull request #1444:
URL: https://github.com/apache/fineract/pull/1444#issuecomment-717137108
> @ptuomola @vidakovic I'm undecided / unclear where we should take this
to.. thoughts? I guess we could... EITHER (probably best AFTER #1465 will have
gone in):
>
>
vorburger commented on pull request #1251:
URL: https://github.com/apache/fineract/pull/1251#issuecomment-717046148
@thesmallstar @ptuomola where were we with this one? Good to merge as-is, or
updates needed? (Perhaps best to rebase it now.)
vorburger commented on pull request #1156:
URL: https://github.com/apache/fineract/pull/1156#issuecomment-717045470
@thesmallstar ping on this?
This is an automated message from the Apache Git Service.
To respond to the
vorburger commented on pull request #1444:
URL: https://github.com/apache/fineract/pull/1444#issuecomment-717040235
BTW #1422 has some related thoughts re. our testing strategy, I'll comment
over there as well.
This is an
vorburger commented on pull request #1444:
URL: https://github.com/apache/fineract/pull/1444#issuecomment-717039700
@ptuomola @vidakovic I'm undecided / unclear where we should take this to..
thoughts? I guess we could... EITHER (probably best AFTER #1465 will have gone
in):
a)
vorburger commented on a change in pull request #1444:
URL: https://github.com/apache/fineract/pull/1444#discussion_r512457801
##
File path:
fineract-provider/src/test/java/org/apache/fineract/common/RestAssuredFixture.java
##
@@ -34,14 +34,12 @@
private final int
vorburger commented on pull request #1465:
URL: https://github.com/apache/fineract/pull/1465#issuecomment-717034392
> FYI: don't think this is related to my changes; before a run was failing
on a different line (creating Docker images). Locally the integration tests
worked ok; maybe the
vorburger commented on a change in pull request #1361:
URL: https://github.com/apache/fineract/pull/1361#discussion_r512439405
##
File path:
fineract-provider/src/main/resources/sql/migrations/core_db/V327__creditbureau_configuration.sql
##
@@ -66,7 +66,7 @@ CREATE TABLE
13 matches
Mail list logo
