Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-03-28 Thread via GitHub
jdailey commented on PR #3842: URL: https://github.com/apache/fineract/pull/3842#issuecomment-2026136703 I see a failure in the build, might be unrelated. But, need to have you also check the boxes on the commit. See list and make sure all are covered. Why is the delinquency

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-03-28 Thread via GitHub
Aboya1417 commented on PR #3842: URL: https://github.com/apache/fineract/pull/3842#issuecomment-2025749731 Commits has been squashed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-03-28 Thread via GitHub
Aboya1417 commented on code in PR #3842: URL: https://github.com/apache/fineract/pull/3842#discussion_r1543289876 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java: ## @@ -474,6 +479,7

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-03-28 Thread via GitHub
adamsaghy commented on PR #3842: URL: https://github.com/apache/fineract/pull/3842#issuecomment-2025654338 @Aboya1417 Please squash your commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-03-28 Thread via GitHub
adamsaghy commented on code in PR #3842: URL: https://github.com/apache/fineract/pull/3842#discussion_r1543273267 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/accountdetails/service/AccountDetailsReadPlatformServiceJpaRepositoryImpl.java: ## @@ -474,6 +479,7

Re: [PR] FINERACT-2065: Fix schedule handling with higher fixed length value t… [fineract]

2024-03-28 Thread via GitHub
adamsaghy commented on code in PR #3836: URL: https://github.com/apache/fineract/pull/3836#discussion_r1543234638 ## fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractProgressiveLoanScheduleGenerator.java: ## @@ -181,6 +181,13

Re: [PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-03-28 Thread via GitHub
Aboya1417 commented on PR #3842: URL: https://github.com/apache/fineract/pull/3842#issuecomment-2025546339 We want the loan account summary data to contain currency as we will like to know the currencies tied to different loan products during setup. The client account endpoint 

[PR] FINERACT-2020:Added currency field to LoanAccountSummaryData, also ad… [fineract]

2024-03-28 Thread via GitHub
Aboya1417 opened a new pull request, #3842: URL: https://github.com/apache/fineract/pull/3842 …ded integration test and swagger documentation ## Description We want the loan account summary data to contain currency as we will like to know the currencies tied to different loan

Re: [PR] FINERACT-2057: JSON deserialization backward compatibility [fineract]

2024-03-28 Thread via GitHub
adamsaghy merged PR #3840: URL: https://github.com/apache/fineract/pull/3840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(fineract) branch develop updated: FINERACT-2057: JSON deserialization backward compatibility

2024-03-28 Thread adamsaghy
This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 5fa2295bd FINERACT-2057: JSON

Re: [PR] FINERACT-2057: JSON deserialization backward compatibility [fineract]

2024-03-28 Thread via GitHub
reluxa commented on code in PR #3840: URL: https://github.com/apache/fineract/pull/3840#discussion_r1543041900 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBFilterHelper.java: ## @@ -259,4 +261,10 @@ private List getLoanIdList(String

Re: [PR] FINERACT-2057: JSON deserialization backward compatibility [fineract]

2024-03-28 Thread via GitHub
reluxa commented on code in PR #3840: URL: https://github.com/apache/fineract/pull/3840#discussion_r1543039722 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/filter/LoanCOBFilterHelper.java: ## @@ -259,4 +261,10 @@ private List getLoanIdList(String

[PR] FINERACT-1971: use KeyHolder instead of LASTVAL/LAST_INSERT_ID [fineract]

2024-03-28 Thread via GitHub
adamsaghy opened a new pull request, #3841: URL: https://github.com/apache/fineract/pull/3841 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[PR] FINERACT-2057: JSON deserialization backward compatibility [fineract]

2024-03-28 Thread via GitHub
reluxa opened a new pull request, #3840: URL: https://github.com/apache/fineract/pull/3840 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

(fineract) branch develop updated: Bump actions/checkout from 4.1.1 to 4.1.2

2024-03-28 Thread arnold
This is an automated email from the ASF dual-hosted git repository. arnold pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 444df1bbb Bump actions/checkout from 4.1.1

Re: [PR] Bump actions/checkout from 4.1.1 to 4.1.2 [fineract]

2024-03-28 Thread via GitHub
galovics merged PR #3837: URL: https://github.com/apache/fineract/pull/3837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(fineract) branch dependabot/github_actions/actions/checkout-4.1.2 deleted (was b4f5edfc4)

2024-03-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/github_actions/actions/checkout-4.1.2 in repository https://gitbox.apache.org/repos/asf/fineract.git was b4f5edfc4 Bump actions/checkout from 4.1.1 to 4.1.2 The revisions

(fineract) branch develop updated: FINERACT-2072: Disburse without auto down payment

2024-03-28 Thread taskain
This is an automated email from the ASF dual-hosted git repository. taskain pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new dfd2968c4 FINERACT-2072: Disburse without

Re: [PR] FINERACT-2072: Disburse without auto down payment [fineract]

2024-03-28 Thread via GitHub
taskain7 merged PR #3838: URL: https://github.com/apache/fineract/pull/3838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] FINERACT-2070: Revert new test framework [fineract]

2024-03-28 Thread via GitHub
galovics opened a new pull request, #3839: URL: https://github.com/apache/fineract/pull/3839 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[PR] FINERACT-2072: Disburse without auto down payment [fineract]

2024-03-28 Thread via GitHub
taskain7 opened a new pull request, #3838: URL: https://github.com/apache/fineract/pull/3838 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA