[GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

2020-01-13 Thread GitBox
vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684#issuecomment-573551071 @awasum this now passed the build (because it's Monday), and is finished and ready from my side. Will you re

[GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

2020-01-12 Thread GitBox
vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684#issuecomment-573419177 The `ShareAccountIntegrationTests.testCreateShareAccountWithCharges()` failure was related to `ShareAccountCharge`,

[GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

2020-01-12 Thread GitBox
vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684#issuecomment-573415656 > why `ShareAccountIntegrationTests` (only) fails on this PR specifically `testCreateShareAccountWithCharges(

[GitHub] [fineract] vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702)

2020-01-12 Thread GitBox
vorburger commented on issue #684: more SpotBugs related / inspired code clean up (see FINERACT-702) URL: https://github.com/apache/fineract/pull/684#issuecomment-573411261 > Is this still relevant? Yes, very much so; this contains more but new SpotBugs related / inspired clean up