[GitHub] [fineract] reluxa opened a new pull request, #3344: FINERACT-1724 - activemq is pinned to 5.15.9-alpine

reluxa opened a new pull request, #3344: URL: https://github.com/apache/fineract/pull/3344 - activemq is pinned to 5.15.9-alpine ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[fineract] branch develop updated: FINERACT-1724 - Fixing broken kafka config - kafka image is pinned to 3.3.2

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new a9b73aa9f FINERACT-1724 - Fixing broken

[GitHub] [fineract] adamsaghy commented on pull request #3343: FINERACT-1724 Fixing broken kafka config

adamsaghy commented on PR #3343: URL: https://github.com/apache/fineract/pull/3343#issuecomment-1659790735 There are some failing integ test with wrong date handling. Those will be fixed in follow up PRs. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [fineract] adamsaghy merged pull request #3343: FINERACT-1724 Fixing broken kafka config

adamsaghy merged PR #3343: URL: https://github.com/apache/fineract/pull/3343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] reluxa opened a new pull request, #3343: FINERACT-1724 Fixing broken kafka config

reluxa opened a new pull request, #3343: URL: https://github.com/apache/fineract/pull/3343 - Fixing broken kafka config - kafka image is pinned to 3.3.2 ## Description Describe the changes made and why they were made. Ignore if these details are present on the

[GitHub] [fineract] adamsaghy commented on pull request #3346: FINERACT-1724: fix sql injection pattern check

adamsaghy commented on PR #3346: URL: https://github.com/apache/fineract/pull/3346#issuecomment-1660174900 Failing mysql and mariadb integ test check is overruled, those errors to be fixed by this PR: https://github.com/apache/fineract/pull/3345 -- This is an automated message from the

[GitHub] [fineract] adamsaghy merged pull request #3346: FINERACT-1724: fix sql injection pattern check

adamsaghy merged PR #3346: URL: https://github.com/apache/fineract/pull/3346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on pull request #3341: FINERACT-1724: Fix date handling of testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX

adamsaghy commented on PR #3341: URL: https://github.com/apache/fineract/pull/3341#issuecomment-1660083698 The failing test cases will be fixed by this PR: https://github.com/apache/fineract/pull/3345 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [fineract] adamsaghy commented on pull request #3338: Add flag to Savings Charges to be recognized as accrual income

adamsaghy commented on PR #3338: URL: https://github.com/apache/fineract/pull/3338#issuecomment-1660095520 @josehernandezfintecheandomx Can you please link the relevant FINERACT story for this change? @bharathc27 Could you please review the business need after it got linked? -- This

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3337: FINERACT-1945

adamsaghy commented on code in PR #3337: URL: https://github.com/apache/fineract/pull/3337#discussion_r1280477212 ## fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/SchedulerJobRunnerReadServiceImpl.java: ## @@ -154,11 +154,11 @@ private static

[GitHub] [fineract] adamsaghy opened a new pull request, #3345: FINERACT-1724: Fix `update last cob date of loan update` query

adamsaghy opened a new pull request, #3345: URL: https://github.com/apache/fineract/pull/3345 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] marta-jankovics opened a new pull request, #3346: FINERACT-1724: fix sql injection pattern check

marta-jankovics opened a new pull request, #3346: URL: https://github.com/apache/fineract/pull/3346 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] adamsaghy merged pull request #3341: FINERACT-1724: Fix date handling of testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX

adamsaghy merged PR #3341: URL: https://github.com/apache/fineract/pull/3341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[fineract] branch develop updated: FINERACT-1724: Fix date handling of testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 70b14e601 FINERACT-1724: Fix date

[GitHub] [fineract] b0c1 commented on a diff in pull request #3340: FINERACT-1724: Fix Multi Disburse internal server error

b0c1 commented on code in PR #3340: URL: https://github.com/apache/fineract/pull/3340#discussion_r1280524549 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/repaymentwithpostdatedchecks/domain/PostDatedChecks.java: ## @@ -40,7 +39,7 @@ public class PostDatedChecks

[fineract] branch develop updated: FINERACT-1724: Fix `update last cob date of loan update` query

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new f640c790c FINERACT-1724: Fix `update

[GitHub] [fineract] adamsaghy merged pull request #3345: FINERACT-1724: Fix `update last cob date of loan update` query

adamsaghy merged PR #3345: URL: https://github.com/apache/fineract/pull/3345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy commented on a diff in pull request #3340: FINERACT-1724: Fix Multi Disburse internal server error

adamsaghy commented on code in PR #3340: URL: https://github.com/apache/fineract/pull/3340#discussion_r1280467818 ## fineract-loan/src/main/java/org/apache/fineract/portfolio/repaymentwithpostdatedchecks/domain/PostDatedChecks.java: ## @@ -40,7 +39,7 @@ public class

[fineract] branch develop updated: FINERACT-1724: fix sql injection pattern check

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/fineract.git The following commit(s) were added to refs/heads/develop by this push: new 987d414ac FINERACT-1724: fix sql

[GitHub] [fineract] adamsaghy merged pull request #3339: FINERACT-1905: Same day repayment + charge handling improvement

adamsaghy merged PR #3339: URL: https://github.com/apache/fineract/pull/3339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] adamsaghy opened a new pull request, #3348: FINERACT-1905: Same day repayment + charge handling improvement

adamsaghy opened a new pull request, #3348: URL: https://github.com/apache/fineract/pull/3348 ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[fineract] branch revert-3339-FINERACT-1905/same_day_charge_and_repayment_handling created (now 1cd497f5c)

This is an automated email from the ASF dual-hosted git repository. adamsaghy pushed a change to branch revert-3339-FINERACT-1905/same_day_charge_and_repayment_handling in repository https://gitbox.apache.org/repos/asf/fineract.git at 1cd497f5c Revert "FINERACT-1905: Same day repayment +

[GitHub] [fineract] adamsaghy opened a new pull request, #3347: Revert "FINERACT-1905: Same day repayment + charge handling improvement"

adamsaghy opened a new pull request, #3347: URL: https://github.com/apache/fineract/pull/3347 Reverts apache/fineract#3339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [fineract] adamsaghy merged pull request #3347: Revert "FINERACT-1905: Same day repayment + charge handling improvement"

adamsaghy merged PR #3347: URL: https://github.com/apache/fineract/pull/3347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [fineract] vidakovic commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

vidakovic commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281102732 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -189,4 +207,49 @@ public String

[GitHub] [fineract] vidakovic commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

vidakovic commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281116016 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JavaType.java: ## @@ -0,0 +1,352 @@ +package

[GitHub] [fineract] vidakovic commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

vidakovic commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r128751 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseTypeResolver.java: ## @@ -58,10 +58,10 @@ public DatabaseType

[GitHub] [fineract] josehernandezfintecheandomx opened a new pull request, #3350: API for Asset Externalization Feature

josehernandezfintecheandomx opened a new pull request, #3350: URL: https://github.com/apache/fineract/pull/3350 ## Description API for Asset Externalization Feature, in order to analyze and work on the asset external owner details, I need to be able to view filer and search the

[GitHub] [fineract] vidakovic commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

vidakovic commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281094881 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public

[GitHub] [fineract] vidakovic commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

vidakovic commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281113631 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseTypeResolver.java: ## @@ -58,10 +58,10 @@ public DatabaseType

[GitHub] [fineract] vidakovic commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

vidakovic commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281091257 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public

[GitHub] [fineract] vidakovic commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

vidakovic commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281109886 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseType.java: ## @@ -19,5 +19,16 @@ package

[GitHub] [fineract] vidakovic commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

vidakovic commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281116812 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JdbcJavaType.java: ## @@ -0,0 +1,321 @@ +package

[GitHub] [fineract] abhinav7sinha opened a new pull request, #3349: FINERACT-1932: Create a new fineract-module directory for Fineract mo…

abhinav7sinha opened a new pull request, #3349: URL: https://github.com/apache/fineract/pull/3349 …dules ## Description Describe the changes made and why they were made. Ignore if these details are present on the associated [Apache Fineract JIRA

[GitHub] [fineract] vidakovic commented on a diff in pull request #3321: Fineract-1910 data table query advanced marta

vidakovic commented on code in PR #3321: URL: https://github.com/apache/fineract/pull/3321#discussion_r1281093647 ## fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/DatabaseSpecificSQLGenerator.java: ## @@ -36,14 +42,26 @@ public