[GitHub] [fineract] ptuomola commented on pull request #1237: Fixes Swagger-UI for Accrual

2020-08-14 Thread GitBox
ptuomola commented on pull request #1237: URL: https://github.com/apache/fineract/pull/1237#issuecomment-673945067 @thesmallstar Finally had some time to look at this! So the problem seems to be that in this one, the request body was annotated with @Parameter whereas in all the others it

[GitHub] [fineract] ptuomola commented on pull request #1237: Fixes Swagger-UI for Accrual

2020-08-14 Thread GitBox
ptuomola commented on pull request #1237: URL: https://github.com/apache/fineract/pull/1237#issuecomment-673945380 @thesmallstar PR #1247 - can you have a look? This is an automated message from the Apache Git Service. To

[GitHub] [fineract] ptuomola commented on pull request #1237: Fixes Swagger-UI for Accrual

2020-08-12 Thread GitBox
ptuomola commented on pull request #1237: URL: https://github.com/apache/fineract/pull/1237#issuecomment-672776509 @thesmallstar would be great to understand why this is different before we merge, and then fix all in one go. Straightaway I can't see why this would be different...

[GitHub] [fineract] ptuomola commented on pull request #1237: Fixes Swagger-UI for Accrual

2020-08-06 Thread GitBox
ptuomola commented on pull request #1237: URL: https://github.com/apache/fineract/pull/1237#issuecomment-670305942 @thesmallstar great to hear it works! Wonder why it wasn't done like that to start off with... hope there isn't some sort of non-obvious side effect. Are there lots of

[GitHub] [fineract] ptuomola commented on pull request #1237: Fixes Swagger-UI for Accrual

2020-08-06 Thread GitBox
ptuomola commented on pull request #1237: URL: https://github.com/apache/fineract/pull/1237#issuecomment-669916044 Hmm... I thought the idea here was that the actual argument (jsonRequestBody) is hidden, and instead a "pseudo-argument" is created with the correct schema type using the