Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r209071812
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/domain/RateRepositoryWrapper.java
---
@@ -0,0 +1,72 @@
+/**
+ *
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r209071876
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanProductWritePlatformServiceJpaRepositoryImpl.java
---
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r209071842
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanProductWritePlatformServiceJpaRepositoryImpl.java
---
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r209071792
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/serialization/RateDefinitionCommandFromApiJsonDeserializer.java
---
@@
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r208863491
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/serialization/RateDefinitionCommandFromApiJsonDeserializer.java
---
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r208853745
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java
---
@@ -135,10 +135,10 @@ public
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r208863144
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanProductWritePlatformServiceJpaRepositoryImpl.java
---
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r208664400
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java
---
@@ -325,4 +332,35 @@ private
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r208390127
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanProductWritePlatformServiceJpaRepositoryImpl.java
---
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r207370679
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
---
@@ -392,20 +395,24 @@
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r207369492
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
---
@@ -178,30 +180,30 @@
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r207369345
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/handler/DeleteRateCommandHandler.java
---
@@ -0,0 +1,26 @@
+/**
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r207365498
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java
---
@@ -325,4 +332,35 @@ private
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r207364751
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProduct.java
---
@@ -102,6 +103,10 @@
Github user angelboxes commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r207358094
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java
---
@@ -325,4 +332,35 @@ private
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206853841
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanProductReadPlatformServiceImpl.java
---
@@ -465,7
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206854050
--- Diff:
fineract-provider/src/main/resources/sql/migrations/core_db/V343__rates.sql ---
@@ -0,0 +1,62 @@
+--
+-- Licensed to the Apache
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206853561
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java
---
@@ -325,4 +332,35 @@ private
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206853418
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java
---
@@ -178,30 +180,30 @@
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206853778
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/domain/LoanProduct.java
---
@@ -102,6 +103,10 @@
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206853632
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java
---
@@ -325,4 +332,35 @@ private
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206853956
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/rate/handler/DeleteRateCommandHandler.java
---
@@ -0,0 +1,26 @@
+/**
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206853697
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanUtilService.java
---
@@ -325,4 +332,35 @@ private
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206853888
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanproduct/service/LoanProductWritePlatformServiceJpaRepositoryImpl.java
---
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206854038
--- Diff:
fineract-provider/src/main/resources/sql/migrations/core_db/V343__rates.sql ---
@@ -0,0 +1,62 @@
+--
+-- Licensed to the Apache
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206853497
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java
---
@@ -392,20 +395,24 @@
Github user ShruthiRajaram commented on a diff in the pull request:
https://github.com/apache/fineract/pull/465#discussion_r206768853
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java
---
@@ -454,7 +454,7 @@
GitHub user angelboxes opened a pull request:
https://github.com/apache/fineract/pull/465
Fineract 614: Rates module
Previously defined sub-rates can be added to set the nominal interest rate
of a loan product. When a loan account is created you can choose which rates
from the
28 matches
Mail list logo
