bvaradar commented on issue #2414:
URL: https://github.com/apache/hudi/issues/2414#issuecomment-756578166
Answer provided :
https://apache-hudi.slack.com/archives/C4D716NPQ/p1609922670490200?thread_ts=1609360627.455000=C4D716NPQ
Regarding your first question, Bulk_Insert mode simply
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553164370
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -232,17 +250,18 @@ void
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553165180
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -580,6 +602,11 @@ public
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553758784
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -707,24 +739,51 @@ public void
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553758341
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -707,24 +739,51 @@ public void
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553182089
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java
##
@@ -0,0 +1,265 @@
+/*
+ * Licensed
yanghua commented on a change in pull request #2412:
URL: https://github.com/apache/hudi/pull/2412#discussion_r553751737
##
File path: pom.xml
##
@@ -110,9 +110,10 @@
2.4.4
3.0.0
1.8.2
-2.11.12
+2.11.12
Review comment:
Ok, so wdyt about `spark3`
codecov-io edited a comment on pull request #2418:
URL: https://github.com/apache/hudi/pull/2418#issuecomment-756542561
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
codecov-io edited a comment on pull request #2418:
URL: https://github.com/apache/hudi/pull/2418#issuecomment-756542561
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2418?src=pr=h1) Report
> Merging
[#2418](https://codecov.io/gh/apache/hudi/pull/2418?src=pr=desc) (e391e86)
into
codecov-io commented on pull request #2418:
URL: https://github.com/apache/hudi/pull/2418#issuecomment-756542561
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2418?src=pr=h1) Report
> Merging
[#2418](https://codecov.io/gh/apache/hudi/pull/2418?src=pr=desc) (e391e86)
into
codecov-io edited a comment on pull request #2417:
URL: https://github.com/apache/hudi/pull/2417#issuecomment-756532045
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
codecov-io edited a comment on pull request #2417:
URL: https://github.com/apache/hudi/pull/2417#issuecomment-756532045
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2417?src=pr=h1) Report
> Merging
[#2417](https://codecov.io/gh/apache/hudi/pull/2417?src=pr=desc) (145372c)
into
codecov-io commented on pull request #2417:
URL: https://github.com/apache/hudi/pull/2417#issuecomment-756532045
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2417?src=pr=h1) Report
> Merging
[#2417](https://codecov.io/gh/apache/hudi/pull/2417?src=pr=desc) (145372c)
into
SteNicholas commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-756519212
@vinothchandar I didn't think the changes of @nsivabalan add different
IOHandle to `HoodieMergeHandle`. We should add `HoodieInsertHandle` inherited
from `HoodieIOHandle` to
vinothchandar commented on a change in pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#discussion_r553713192
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
##
@@ -133,6 +133,10 @@
private static
vinothchandar commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-756515101
@nsivabalan can you please check the tests?
This is an automated message from the Apache Git Service.
To
vinothchandar commented on a change in pull request #2417:
URL: https://github.com/apache/hudi/pull/2417#discussion_r553710593
##
File path:
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##
@@ -39,6 +39,7 @@
// Validate contents of
Karl-WangSK commented on a change in pull request #2260:
URL: https://github.com/apache/hudi/pull/2260#discussion_r553710167
##
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/compact/SparkScheduleCompactionActionExecutor.java
##
@@ -60,17
wangxianghu commented on a change in pull request #2260:
URL: https://github.com/apache/hudi/pull/2260#discussion_r553699091
##
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/compact/SparkScheduleCompactionActionExecutor.java
##
@@ -60,17
so-lazy commented on issue #2338:
URL: https://github.com/apache/hudi/issues/2338#issuecomment-756485939
> @so-lazy : I think the hive table may not be a hudi table. can you show
the output of the following hive command ?
>
> desc formatted table
>
> Also, can you please
[
https://issues.apache.org/jira/browse/HUDI-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HUDI-1266:
-
Labels: pull-request-available (was: )
> Add e2e integration tests for replace and
satishkotha opened a new pull request #2418:
URL: https://github.com/apache/hudi/pull/2418
## What is the purpose of the pull request
Verify that rollback works correctly with replacecommit
## Brief change log
Add unit test for validating replacecommit rollback works
zhedoubushishi commented on a change in pull request #2412:
URL: https://github.com/apache/hudi/pull/2412#discussion_r553642229
##
File path: pom.xml
##
@@ -110,9 +110,10 @@
2.4.4
3.0.0
1.8.2
-2.11.12
+2.11.12
Review comment:
They are the same,
[
https://issues.apache.org/jira/browse/HUDI-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HUDI-1479:
-
Labels: pull-request-available (was: )
> Replace FSUtils.getAllPartitionPaths() with
>
umehrot2 opened a new pull request #2417:
URL: https://github.com/apache/hudi/pull/2417
## What is the purpose of the pull request
In HUDI-1510 we moved `HoodieEngineContext` so it can be used to parallelize
fetching of partition paths from `FileSystemBackedMetadata` implementation.
codecov-io edited a comment on pull request #2283:
URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
codecov-io edited a comment on pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#issuecomment-752876566
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1938?src=pr=h1) Report
> Merging
[#1938](https://codecov.io/gh/apache/hudi/pull/1938?src=pr=desc) (452be51)
into
vinothchandar commented on issue #2416:
URL: https://github.com/apache/hudi/issues/2416#issuecomment-756403172
We will have 0.7.0 out next week. Is there a specific feature you are
looking for?
This is an automated message
codecov-io edited a comment on pull request #2283:
URL: https://github.com/apache/hudi/pull/2283#issuecomment-734137301
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2283?src=pr=h1) Report
> Merging
[#2283](https://codecov.io/gh/apache/hudi/pull/2283?src=pr=desc) (63cbf01)
into
Rap70r opened a new issue #2416:
URL: https://github.com/apache/hudi/issues/2416
Hello,
Do you have an estimate on when version 0.6.1 will be released?
Thank you
This is an automated message from the Apache Git
codecov-io edited a comment on pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#issuecomment-752876566
# [Codecov](https://codecov.io/gh/apache/hudi/pull/1938?src=pr=h1) Report
> Merging
[#1938](https://codecov.io/gh/apache/hudi/pull/1938?src=pr=desc) (452be51)
into
codecov-io edited a comment on pull request #2334:
URL: https://github.com/apache/hudi/pull/2334#issuecomment-745334158
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2334?src=pr=h1) Report
> Merging
[#2334](https://codecov.io/gh/apache/hudi/pull/2334?src=pr=desc) (908bb9e)
into
codecov-io edited a comment on pull request #2334:
URL: https://github.com/apache/hudi/pull/2334#issuecomment-745334158
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2334?src=pr=h1) Report
> Merging
[#2334](https://codecov.io/gh/apache/hudi/pull/2334?src=pr=desc) (908bb9e)
into
umehrot2 merged pull request #2410:
URL: https://github.com/apache/hudi/pull/2410
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jtmzheng commented on issue #2408:
URL: https://github.com/apache/hudi/issues/2408#issuecomment-756289589
Thank you, I have also tried setting `hoodie.write.buffer.limit.bytes` as
per https://github.com/apache/hudi/issues/1491#issuecomment-610626104 but it
still OOMs in same way (this
vinothchandar commented on a change in pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#discussion_r553482746
##
File path:
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/utils/HoodieInputFormatUtils.java
##
@@ -470,4 +471,45 @@ private static
vinothchandar commented on pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#issuecomment-756264377
>hmm, the test was passed in my local.
typically, if the test depends on some aspect of the data generated, then it
can pass locally and fail in CI, because the
codecov-io edited a comment on pull request #2375:
URL: https://github.com/apache/hudi/pull/2375#issuecomment-752011479
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2375?src=pr=h1) Report
> Merging
[#2375](https://codecov.io/gh/apache/hudi/pull/2375?src=pr=desc) (36b92db)
into
Karl-WangSK commented on a change in pull request #2260:
URL: https://github.com/apache/hudi/pull/2260#discussion_r553411690
##
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/compact/SparkScheduleCompactionActionExecutor.java
##
@@ -60,17
[
https://issues.apache.org/jira/browse/HUDI-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260583#comment-17260583
]
pengzhiwei commented on HUDI-1109:
--
Hi [~linshan], are you still working on this issue? I am interested
yanghua commented on pull request #2415:
URL: https://github.com/apache/hudi/pull/2415#issuecomment-756177087
@wangxianghu Tiger brother, please help to review, thanks.
This is an automated message from the Apache Git
garyli1019 commented on pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#issuecomment-756173953
> ```
> [INFO]
> [ERROR] Failures:
> [ERROR] TestMORDataSource.testCount:309 expected: <142> but was: <138>
> ```
>
> seems related?
hmm, the test
codecov-io edited a comment on pull request #2260:
URL: https://github.com/apache/hudi/pull/2260#issuecomment-729530724
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2260?src=pr=h1) Report
> Merging
[#2260](https://codecov.io/gh/apache/hudi/pull/2260?src=pr=desc) (ddf8fca)
into
[
https://issues.apache.org/jira/browse/HUDI-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260520#comment-17260520
]
sivabalan narayanan edited comment on HUDI-1496 at 1/7/21, 2:04 PM:
[
https://issues.apache.org/jira/browse/HUDI-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260520#comment-17260520
]
sivabalan narayanan commented on HUDI-1496:
---
[~vbalaji]: is this the fix you are suggesting
```
nsivabalan commented on pull request #2111:
URL: https://github.com/apache/hudi/pull/2111#issuecomment-756127108
@vinothchandar : have fixed tests as well. you are good to review.
This is an automated message from the
Trevor-zhang opened a new pull request #2415:
URL: https://github.com/apache/hudi/pull/2415
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contributing.html before opening a
pull request.*
## What is the purpose of
[
https://issues.apache.org/jira/browse/HUDI-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17260452#comment-17260452
]
Leandro Rosa commented on HUDI-1358:
By my understaning this issue impacts any Streaming job, right?
yanghua commented on a change in pull request #2412:
URL: https://github.com/apache/hudi/pull/2412#discussion_r553277293
##
File path: pom.xml
##
@@ -110,9 +110,10 @@
2.4.4
3.0.0
1.8.2
-2.11.12
+2.11.12
Review comment:
Hi, why do we use
yanghua commented on a change in pull request #2260:
URL: https://github.com/apache/hudi/pull/2260#discussion_r553275932
##
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/compact/SparkScheduleCompactionActionExecutor.java
##
@@ -60,17
[
https://issues.apache.org/jira/browse/HUDI-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
wangxianghu updated HUDI-1514:
--
Fix Version/s: (was: 0.6.1)
0.7.0
> Avoid raw type use for parameter of
puyvqi created HUDI-1514:
Summary: Avoid raw type use for parameter of interface
Key: HUDI-1514
URL: https://issues.apache.org/jira/browse/HUDI-1514
Project: Apache Hudi
Issue Type: Improvement
codecov-io edited a comment on pull request #2334:
URL: https://github.com/apache/hudi/pull/2334#issuecomment-745334158
# [Codecov](https://codecov.io/gh/apache/hudi/pull/2334?src=pr=h1) Report
> Merging
[#2334](https://codecov.io/gh/apache/hudi/pull/2334?src=pr=desc) (79422fe)
into
pranotishanbhag opened a new issue #2414:
URL: https://github.com/apache/hudi/issues/2414
**_Tips before filing an issue_**
- Have you gone through our
[FAQs](https://cwiki.apache.org/confluence/display/HUDI/FAQ)? Yes. Also looked
at the Tuning guide:
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553198185
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -707,24 +739,51 @@ public void
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553182089
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java
##
@@ -0,0 +1,265 @@
+/*
+ * Licensed
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553177992
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -408,13 +426,14 @@ protected void
vinothchandar commented on pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#issuecomment-755963403
```
[INFO]
[ERROR] Failures:
[ERROR] TestMORDataSource.testCount:309 expected: <142> but was: <138>
```
seems related?
vinothchandar commented on pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#issuecomment-755962801
Sounds good. Will do a review, morning time PST.
Could you please check why CI is unhappy
This is an
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553171497
##
File path:
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/heartbeat/TestHoodieHeartbeatClient.java
##
@@ -0,0 +1,152 @@
+/*
+ *
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553170553
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCompactionConfig.java
##
@@ -260,6 +264,11 @@ public Builder
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553169905
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/heartbeat/HoodieHeartbeatClient.java
##
@@ -0,0 +1,265 @@
+/*
+ * Licensed
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553168356
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -859,6 +931,10 @@ protected void
garyli1019 commented on pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#issuecomment-755955479
> @garyli1019 any hopes for this PR to be completed in the next day or so? :)
@vinothchandar The current version should work with the newer version commit
file, but I
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553165180
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -580,6 +602,11 @@ public
n3nash commented on a change in pull request #2359:
URL: https://github.com/apache/hudi/pull/2359#discussion_r553164370
##
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -232,17 +250,18 @@ void
vinothchandar commented on pull request #1938:
URL: https://github.com/apache/hudi/pull/1938#issuecomment-755953071
@garyli1019 any hopes for this PR to be completed in the next day or so? :)
This is an automated message
67 matches
Mail list logo
