Re: [PR] [HUDI-5973] Fixing refreshing of schemas in HoodieStreamer continuous mode [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10261: URL: https://github.com/apache/hudi/pull/10261#issuecomment-1859065053 ## CI report: * 21b7f2c89745631fc854f11ca201080762728105 UNKNOWN * a6e71f3ef494421c08b895bf9bf0aa9c0395e351 Azure:

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader (0.x branch) [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10339: URL: https://github.com/apache/hudi/pull/10339#issuecomment-1859045969 ## CI report: * a4a30405db038272466adea3ee51c2923fcd944e Azure:

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10340: URL: https://github.com/apache/hudi/pull/10340#issuecomment-1859037963 ## CI report: * 53875b1c03bc5d2c761e57c998a3fb1c2e038b01 Azure:

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader (0.x branch) [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10339: URL: https://github.com/apache/hudi/pull/10339#issuecomment-1859037954 ## CI report: * dd3845421a5be07fc18939cd23537a23662f7515 Azure:

Re: [PR] [HUDI-5973] Fixing refreshing of schemas in HoodieStreamer continuous mode [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10261: URL: https://github.com/apache/hudi/pull/10261#issuecomment-1859037918 ## CI report: * 21b7f2c89745631fc854f11ca201080762728105 UNKNOWN * c79d1211484ff1d8751cee0a01e60ca2b8cf84bf Azure:

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10340: URL: https://github.com/apache/hudi/pull/10340#issuecomment-1859032793 ## CI report: * 7fa7aea0f00ac1592556c40f6a72817b973fa5b1 Azure:

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader (0.x branch) [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10339: URL: https://github.com/apache/hudi/pull/10339#issuecomment-1859032784 ## CI report: * dd3845421a5be07fc18939cd23537a23662f7515 Azure:

Re: [PR] [HUDI-5973] Fixing refreshing of schemas in HoodieStreamer continuous mode [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10261: URL: https://github.com/apache/hudi/pull/10261#issuecomment-1859032737 ## CI report: * 21b7f2c89745631fc854f11ca201080762728105 UNKNOWN * c79d1211484ff1d8751cee0a01e60ca2b8cf84bf Azure:

Re: [PR] [HUDI-7237] Hudi Streamer: Handle edge case with null schema, minor cleanups [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10342: URL: https://github.com/apache/hudi/pull/10342#issuecomment-1859029231 ## CI report: * cb62ad9bed32bf3acc6f8227e5e824cb73e8f0e4 UNKNOWN * 7c3ea778cc509ea71d9b837d4b228bb07abf18b2 Azure:

(hudi) branch master updated: [HUDI-7183] Fix static insert overwrite partitions issue (#10254)

2023-12-16 Thread vbalaji
This is an automated email from the ASF dual-hosted git repository. vbalaji pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/hudi.git The following commit(s) were added to refs/heads/master by this push: new 27ac42818bc [HUDI-7183] Fix static insert

Re: [PR] [HUDI-7183] Fix static insert overwrite partitions issue [hudi]

2023-12-16 Thread via GitHub
bvaradar merged PR #10254: URL: https://github.com/apache/hudi/pull/10254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [HUDI-7237] Hudi Streamer: Handle edge case with null schema, minor cleanups [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10342: URL: https://github.com/apache/hudi/pull/10342#issuecomment-1859021797 ## CI report: * cb62ad9bed32bf3acc6f8227e5e824cb73e8f0e4 UNKNOWN * 7c3ea778cc509ea71d9b837d4b228bb07abf18b2 Azure:

Re: [PR] [HUDI-7237] Hudi Streamer: Handle edge case with null schema, minor cleanups [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10342: URL: https://github.com/apache/hudi/pull/10342#issuecomment-1859020883 ## CI report: * cb62ad9bed32bf3acc6f8227e5e824cb73e8f0e4 UNKNOWN * 7c3ea778cc509ea71d9b837d4b228bb07abf18b2 UNKNOWN Bot commands @hudi-bot supports the

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader (0.x branch) [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10339: URL: https://github.com/apache/hudi/pull/10339#issuecomment-1859020875 ## CI report: * dd3845421a5be07fc18939cd23537a23662f7515 Azure:

Re: [PR] [HUDI-7237] Hudi Streamer: Handle edge case with null schema, minor cleanups [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10342: URL: https://github.com/apache/hudi/pull/10342#issuecomment-1859014631 ## CI report: * cb62ad9bed32bf3acc6f8227e5e824cb73e8f0e4 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

[jira] [Updated] (HUDI-7237) Minor Improvements to Schema Handling in Delta Sync

2023-12-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-7237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-7237: - Labels: pull-request-available (was: ) > Minor Improvements to Schema Handling in Delta Sync >

[PR] [HUDI-7237] Hudi Streamer: Handle edge case with null schema, minor cleanups [hudi]

2023-12-16 Thread via GitHub
the-other-tim-brown opened a new pull request, #10342: URL: https://github.com/apache/hudi/pull/10342 ### Change Logs - Reduces number of calls to schema provider by properly using `orElseGet` in one case and reusing existing writer config instead of recomputing - Reuses existing

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10340: URL: https://github.com/apache/hudi/pull/10340#issuecomment-1859012003 ## CI report: * 7fa7aea0f00ac1592556c40f6a72817b973fa5b1 Azure:

[jira] [Created] (HUDI-7237) Minor Improvements to Schema Handling in Delta Sync

2023-12-16 Thread Timothy Brown (Jira)
Timothy Brown created HUDI-7237: --- Summary: Minor Improvements to Schema Handling in Delta Sync Key: HUDI-7237 URL: https://issues.apache.org/jira/browse/HUDI-7237 Project: Apache Hudi Issue

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10340: URL: https://github.com/apache/hudi/pull/10340#issuecomment-1859003258 ## CI report: * b319a7c193a79252dd18c5df782667d96c47a64a Azure:

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10340: URL: https://github.com/apache/hudi/pull/10340#issuecomment-1859001927 ## CI report: * b319a7c193a79252dd18c5df782667d96c47a64a Azure:

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader (0.x branch) [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10339: URL: https://github.com/apache/hudi/pull/10339#issuecomment-1859001909 ## CI report: * 380da64e8a28ae34f4315f6df34367f7f0c74cdd Azure:

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader (0.x branch) [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10339: URL: https://github.com/apache/hudi/pull/10339#issuecomment-1859000751 ## CI report: * 380da64e8a28ae34f4315f6df34367f7f0c74cdd Azure:

Re: [PR] [HUDI-7236] Allow MIT to change partition path when using global index [hudi]

2023-12-16 Thread via GitHub
nsivabalan commented on code in PR #10337: URL: https://github.com/apache/hudi/pull/10337#discussion_r1428851434 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestMergeIntoTable.scala: ## @@ -182,6 +182,82 @@ class TestMergeIntoTable extends

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader (0.x branch) [hudi]

2023-12-16 Thread via GitHub
nsivabalan commented on PR #10339: URL: https://github.com/apache/hudi/pull/10339#issuecomment-1858857129 @linliu-code : yes, we do have a fix for master here here https://github.com/apache/hudi/pull/10340 -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] ceshi [hudi]

2023-12-16 Thread via GitHub
zoomake closed issue #10341: ceshi URL: https://github.com/apache/hudi/issues/10341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in… [hudi]

2023-12-16 Thread via GitHub
danny0405 commented on PR #10255: URL: https://github.com/apache/hudi/pull/10255#issuecomment-1858800572 > Overall it looks solid to me. Only concern is that this code is very critical and complex, do we have enough tests to ensure the correctness? We have all the tests for each use

Re: [PR] [HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in… [hudi]

2023-12-16 Thread via GitHub
danny0405 commented on code in PR #10255: URL: https://github.com/apache/hudi/pull/10255#discussion_r1428788123 ## hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java: ## @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in… [hudi]

2023-12-16 Thread via GitHub
danny0405 commented on code in PR #10255: URL: https://github.com/apache/hudi/pull/10255#discussion_r1428787998 ## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/CompletionTimeQueryView.java: ## @@ -175,42 +187,111 @@ public Option getCompletionTime(String

Re: [PR] [HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in… [hudi]

2023-12-16 Thread via GitHub
danny0405 commented on code in PR #10255: URL: https://github.com/apache/hudi/pull/10255#discussion_r1428787710 ## hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java: ## @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in… [hudi]

2023-12-16 Thread via GitHub
danny0405 commented on code in PR #10255: URL: https://github.com/apache/hudi/pull/10255#discussion_r1428787379 ## hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java: ## @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in… [hudi]

2023-12-16 Thread via GitHub
danny0405 commented on code in PR #10255: URL: https://github.com/apache/hudi/pull/10255#discussion_r1428787494 ## hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java: ## @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in… [hudi]

2023-12-16 Thread via GitHub
danny0405 commented on code in PR #10255: URL: https://github.com/apache/hudi/pull/10255#discussion_r1428787116 ## hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java: ## @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in… [hudi]

2023-12-16 Thread via GitHub
danny0405 commented on code in PR #10255: URL: https://github.com/apache/hudi/pull/10255#discussion_r1428786843 ## hudi-common/src/main/java/org/apache/hudi/common/table/log/InstantRange.java: ## @@ -166,6 +169,28 @@ public boolean isInRange(String instant) { } } +

Re: [PR] [HUDI-7184] Add IncrementalQueryAnalyzer for completion time based in… [hudi]

2023-12-16 Thread via GitHub
danny0405 commented on code in PR #10255: URL: https://github.com/apache/hudi/pull/10255#discussion_r1428786517 ## hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java: ## @@ -0,0 +1,429 @@ +/* + * Licensed to the Apache Software Foundation

Re: [I] [SUPPORT] Spark SQL insert to write hudI table. Metadata sync failed. [hudi]

2023-12-16 Thread via GitHub
AnchorAnim commented on issue #4903: URL: https://github.com/apache/hudi/issues/4903#issuecomment-1858789575 请问这个问题你当时怎么解决的? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [HUDI-7228] Fix eager closure of log reader input streams with log record reader [hudi]

2023-12-16 Thread via GitHub
hudi-bot commented on PR #10340: URL: https://github.com/apache/hudi/pull/10340#issuecomment-1858776223 ## CI report: * b319a7c193a79252dd18c5df782667d96c47a64a Azure: