danny0405 commented on PR #10255: URL: https://github.com/apache/hudi/pull/10255#issuecomment-1858800572
> Overall it looks solid to me. Only concern is that this code is very critical and complex, do we have enough tests to ensure the correctness? We have all the tests for each use case in `TestInputFormat` and `TestIncrementalInputSplits`, they are currently Flink UTs, somehow we need to refactoring the tests into the `hudi-common`. (an engine agnostic data set validation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
