lw309637554 commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-669248590
> @lw309637554 this seems ready?
yes, but the test failed for some reason, i rerun it
This is an
lw309637554 commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-667553349
> @lw309637554 would you please rebase and fix the conflicts.
okay, done
This is an automated message
lw309637554 commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-663442107
> couple
okay ,thanks
This is an automated message from the Apache Git Service.
To respond to the
lw309637554 commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-661736470
@vinothchandar The pr is ready overall. Can you help to review ?
This is an automated message from the Apache
lw309637554 commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-659747098
> > this is a good point. I think remove hive dependency from hudi-spark and
hudi-utilities is a another work . we can open another issue resolve it
>
> sounds good.
lw309637554 commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-659182664
> Hi @lw309637554 , I totally understand the importance of the backward
capability. IMO, that will be great if we can remove the hive dependency from
`hudi-spark` and
lw309637554 commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-658740024
@vinothchandar @garyli1019 I think in this PR the hudi-sync abstract is
ready. Expect your review. Thanks
1. the module abstract is
hudi-sync
lw309637554 commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-656092089
@vinothchandar I meet some mistakes, just opened a new PR.
In the new PR, I fix the build break. This is my thinks about backwards
compatible .
a. about users code
lw309637554 commented on pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#issuecomment-656086937
> @lw309637554 Thanks for your contribution! Overall looks good.
> Open to discuss where to put these modules. I vote to put the base class
to `hudi-common` and have
