lw309637554 commented on pull request #1810: URL: https://github.com/apache/hudi/pull/1810#issuecomment-656092089
@vinothchandar I meet some mistakes, just opened a new PR. In the new PR, I fix the build break. This is my thinks about backwards compatible . a. about users code compatible: because do not modify the hivesync class name. Users do not need to modify these old code. b. about users pom dependency compatible: because do not modify the module name hudi-hive-sync. Users not need to modify pom dependency c. about users local jar files compatible: if users's local jars is do not shaded the hudi-hive-sync's Indirect dependence. Old users just need add the hudi-sync-common.jar to their directory. Just like hudi-utilities-bundle modiry in this PR. Reply: we can do this to put the hudi-sync-common base class to hudi-common d. about sync parameters, just add new parameters. Compatible is ok. what about your suggestion? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
