Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-09 Thread via GitHub
codope merged PR #10860: URL: https://github.com/apache/hudi/pull/10860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-09 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1557417357 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -991,9 +1001,9 @@ private void

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-07 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1555159066 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -991,9 +1001,9 @@ private void

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-07 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2041474216 ## CI report: * bbfbe38b86b5bd11972591a346ac9b847a7daa6a Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-07 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2041454934 ## CI report: * dbda44942240ecdf008df975aa15d58eaaa45a33 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-07 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2041453013 ## CI report: * dbda44942240ecdf008df975aa15d58eaaa45a33 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-07 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1554955230 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -991,9 +1001,9 @@ private void

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-07 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1554954192 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/TableFileSystemView.java: ## @@ -107,6 +107,14 @@ interface SliceViewWithLatestSlice { */

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-07 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1554953956 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -434,7 +433,12 @@ private boolean

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-05 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r155535 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/TableFileSystemView.java: ## @@ -107,6 +107,14 @@ interface SliceViewWithLatestSlice { */

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-05 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1553326198 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -991,9 +1001,9 @@ private void

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-04 Thread via GitHub
bhat-vinay commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1552836822 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -434,7 +433,12 @@ private boolean

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-04 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1552661236 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -434,7 +433,12 @@ private boolean

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-04 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2037332583 ## CI report: * dbda44942240ecdf008df975aa15d58eaaa45a33 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-04 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2037190595 ## CI report: * 971883fd498830b3c1257b9df61bf012d3be1554 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-04 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2037169431 ## CI report: * 971883fd498830b3c1257b9df61bf012d3be1554 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-04 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1551490057 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -991,9 +1001,9 @@ private void

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-04 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1551488498 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java: ## @@ -428,6 +428,7 @@ protected Option getReplaceInstant(final

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-04-04 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1551487833 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -434,7 +433,12 @@ private boolean

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-22 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1535241868 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -434,7 +433,12 @@ private boolean

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-22 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1535126995 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -434,7 +433,12 @@ private boolean

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-22 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1535123166 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -534,10 +537,17 @@ private Pair>

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1534943897 ## hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java: ## @@ -428,6 +428,7 @@ protected Option getReplaceInstant(final

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1534943496 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -991,9 +1001,9 @@ private void

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1534943099 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -534,10 +537,17 @@ private Pair>

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1534942879 ## hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java: ## @@ -434,7 +433,12 @@ private boolean

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
codope commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2012814839 @danny0405 @bhat-vinay @yihua All tests passed now. Please take another pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2012296763 ## CI report: * 971883fd498830b3c1257b9df61bf012d3be1554 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2012155756 ## CI report: * c37115caa8348eeb0653cb03d5f773e2d046082b Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2012137384 ## CI report: * c37115caa8348eeb0653cb03d5f773e2d046082b Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2011575469 ## CI report: * c37115caa8348eeb0653cb03d5f773e2d046082b Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2011305161 ## CI report: * 567e8faf62ac6ed8c6df54ae8cbc4a0c6d994323 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-21 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-2011297856 ## CI report: * 567e8faf62ac6ed8c6df54ae8cbc4a0c6d994323 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-16 Thread via GitHub
bhat-vinay commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1527415181 ## hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java: ## @@ -737,11 +738,12 @@ public boolean isMetadataTableAvailable() { /** *

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-15 Thread via GitHub
danny0405 commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-1999175611 Hmm, it looks like there are many test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-14 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-1998845915 ## CI report: * 567e8faf62ac6ed8c6df54ae8cbc4a0c6d994323 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-14 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-1998792317 ## CI report: * 0b76cded2d8eab1c306d16a62717c7cba02e9b96 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-14 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1525665975 ## hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java: ## @@ -737,11 +738,12 @@ public boolean isMetadataTableAvailable() { /** *

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-14 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-1998775560 ## CI report: * 0b76cded2d8eab1c306d16a62717c7cba02e9b96 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-14 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1524587040 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java: ## @@ -1919,7 +1920,7 @@ public HoodieRecord next() { public static Schema

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-14 Thread via GitHub
codope commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1524586719 ## hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java: ## @@ -737,11 +738,12 @@ public boolean isMetadataTableAvailable() { /** *

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-13 Thread via GitHub
bhat-vinay commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1524160977 ## hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/TestFunctionalIndex.scala: ## @@ -253,6 +253,47 @@ class

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-13 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1524070449 ## hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java: ## @@ -1919,7 +1920,7 @@ public HoodieRecord next() { public static Schema

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-13 Thread via GitHub
danny0405 commented on code in PR #10860: URL: https://github.com/apache/hudi/pull/10860#discussion_r1524070179 ## hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java: ## @@ -737,11 +738,12 @@ public boolean isMetadataTableAvailable() { /** *

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-13 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-1995528694 ## CI report: * 0b76cded2d8eab1c306d16a62717c7cba02e9b96 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-13 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-1995186398 ## CI report: * 0b76cded2d8eab1c306d16a62717c7cba02e9b96 Azure:

Re: [PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-13 Thread via GitHub
hudi-bot commented on PR #10860: URL: https://github.com/apache/hudi/pull/10860#issuecomment-1995162248 ## CI report: * 0b76cded2d8eab1c306d16a62717c7cba02e9b96 UNKNOWN Bot commands @hudi-bot supports the following commands: - `@hudi-bot run azure` re-run

[PR] [HUDI-7480] Fix functional index and avoid multiple initializations [hudi]

2024-03-13 Thread via GitHub
codope opened a new pull request, #10860: URL: https://github.com/apache/hudi/pull/10860 ### Change Logs This PR fixes two issues: 1. When a functional index is updated, it was getting re-initialized. This was happening because metadata partition type only contains the