[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979098#comment-16979098 ] lamber-ken commented on HUDI-354: - hi, [~yanghua],how about creating a subtask that add the XML code

[GitHub] [incubator-hudi] n3nash commented on issue #991: Hudi Test Suite (Refactor)

2019-11-21 Thread GitBox
n3nash commented on issue #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#issuecomment-557029657 @yanghua I've pushed the PR to a feature branch : https://github.com/apache/incubator-hudi/tree/hudi_test_suite_refactor. I will shortly close this PR.

[GitHub] [incubator-hudi] n3nash edited a comment on issue #991: Hudi Test Suite (Refactor)

2019-11-21 Thread GitBox
n3nash edited a comment on issue #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#issuecomment-557029657 @yanghua I've pushed the PR to a feature branch : https://github.com/apache/incubator-hudi/tree/hudi_test_suite_refactor. I will shortly close

[GitHub] [incubator-hudi] hddong closed pull request #1037: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages

2019-11-21 Thread GitBox
hddong closed pull request #1037: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages URL: https://github.com/apache/incubator-hudi/pull/1037 This is an automated message from the Apache

[GitHub] [incubator-hudi] Guru107 commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project

2019-11-21 Thread GitBox
Guru107 commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project URL: https://github.com/apache/incubator-hudi/pull/1029#discussion_r348951805 ## File path: .github/ISSUE_TEMPLATE/bug_report.md ## @@ -0,0 +1,30 @@ +--- +name: Bug report

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project

2019-11-21 Thread GitBox
yanghua commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project URL: https://github.com/apache/incubator-hudi/pull/1029#discussion_r348984775 ## File path: .github/ISSUE_TEMPLATE/SUPPORT_REQUEST.md ## @@ -0,0 +1,53 @@ +--- +name: Support

[jira] [Comment Edited] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979133#comment-16979133 ] lamber-ken edited comment on HUDI-354 at 11/21/19 9:46 AM: --- hi, I test in my

[jira] [Comment Edited] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979143#comment-16979143 ] lamber-ken edited comment on HUDI-354 at 11/21/19 10:13 AM: right, I tried

[GitHub] [incubator-hudi] hddong opened a new pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages

2019-11-21 Thread GitBox
hddong opened a new pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages URL: https://github.com/apache/incubator-hudi/pull/1038 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review

[GitHub] [incubator-hudi] hddong opened a new pull request #1037: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages

2019-11-21 Thread GitBox
hddong opened a new pull request #1037: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages URL: https://github.com/apache/incubator-hudi/pull/1037 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979108#comment-16979108 ] vinoyang commented on HUDI-354: --- [~lamber-ken] welcome to join the refactor work, if you want. It has a lot

[jira] [Assigned] (HUDI-355) Refactor hudi-common based on new comment and code style rules

2019-11-21 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned HUDI-355: - Assignee: vinoyang > Refactor hudi-common based on new comment and code style rules >

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project

2019-11-21 Thread GitBox
yanghua commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project URL: https://github.com/apache/incubator-hudi/pull/1029#discussion_r348977066 ## File path: .github/ISSUE_TEMPLATE/SUPPORT_REQUEST.md ## @@ -0,0 +1,53 @@ +--- +name: Support

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project

2019-11-21 Thread GitBox
yanghua commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project URL: https://github.com/apache/incubator-hudi/pull/1029#discussion_r348976125 ## File path: .github/ISSUE_TEMPLATE/SUPPORT_REQUEST.md ## @@ -0,0 +1,53 @@ +--- +name: Support

[GitHub] [incubator-hudi] Guru107 commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project

2019-11-21 Thread GitBox
Guru107 commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project URL: https://github.com/apache/incubator-hudi/pull/1029#discussion_r348983881 ## File path: .github/ISSUE_TEMPLATE/SUPPORT_REQUEST.md ## @@ -0,0 +1,53 @@ +--- +name: Support

[jira] [Updated] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated HUDI-354: -- Description: This is an umbrella issue used to track apply some stricter comment and code style validation

[jira] [Updated] (HUDI-340) Increase Default max events to read from kafka source

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-340: Labels: pull-request-available (was: ) > Increase Default max events to read from kafka source >

[GitHub] [incubator-hudi] pratyakshsharma opened a new pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-21 Thread GitBox
pratyakshsharma opened a new pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039 This is an automated message from the Apache Git

[incubator-hudi] branch hudi_test_suite_refactor created (now b060994)

2019-11-21 Thread nagarwal
This is an automated email from the ASF dual-hosted git repository. nagarwal pushed a change to branch hudi_test_suite_refactor in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git. at b060994 fixing build issues due to javax servlet No new revisions were added by this

[GitHub] [incubator-hudi] simonqin edited a comment on issue #1021: how can i deal this problem when partition's value changed with the same row_key?

2019-11-21 Thread GitBox
simonqin edited a comment on issue #1021: how can i deal this problem when partition's value changed with the same row_key? URL: https://github.com/apache/incubator-hudi/issues/1021#issuecomment-555870581 @bhasudha I tested three versions, such as 0.4.7, 0.5.0, master,all of them have

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979143#comment-16979143 ] lamber-ken commented on HUDI-354: - right > Introduce stricter comment and code style validation rules >

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979133#comment-16979133 ] lamber-ken commented on HUDI-354: - hi, I test in my local env just now, it did affect the build process

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979102#comment-16979102 ] vinoyang commented on HUDI-354: --- I thought about the idea. However, if we merge the rules before refactoring.

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979142#comment-16979142 ] vinoyang commented on HUDI-354: --- [~lamber-ken] It's strange. It takes effect in my local env. Did you add the

[GitHub] [incubator-hudi] yanghua commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project

2019-11-21 Thread GitBox
yanghua commented on a change in pull request #1029: [HUDI-348] Add Issue template for the project URL: https://github.com/apache/incubator-hudi/pull/1029#discussion_r348953543 ## File path: .github/ISSUE_TEMPLATE/bug_report.md ## @@ -0,0 +1,30 @@ +--- +name: Bug report

[GitHub] [incubator-hudi] jienan commented on issue #143: Tracking ticket for folks to be added to slack group

2019-11-21 Thread GitBox
jienan commented on issue #143: Tracking ticket for folks to be added to slack group URL: https://github.com/apache/incubator-hudi/issues/143#issuecomment-556983045 Please add me to Slack :) email is zeng4...@gmail.com This

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979225#comment-16979225 ] leesf commented on HUDI-354: I verified in my local dev. If set_ severity_ property to _info_, the checkstyle

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages

2019-11-21 Thread GitBox
leesf commented on a change in pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages URL: https://github.com/apache/incubator-hudi/pull/1038#discussion_r349058575 ## File path: docs/quickstart.cn.md ## @@ -108,6

[GitHub] [incubator-hudi] leesf commented on issue #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages

2019-11-21 Thread GitBox
leesf commented on issue #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages URL: https://github.com/apache/incubator-hudi/pull/1038#issuecomment-557064913 Thanks for opening the PR @hddong ! Only left a minor comment.

[GitHub] [incubator-hudi] yanghua commented on issue #991: Hudi Test Suite (Refactor)

2019-11-21 Thread GitBox
yanghua commented on issue #991: Hudi Test Suite (Refactor) URL: https://github.com/apache/incubator-hudi/pull/991#issuecomment-557044875 @n3nash Thanks. Will check out the new feature branch soon. This is an automated

[jira] [Comment Edited] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread Gurudatt Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979351#comment-16979351 ] Gurudatt Kulkarni edited comment on HUDI-354 at 11/21/19 3:11 PM: --

[jira] [Reopened] (HUDI-350) Update javadocs in HoodieCleanHelper to reflect correct defaults for retained commits

2019-11-21 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf reopened HUDI-350: > Update javadocs in HoodieCleanHelper to reflect correct defaults for retained > commits >

[jira] [Closed] (HUDI-350) Update javadocs in HoodieCleanHelper to reflect correct defaults for retained commits

2019-11-21 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf closed HUDI-350. -- Fix Version/s: 0.5.1 Resolution: Fixed > Update javadocs in HoodieCleanHelper to reflect correct defaults for

[jira] [Created] (HUDI-357) Refactor hudi-cli based on new comment and code style rules

2019-11-21 Thread Gurudatt Kulkarni (Jira)
Gurudatt Kulkarni created HUDI-357: -- Summary: Refactor hudi-cli based on new comment and code style rules Key: HUDI-357 URL: https://issues.apache.org/jira/browse/HUDI-357 Project: Apache Hudi

[jira] [Updated] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated HUDI-354: -- Description: This is an umbrella issue used to track apply some stricter comment and code style validation

[GitHub] [incubator-hudi] leesf commented on issue #1024: [HUDI-345] Fix used deprecated function

2019-11-21 Thread GitBox
leesf commented on issue #1024: [HUDI-345] Fix used deprecated function URL: https://github.com/apache/incubator-hudi/pull/1024#issuecomment-557066756 @vinothchandar If there are no other concern. we would merge this PR. This

[jira] [Commented] (HUDI-350) Update javadocs in HoodieCleanHelper to reflect correct defaults for retained commits

2019-11-21 Thread Pratyaksh Sharma (Jira)
[ https://issues.apache.org/jira/browse/HUDI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979245#comment-16979245 ] Pratyaksh Sharma commented on HUDI-350: --- [~xleesf], [~vbalaji] I am not able to find any option to

[jira] [Comment Edited] (HUDI-350) Update javadocs in HoodieCleanHelper to reflect correct defaults for retained commits

2019-11-21 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979258#comment-16979258 ] leesf edited comment on HUDI-350 at 11/21/19 1:05 PM: -- Fixed(reopen and close)

[jira] [Commented] (HUDI-350) Update javadocs in HoodieCleanHelper to reflect correct defaults for retained commits

2019-11-21 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979258#comment-16979258 ] leesf commented on HUDI-350: Fixed [~Pratyaksh] and thanks for your contributing. > Update javadocs in

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979227#comment-16979227 ] leesf commented on HUDI-354: Also, when we fix the comment error, should we also fix some semantic errors of

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979178#comment-16979178 ] vinoyang commented on HUDI-354: --- [~xleesf] Can you help to verify whether the check-style works fine? >

[incubator-hudi] branch hudi_test_suite_refactor updated (b060994 -> 0c2ed53)

2019-11-21 Thread nagarwal
This is an automated email from the ASF dual-hosted git repository. nagarwal pushed a change to branch hudi_test_suite_refactor in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git. omit b060994 fixing build issues due to javax servlet new 0c2ed53 fixing build issues

[incubator-hudi] 01/01: fixing build issues due to javax servlet

2019-11-21 Thread nagarwal
This is an automated email from the ASF dual-hosted git repository. nagarwal pushed a commit to branch hudi_test_suite_refactor in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git commit 0c2ed5334559250cc30d4d4a80fa4d5b517bb9bd Author: Nishith Agarwal AuthorDate: Tue Nov 19

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979228#comment-16979228 ] lamber-ken commented on HUDI-354: - thanks, [~xleesf] > Introduce stricter comment and code style

[jira] [Commented] (HUDI-350) Update javadocs in HoodieCleanHelper to reflect correct defaults for retained commits

2019-11-21 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979243#comment-16979243 ] leesf commented on HUDI-350: [~Pratyaksh][~vbalaji], Hi, I think we had better mark the jira resolved instead

[GitHub] [incubator-hudi] zhedoubushishi commented on issue #1001: [HUDI-325] Fix Hive partition error for updated HDFS Hudi table

2019-11-21 Thread GitBox
zhedoubushishi commented on issue #1001: [HUDI-325] Fix Hive partition error for updated HDFS Hudi table URL: https://github.com/apache/incubator-hudi/pull/1001#issuecomment-557221059 > > HDFS partition path provided by Hudi and what it gets from Hive do not match > > +1 > >

[GitHub] [incubator-hudi] zhedoubushishi edited a comment on issue #1001: [HUDI-325] Fix Hive partition error for updated HDFS Hudi table

2019-11-21 Thread GitBox
zhedoubushishi edited a comment on issue #1001: [HUDI-325] Fix Hive partition error for updated HDFS Hudi table URL: https://github.com/apache/incubator-hudi/pull/1001#issuecomment-557221059 > > HDFS partition path provided by Hudi and what it gets from Hive do not match > > +1 >

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-21 Thread GitBox
leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349321525 ## File path:

[GitHub] [incubator-hudi] leesf commented on issue #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-21 Thread GitBox
leesf commented on issue #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#issuecomment-557276975 Thanks for opening the PR @pratyakshsharma ! Looks good overall, only left some minor comments.

[GitHub] [incubator-hudi] bschell opened a new pull request #1040: [HUDI-327] Add null/empty checks to key generators

2019-11-21 Thread GitBox
bschell opened a new pull request #1040: [HUDI-327] Add null/empty checks to key generators URL: https://github.com/apache/incubator-hudi/pull/1040 ## Summary Adds null and empty checks to all key generators. Also improves error messaging for key generator issues. Additionally

[jira] [Updated] (HUDI-327) Introduce "null" supporting KeyGenerator

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-327: Labels: pull-request-available (was: ) > Introduce "null" supporting KeyGenerator >

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-21 Thread GitBox
leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349322440 ## File path:

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-21 Thread GitBox
leesf commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349322511 ## File path:

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #106

2019-11-21 Thread Apache Jenkins Server
See Changes: -- [...truncated 2.17 KB...] /home/jenkins/tools/maven/apache-maven-3.5.4/bin: m2.conf mvn mvn.cmd mvnDebug mvnDebug.cmd mvnyjp

[GitHub] [incubator-hudi] rbhartia commented on issue #1034: Datasource Writer throws error on resolving struct fields

2019-11-21 Thread GitBox
rbhartia commented on issue #1034: Datasource Writer throws error on resolving struct fields URL: https://github.com/apache/incubator-hudi/issues/1034#issuecomment-557351957 @alphairys - We were able to reproduce the problem and see that it is happening due to the struct type in there.

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages

2019-11-21 Thread GitBox
hddong commented on a change in pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages URL: https://github.com/apache/incubator-hudi/pull/1038#discussion_r349393423 ## File path: docs/quickstart.cn.md ## @@ -108,6

[GitHub] [incubator-hudi] rbhartia commented on issue #1034: Datasource Writer throws error on resolving struct fields

2019-11-21 Thread GitBox
rbhartia commented on issue #1034: Datasource Writer throws error on resolving struct fields URL: https://github.com/apache/incubator-hudi/issues/1034#issuecomment-557348214 @alphairys - Would you mind dropping a mail to emr-h...@amazon.com or rbhar...@amazon.com with the steps to

[jira] [Commented] (HUDI-184) Integrate Hudi with Apache Flink

2019-11-21 Thread Taher Koitawala (Jira)
[ https://issues.apache.org/jira/browse/HUDI-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979838#comment-16979838 ] Taher Koitawala commented on HUDI-184: -- [~yanghua] In terms of Streaming I do not have a specific plan

[GitHub] [incubator-hudi] vinothchandar commented on issue #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types

2019-11-21 Thread GitBox
vinothchandar commented on issue #1005: [HUDI-91][HUDI-12]Migrate to spark 2.4.4, migrate to spark-avro library instead of databricks-avro, add support for Decimal/Date types URL: https://github.com/apache/incubator-hudi/pull/1005#issuecomment-557385552 What balaji suggested makes sense

[GitHub] [incubator-hudi] hddong commented on a change in pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages

2019-11-21 Thread GitBox
hddong commented on a change in pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages URL: https://github.com/apache/incubator-hudi/pull/1038#discussion_r349393423 ## File path: docs/quickstart.cn.md ## @@ -108,6

[jira] [Comment Edited] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979877#comment-16979877 ] lamber-ken edited comment on HUDI-354 at 11/22/19 5:50 AM: --- hi, [~yanghua] I

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread vinoyang (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979881#comment-16979881 ] vinoyang commented on HUDI-354: --- {quote}I think we also should add maven-enforcer-plugin to limit the maven

[GitHub] [incubator-hudi] lamber-ken opened a new issue #1041: [Question] Where is client jar in hudi-cli.sh

2019-11-21 Thread GitBox
lamber-ken opened a new issue #1041: [Question] Where is client jar in hudi-cli.sh URL: https://github.com/apache/incubator-hudi/issues/1041 hi, I can not find out what is the client jar in hudi-cli.sh, can some one tell me, thanks. ``` DIR="$( cd "$( dirname

[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-21 Thread GitBox
pratyakshsharma commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349453291 ## File path:

[incubator-hudi] branch asf-site updated: [HUDI-356][chinese] Sync changes in quickstart.cn and admin_guide.cn pages (#1038)

2019-11-21 Thread leesf
This is an automated email from the ASF dual-hosted git repository. leesf pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/asf-site by this push: new 46a1546 [HUDI-356][chinese] Sync

[GitHub] [incubator-hudi] leesf merged pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages

2019-11-21 Thread GitBox
leesf merged pull request #1038: [HUDI-356][chinese] Sync translation and code in quickstart.cn and admin_guide.cn pages URL: https://github.com/apache/incubator-hudi/pull/1038 This is an automated message from the Apache

[jira] [Closed] (HUDI-356) Sync translation and code in quickstart.cn and admin_guide.cn pages

2019-11-21 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf closed HUDI-356. -- Fix Version/s: 0.5.1 Resolution: Fixed Fix via asf-site: 46a1546259fcfb629a26508e829d3d3e4b9cee21 > Sync

[jira] [Updated] (HUDI-359) Add hudi-env for hudi-cli module

2019-11-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-359: Labels: pull-request-available (was: ) > Add hudi-env for hudi-cli module >

[GitHub] [incubator-hudi] hddong opened a new pull request #1042: [HUDI-359] Add hudi-env for hudi-cli module

2019-11-21 Thread GitBox
hddong opened a new pull request #1042: [HUDI-359] Add hudi-env for hudi-cli module URL: https://github.com/apache/incubator-hudi/pull/1042 ## *Tips* - *Thank you very much for contributing to Apache Hudi.* - *Please review https://hudi.apache.org/contributing.html before opening a

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread Gurudatt Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979861#comment-16979861 ] Gurudatt Kulkarni commented on HUDI-354: [~yanghua] So which rule do we keep? CustomImportOrder /

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979875#comment-16979875 ] lamber-ken commented on HUDI-354: - hi [~gurudatt]. from this official website

[jira] [Created] (HUDI-358) Add Java-doc and importOrder checkstyle rule

2019-11-21 Thread lamber-ken (Jira)
lamber-ken created HUDI-358: --- Summary: Add Java-doc and importOrder checkstyle rule Key: HUDI-358 URL: https://issues.apache.org/jira/browse/HUDI-358 Project: Apache Hudi (incubating) Issue Type:

[GitHub] [incubator-hudi] lamber-ken commented on issue #143: Tracking ticket for folks to be added to slack group

2019-11-21 Thread GitBox
lamber-ken commented on issue #143: Tracking ticket for folks to be added to slack group URL: https://github.com/apache/incubator-hudi/issues/143#issuecomment-557400930 hi, @vinothchandar, email lamber...@163.com, thanks

[jira] [Commented] (HUDI-354) Introduce stricter comment and code style validation rules

2019-11-21 Thread lamber-ken (Jira)
[ https://issues.apache.org/jira/browse/HUDI-354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979899#comment-16979899 ] lamber-ken commented on HUDI-354: - Sorry, [~gurudatt], the value of option should set *top*, if so 

[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-21 Thread GitBox
pratyakshsharma commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349453011 ## File path:

[GitHub] [incubator-hudi] pratyakshsharma commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable

2019-11-21 Thread GitBox
pratyakshsharma commented on a change in pull request #1039: [HUDI-340]: made max events to read from kafka source configurable URL: https://github.com/apache/incubator-hudi/pull/1039#discussion_r349453291 ## File path: