yanghua commented on pull request #2058:
URL: https://github.com/apache/hudi/pull/2058#issuecomment-691431626
> Would you mind helping document this if possible ?
OK, my pleasure.
This is an automated message
sathyaprakashg commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487415553
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord
[
https://issues.apache.org/jira/browse/HUDI-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf resolved HUDI-802.
Resolution: Fixed
> AWSDmsTransformer does not handle insert -> delete of a row in a single batch
> correctly
>
[
https://issues.apache.org/jira/browse/HUDI-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf closed HUDI-802.
--
> AWSDmsTransformer does not handle insert -> delete of a row in a single batch
> correctly
>
[
https://issues.apache.org/jira/browse/HUDI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf resolved HUDI-1181.
-
Fix Version/s: 0.6.1
Resolution: Fixed
> Decimal type display issue for record key field
>
[
https://issues.apache.org/jira/browse/HUDI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf closed HUDI-1181.
---
> Decimal type display issue for record key field
> ---
>
>
[
https://issues.apache.org/jira/browse/HUDI-1181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf updated HUDI-1181:
Status: Open (was: New)
> Decimal type display issue for record key field
>
[
https://issues.apache.org/jira/browse/HUDI-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf updated HUDI-1130:
Status: Open (was: New)
> Allow for schema evolution within DAG for hudi test suite
>
[
https://issues.apache.org/jira/browse/HUDI-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf closed HUDI-1254.
---
> TypedProperties can not get values by initializing an existing properties
>
[
https://issues.apache.org/jira/browse/HUDI-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf resolved HUDI-1254.
-
Resolution: Fixed
> TypedProperties can not get values by initializing an existing properties
>
[
https://issues.apache.org/jira/browse/HUDI-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf resolved HUDI-1130.
-
Fix Version/s: 0.6.1
Resolution: Fixed
> Allow for schema evolution within DAG for hudi test suite
>
[
https://issues.apache.org/jira/browse/HUDI-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf updated HUDI-1254:
Status: Open (was: New)
> TypedProperties can not get values by initializing an existing properties
>
[
https://issues.apache.org/jira/browse/HUDI-1130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf closed HUDI-1130.
---
> Allow for schema evolution within DAG for hudi test suite
> -
>
[
https://issues.apache.org/jira/browse/HUDI-1255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
leesf closed HUDI-1255.
---
> Combine and get updateValue in multiFields
> --
>
> Key:
vinothchandar commented on pull request #1978:
URL: https://github.com/apache/hudi/pull/1978#issuecomment-691505393
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hj2016 commented on a change in pull request #2078:
URL: https://github.com/apache/hudi/pull/2078#discussion_r486733426
##
File path: docs/_docs/1_4_powered_by.md
##
@@ -28,6 +29,9 @@ offering real-time analysis on hudi dataset.
Amazon Web Services is the World's leading
leesf commented on a change in pull request #1929:
URL: https://github.com/apache/hudi/pull/1929#discussion_r487126922
##
File path:
hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -117,7 +118,17 @@ public boolean commitStats(String
xushiyan commented on a change in pull request #2079:
URL: https://github.com/apache/hudi/pull/2079#discussion_r487433796
##
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java
##
@@ -66,6 +73,30 @@ public static HoodieTestTable
pratyakshsharma commented on pull request #2078:
URL: https://github.com/apache/hudi/pull/2078#issuecomment-691050799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
sathyaprakashg commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487415553
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord
bvaradar commented on issue #2062:
URL: https://github.com/apache/hudi/issues/2062#issuecomment-691206241
@kpurella : I think you should either try patching the PR I had mentioned
or use 0.6.0
This is an automated message
vinothchandar commented on pull request #1978:
URL: https://github.com/apache/hudi/pull/1978#issuecomment-691505393
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
leesf commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-691043300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sathyaprakashg commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487415553
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord
abhijeetkushe commented on issue #1737:
URL: https://github.com/apache/hudi/issues/1737#issuecomment-691268965
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nsivabalan commented on pull request #2084:
URL: https://github.com/apache/hudi/pull/2084#issuecomment-691327993
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pratyakshsharma commented on pull request #2085:
URL: https://github.com/apache/hudi/pull/2085#issuecomment-691021969
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
bvaradar closed issue #2062:
URL: https://github.com/apache/hudi/issues/2062
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vinothchandar commented on pull request #1704:
URL: https://github.com/apache/hudi/pull/1704#issuecomment-691505318
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tooptoop4 commented on pull request #2084:
URL: https://github.com/apache/hudi/pull/2084#issuecomment-690925786
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vinothchandar commented on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-691505048
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
leesf commented on a change in pull request #1929:
URL: https://github.com/apache/hudi/pull/1929#discussion_r487126922
##
File path:
hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -117,7 +118,17 @@ public boolean commitStats(String
n3nash commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-691200964
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
abhijeetkushe commented on issue #1737:
URL: https://github.com/apache/hudi/issues/1737#issuecomment-691268965
@bvaradar The hudi version we are using 0.5.2-incubating deployed on EMR.
Good point on the terminology.I will rephrase my question
COW with 'hoodie.cleaner.commits.retained':
n3nash commented on pull request #1978:
URL: https://github.com/apache/hudi/pull/1978#issuecomment-691202637
@hj2016 Please rebase and fix the tests, we can land after that.
This is an automated message from the Apache Git
hj2016 commented on pull request #1978:
URL: https://github.com/apache/hudi/pull/1978#issuecomment-691379071
@n3nash The problem nsivabalan said, I have fixed it a few days ago. I don’t
know if you are talking about the same problem. If not, can I elaborate on it?
xushiyan commented on a change in pull request #2079:
URL: https://github.com/apache/hudi/pull/2079#discussion_r487433796
##
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java
##
@@ -66,6 +73,30 @@ public static HoodieTestTable
yanghua closed pull request #2058:
URL: https://github.com/apache/hudi/pull/2058
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
leesf closed pull request #1748:
URL: https://github.com/apache/hudi/pull/1748
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pratyakshsharma merged pull request #2078:
URL: https://github.com/apache/hudi/pull/2078
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pratyakshsharma commented on pull request #2078:
URL: https://github.com/apache/hudi/pull/2078#issuecomment-691050799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
abhijeetkushe edited a comment on issue #1737:
URL: https://github.com/apache/hudi/issues/1737#issuecomment-690685990
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vinothchandar commented on a change in pull request #2048:
URL: https://github.com/apache/hudi/pull/2048#discussion_r486369440
##
File path:
hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -87,44 +88,55 @@ protected
shenh062326 commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-690928998
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
hj2016 commented on pull request #1978:
URL: https://github.com/apache/hudi/pull/1978#issuecomment-691379071
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
bvaradar commented on pull request #2084:
URL: https://github.com/apache/hudi/pull/2084#issuecomment-690863065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pratyakshsharma merged pull request #2078:
URL: https://github.com/apache/hudi/pull/2078
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
yanghua commented on pull request #2058:
URL: https://github.com/apache/hudi/pull/2058#issuecomment-691431626
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
n3nash commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487165310
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[]
bvaradar merged pull request #2084:
URL: https://github.com/apache/hudi/pull/2084
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vinothchandar commented on pull request #1242:
URL: https://github.com/apache/hudi/pull/1242#issuecomment-691504599
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
shenh062326 commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-690928998
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/HUDI-1277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balaji Varadarajan updated HUDI-1277:
-
Status: Open (was: New)
> [DOC] Need documentation explaining how to write custom record
Balaji Varadarajan created HUDI-1277:
Summary: [DOC] Need documentation explaining how to write custom
record payload class
Key: HUDI-1277
URL: https://issues.apache.org/jira/browse/HUDI-1277
[
https://issues.apache.org/jira/browse/HUDI-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Balaji Varadarajan updated HUDI-1278:
-
Status: Open (was: New)
> Need a generic payload class which can skip late arriving data
Balaji Varadarajan created HUDI-1278:
Summary: Need a generic payload class which can skip late arriving
data based on specific fields
Key: HUDI-1278
URL: https://issues.apache.org/jira/browse/HUDI-1278
bvaradar commented on issue #2062:
URL: https://github.com/apache/hudi/issues/2062#issuecomment-691206241
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
n3nash commented on pull request #1242:
URL: https://github.com/apache/hudi/pull/1242#issuecomment-691203252
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
bvaradar commented on pull request #2058:
URL: https://github.com/apache/hudi/pull/2058#issuecomment-691209314
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
yanghua commented on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-690922454
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rajgowtham24 commented on issue #2075:
URL: https://github.com/apache/hudi/issues/2075#issuecomment-691079649
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bvaradar commented on issue #1737:
URL: https://github.com/apache/hudi/issues/1737#issuecomment-691198064
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
abhijeetkushe edited a comment on issue #1737:
URL: https://github.com/apache/hudi/issues/1737#issuecomment-690685990
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pratyakshsharma commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-690966794
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pratyakshsharma commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-690966794
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
n3nash commented on pull request #1978:
URL: https://github.com/apache/hudi/pull/1978#issuecomment-691202637
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
yanghua closed pull request #2058:
URL: https://github.com/apache/hudi/pull/2058
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
leesf closed pull request #1748:
URL: https://github.com/apache/hudi/pull/1748
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vinothchandar commented on pull request #1990:
URL: https://github.com/apache/hudi/pull/1990#issuecomment-691505608
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vinothchandar commented on a change in pull request #2048:
URL: https://github.com/apache/hudi/pull/2048#discussion_r486369440
##
File path:
hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -87,44 +88,55 @@ protected
leesf commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-691043300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
sathyaprakashg commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487415553
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord
nsivabalan commented on pull request #2084:
URL: https://github.com/apache/hudi/pull/2084#issuecomment-691327993
yeah, https://github.com/apache/hudi/pull/1792 fixed the issue for
OverwriteWithLatestAvroPayload and not for AWSDmsAvroPayload. thanks @bvaradar.
yanghua commented on pull request #2058:
URL: https://github.com/apache/hudi/pull/2058#issuecomment-690838645
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vinothchandar commented on pull request #1242:
URL: https://github.com/apache/hudi/pull/1242#issuecomment-691504599
@n3nash if you wish you can also rebase this yourself and push. See
https://cwiki.apache.org/confluence/display/HUDI/Resources#Resources-PushingChangesToPRs
for a how-to
leesf commented on a change in pull request #1929:
URL: https://github.com/apache/hudi/pull/1929#discussion_r487126922
##
File path:
hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -117,7 +118,17 @@ public boolean commitStats(String
vinothchandar commented on pull request #1990:
URL: https://github.com/apache/hudi/pull/1990#issuecomment-691505608
@pratyakshsharma please always wait for an explicit LGTM from another
committer before merging :)
I will take another pass
vinothchandar commented on a change in pull request #2048:
URL: https://github.com/apache/hudi/pull/2048#discussion_r486369440
##
File path:
hudi-client/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##
@@ -87,44 +88,55 @@ protected
abhijeetkushe commented on issue #1737:
URL: https://github.com/apache/hudi/issues/1737#issuecomment-691268965
@bvaradar The hudi version we are using 0.5.2-incubating deployed on EMR.
Good point on the terminology.I will rephrase my question
COW with 'hoodie.cleaner.commits.retained':
abhijeetkushe edited a comment on issue #1737:
URL: https://github.com/apache/hudi/issues/1737#issuecomment-690685990
@vinothchandar
I am facing a similar problem.I am doing a POC for Hudi and am using with
the same data for both COW and MOR.I see the compaction happening for both
bvaradar commented on pull request #2084:
URL: https://github.com/apache/hudi/pull/2084#issuecomment-690863065
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vinothchandar commented on pull request #1242:
URL: https://github.com/apache/hudi/pull/1242#issuecomment-691504599
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
shenh062326 commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-690928998
@n3nash can you take a look at this MR.
This is an automated message from the Apache Git Service.
To respond
bvaradar commented on issue #2062:
URL: https://github.com/apache/hudi/issues/2062#issuecomment-691206241
@kpurella : I think you should either try patching the PR I had mentioned
or use 0.6.0
This is an automated message
bvaradar closed issue #2062:
URL: https://github.com/apache/hudi/issues/2062
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
n3nash commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487165310
##
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[]
bvaradar commented on issue #1737:
URL: https://github.com/apache/hudi/issues/1737#issuecomment-691198064
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
vinothchandar commented on pull request #1704:
URL: https://github.com/apache/hudi/pull/1704#issuecomment-691505318
Looks like this is almost ready . I will rebase, review and try to land this
first.
thanks for flagging @shenh062326 !
vinothchandar commented on pull request #1978:
URL: https://github.com/apache/hudi/pull/1978#issuecomment-691505393
@nsivabalan are you good with the test changes like @hj2016 is asking?
please clarify
This is an automated
pratyakshsharma commented on pull request #2085:
URL: https://github.com/apache/hudi/pull/2085#issuecomment-691021969
Changes look good to me. Can you see why the build is failing? @shenh062326
This is an automated message
vinothchandar commented on pull request #1704:
URL: https://github.com/apache/hudi/pull/1704#issuecomment-691505318
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
xushiyan commented on a change in pull request #2079:
URL: https://github.com/apache/hudi/pull/2079#discussion_r487433796
##
File path:
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java
##
@@ -66,6 +73,30 @@ public static HoodieTestTable
bvaradar commented on pull request #2058:
URL: https://github.com/apache/hudi/pull/2058#issuecomment-691209314
Yes @yanghua : The docker containers are for mainly for internal (testing
and demo) consumption but I agree we can document it for engineers to know.
Would you mind helping
n3nash commented on pull request #1242:
URL: https://github.com/apache/hudi/pull/1242#issuecomment-691203252
@hddong Extremely sorry, this fell through the crack, please rebase and I
will merge this right after.
This is an
yanghua commented on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-690922454
@leesf Thanks for your awesome work. Can you squash these commits for the
subsequent review?
This is an automated
n3nash commented on pull request #2071:
URL: https://github.com/apache/hudi/pull/2071#issuecomment-691200964
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
vinothchandar commented on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-691505048
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vinothchandar commented on pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#issuecomment-691505048
@wangxianghu That's awesome. Will resume the Review again this weekend
This is an automated message from the
leesf commented on pull request #1748:
URL: https://github.com/apache/hudi/pull/1748#issuecomment-691043300
> @leesf we no longer use SimpleDateFormat in TimestampBasedKeyGenerator. So
the issues linked with usage of SimpleDateFormat are also no longer there.
Guess we can close this?
vinothchandar commented on pull request #1990:
URL: https://github.com/apache/hudi/pull/1990#issuecomment-691505608
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
1 - 100 of 108 matches
Mail list logo
