[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
nsivabalan commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340439921 ## File path: hudi-common/src/main/java/org/apache/hudi/common/BloomFilterFactory.java ##

[jira] [Updated] (HUDI-317) Edit Quickstart page to point to Hudi maven artifact in spark shell command

2019-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-317: Labels: pull-request-available (was: ) > Edit Quickstart page to point to Hudi maven artifact in

[GitHub] [incubator-hudi] bhasudha opened a new pull request #986: [HUDI-317] change quickstart page spark-shell command

2019-10-29 Thread GitBox
bhasudha opened a new pull request #986: [HUDI-317] change quickstart page spark-shell command URL: https://github.com/apache/incubator-hudi/pull/986 Uses --packages option referring to Hudi maven artifact instead of --jars.

[jira] [Created] (HUDI-317) Edit Quickstart page to point to Hudi maven artifact in spark shell command

2019-10-29 Thread Bhavani Sudha Saktheeswaran (Jira)
Bhavani Sudha Saktheeswaran created HUDI-317: Summary: Edit Quickstart page to point to Hudi maven artifact in spark shell command Key: HUDI-317 URL: https://issues.apache.org/jira/browse/HUDI-317

[GitHub] [incubator-hudi] yihua commented on issue #985: [HUDI-275] Translate the Querying Data page into Chinese documentation

2019-10-29 Thread GitBox
yihua commented on issue #985: [HUDI-275] Translate the Querying Data page into Chinese documentation URL: https://github.com/apache/incubator-hudi/pull/985#issuecomment-547745115 @leesf @garyli1019 PTAL when you have time. Thanks!

[jira] [Updated] (HUDI-275) Translate Documentation -> Querying Data page

2019-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HUDI-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HUDI-275: Labels: pull-request-available (was: ) > Translate Documentation -> Querying Data page >

[GitHub] [incubator-hudi] yihua opened a new pull request #985: [HUDI-275] Translate the Querying Data page into Chinese documentation

2019-10-29 Thread GitBox
yihua opened a new pull request #985: [HUDI-275] Translate the Querying Data page into Chinese documentation URL: https://github.com/apache/incubator-hudi/pull/985 Jira ticket: https://issues.apache.org/jira/browse/HUDI-275

[GitHub] [incubator-hudi] vinothchandar merged pull request #984: [MINOR] Fix no output in travis

2019-10-29 Thread GitBox
vinothchandar merged pull request #984: [MINOR] Fix no output in travis URL: https://github.com/apache/incubator-hudi/pull/984 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-hudi] branch master updated: [MINOR] Fix no output in travis (#984)

2019-10-29 Thread vinoth
This is an automated email from the ASF dual-hosted git repository. vinoth pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new b0838d2 [MINOR] Fix no output in

[GitHub] [incubator-hudi] vinothchandar commented on issue #666: Add support for dynamic bloom filter to increase efficiency of bloom filter for static sizing

2019-10-29 Thread GitBox
vinothchandar commented on issue #666: Add support for dynamic bloom filter to increase efficiency of bloom filter for static sizing URL: https://github.com/apache/incubator-hudi/pull/666#issuecomment-547731457 Closing in favor of #976

[GitHub] [incubator-hudi] vinothchandar closed pull request #666: Add support for dynamic bloom filter to increase efficiency of bloom filter for static sizing

2019-10-29 Thread GitBox
vinothchandar closed pull request #666: Add support for dynamic bloom filter to increase efficiency of bloom filter for static sizing URL: https://github.com/apache/incubator-hudi/pull/666 This is an automated message from

[GitHub] [incubator-hudi] vinothchandar commented on issue #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
vinothchandar commented on issue #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#issuecomment-547726737 Consolidating package makes sense. This is an automated

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #83

2019-10-29 Thread Apache Jenkins Server
See Changes: -- [...truncated 2.37 KB...] /home/jenkins/tools/maven/apache-maven-3.5.4/conf/logging: simplelogger.properties

[GitHub] [incubator-hudi] nsivabalan commented on issue #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
nsivabalan commented on issue #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#issuecomment-547716257 Should I create a package for bloom.filter in org.apache.hudi.common? and move all BloomFilter related classes to it.

[GitHub] [incubator-hudi] leesf commented on issue #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
leesf commented on issue #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#issuecomment-547699330 Thanks for your detail review @yihua @garyli1019 ! Updated the PR to address your comments.

[GitHub] [incubator-hudi] zhedoubushishi edited a comment on issue #972: [HUDI-313] Fix select count star error when querying a realtime table

2019-10-29 Thread GitBox
zhedoubushishi edited a comment on issue #972: [HUDI-313] Fix select count star error when querying a realtime table URL: https://github.com/apache/incubator-hudi/pull/972#issuecomment-547675465 > Just the 1 comment.. and you may also want to change the target branch to `master` instead

[GitHub] [incubator-hudi] zhedoubushishi commented on a change in pull request #978: [HUDI-314] Fix multi partition keys error when querying a realtime table

2019-10-29 Thread GitBox
zhedoubushishi commented on a change in pull request #978: [HUDI-314] Fix multi partition keys error when querying a realtime table URL: https://github.com/apache/incubator-hudi/pull/978#discussion_r340375514 ## File path:

[GitHub] [incubator-hudi] zhedoubushishi commented on issue #972: [HUDI-313] Fix select count star error when querying a realtime table

2019-10-29 Thread GitBox
zhedoubushishi commented on issue #972: [HUDI-313] Fix select count star error when querying a realtime table URL: https://github.com/apache/incubator-hudi/pull/972#issuecomment-547675465 > Just the 1 comment.. and you may also want to change the target branch to `master` instead of

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340360494 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] leesf removed a comment on issue #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
leesf removed a comment on issue #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#issuecomment-547632746 Thanks for your review @yihua . Updated the PR to address your comments.

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340331432 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340334919 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340338702 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340337886 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340332917 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340340279 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340339003 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] leesf commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
leesf commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340332420 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] leesf opened a new pull request #984: [MINOR] Fix no output in travis

2019-10-29 Thread GitBox
leesf opened a new pull request #984: [MINOR] Fix no output in travis URL: https://github.com/apache/incubator-hudi/pull/984 see jira: https://jira.apache.org/jira/projects/HUDI/issues/HUDI-312 Cc @vinothchandar This

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340321952 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340318571 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340325662 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340303412 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340328513 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340326516 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340329955 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340316214 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340329137 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] leesf commented on issue #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
leesf commented on issue #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#issuecomment-547632746 Thanks for your review @yihua . Updated the PR to address your comments. This is

[jira] [Commented] (HUDI-312) Investigate recent flaky CI runs

2019-10-29 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962467#comment-16962467 ] leesf commented on HUDI-312: Will provide a PR soon. Of cause it is suitable to open a new issue to track integ

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340260437 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340258894 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340262194 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340253838 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340258341 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340251584 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340208841 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340207059 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340204418 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340205507 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] bvaradar commented on issue #942: [HUDI-137] Fix state transitions for Hudi cleaning action

2019-10-29 Thread GitBox
bvaradar commented on issue #942: [HUDI-137] Fix state transitions for Hudi cleaning action URL: https://github.com/apache/incubator-hudi/pull/942#issuecomment-547528039 @vinothchandar : Addressed review comments. Also, re-enabled spotless to fix any linting automatically and disabled

[GitHub] [incubator-hudi] yihua commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
yihua commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340201850 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action

2019-10-29 Thread GitBox
bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action URL: https://github.com/apache/incubator-hudi/pull/942#discussion_r340197742 ## File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieCopyOnWriteTable.java

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action

2019-10-29 Thread GitBox
bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action URL: https://github.com/apache/incubator-hudi/pull/942#discussion_r340197675 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action

2019-10-29 Thread GitBox
bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action URL: https://github.com/apache/incubator-hudi/pull/942#discussion_r340197191 ## File path: hudi-client/src/test/java/org/apache/hudi/HoodieClientTestHarness.java

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action

2019-10-29 Thread GitBox
bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action URL: https://github.com/apache/incubator-hudi/pull/942#discussion_r340196259 ## File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieTable.java ## @@

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action

2019-10-29 Thread GitBox
bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action URL: https://github.com/apache/incubator-hudi/pull/942#discussion_r340196156 ## File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieTable.java ## @@

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action

2019-10-29 Thread GitBox
bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action URL: https://github.com/apache/incubator-hudi/pull/942#discussion_r340195681 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action

2019-10-29 Thread GitBox
bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action URL: https://github.com/apache/incubator-hudi/pull/942#discussion_r340194965 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action

2019-10-29 Thread GitBox
bvaradar commented on a change in pull request #942: [HUDI-137] Fix state transitions for Hudi cleaning action URL: https://github.com/apache/incubator-hudi/pull/942#discussion_r340195022 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java ## @@

[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #978: [HUDI-314] Fix multi partition keys error when querying a realtime table

2019-10-29 Thread GitBox
bvaradar commented on a change in pull request #978: [HUDI-314] Fix multi partition keys error when querying a realtime table URL: https://github.com/apache/incubator-hudi/pull/978#discussion_r340192722 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340178616 ## File path: hudi-common/src/main/java/org/apache/hudi/common/BloomFilterFactory.java

[jira] [Commented] (HUDI-15) Add a delete() API to HoodieWriteClient as well as Spark datasource #531

2019-10-29 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962147#comment-16962147 ] Vinoth Chandar commented on HUDI-15: 1. yes. we already support deletes like that by issuing upsert().

[jira] [Comment Edited] (HUDI-15) Add a delete() API to HoodieWriteClient as well as Spark datasource #531

2019-10-29 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962041#comment-16962041 ] Vinoth Chandar edited comment on HUDI-15 at 10/29/19 3:41 PM: -- Few

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
nsivabalan commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340126613 ## File path: hudi-common/src/main/java/org/apache/hudi/common/BloomFilterFactory.java ##

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
nsivabalan commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340123836 ## File path: hudi-common/src/main/java/org/apache/hudi/common/HudiDynamicBloomFilter.java

[GitHub] [incubator-hudi] nsivabalan commented on issue #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
nsivabalan commented on issue #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#issuecomment-547458994 > @nsivabalan can you rebase against master and see if that helps the test pass Nope. I didn't import the checkstyle.

[jira] [Commented] (HUDI-15) Add a delete() API to HoodieWriteClient as well as Spark datasource #531

2019-10-29 Thread sivabalan narayanan (Jira)
[ https://issues.apache.org/jira/browse/HUDI-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16962041#comment-16962041 ] sivabalan narayanan commented on HUDI-15: - Few questions/clarifications as I am working through

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340058340 ## File path: hudi-common/src/main/java/org/apache/hudi/common/BloomFilterFactory.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340060736 ## File path: hudi-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java ##

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340058698 ## File path: hudi-common/src/main/java/org/apache/hudi/common/BloomFilterFactory.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340059491 ## File path: hudi-common/src/main/java/org/apache/hudi/common/HudiDynamicBloomFilter.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340059786 ## File path: hudi-common/src/main/java/org/apache/hudi/common/HudiDynamicBloomFilter.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#discussion_r340060321 ## File path: hudi-common/src/main/java/org/apache/hudi/common/SimpleBloomFilter.java ##

[jira] [Commented] (HUDI-305) Presto MOR "_rt" queries only reads base parquet file

2019-10-29 Thread Bhavani Sudha Saktheeswaran (Jira)
[ https://issues.apache.org/jira/browse/HUDI-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961983#comment-16961983 ] Bhavani Sudha Saktheeswaran commented on HUDI-305: -- Thanks [~bdscheller]  for the detailed

[jira] [Commented] (HUDI-312) Investigate recent flaky CI runs

2019-10-29 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961960#comment-16961960 ] Vinoth Chandar commented on HUDI-312: - May be we should open a new issue for the case of integ test

[jira] [Commented] (HUDI-312) Investigate recent flaky CI runs

2019-10-29 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961956#comment-16961956 ] Vinoth Chandar commented on HUDI-312: - Please open a PR. lets see how this goes.. > Investigate

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/969#discussion_r340037952 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/969#discussion_r340044181 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/969#discussion_r340041534 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/969#discussion_r340037589 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/969#discussion_r340038709 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on issue #976: [HUDI-106] Adding support for DynamicBloomFilter

2019-10-29 Thread GitBox
vinothchandar commented on issue #976: [HUDI-106] Adding support for DynamicBloomFilter URL: https://github.com/apache/incubator-hudi/pull/976#issuecomment-547395996 @nsivabalan can you rebase against master and see if that helps the test pass

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/969#discussion_r340043713 ## File path:

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer

2019-10-29 Thread GitBox
vinothchandar commented on a change in pull request #969: [HUDI-251] JDBC incremental load to HUDI DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/969#discussion_r340037308 ## File path:

[jira] [Commented] (HUDI-312) Investigate recent flaky CI runs

2019-10-29 Thread Vinoth Chandar (Jira)
[ https://issues.apache.org/jira/browse/HUDI-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961934#comment-16961934 ] Vinoth Chandar commented on HUDI-312: - But does the test pass? I am wondering if there is a root cause

[GitHub] [incubator-hudi] leesf commented on issue #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
leesf commented on issue #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#issuecomment-547360105 Thanks for your detail review @garyli1019 . Updated the PR to address your comments.

[GitHub] [incubator-hudi] leesf commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
leesf commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r340001906 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[jira] [Comment Edited] (HUDI-312) Investigate recent flaky CI runs

2019-10-29 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961772#comment-16961772 ] leesf edited comment on HUDI-312 at 10/29/19 7:50 AM: -- On no output, I changed the

[jira] [Commented] (HUDI-312) Investigate recent flaky CI runs

2019-10-29 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961772#comment-16961772 ] leesf commented on HUDI-312: On no output, I changed the

[jira] [Assigned] (HUDI-312) Investigate recent flaky CI runs

2019-10-29 Thread leesf (Jira)
[ https://issues.apache.org/jira/browse/HUDI-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf reassigned HUDI-312: -- Assignee: leesf > Investigate recent flaky CI runs > > > Key:

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r339906050 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r339892674 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r339893349 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r339903145 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r339899303 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r339902014 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r339901604 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r339904946 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page

2019-10-29 Thread GitBox
garyli1019 commented on a change in pull request #977: [HUDI-221] Translate concept page URL: https://github.com/apache/incubator-hudi/pull/977#discussion_r339904105 ## File path: docs/concepts.cn.md ## @@ -4,168 +4,151 @@ keywords: hudi, design, storage, views, timeline

  1   2   >