[jira] [Commented] (HUDI-377) Add Delete() support to HoodieDeltaStreamer

[ https://issues.apache.org/jira/browse/HUDI-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001835#comment-17001835 ] sivabalan narayanan commented on HUDI-377: -- [~vinoth] [~vbalaji] A suggestion as an enhancement

[GitHub] [incubator-hudi] nsivabalan commented on issue #1073: [HUDI-377] Adding Delete() support to DeltaStreamer

nsivabalan commented on issue #1073: [HUDI-377] Adding Delete() support to DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/1073#issuecomment-568236826 @vinothchandar @bvaradar : patch is ready to be reviewed.

[GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1073: [WIP] [HUDI-377] Adding Delete() support to DeltaStreamer

nsivabalan commented on a change in pull request #1073: [WIP] [HUDI-377] Adding Delete() support to DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/1073#discussion_r360684767 ## File path:

[GitHub] [incubator-hudi] XuQianJin-Stars commented on issue #1106: [HUDI-209] Implement JMX metrics reporter

XuQianJin-Stars commented on issue #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#issuecomment-568235277 hi @leesf Thanks, I have addressed. This is an

[GitHub] [incubator-hudi] vinothchandar commented on issue #736: hoodie-hive-hundle don't have hive jars

vinothchandar commented on issue #736: hoodie-hive-hundle don't have hive jars URL: https://github.com/apache/incubator-hudi/issues/736#issuecomment-568230395 https://github.com/apache/incubator-hudi/blob/master/hudi-hive/run_sync_tool.sh#L30 Adds in all the jars.. and we use the script

Build failed in Jenkins: hudi-snapshot-deployment-0.5 #136

See Changes: -- [...truncated 2.18 KB...] /home/jenkins/tools/maven/apache-maven-3.5.4/bin: m2.conf mvn mvn.cmd mvnDebug mvnDebug.cmd mvnyjp

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

vinothchandar commented on a change in pull request #: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/#discussion_r360676144 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

vinothchandar commented on a change in pull request #: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/#discussion_r360676356 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

vinothchandar commented on a change in pull request #: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/#discussion_r360676353 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

vinothchandar commented on a change in pull request #: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/#discussion_r360676270 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java

[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

vinothchandar commented on a change in pull request #: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/#discussion_r360676113 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java

[GitHub] [incubator-hudi] leesf commented on issue #1106: [HUDI-209] Implement JMX metrics reporter

leesf commented on issue #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#issuecomment-568224858 Hi, Thanks for opening the PR @XuQianJin-Stars and sorry for lately response. Left some comments may need to be addressed.

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter

leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r360676268 ## File path: hudi-client/src/main/java/org/apache/hudi/metrics/JmxMetricsReporter.java ## @@ -18,47

[GitHub] [incubator-hudi] vinothchandar commented on issue #1114: [HUDI-438] Merge duplicated code fragment

vinothchandar commented on issue #1114: [HUDI-438] Merge duplicated code fragment URL: https://github.com/apache/incubator-hudi/pull/1114#issuecomment-568223973 @leesf and @nsivabalan leave it to you both to decide and merge.

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter

leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r360675665 ## File path: hudi-client/src/main/java/org/apache/hudi/metrics/JmxMetricsReporter.java ## @@ -18,47

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter

leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r360675434 ## File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieMetricsConfig.java ## @@ -50,10

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter

leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r360675024 ## File path: hudi-client/src/main/java/org/apache/hudi/client/utils/NetUtils.java ## @@ -0,0 +1,458

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter

leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r360674909 ## File path: hudi-client/src/main/java/org/apache/hudi/client/utils/NetUtils.java ## @@ -0,0 +1,458

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter

leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r360674909 ## File path: hudi-client/src/main/java/org/apache/hudi/client/utils/NetUtils.java ## @@ -0,0 +1,458

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter

leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r360674884 ## File path: hudi-client/src/main/java/org/apache/hudi/client/utils/NetUtils.java ## @@ -0,0 +1,458

[jira] [Closed] (HUDI-386) Refactor hudi scala checkstyle rules

[ https://issues.apache.org/jira/browse/HUDI-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf closed HUDI-386. -- Fix Version/s: 0.5.1 Resolution: Fixed Fixed via master: b284091783af44341f20af11825ea9b6e3ba23da > Refactor

[GitHub] [incubator-hudi] leesf merged pull request #1099: [HUDI-386] Refactor hudi scala checkstyle rules

leesf merged pull request #1099: [HUDI-386] Refactor hudi scala checkstyle rules URL: https://github.com/apache/incubator-hudi/pull/1099 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-hudi] branch master updated: [HUDI-386] Refactor hudi scala checkstyle rules (#1099)

This is an automated email from the ASF dual-hosted git repository. leesf pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-hudi.git The following commit(s) were added to refs/heads/master by this push: new b284091 [HUDI-386] Refactor hudi scala

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1110: [HUDI-416] improve hint information for cli

leesf commented on a change in pull request #1110: [HUDI-416] improve hint information for cli URL: https://github.com/apache/incubator-hudi/pull/1110#discussion_r360672783 ## File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/CompactionCommand.java ## @@

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

leesf commented on a change in pull request #: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/#discussion_r360671597 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java

[GitHub] [incubator-hudi] leesf commented on a change in pull request #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

leesf commented on a change in pull request #: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/#discussion_r360671592 ## File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java

[GitHub] [incubator-hudi] hddong edited a comment on issue #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

hddong edited a comment on issue #: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/#issuecomment-568185234 @nsivabalan @leesf thanks for review. All comments have been fixed.

[GitHub] [incubator-hudi] hddong commented on issue #1111: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient

hddong commented on issue #: [HUDI-331]Fix java docs for all public apis in HoodieWriteClient URL: https://github.com/apache/incubator-hudi/pull/#issuecomment-568185234 @nsivabalan @leesf thanks for review. All be fixed.

[GitHub] [incubator-hudi] hddong commented on issue #1110: [HUDI-416] improve hint information for cli

hddong commented on issue #1110: [HUDI-416] improve hint information for cli URL: https://github.com/apache/incubator-hudi/pull/1110#issuecomment-568183388 @nsivabalan @leesf thank for your review. All is be fixed and please point out if any ignored.

[GitHub] [incubator-hudi] hddong commented on issue #1110: [HUDI-416] improve hint information for cli

hddong commented on issue #1110: [HUDI-416] improve hint information for cli URL: https://github.com/apache/incubator-hudi/pull/1110#issuecomment-568183298 @lamber-ken hudi-cli mainlu for ops, so the exception trace may is ok here.

[GitHub] [incubator-hudi] lamber-ken commented on issue #828: Synchronizing to hive partition is incorrect

lamber-ken commented on issue #828: Synchronizing to hive partition is incorrect URL: https://github.com/apache/incubator-hudi/issues/828#issuecomment-568181869 > it's correct on hudi-0.5.0 > > ```java > private transient DateTimeFormatter dtfOut; > > public

[GitHub] [incubator-hudi] haospotai commented on issue #828: Synchronizing to hive partition is incorrect

haospotai commented on issue #828: Synchronizing to hive partition is incorrect URL: https://github.com/apache/incubator-hudi/issues/828#issuecomment-568181245 it's correct on hudi-0.5.0 ```java private transient DateTimeFormatter dtfOut; public